Backed out changeset 14f893f7de2d (bug 1488377) for mochitest failures in devtools/server/tests/mochitest/test_css-properties.html
authorMargareta Eliza Balazs <ebalazs@mozilla.com>
Mon, 08 Oct 2018 16:25:17 +0300
changeset 495710 0e28323e25ef72bc60ce7238f982d071feb6f509
parent 495709 a62325e55d0dc8ba10729f79adf8b425ce1f12ef
child 495711 c9a6fdac66bb16e6a5cff14ecf2a27514ef4df88
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1488377
milestone64.0a1
backs out14f893f7de2dac98a5690d11507cadd1f6bd0030
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 14f893f7de2d (bug 1488377) for mochitest failures in devtools/server/tests/mochitest/test_css-properties.html
devtools/client/inspector/inspector.js
devtools/shared/fronts/css-properties.js
--- a/devtools/client/inspector/inspector.js
+++ b/devtools/client/inspector/inspector.js
@@ -1449,16 +1449,17 @@ Inspector.prototype = {
       this._highlighters = null;
     }
 
     if (this._search) {
       this._search.destroy();
       this._search = null;
     }
 
+    const cssPropertiesDestroyer = this._cssProperties.front.destroy();
     const sidebarDestroyer = this.sidebar.destroy();
     const ruleViewSideBarDestroyer = this.ruleViewSideBar ?
       this.ruleViewSideBar.destroy() : null;
     const markupDestroyer = this._destroyMarkup();
 
     this.teardownToolbar();
 
     this.breadcrumbs.destroy();
@@ -1481,16 +1482,17 @@ Inspector.prototype = {
     this.resultsLength = null;
     this.searchBox = null;
     this.show3PaneTooltip = null;
     this.sidebar = null;
     this.store = null;
     this.telemetry = null;
 
     this._panelDestroyer = promise.all([
+      cssPropertiesDestroyer,
       markupDestroyer,
       sidebarDestroyer,
       ruleViewSideBarDestroyer
     ]);
 
     return this._panelDestroyer;
   },
 
--- a/devtools/shared/fronts/css-properties.js
+++ b/devtools/shared/fronts/css-properties.js
@@ -232,17 +232,17 @@ const initCssProperties = async function
   if (cachedCssProperties.has(client)) {
     return cachedCssProperties.get(client);
   }
 
   let db, front;
 
   // Get the list dynamically if the cssProperties actor exists.
   if (toolbox.target.hasActor("cssProperties")) {
-    front = toolbox.target.getFront("cssProperties");
+    front = CssPropertiesFront(client, toolbox.target.form);
     db = await front.getCSSDatabase();
   } else {
     // The target does not support this actor, so require a static list of supported
     // properties.
     db = CSS_PROPERTIES_DB;
   }
 
   const cssProperties = new CssProperties(normalizeCssData(db));