Bug 928712 = Remove the rest of the unneeded prtypes.h inclusions; rs=bsmedberg
☠☠ backed out by 0bf3c7b93cab ☠ ☠
authorEhsan Akhgari <ehsan@mozilla.com>
Sun, 20 Oct 2013 09:10:07 -0400
changeset 165285 0ddbf9b3b20c8f4a799cf36a1778f55ee759b17b
parent 165284 50ad84fae4019eeebc209ba6cd43cc3e6e01f034
child 165286 eb4a385bd96c2da4cccfbaef9f81e7787c1278a3
push id3066
push userakeybl@mozilla.com
push dateMon, 09 Dec 2013 19:58:46 +0000
treeherdermozilla-beta@a31a0dce83aa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbsmedberg
bugs928712
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 928712 = Remove the rest of the unneeded prtypes.h inclusions; rs=bsmedberg
js/src/vm/ThreadPool.h
media/webrtc/signaling/src/common/browser_logging/CSFLog.cpp
media/webrtc/signaling/src/sipcc/core/common/thread_monitor.c
media/webrtc/signaling/src/sipcc/cpr/android/cpr_android_threads.c
media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_threads.c
media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_threads.c
modules/libjar/nsJAR.h
modules/libpref/src/prefread.h
tools/trace-malloc/bloatblame.cpp
tools/trace-malloc/lib/nsDebugHelpWin32.cpp
tools/trace-malloc/lib/nsTypeInfo.h
tools/trace-malloc/lib/nsWinTraceMalloc.cpp
--- a/js/src/vm/ThreadPool.h
+++ b/js/src/vm/ThreadPool.h
@@ -10,17 +10,16 @@
 #include <stddef.h>
 #include <stdint.h>
 
 #include "jsalloc.h"
 #include "jspubtd.h"
 #ifdef JS_THREADSAFE
 # include "prcvar.h"
 # include "prlock.h"
-# include "prtypes.h"
 #endif
 
 #include "js/Vector.h"
 
 struct JSRuntime;
 struct JSCompartment;
 
 namespace js {
--- a/media/webrtc/signaling/src/common/browser_logging/CSFLog.cpp
+++ b/media/webrtc/signaling/src/common/browser_logging/CSFLog.cpp
@@ -3,17 +3,16 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include <stdio.h>
 #include <string.h>
 #include <stdarg.h>
 
 #include "CSFLog.h"
 #include "base/basictypes.h"
-#include "prtypes.h"
 
 #include <map>
 #include "cpr_threads.h"
 #include "prrwlock.h"
 #include "prthread.h"
 #include "nsThreadUtils.h"
 #ifndef WIN32
 #include <pthread.h>
--- a/media/webrtc/signaling/src/sipcc/core/common/thread_monitor.c
+++ b/media/webrtc/signaling/src/sipcc/core/common/thread_monitor.c
@@ -1,16 +1,15 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "cpr_types.h"
 #include "cpr_stdlib.h"
 #include "thread_monitor.h"
-#include "prtypes.h"
 #include "mozilla/Assertions.h"
 
 /*
  * If thread is running, should have a non-zero entry here that is the threadId
  */
 static cprThread_t thread_list[THREADMON_MAX];
 static boolean wait_list[THREADMON_MAX];
 
--- a/media/webrtc/signaling/src/sipcc/cpr/android/cpr_android_threads.c
+++ b/media/webrtc/signaling/src/sipcc/cpr/android/cpr_android_threads.c
@@ -5,17 +5,16 @@
 #include "cpr.h"
 #include "cpr_stdlib.h"
 #include "cpr_stdio.h"
 #include <pthread.h>
 #include <errno.h>
 #include <unistd.h>
 #include <sys/resource.h>
 #include "thread_monitor.h"
-#include "prtypes.h"
 #include "mozilla/Assertions.h"
 
 #define ANDROID_MIN_THREAD_PRIORITY (-20)	/* tbd: check MV linux: current val from Larry port */
 #define ANDROID_MAX_THREAD_PRIORITY (+19)	/* tbd: check MV linux. current val from Larry port */
 
 void CSFLogRegisterThread(const cprThread_t thread);
 
 /**
--- a/media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_threads.c
+++ b/media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_threads.c
@@ -1,17 +1,16 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "cpr.h"
 #include "cpr_stdlib.h"
 #include "cpr_stdio.h"
 #include "thread_monitor.h"
-#include "prtypes.h"
 #include "mozilla/Assertions.h"
 #include <pthread.h>
 #include <errno.h>
 #include <unistd.h>
 #include <sys/resource.h>
 
 #define LINUX_MIN_THREAD_PRIORITY (-20)	/* tbd: check MV linux: current val from Larry port */
 #define LINUX_MAX_THREAD_PRIORITY (+19)	/* tbd: check MV linux. current val from Larry port */
--- a/media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_threads.c
+++ b/media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_threads.c
@@ -3,17 +3,16 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "cpr_types.h"
 #include "cpr_threads.h"
 #include "cpr_stdio.h"
 #include "cpr_stdlib.h"
 #include "cpr_debug.h"
 #include "cpr_memory.h"
-#include "prtypes.h"
 #include "mozilla/Assertions.h"
 
 #ifndef WIN32_LEAN_AND_MEAN
 #define WIN32_LEAN_AND_MEAN
 #endif
 
 #include <windows.h>
 #include <process.h>
--- a/modules/libjar/nsJAR.h
+++ b/modules/libjar/nsJAR.h
@@ -6,17 +6,16 @@
 
 #ifndef nsJAR_h__
 #define nsJAR_h__
 
 #include "nscore.h"
 #include "prio.h"
 #include "plstr.h"
 #include "prlog.h"
-#include "prtypes.h"
 #include "prinrval.h"
 
 #include "mozilla/Mutex.h"
 #include "nsIComponentManager.h"
 #include "nsCOMPtr.h"
 #include "nsString.h"
 #include "nsIFile.h"
 #include "nsStringEnumerator.h"
--- a/modules/libpref/src/prefread.h
+++ b/modules/libpref/src/prefread.h
@@ -1,16 +1,15 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef prefread_h__
 #define prefread_h__
 
-#include "prtypes.h"
 #include "prefapi.h"
 
 #ifdef __cplusplus
 extern "C" {
 #endif
 
 /**
  * Callback function used to notify consumer of preference name value pairs.
--- a/tools/trace-malloc/bloatblame.cpp
+++ b/tools/trace-malloc/bloatblame.cpp
@@ -17,17 +17,16 @@
 extern int  getopt(int argc, char *const *argv, const char *shortopts);
 extern char *optarg;
 extern int  optind;
 #endif
 #endif
 #include <math.h>
 #include <time.h>
 #include <sys/stat.h>
-#include "prtypes.h"
 #include "prlog.h"
 #include "prprf.h"
 #include "plhash.h"
 #include "pldhash.h"
 #include "nsTraceMalloc.h"
 #include "tmreader.h"
 
 static char   *program;
--- a/tools/trace-malloc/lib/nsDebugHelpWin32.cpp
+++ b/tools/trace-malloc/lib/nsDebugHelpWin32.cpp
@@ -3,17 +3,16 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 
 #if defined(_WIN32) && (defined(_M_IX86) || defined(_M_X64))
 // This is the .cpp file where the globals live
 #define DHW_IMPLEMENT_GLOBALS
 #include <stdio.h>
-#include "prtypes.h"
 #include "prprf.h"
 #include "prlog.h"
 #include "plstr.h"
 #include "prlock.h"
 #include "nscore.h"
 #include "nsDebugHelpWin32.h"
 #else
 #error "nsDebugHelpWin32.cpp should only be built in Win32 x86/x64 builds"
--- a/tools/trace-malloc/lib/nsTypeInfo.h
+++ b/tools/trace-malloc/lib/nsTypeInfo.h
@@ -2,18 +2,16 @@
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef trace_malloc_nsTypeInfo_h_
 #define trace_malloc_nsTypeInfo_h_
 
-#include "prtypes.h"
-
 #ifdef __cplusplus
 extern "C" {
 #endif
 
 extern const char* nsGetTypeName(void* ptr);
 
 extern void RegisterTraceMallocShutdown();
 
--- a/tools/trace-malloc/lib/nsWinTraceMalloc.cpp
+++ b/tools/trace-malloc/lib/nsWinTraceMalloc.cpp
@@ -2,17 +2,16 @@
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include <stdio.h>
 #include <stdlib.h>
 
-#include "prtypes.h"
 #include "prinrval.h"
 #include "prlock.h"
 #include "nscore.h"
 
 #include "nsDebugHelpWin32.h"
 #include "nsTraceMallocCallbacks.h"
 
 /***************************************************************************/