Bug 1477679 - Prevent the dropdown panel swallowing the first click r=Honza
authorHemanth Kumar Veeranki <hems.india1997@gmail.com>
Thu, 10 Jan 2019 13:48:09 +0000
changeset 519030 0db3a6976abd4c2af63749e51f37f3c90cff3ee5
parent 519029 faf6df595f9fb9b4a9a22aeead6c7be64e730049
child 519031 1d4617ef65c8e1dee0f3f47786e60882bfd2e9f3
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1477679
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1477679 - Prevent the dropdown panel swallowing the first click r=Honza Network - HAR and Throtthling menus when they are opened are preventing other events to trigger by the first mouse click. After this change, they will not consume the first click. Differential Revision: https://phabricator.services.mozilla.com/D15444
devtools/client/framework/menu.js
--- a/devtools/client/framework/menu.js
+++ b/devtools/client/framework/menu.js
@@ -92,17 +92,17 @@ Menu.prototype.popup = function(screenX,
   // opening a new one.
   let popup = popupset.querySelector("menupopup[menu-api=\"true\"]");
   if (popup) {
     popup.hidePopup();
   }
 
   popup = doc.createXULElement("menupopup");
   popup.setAttribute("menu-api", "true");
-  popup.setAttribute("consumeoutsideclicks", "true");
+  popup.setAttribute("consumeoutsideclicks", "false");
 
   if (this.id) {
     popup.id = this.id;
   }
   this._createMenuItems(popup);
 
   // Remove the menu from the DOM once it's hidden.
   popup.addEventListener("popuphidden", (e) => {