Bug 1494026 - Part 0b: Cleanup javadoc. r=VladBaicu
authorJan Henning <jh+bugzilla@buttercookie.de>
Tue, 07 May 2019 17:21:51 +0000
changeset 531766 0cca2f068966246ac6468255a87e0a1b4cf64dc4
parent 531765 3e6bf14530c846509ed8c5fd004fbe8be9083fc6
child 531767 a66cab570864911c2607359e76d510a43fbbeb4f
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersVladBaicu
bugs1494026
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1494026 - Part 0b: Cleanup javadoc. r=VladBaicu Somehow that comment ended up in the wrong file after refactoring. Differential Revision: https://phabricator.services.mozilla.com/D29972
mobile/android/base/java/org/mozilla/gecko/preferences/DefaultBrowserPreference.java
mobile/android/base/java/org/mozilla/gecko/preferences/LinkPreference.java
--- a/mobile/android/base/java/org/mozilla/gecko/preferences/DefaultBrowserPreference.java
+++ b/mobile/android/base/java/org/mozilla/gecko/preferences/DefaultBrowserPreference.java
@@ -18,16 +18,20 @@ public class DefaultBrowserPreference ex
     public DefaultBrowserPreference(Context context, AttributeSet attrs) {
         super(context, attrs);
     }
 
     public DefaultBrowserPreference(Context context, AttributeSet attrs, int defStyle) {
         super(context, attrs, defStyle);
     }
 
+    /**
+     * Open Default apps screen of Settings for API Levels>=24.
+     * Support URL will open for lower API levels.
+     */
     @Override
     protected void onClick() {
         if (GeckoPreferences.PREFS_DEFAULT_BROWSER.equals(getKey()) && AppConstants.Versions.feature24Plus) {
             Toast.makeText(this.getContext(),
                     this.getContext().getString(R.string.default_browser_system_settings_toast),
                     Toast.LENGTH_LONG).show();
 
             // We are special casing the link to set the default browser here: On old Android versions we
--- a/mobile/android/base/java/org/mozilla/gecko/preferences/LinkPreference.java
+++ b/mobile/android/base/java/org/mozilla/gecko/preferences/LinkPreference.java
@@ -22,17 +22,14 @@ class LinkPreference extends Preference 
         super(context, attrs, defStyle);
         mUrl = attrs.getAttributeValue(null, "url");
     }
 
     public void setUrl(String url) {
         mUrl = url;
     }
 
-    /**
-     * Open Default apps screen of Settings for API Levels>=24. Support URL will open for lower API levels
-     */
     @Override
     protected void onClick() {
         Tabs.getInstance().loadUrlInTab(mUrl);
         callChangeListener(mUrl);
     }
 }