Bug 1471614 - remove some dead code in CycleCollectedJSRuntime; r=mccr8
☠☠ backed out by 682adcb25f4e ☠ ☠
authorNathan Froyd <froydnj@mozilla.com>
Wed, 27 Jun 2018 11:10:31 -0400
changeset 479037 0ca9cade77252f5b7a11c1cb8d00d792ee25c78a
parent 479036 ad943a10a01d0af3fc657b0672a67e1b5925a1c8
child 479038 856e0bddbcadde8594a2e9f117b504c3be9acb1b
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmccr8
bugs1471614
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1471614 - remove some dead code in CycleCollectedJSRuntime; r=mccr8 Not only is it dead code, but it's a significant amount of useless work!
xpcom/base/CycleCollectedJSRuntime.cpp
--- a/xpcom/base/CycleCollectedJSRuntime.cpp
+++ b/xpcom/base/CycleCollectedJSRuntime.cpp
@@ -1631,19 +1631,17 @@ CycleCollectedJSRuntime::ErrorIntercepto
   details.mType = *type;
   // If `exn` isn't an exception object, `ExtractErrorValues` could end up calling
   // `toString()`, which could in turn end up throwing an error. While this should
   // work, we want to avoid that complex use case.
   // Fortunately, we have already checked above that `exn` is an exception object,
   // so nothing such should happen.
   nsContentUtils::ExtractErrorValues(cx, value, details.mFilename, &details.mLine, &details.mColumn, details.mMessage);
 
-  nsAutoCString stack;
   JS::UniqueChars buf = JS::FormatStackDump(cx, nullptr, /* showArgs = */ false, /* showLocals = */ false, /* showThisProps = */ false);
-  stack.Append(buf.get());
   CopyUTF8toUTF16(buf.get(), details.mStack);
 
   mThrownError.emplace(std::move(details));
 }
 
 void
 CycleCollectedJSRuntime::ClearRecentDevError()
 {