Bug 1368147 - Pre: Don't forget to call super.finalize in finalize override r=sebastian
authorGrigory Kruglov <gkruglov@mozilla.com>
Wed, 30 Aug 2017 20:35:33 -0400
changeset 429957 0ca257bd9dcb3fe1343e523104bd18333bef9776
parent 429956 487a253f5548d646d6ce3edbcbcdb636329fa837
child 429958 d881fed7d5ca3af4680bf0f75b0f3fd5ed886b48
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1368147
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1368147 - Pre: Don't forget to call super.finalize in finalize override r=sebastian MozReview-Commit-ID: B7gatdHlCDb
mobile/android/services/src/main/java/org/mozilla/gecko/fxa/authenticator/AndroidFxAccount.java
--- a/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/authenticator/AndroidFxAccount.java
+++ b/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/authenticator/AndroidFxAccount.java
@@ -927,17 +927,18 @@ public class AndroidFxAccount {
       locked = false;
       Log.d(Logger.DEFAULT_LOG_TAG, "Thread with tag and thread id releasing lock: " + lockTag + ", " + id + " ... RELEASED");
     } else {
       Log.d(Logger.DEFAULT_LOG_TAG, "Thread with tag and thread id releasing lock: " + lockTag + ", " + id + " ... NOT LOCKED");
     }
   }
 
   @Override
-  protected synchronized void finalize() {
+  protected synchronized void finalize() throws Throwable {
+    super.finalize();
     if (locked) {
       // Should never happen, but...
       sLock.release();
       locked = false;
       final long id = Thread.currentThread().getId();
       Log.e(Logger.DEFAULT_LOG_TAG, "Thread with tag and thread id releasing lock: " + lockTag + ", " + id + " ... RELEASED DURING FINALIZE");
     }
   }