bug 1242268 document mLifecycleState multithread access management r=padenot
authorKarl Tomlinson <karlt+@karlt.net>
Mon, 04 Jul 2016 16:33:05 +1200
changeset 346162 0c21f0c5a2964f384d37e29f98a7489901741218
parent 346161 2ce848f8b804c55792014cd9b70c9a54854bf9d7
child 346163 20c9343e899cd674fc309180dbcbef69245123e1
push id6389
push userraliiev@mozilla.com
push dateMon, 19 Sep 2016 13:38:22 +0000
treeherdermozilla-beta@01d67bfe6c81 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1242268
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1242268 document mLifecycleState multithread access management r=padenot MozReview-Commit-ID: 1479atSNipN
dom/media/MediaStreamGraphImpl.h
--- a/dom/media/MediaStreamGraphImpl.h
+++ b/dom/media/MediaStreamGraphImpl.h
@@ -739,16 +739,19 @@ public:
     // to shut down the graph thread(s).
     LIFECYCLE_WAITING_FOR_THREAD_SHUTDOWN,
     // Graph threads have shut down but we're waiting for remaining streams
     // to be destroyed. Only happens during application shutdown and on
     // completed non-realtime graphs, since normally we'd only shut down a
     // realtime graph when it has no streams.
     LIFECYCLE_WAITING_FOR_STREAM_DESTRUCTION
   };
+  /**
+   * Modified only on the main thread in mMonitor.
+   */
   LifecycleState mLifecycleState;
   /**
    * The graph should stop processing at or after this time.
    */
   GraphTime mEndTime;
 
   /**
    * True when we need to do a forced shutdown during application shutdown.