Bug 1496297 - Use |jit-test| skip-if as appropriate in jit-test/tests/regexp/ (r=jorendorff)
authorEric Faust <efausbmo@gmail.com>
Tue, 09 Oct 2018 15:41:50 -0700
changeset 496125 0b8297687615c6674a16bdcd168e7efd8b18d8a0
parent 496124 b95948e9a1265a7d707f2d70d78f50bd99a3131f
child 496126 9da32b3fe7051f57ea7ea8d516170639f3951964
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
bugs1496297
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496297 - Use |jit-test| skip-if as appropriate in jit-test/tests/regexp/ (r=jorendorff)
js/src/jit-test/tests/regexp/bug1445907.js
js/src/jit-test/tests/regexp/clone-statics.js
--- a/js/src/jit-test/tests/regexp/bug1445907.js
+++ b/js/src/jit-test/tests/regexp/bug1445907.js
@@ -1,15 +1,14 @@
+// |jit-test| skip-if: !wasmIsSupported()
+
 // On ARM64, we failed to save x28 properly when generating code for the regexp
 // matcher.
 //
 // There's wasm and Debugger code here because the combination forces the use of
 // x28 and exposes the bug when running on the simulator.
 
-if (!wasmIsSupported())
-    quit();
-
 var g = newGlobal('');
 var dbg = new Debugger(g);
 g.eval(`var m = new WebAssembly.Instance(new WebAssembly.Module(wasmTextToBinary('(module (func (export "test")))')))`);
 var re = /./;
 dbg.onEnterFrame = function(frame) { re.exec("x") };
 result = g.eval("m.exports.test()");
--- a/js/src/jit-test/tests/regexp/clone-statics.js
+++ b/js/src/jit-test/tests/regexp/clone-statics.js
@@ -1,10 +1,9 @@
-if (helperThreadCount() === 0)
-  quit(0);
+// |jit-test| skip-if: helperThreadCount() === 0
 
 offThreadCompileScript(`
   function foo(x, {}) {
     do {
       re = /erwe/;
       if (x === 1)
         re.x = 1;
       else