Bug 1229097: Fix missed review comment by converting all rules to errors.
authorDave Townsend <dtownsend@oxymoronical.com>
Wed, 02 Dec 2015 10:18:30 -0800
changeset 309353 0ae21184dbe776ca22e68ff162428ac11348a030
parent 309352 ed6fd38d7eb2782a3d6562f22786d66f8c7db9aa
child 309354 1b749564824e101e9a5fca10ce939e3b6362b019
push id5513
push userraliiev@mozilla.com
push dateMon, 25 Jan 2016 13:55:34 +0000
treeherdermozilla-beta@5ee97dd05b5c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1229097
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1229097: Fix missed review comment by converting all rules to errors.
toolkit/.eslintrc
--- a/toolkit/.eslintrc
+++ b/toolkit/.eslintrc
@@ -16,17 +16,17 @@
 
     // No space before always a space after a comma
     // "comma-spacing": [2, {"before": false, "after": true}],
 
     // Commas at the end of the line not the start
     // "comma-style": 2,
 
     // Don't require spaces around computed properties
-    // "computed-property-spacing": [1, "never"],
+    // "computed-property-spacing": [2, "never"],
 
     // Functions must always return something or nothing
     // "consistent-return": 2,
 
     // Require braces around blocks that start a new line
     // Note that this rule is likely to be overridden on a per-directory basis
     // very frequently.
     // "curly": [2, "multi-line"],
@@ -45,17 +45,17 @@
 
     // Unix linebreaks
     // "linebreak-style": [2, "unix"],
 
     // Always require parenthesis for new calls
     // "new-parens": 2,
 
     // Use [] instead of Array()
-    // "no-array-constructor": 1,
+    // "no-array-constructor": 2,
 
     // No duplicate arguments in function declarations
     // "no-dupe-args": 2,
 
     // No duplicate keys in object declarations
     // "no-dupe-keys": 2,
 
     // No duplicate cases in switch statements
@@ -75,71 +75,71 @@
 
     // Disallow empty destructuring
     // "no-empty-pattern": 2,
 
     // No assiging to exception variable
     // "no-ex-assign": 2,
 
     // No using !! where casting to boolean is already happening
-    // "no-extra-boolean-cast": 1,
+    // "no-extra-boolean-cast": 2,
 
     // No double semicolon
     // "no-extra-semi": 2,
 
     // No overwriting defined functions
     // "no-func-assign": 2,
 
     // No invalid regular expresions
     // "no-invalid-regexp": 2,
 
     // No odd whitespace characters
     // "no-irregular-whitespace": 2,
 
     // No single if block inside an else block
-    // "no-lonely-if": 1,
+    // "no-lonely-if": 2,
 
     // No mixing spaces and tabs in indent
     // "no-mixed-spaces-and-tabs": [2, "smart-tabs"],
 
     // No unnecessary spacing
-    // "no-multi-spaces": 1,
+    // "no-multi-spaces": 2,
 
     // No reassigning native JS objects
     // "no-native-reassign": 2,
 
     // No (!foo in bar)
     // "no-negated-in-lhs": 2,
 
     // Nested ternary statements are confusing
     // "no-nested-ternary": 2,
 
     // Use {} instead of new Object()
-    // "no-new-object": 1,
+    // "no-new-object": 2,
 
     // No Math() or JSON()
     // "no-obj-calls": 2,
 
     // No octal literals
     // "no-octal": 2,
 
     // No redeclaring variables
-    // "no-redeclare": 1,
+    // "no-redeclare": 2,
 
     // No unnecessary comparisons
     // "no-self-compare": 2,
 
     // No declaring variables from an outer scope
-    // "no-shadow": 1,
+    // "no-shadow": 2,
 
     // No declaring variables that hide things like arguments
     // "no-shadow-restricted-names": 2,
 
     // No spaces between function name and parentheses
-    // "no-spaced-func": 1,
+    // "no-spaced-func": 2,
 
     // No trailing whitespace
     // "no-trailing-spaces": 2,
 
     // No using undeclared variables
     // "no-undef": 2,
 
     // Error on newline where a semicolon is needed
@@ -147,17 +147,17 @@
 
     // No unreachable statements
     // "no-unreachable": 2,
 
     // No expressions where a statement is expected
     // "no-unused-expressions": 2,
 
     // No declaring variables that are never used
-    // "no-unused-vars": [1, {"vars": "all", "args": "none"}],
+    // "no-unused-vars": [2, {"vars": "all", "args": "none"}],
 
     // No using variables before defined
     // "no-use-before-define": 2,
 
     // No using with
     // "no-with": 2,
 
     // Always require semicolon at end of statement
@@ -180,17 +180,17 @@
 
     // Require spaces around operators
     // "space-infix-ops": 2,
 
     // Require spaces after return, throw and case
     // "space-return-throw-case": 2,
 
     // ++ and -- should not need spacing
-    // "space-unary-ops": [1, { "words": true, "nonwords": false }],
+    // "space-unary-ops": [2, { "words": true, "nonwords": false }],
 
     // No comparisons to NaN
     // "use-isnan": 2,
 
     // Only check typeof against valid results
     // "valid-typeof": 2,
   }
 }