Bug 598316 - Fix a comparison between signed and unsigned integers in nsHTMLFieldSetElement::InsertChildAt; r=volkmar a=jst
authorMs2ger <ms2ger@gmail.com>
Sun, 24 Oct 2010 11:05:50 +0200
changeset 56407 094d838ed780c6a12dfdbf9e12478f83354dabd7
parent 56406 52811d688f2b43c7ef86d0909c1b3f6e2ec582b4
child 56408 f7972361c2687e6a9a3fb676fcb04ec893aa01a6
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersvolkmar, jst
bugs598316
milestone2.0b8pre
first release with
nightly linux32
094d838ed780 / 4.0b8pre / 20101024030113 / files
nightly linux64
094d838ed780 / 4.0b8pre / 20101024030852 / files
nightly mac
094d838ed780 / 4.0b8pre / 20101024030754 / files
nightly win32
094d838ed780 / 4.0b8pre / 20101024042142 / files
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
Bug 598316 - Fix a comparison between signed and unsigned integers in nsHTMLFieldSetElement::InsertChildAt; r=volkmar a=jst
content/html/content/src/nsHTMLFieldSetElement.cpp
--- a/content/html/content/src/nsHTMLFieldSetElement.cpp
+++ b/content/html/content/src/nsHTMLFieldSetElement.cpp
@@ -188,17 +188,17 @@ nsHTMLFieldSetElement::InsertChildAt(nsI
 
   if (aChild->IsHTML(nsGkAtoms::legend)) {
     if (!mFirstLegend) {
       mFirstLegend = aChild;
       // We do not want to notify the first time mFirstElement is set.
     } else {
       // If mFirstLegend is before aIndex, we do not change it.
       // Otherwise, mFirstLegend is now aChild.
-      if (aIndex <= IndexOf(mFirstLegend)) {
+      if (PRInt32(aIndex) <= IndexOf(mFirstLegend)) {
         mFirstLegend = aChild;
         firstLegendHasChanged = true;
       }
     }
   }
 
   nsresult rv = nsGenericHTMLFormElement::InsertChildAt(aChild, aIndex, aNotify);
   NS_ENSURE_SUCCESS(rv, rv);