Bug 1508088 - Don't start new recording when navigating from blank tab, r=jlast.
authorBrian Hackett <bhackett1024@gmail.com>
Sat, 17 Nov 2018 11:28:50 -1000
changeset 503562 0892fe15bc04299d99b9ae77088dafa31157584a
parent 503561 52fea45d53421be98d29d3f9c619f64809449482
child 503563 f816f239955c03172fc46f1caf8a46a898eca4e8
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjlast
bugs1508088
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1508088 - Don't start new recording when navigating from blank tab, r=jlast.
browser/base/content/utilityOverlay.js
devtools/client/debugger/new/test/mochitest/browser.ini
devtools/server/actors/webconsole.js
--- a/browser/base/content/utilityOverlay.js
+++ b/browser/base/content/utilityOverlay.js
@@ -501,17 +501,18 @@ function openLinkIn(url, where, params) 
          (doGetProtocolFlags(uriObj) & URI_INHERITS_SECURITY_CONTEXT))) {
       // Unless we know for sure we're not inheriting principals,
       // force the about:blank viewer to have the right principal:
       targetBrowser.createAboutBlankContentViewer(aPrincipal);
     }
 
     // When navigating a recording tab, use a new content process in order to
     // start a new recording.
-    if (targetBrowser.hasAttribute("recordExecution")) {
+    if (targetBrowser.hasAttribute("recordExecution") &&
+        targetBrowser.currentURI.spec != "about:blank") {
       w.gBrowser.updateBrowserRemoteness(targetBrowser, true,
                                          { recordExecution: "*", newFrameloader: true });
     }
 
     targetBrowser.loadURI(url, {
       triggeringPrincipal: aTriggeringPrincipal,
       flags,
       referrerURI: aNoReferrer ? null : aReferrerURI,
--- a/devtools/client/debugger/new/test/mochitest/browser.ini
+++ b/devtools/client/debugger/new/test/mochitest/browser.ini
@@ -775,9 +775,9 @@ skip-if = os != "mac" || debug || !night
 skip-if = true # See bug 1481009
 [browser_dbg_rr_replay-01.js]
 skip-if = os != "mac" || debug || !nightly_build
 [browser_dbg_rr_replay-02.js]
 skip-if = os != "mac" || debug || !nightly_build
 [browser_dbg_rr_replay-03.js]
 skip-if = os != "mac" || debug || !nightly_build
 [browser_dbg_rr_console_warp-01.js]
-skip-if = true # Bug 1483969
+skip-if = os != "mac" || debug || !nightly_build
--- a/devtools/server/actors/webconsole.js
+++ b/devtools/server/actors/webconsole.js
@@ -367,16 +367,20 @@ WebConsoleActor.prototype =
 
     this.conn.removeActorPool(this._actorPool);
 
     if (this.parentActor.isRootActor) {
       Services.obs.removeObserver(this._onObserverNotification,
                                   "last-pb-context-exited");
     }
 
+    if (this.dbg.replaying && !isWorker) {
+      this.dbg.onConsoleMessage = null;
+    }
+
     this._actorPool = null;
     this._webConsoleCommandsCache = null;
     this._lastConsoleInputEvaluation = null;
     this._evalWindow = null;
     this.dbg.enabled = false;
     this.dbg = null;
     this.conn = null;
   },