Bug 888908 - When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway. r=jaws, a=bajaj
authorBenjamin Smedberg <benjamin@smedbergs.us>
Fri, 19 Jul 2013 10:02:47 -0400
changeset 148120 0883cacf940bbeb711235ce0d6ecba42b5f6c192
parent 148119 142db87e69e4da743aac407ffbb1617adf284869
child 148121 c5c2d41b057294cdc24b931160a77640aa41dbab
push id2697
push userbbajaj@mozilla.com
push dateMon, 05 Aug 2013 18:49:53 +0000
treeherdermozilla-beta@dfec938c7b63 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws, bajaj
bugs888908
milestone24.0a2
Bug 888908 - When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway. r=jaws, a=bajaj
browser/base/content/browser-plugins.js
--- a/browser/base/content/browser-plugins.js
+++ b/browser/base/content/browser-plugins.js
@@ -760,18 +760,17 @@ var gPluginHandler = {
 
     let haveVulnerablePlugin = plugins.some(function(plugin) {
       let fallbackType = plugin.pluginFallbackType;
       return fallbackType == plugin.PLUGIN_VULNERABLE_UPDATABLE ||
         fallbackType == plugin.PLUGIN_VULNERABLE_NO_UPDATE ||
         fallbackType == plugin.PLUGIN_BLOCKLISTED;
     });
     let dismissed = notification ? notification.dismissed : true;
-    // Always show the doorhanger if the anchor is not available.
-    if (!isElementVisible(gURLBar) || aPrimaryPlugin)
+    if (aPrimaryPlugin)
       dismissed = false;
 
     let primaryPluginPermission = null;
     if (aPrimaryPlugin) {
       primaryPluginPermission = this._getPluginInfo(aPrimaryPlugin).permissionString;
     }
 
     let options = {