Bug 1509340 - Don't dispatch STATE_COOKIES_LOADED notifications from the parent process for fastblock r=baku
authorEhsan Akhgari <ehsan@mozilla.com>
Thu, 22 Nov 2018 16:49:39 +0000
changeset 504146 07a947ccd73ad20f12144df34462150ca6962ca1
parent 504145 87bad1f80deeaf4a3cd715d75b405877165c1eeb
child 504147 275ccc8b8fe7b89f1958a49262b896ba833c6fb5
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1509340
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1509340 - Don't dispatch STATE_COOKIES_LOADED notifications from the parent process for fastblock r=baku Differential Revision: https://phabricator.services.mozilla.com/D12679
toolkit/components/antitracking/AntiTrackingCommon.cpp
--- a/toolkit/components/antitracking/AntiTrackingCommon.cpp
+++ b/toolkit/components/antitracking/AntiTrackingCommon.cpp
@@ -1288,17 +1288,17 @@ AntiTrackingCommon::NotifyBlockingDecisi
   // Can be called in EITHER the parent or child process.
   nsCOMPtr<nsIParentChannel> parentChannel;
   NS_QueryNotificationCallbacks(aChannel, parentChannel);
   if (parentChannel) {
     // This channel is a parent-process proxy for a child process request.
     // Tell the child process channel to do this instead.
     if (aDecision == BlockingDecision::eBlock) {
       parentChannel->NotifyTrackingCookieBlocked(aRejectedReason);
-    } else {
+    } else if (sendCookieLoadedNotification) {
       // Ignore the code related to fastblock
       parentChannel->NotifyCookieAllowed();
     }
     return;
   }
 
   nsCOMPtr<mozIThirdPartyUtil> thirdPartyUtil = services::GetThirdPartyUtil();
   if (!thirdPartyUtil) {