Bug 865766 - Reorder MessageLoop init list to fix build warning. r=jlebar
authorDaniel Holbert <dholbert@cs.stanford.edu>
Fri, 26 Apr 2013 10:11:00 -0400
changeset 141016 06927647efd749840163d54a80c4e2e1e478d52b
parent 141015 c5224bbcf40b333d703259965776ebb0ac29c69b
child 141017 d3f88b2e42f7a70d7505fe0f0de0d6f8d50986fd
push id2579
push userakeybl@mozilla.com
push dateMon, 24 Jun 2013 18:52:47 +0000
treeherdermozilla-beta@b69b7de8a05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjlebar
bugs865766
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 865766 - Reorder MessageLoop init list to fix build warning. r=jlebar
ipc/chromium/src/base/message_loop.cc
--- a/ipc/chromium/src/base/message_loop.cc
+++ b/ipc/chromium/src/base/message_loop.cc
@@ -85,25 +85,25 @@ MessageLoop* MessageLoop::current() {
   //DCHECK(loop) << "Ouch, did you forget to initialize me?";
   return lazy_tls_ptr.Pointer()->Get();
 }
 
 PRInt32 message_loop_id_seq = 0;
 
 MessageLoop::MessageLoop(Type type)
     : type_(type),
+      id_(PR_ATOMIC_INCREMENT(&message_loop_id_seq)),
       nestable_tasks_allowed_(true),
       exception_restoration_(false),
       state_(NULL),
       run_depth_base_(1),
 #ifdef OS_WIN
       os_modal_loop_(false),
 #endif  // OS_WIN
-      next_sequence_num_(0),
-      id_(PR_ATOMIC_INCREMENT(&message_loop_id_seq)) {
+      next_sequence_num_(0) {
   DCHECK(!current()) << "should only have one message loop per thread";
   lazy_tls_ptr.Pointer()->Set(this);
   if (type_ == TYPE_MOZILLA_UI) {
     pump_ = new mozilla::ipc::MessagePump();
     return;
   }
   if (type_ == TYPE_MOZILLA_CHILD) {
     pump_ = new mozilla::ipc::MessagePumpForChildProcess();