Bug 1483252 - Replace 0px with 0 throughout menu.css r=dao
authorBharat Raghunathan <bharatraghunthan9767@gmail.com>
Sat, 18 Aug 2018 15:20:26 +0000
changeset 487344 060ff053ae2764fcbea5f30d39402b6cd33e0789
parent 487343 48892db33179b3489126e9097f33b8c96c4c0440
child 487345 369762aaed07c4e20d5837219ff55f6f17c28aa8
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1483252
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1483252 - Replace 0px with 0 throughout menu.css r=dao MozReview-Commit-ID: DiHVfBuSH7V Differential Revision: https://phabricator.services.mozilla.com/D3689
toolkit/themes/linux/global/menu.css
toolkit/themes/windows/global/menu.css
--- a/toolkit/themes/linux/global/menu.css
+++ b/toolkit/themes/linux/global/menu.css
@@ -44,17 +44,17 @@ menuitem[customoptionstyling="true"][_mo
 
 menu[disabled="true"],
 menuitem[disabled="true"],
 menucaption[disabled="true"] {
   color: GrayText;
 }
 
 menubar > menu {
-  padding: 0px 4px;
+  padding: 0 4px;
   color: -moz-menubartext;
 }
 
 menubar:-moz-lwtheme > menu {
   text-shadow: none;
 }
 
 menubar:-moz-lwtheme > menu:not([open="true"]) {
@@ -90,31 +90,31 @@ menulist > menupopup > menu {
   max-width: none;
 }
 
 /* ..... internal content .... */
 
 .menu-text,
 .menu-iconic-left,
 .menu-iconic-text {
-  margin-top: 0px !important;
-  margin-bottom: 0px !important;
-  margin-inline-start: 0px !important;
+  margin-top: 0 !important;
+  margin-bottom: 0 !important;
+  margin-inline-start: 0 !important;
   margin-inline-end: 2px !important;
 }
 
 .menu-text {
   /* This is (18 + the size of end-padding on .menu-iconic-left)px */
   margin-inline-start: 21px !important;
 }
 
 .menu-accel,
 .menu-iconic-accel {
-  margin-top: 0px !important;
-  margin-bottom: 0px !important;
+  margin-top: 0 !important;
+  margin-bottom: 0 !important;
   margin-inline-start: 7px !important;
 }
 
 .menu-accel-container {
   -moz-box-pack: end;
 }
 
 .menu-iconic-left {
@@ -124,32 +124,32 @@ menulist > menupopup > menu {
 }
 
 .menu-iconic-icon {
   width: 16px;
   height: 16px;
 }
 
 .menu-right {
-  margin-top: 0px;
-  margin-bottom: 0px;
+  margin-top: 0;
+  margin-bottom: 0;
   margin-inline-start: 6px;
-  margin-inline-end: 0px;
+  margin-inline-end: 0;
   width: 1ex;
   height: 1ex;
   /* These next two rules are needed to prevent inheritance and thus ugliness */
   list-style-image: none;
   -moz-image-region: auto;
   -moz-appearance: menuarrow;
 }
 
 .menubar-left {
-  margin-top: 0px;
-  margin-bottom: 0px;
-  margin-inline-start: 0px;
+  margin-top: 0;
+  margin-bottom: 0;
+  margin-inline-start: 0;
   margin-inline-end: 2px;
 }
 
 .menubar-text {
   margin: 0 1px !important;
 }
 
 
--- a/toolkit/themes/windows/global/menu.css
+++ b/toolkit/themes/windows/global/menu.css
@@ -48,18 +48,18 @@ menucaption {
 }
 
 /* ..... internal content .... */
 
 .menu-accel,
 .menu-iconic-accel,
 .menu-text,
 .menu-iconic-text {
-  margin: 0px !important;
-  padding: 1px 0px;
+  margin: 0 !important;
+  padding: 1px 0;
 }
 
 .menu-text {
   padding-inline-start: 1.45em !important;
   -moz-appearance: menuitemtext;
 }
 
 .menu-text,
@@ -194,18 +194,18 @@ menulist > menupopup > menuitem > .menu-
 menulist > menupopup > menucaption > .menu-iconic-left,
 menulist > menupopup > menu > .menu-iconic-left {
   display: none;
 }
 
 menulist > menupopup > menuitem > label,
 menulist > menupopup > menucaption > label,
 menulist > menupopup > menu > label {
-  padding-top: 0px;
-  padding-bottom: 0px;
+  padding-top: 0;
+  padding-bottom: 0;
 }
 
 menulist:-moz-focusring > menupopup > menuitem[_moz-menuactive="true"] {
   border: 1px dotted #F5DB95;
 }
 
 menulist > menupopup > menuitem[_moz-menuactive="true"][disabled="true"] {
   color: GrayText;
@@ -226,25 +226,25 @@ menulist > menupopup > :-moz-any(menuite
 
 menuitem[type="checkbox"],
 menuitem[checked="true"] {
   -moz-appearance: checkmenuitem;
 }
 menuitem[type="checkbox"] > .menu-iconic-left,
 menuitem[checked="true"] > .menu-iconic-left {
   -moz-appearance: menucheckbox;
-  padding-top: 0px;
+  padding-top: 0;
 }
 
 menuitem[type="radio"] {
   -moz-appearance: radiomenuitem;
 }
 menuitem[type="radio"] > .menu-iconic-left {
   -moz-appearance: menuradio;
-  padding-top: 0px;
+  padding-top: 0;
 }
 
 menuitem[type="checkbox"] > .menu-iconic-left > .menu-iconic-icon,
 menuitem[checked="true"] > .menu-iconic-left > .menu-iconic-icon,
 menuitem[type="radio"] > .menu-iconic-left > .menu-iconic-icon {
   /* prevent .menu-iconic-icon from enforcing a minimal height of 16px (see bug 411064)
      XXXzeniko apply that .menu-iconic-icon rule only for children of .menu-iconic */
   display: none;