Bug 1130449 - fix reuse of accesskey string for protocol handler notification "Add" button, r=gijs
authorTanner Parker <tparker12@mail.wou.edu>
Sun, 21 Feb 2016 16:05:00 +0000
changeset 321433 0566796ccc7dfea6d0a1cc0675b57795ee462d7a
parent 321432 d5153540fc53c84d11017b5c179ff8c2fe4e03b2
child 321434 6670d69a9f5101d294d2db8a272c62872a1ca791
push id5913
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 16:57:49 +0000
treeherdermozilla-beta@dcaf0a6fa115 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgijs
bugs1130449
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1130449 - fix reuse of accesskey string for protocol handler notification "Add" button, r=gijs MozReview-Commit-ID: BMJoDh77yIB
browser/components/feeds/WebContentConverter.js
browser/locales/en-US/chrome/browser/feeds/subscribe.properties
--- a/browser/components/feeds/WebContentConverter.js
+++ b/browser/components/feeds/WebContentConverter.js
@@ -408,17 +408,17 @@ WebContentConverterRegistrar.prototype =
     // Now Ask the user and provide the proper callback
     let message = this._getFormattedString("addProtocolHandler",
                                            [aTitle, uri.host, aProtocol]);
 
     let notificationIcon = uri.prePath + "/favicon.ico";
     let notificationValue = "Protocol Registration: " + aProtocol;
     let addButton = {
       label: this._getString("addProtocolHandlerAddButton"),
-      accessKey: this._getString("addHandlerAddButtonAccesskey"),
+      accessKey: this._getString("addProtocolHandlerAddButtonAccesskey"),
       protocolInfo: { protocol: aProtocol, uri: uri.spec, name: aTitle },
 
       callback(aNotification, aButtonInfo) {
           let protocol = aButtonInfo.protocolInfo.protocol;
           let uri      = aButtonInfo.protocolInfo.uri;
           let name     = aButtonInfo.protocolInfo.name;
 
           let handler = Cc["@mozilla.org/uriloader/web-handler-app;1"].
--- a/browser/locales/en-US/chrome/browser/feeds/subscribe.properties
+++ b/browser/locales/en-US/chrome/browser/feeds/subscribe.properties
@@ -44,8 +44,9 @@ feedSubscriptionVideoPodcast1=This is a 
 feedSubscriptionFeed2=You can subscribe to this feed to receive updates when this content changes.
 feedSubscriptionAudioPodcast2=You can subscribe to this podcast to receive updates when this content changes.
 feedSubscriptionVideoPodcast2=You can subscribe to this video podcast to receive updates when this content changes.
 
 # Protocol Handling
 # "Add %appName (%appDomain) as an application for %protocolType links?"
 addProtocolHandler=Add %S (%S) as an application for %S links?
 addProtocolHandlerAddButton=Add Application
+addProtocolHandlerAddButtonAccesskey=A
\ No newline at end of file