Bug 1344753 - Update for-of stack depth in ControlFlowGenerator::processWhileOrForInLoop. r=jandem
authorTooru Fujisawa <arai_a@mac.com>
Tue, 07 Mar 2017 22:41:04 +0900
changeset 394471 047b8fb1c6a353d12fe48008d64b81946ba757cb
parent 394470 0060ab5eefa8884ad78bc2e601159fdc6f99bc3f
child 394472 7183f7b691fb198e90393767a88eaacea93210bc
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1344753
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1344753 - Update for-of stack depth in ControlFlowGenerator::processWhileOrForInLoop. r=jandem
js/src/jit/IonControlFlow.cpp
--- a/js/src/jit/IonControlFlow.cpp
+++ b/js/src/jit/IonControlFlow.cpp
@@ -932,17 +932,17 @@ ControlFlowGenerator::processWhileOrForI
     // Verify that the IFNE goes back to a loophead op.
     MOZ_ASSERT(JSOp(*GetNextPc(pc)) == JSOP_LOOPHEAD);
     MOZ_ASSERT(GetNextPc(pc) == ifne + GetJumpOffset(ifne));
 
     jsbytecode* loopEntry = pc + GetJumpOffset(pc);
 
     size_t stackPhiCount;
     if (SN_TYPE(sn) == SRC_FOR_OF)
-        stackPhiCount = 2;
+        stackPhiCount = 3;
     else if (SN_TYPE(sn) == SRC_FOR_IN)
         stackPhiCount = 1;
     else
         stackPhiCount = 0;
 
     // Skip past the JSOP_LOOPHEAD for the body start.
     jsbytecode* loopHead = GetNextPc(pc);
     jsbytecode* bodyStart = GetNextPc(loopHead);