Bug 1482957 - Download minidump_stackwalk in android-hw tests; r=bc
authorGeoff Brown <gbrown@mozilla.com>
Fri, 17 Aug 2018 09:21:31 -0600
changeset 487275 04521101cd23130ce485dd3f2009666acd35dcf7
parent 487274 e8538f8a05235d2b7326908c18b72187d42d46a6
child 487276 a71e4a20a0a63fb1e996cd7a15fff11cad5fd86c
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbc
bugs1482957
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1482957 - Download minidump_stackwalk in android-hw tests; r=bc The script was setting minidump_stackwalk_path, signalling that minidump_stackwalk is expected to be found pre-installed at that location. When the path is not set, the executable is downloaded.
testing/mozharness/configs/android/android_hw.py
testing/mozharness/scripts/android_hardware_unittest.py
--- a/testing/mozharness/configs/android/android_hw.py
+++ b/testing/mozharness/configs/android/android_hw.py
@@ -18,13 +18,14 @@ config = {
         'create-virtualenv',
         'verify-device',
         'install',
         'run-tests',
     ],
     # from android_common.py
     "download_tooltool": True,
     "download_minidump_stackwalk": True,
+    "minidump_stackwalk_path": "linux64-minidump_stackwalk",
     "tooltool_servers": ['https://tooltool.mozilla-releng.net/'],
     # minidump_tooltool_manifest_path is relative to workspace/build/tests/
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/linux64/releng.manifest",
     "xpcshell_extra": "--remoteTestRoot=/data/local/tests",
 }
--- a/testing/mozharness/scripts/android_hardware_unittest.py
+++ b/testing/mozharness/scripts/android_hardware_unittest.py
@@ -101,17 +101,16 @@ class AndroidHardwareTest(TestingMixin, 
         self.logcat_file = None
         self.logcat_proc = None
         self.installer_url = c.get('installer_url')
         self.installer_path = c.get('installer_path')
         self.test_url = c.get('test_url')
         self.test_packages_url = c.get('test_packages_url')
         self.test_manifest = c.get('test_manifest')
         self.robocop_path = os.path.join(abs_dirs['abs_work_dir'], "robocop.apk")
-        self.minidump_stackwalk_path = c.get("minidump_stackwalk_path")
         self.device_name = os.environ['DEVICE_NAME']
         self.device_serial = os.environ['DEVICE_SERIAL']
         self.device_ip = os.environ['DEVICE_IP']
         self.test_suite = c.get('test_suite')
         self.this_chunk = c.get('this_chunk')
         self.total_chunks = c.get('total_chunks')
         if self.test_suite and self.test_suite not in self.config["suite_definitions"]:
             # accept old-style test suite name like "mochitest-3"