Bug 1190935 - Fix race condition in gtk window EndRemoteDrawingInRegion. r=nical
authorLee Salzman <lsalzman@mozilla.com>
Thu, 06 Aug 2015 11:02:03 -0400
changeset 288352 03c0f6885ea1c8508c6f1f162401f36ac2db67ef
parent 288351 0993bd17c8237fc3b82b082cfc4b28d7798e087a
child 288353 ea804beb9ff6e532f66e30b402b6bab37c2af83f
push id5067
push userraliiev@mozilla.com
push dateMon, 21 Sep 2015 14:04:52 +0000
treeherdermozilla-beta@14221ffe5b2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnical
bugs1190935
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1190935 - Fix race condition in gtk window EndRemoteDrawingInRegion. r=nical
widget/gtk/nsWindow.cpp
--- a/widget/gtk/nsWindow.cpp
+++ b/widget/gtk/nsWindow.cpp
@@ -6199,19 +6199,19 @@ nsWindow::StartRemoteDrawing()
   }
 }
 
 void
 nsWindow::EndRemoteDrawingInRegion(DrawTarget* aDrawTarget, nsIntRegion& aInvalidRegion)
 {
 #ifdef MOZ_X11
 #  ifdef MOZ_HAVE_SHMIMAGE
-  if (!mGdkWindow || mIsFullyObscured || !mHasMappedToplevel || mIsDestroyed ||
-      !mShmImage)
+  if (!mGdkWindow || !mShmImage) {
     return;
+  }
 
   if (mThebesSurface) {
     aInvalidRegion.AndWith(nsIntRect(nsIntPoint(0, 0), mThebesSurface->GetSize()));
   }
 
   mShmImage->Put(mGdkWindow, aInvalidRegion);
 
 #  endif // MOZ_HAVE_SHMIMAGE