Bug 1520647: Add a comment explaining why fdlibm sources can't be unified. DONTBUILD
authorDavid Major <dmajor@mozilla.com>
Fri, 18 Jan 2019 21:28:18 -0500
changeset 511697 030a5f34fa318505c9daa0f0b99d8ebc8ab206a3
parent 511696 5b1c54cbac38c0be22e4f8441710629d620807a1
child 511698 1d1f4d473d92581e24f46a822968f024e28203b0
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1520647
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520647: Add a comment explaining why fdlibm sources can't be unified. DONTBUILD
modules/fdlibm/src/moz.build
--- a/modules/fdlibm/src/moz.build
+++ b/modules/fdlibm/src/moz.build
@@ -25,16 +25,18 @@ if CONFIG['CC_TYPE'] in ('msvc', 'clang-
     CXXFLAGS += [
         '-wd4018', # signed/unsigned mismatch
         '-wd4146', # unary minus operator applied to unsigned type
         '-wd4305', # truncation from 'double' to 'const float'
         '-wd4723', # potential divide by 0
         '-wd4756', # overflow in constant arithmetic
     ]
 
+# These sources can't be unified because there are too many conflicting global
+# variables (e.g. almost every source file defines a `one` and a `huge`).
 SOURCES += [
     'e_acos.cpp',
     'e_acosh.cpp',
     'e_asin.cpp',
     'e_atan2.cpp',
     'e_atanh.cpp',
     'e_cosh.cpp',
     'e_exp.cpp',