Bug 1536668 - Add more check to RecvGetTextureFactoryIdentifier() r=nical
authorsotaro <sotaro.ikeda.g@gmail.com>
Thu, 09 May 2019 07:37:03 +0000
changeset 532381 02b3eb8a1a1388f91c73cce582ce1e2b972f11f7
parent 532380 441e225e25eb16f655ca20745168da240de9f9e4
child 532382 d77d76d37d4dccf39c12fa81c970088b5388d0f1
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnical
bugs1536668
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1536668 - Add more check to RecvGetTextureFactoryIdentifier() r=nical Add a check similar to LayerTransactionParent::RecvSetAsyncZoom() Differential Revision: https://phabricator.services.mozilla.com/D30308
gfx/layers/ipc/LayerTransactionParent.cpp
--- a/gfx/layers/ipc/LayerTransactionParent.cpp
+++ b/gfx/layers/ipc/LayerTransactionParent.cpp
@@ -1026,17 +1026,17 @@ mozilla::ipc::IPCResult LayerTransaction
   if (mLayerManager && mCompositorBridge->IsRemote()) {
     mLayerManager->RecordPaintTimes(aTiming);
   }
   return IPC_OK();
 }
 
 mozilla::ipc::IPCResult LayerTransactionParent::RecvGetTextureFactoryIdentifier(
     TextureFactoryIdentifier* aIdentifier) {
-  if (!mLayerManager) {
+  if (mDestroyed || !mLayerManager || mLayerManager->IsDestroyed()) {
     // Default constructor sets mParentBackend to LAYERS_NONE.
     return IPC_OK();
   }
 
   *aIdentifier = mLayerManager->GetTextureFactoryIdentifier();
   return IPC_OK();
 }