Bug 647550 - Signed-unsigned comparison in nsIconChannel::InitWithGnome; r=bholley
authorMs2ger <ms2ger@gmail.com>
Thu, 07 Apr 2011 21:55:43 -0700
changeset 67646 0243906e73713b90c581b68dc903111a3f3884f2
parent 67645 d74ffcefded77024aedaf09023008f4fdb236c05
child 67647 2763b8586e8842a66162a8437b0969fc7ccac836
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbholley
bugs647550
milestone2.2a1pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 647550 - Signed-unsigned comparison in nsIconChannel::InitWithGnome; r=bholley
modules/libpr0n/decoders/icon/gtk/nsIconChannel.cpp
--- a/modules/libpr0n/decoders/icon/gtk/nsIconChannel.cpp
+++ b/modules/libpr0n/decoders/icon/gtk/nsIconChannel.cpp
@@ -410,18 +410,18 @@ nsIconChannel::InitWithGnome(nsIMozIconU
   
   if (!buf) {
     if (err)
       g_error_free(err);
     return NS_ERROR_UNEXPECTED;
   }
 
   GdkPixbuf* scaled = buf;
-  if (gdk_pixbuf_get_width(buf)  != iconSize &&
-      gdk_pixbuf_get_height(buf) != iconSize) {
+  if (PRUint32(gdk_pixbuf_get_width(buf))  != iconSize &&
+      PRUint32(gdk_pixbuf_get_height(buf)) != iconSize) {
     // scale...
     scaled = gdk_pixbuf_scale_simple(buf, iconSize, iconSize,
                                      GDK_INTERP_BILINEAR);
     g_object_unref(buf);
     if (!scaled)
       return NS_ERROR_OUT_OF_MEMORY;
   }