Bug 1134931: Add some missing MOZ_OVERRIDE annotations in ServiceWorkerManager.cpp, nsFrameMessageManager.cpp, and 2D.h. r=ehsan
authorDaniel Holbert <dholbert@cs.stanford.edu>
Fri, 20 Feb 2015 09:25:07 -0800
changeset 257116 00ea6409e912aac7552509669a8f0528595259ba
parent 257115 0645b0eeb7202ee9e3aa0a0fe90b2affabbc79bc
child 257117 c8a99ee9731326128b418be6fed2a30879f68c29
push id4610
push userjlund@mozilla.com
push dateMon, 30 Mar 2015 18:32:55 +0000
treeherdermozilla-beta@4df54044d9ef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs1134931
milestone38.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1134931: Add some missing MOZ_OVERRIDE annotations in ServiceWorkerManager.cpp, nsFrameMessageManager.cpp, and 2D.h. r=ehsan
dom/base/nsFrameMessageManager.cpp
dom/workers/ServiceWorkerManager.cpp
gfx/2d/2D.h
--- a/dom/base/nsFrameMessageManager.cpp
+++ b/dom/base/nsFrameMessageManager.cpp
@@ -1734,44 +1734,44 @@ public:
     global->LoadScript(aURL);
     return true;
   }
 
   virtual bool DoSendAsyncMessage(JSContext* aCx,
                                   const nsAString& aMessage,
                                   const StructuredCloneData& aData,
                                   JS::Handle<JSObject *> aCpows,
-                                  nsIPrincipal* aPrincipal)
+                                  nsIPrincipal* aPrincipal) MOZ_OVERRIDE
   {
     nsRefPtr<nsIRunnable> ev =
       new nsAsyncMessageToSameProcessChild(aCx, aMessage, aData, aCpows,
                                            aPrincipal);
     NS_DispatchToCurrentThread(ev);
     return true;
   }
 
-  bool CheckPermission(const nsAString& aPermission)
+  bool CheckPermission(const nsAString& aPermission) MOZ_OVERRIDE
   {
     // In a single-process scenario, the child always has all capabilities.
     return true;
   }
 
-  bool CheckManifestURL(const nsAString& aManifestURL)
+  bool CheckManifestURL(const nsAString& aManifestURL) MOZ_OVERRIDE
   {
     // In a single-process scenario, the child always has all capabilities.
     return true;
   }
 
-  bool CheckAppHasPermission(const nsAString& aPermission)
+  bool CheckAppHasPermission(const nsAString& aPermission) MOZ_OVERRIDE
   {
     // In a single-process scenario, the child always has all capabilities.
     return true;
   }
 
-  virtual bool CheckAppHasStatus(unsigned short aStatus)
+  virtual bool CheckAppHasStatus(unsigned short aStatus) MOZ_OVERRIDE
   {
     // In a single-process scenario, the child always has all capabilities.
     return true;
   }
 };
 
 
 /**
--- a/dom/workers/ServiceWorkerManager.cpp
+++ b/dom/workers/ServiceWorkerManager.cpp
@@ -422,17 +422,17 @@ public:
                                                        const nsMainThreadPtrHandle<nsISupports> aJob)
     : WorkerRunnable(aWorkerPrivate, WorkerThreadUnchangedBusyCount)
     , mJob(aJob)
   { 
     AssertIsOnMainThread();
   }
 
   bool
-  WorkerRun(JSContext* aCx, WorkerPrivate* aWorkerPrivate)
+  WorkerRun(JSContext* aCx, WorkerPrivate* aWorkerPrivate) MOZ_OVERRIDE
   {
     aWorkerPrivate->AssertIsOnWorkerThread();
     if (aWorkerPrivate->WorkerScriptExecutedSuccessfully()) {
       nsRefPtr<ContinueUpdateRunnable> r = new ContinueUpdateRunnable(mJob);
       nsresult rv = NS_DispatchToMainThread(r);
       if (NS_FAILED(rv)) {
         NS_WARNING("Failed to dispatch ContinueUpdateRunnable to main thread.");
       }
@@ -2149,17 +2149,17 @@ public:
     , mWindowId(aWindowId)
   {
     MOZ_ASSERT(aWorkerPrivate);
   }
 
   NS_DECL_ISUPPORTS_INHERITED
 
   NS_IMETHOD
-  VisitHeader(const nsACString& aHeader, const nsACString& aValue)
+  VisitHeader(const nsACString& aHeader, const nsACString& aValue) MOZ_OVERRIDE
   {
     mHeaderNames.AppendElement(aHeader);
     mHeaderValues.AppendElement(aValue);
     return NS_OK;
   }
 
   nsresult
   Init()
@@ -2190,17 +2190,17 @@ public:
 
     rv = httpChannel->VisitRequestHeaders(this);
     NS_ENSURE_SUCCESS(rv, rv);
 
     return NS_OK;
   }
 
   bool
-  WorkerRun(JSContext* aCx, WorkerPrivate* aWorkerPrivate)
+  WorkerRun(JSContext* aCx, WorkerPrivate* aWorkerPrivate) MOZ_OVERRIDE
   {
     MOZ_ASSERT(aWorkerPrivate);
     return DispatchFetchEvent(aCx, aWorkerPrivate);
   }
 
 private:
   ~FetchEventRunnable() {}
 
--- a/gfx/2d/2D.h
+++ b/gfx/2d/2D.h
@@ -366,17 +366,17 @@ protected:
   virtual void GuaranteePersistance() {}
 
   UserData mUserData;
 };
 
 class DataSourceSurface : public SourceSurface
 {
 public:
-  MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(DataSourceSurface)
+  MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(DataSourceSurface, MOZ_OVERRIDE)
   DataSourceSurface()
     : mIsMapped(false)
   {
   }
 
 #ifdef DEBUG
   virtual ~DataSourceSurface()
   {