Bug 1383904 - Show old OS X elevation dialog on elevation fail r=rstrong, a=rkothari
authorDoug Thayer <dothayer@mozilla.com>
Mon, 24 Jul 2017 16:29:20 -0700
changeset 412074 009589ce9026
parent 412073 5ff8131b5512
child 412075 c074a7c69384
push id7542
push userrstrong@mozilla.com
push dateMon, 24 Jul 2017 23:29:26 +0000
treeherdermozilla-beta@009589ce9026 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrstrong, rkothari
bugs1383904
milestone55.0
Bug 1383904 - Show old OS X elevation dialog on elevation fail r=rstrong, a=rkothari The patch which originally disabled this seems to have been in error, thinking it was the cause of failing tests on try. Can't provide much more context than that.
toolkit/mozapps/update/nsUpdateService.js
--- a/toolkit/mozapps/update/nsUpdateService.js
+++ b/toolkit/mozapps/update/nsUpdateService.js
@@ -3874,17 +3874,16 @@ UpdatePrompt.prototype = {
                  "Update:History", null, null);
   },
 
   /**
    * See nsIUpdateService.idl
    */
   showUpdateElevationRequired: function UP_showUpdateElevationRequired() {
     if (getPref("getBoolPref", PREF_APP_UPDATE_SILENT, false) ||
-        getPref("getBoolPref", PREF_APP_UPDATE_DOORHANGER, false) ||
         this._getAltUpdateWindow()) {
       return;
     }
 
     let um = Cc["@mozilla.org/updates/update-manager;1"].
              getService(Ci.nsIUpdateManager);
     this._showUI(null, URI_UPDATE_PROMPT_DIALOG, null,
                  UPDATE_WINDOW_NAME, "finishedBackground", um.activeUpdate);