Bug 1137890 - Let containerless scrolling ride the trains. r=kats
authorBotond Ballo <botond@mozilla.com>
Fri, 15 Mar 2019 18:12:27 +0000
changeset 522095 007b5a2e825a543d24783e7b5b65e9e44db34cb7
parent 522094 9f34d0075a7300366203a37ac0155aa2198fdf7a
child 522096 db7eb307e78b6d4831dd36804f5c1b5933a093f8
push id10871
push usercbrindusan@mozilla.com
push dateMon, 18 Mar 2019 15:49:32 +0000
treeherdermozilla-beta@018abdd16060 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskats
bugs1137890
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1137890 - Let containerless scrolling ride the trains. r=kats Differential Revision: https://phabricator.services.mozilla.com/D23370
layout/reftests/bugs/reftest.list
layout/reftests/webm-video/reftest.list
mobile/android/app/geckoview-prefs.js
mobile/android/app/mobile.js
--- a/layout/reftests/bugs/reftest.list
+++ b/layout/reftests/bugs/reftest.list
@@ -1914,23 +1914,23 @@ pref(apz.allow_zooming,true) skip-if(!An
 pref(apz.allow_zooming,true) skip-if(!Android) fails-if(Android) == 1133905-5-v.html 1133905-ref-v.html # bug 1308702
 pref(apz.allow_zooming,true) skip-if(!Android) fails-if(Android) == 1133905-6-v.html 1133905-ref-v.html # bug 1308702
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-1-h.html 1133905-ref-h.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-2-h.html 1133905-ref-h.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-3-h.html 1133905-ref-h.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-4-h.html 1133905-ref-h.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-5-h.html 1133905-ref-h.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-6-h.html 1133905-ref-h.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fuzzy-if(Android,0-54,0-6) == 1133905-1-vh.html 1133905-ref-vh.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fuzzy-if(Android,0-45,0-4) == 1133905-2-vh.html 1133905-ref-vh.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) == 1133905-3-vh.html 1133905-ref-vh.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fuzzy-if(Android,0-45,0-4) == 1133905-4-vh.html 1133905-ref-vh.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fuzzy-if(Android,0-54,0-6) == 1133905-5-vh.html 1133905-ref-vh.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fuzzy-if(Android,0-54,0-8) == 1133905-6-vh.html 1133905-ref-vh.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) != 1133905-ref-vh.html about:blank # make sure it doesn't render blank
+pref(apz.allow_zooming,true) skip-if(!Android) fuzzy-if(Android,0-54,0-6) == 1133905-1-vh.html 1133905-ref-vh.html
+pref(apz.allow_zooming,true) skip-if(!Android) fuzzy-if(Android,0-45,0-4) == 1133905-2-vh.html 1133905-ref-vh.html
+pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-3-vh.html 1133905-ref-vh.html
+pref(apz.allow_zooming,true) skip-if(!Android) fuzzy-if(Android,0-45,0-4) == 1133905-4-vh.html 1133905-ref-vh.html
+pref(apz.allow_zooming,true) skip-if(!Android) fuzzy-if(Android,0-54,0-6) == 1133905-5-vh.html 1133905-ref-vh.html
+pref(apz.allow_zooming,true) skip-if(!Android) fuzzy-if(Android,0-54,0-8) == 1133905-6-vh.html 1133905-ref-vh.html
+pref(apz.allow_zooming,true) skip-if(!Android) != 1133905-ref-vh.html about:blank # make sure it doesn't render blank
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-1-rtl.html 1133905-ref-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-2-rtl.html 1133905-ref-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-3-rtl.html 1133905-ref-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-4-rtl.html 1133905-ref-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-5-rtl.html 1133905-ref-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-6-rtl.html 1133905-ref-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-1-v-rtl.html 1133905-ref-v-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-2-v-rtl.html 1133905-ref-v-rtl.html
@@ -1939,23 +1939,23 @@ pref(apz.allow_zooming,true) skip-if(!An
 pref(apz.allow_zooming,true) skip-if(!Android) fails-if(Android) == 1133905-5-v-rtl.html 1133905-ref-v-rtl.html # bug 1308702
 pref(apz.allow_zooming,true) skip-if(!Android) fails-if(Android) == 1133905-6-v-rtl.html 1133905-ref-v-rtl.html # bug 1308702
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-1-h-rtl.html 1133905-ref-h-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-2-h-rtl.html 1133905-ref-h-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-3-h-rtl.html 1133905-ref-h-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-4-h-rtl.html 1133905-ref-h-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-5-h-rtl.html 1133905-ref-h-rtl.html
 pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-6-h-rtl.html 1133905-ref-h-rtl.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fuzzy-if(Android,0-54,0-6) == 1133905-1-vh-rtl.html 1133905-ref-vh-rtl.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fuzzy-if(Android,0-45,0-4) == 1133905-2-vh-rtl.html 1133905-ref-vh-rtl.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) == 1133905-3-vh-rtl.html 1133905-ref-vh-rtl.html
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fails-if(Android) == 1133905-4-vh-rtl.html 1133905-ref-vh-rtl.html # bug 1527511
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fails-if(Android) == 1133905-5-vh-rtl.html 1133905-ref-vh-rtl.html # bug 1527511
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) fails-if(Android) == 1133905-6-vh-rtl.html 1133905-ref-vh-rtl.html # bug 1527511
-pref(apz.allow_zooming,true) pref(layout.scroll.root-frame-containers,0) skip-if(!Android) != 1133905-ref-vh-rtl.html about:blank # make sure it doesn't render blank
+pref(apz.allow_zooming,true) skip-if(!Android) fuzzy-if(Android,0-54,0-6) == 1133905-1-vh-rtl.html 1133905-ref-vh-rtl.html
+pref(apz.allow_zooming,true) skip-if(!Android) fuzzy-if(Android,0-45,0-4) == 1133905-2-vh-rtl.html 1133905-ref-vh-rtl.html
+pref(apz.allow_zooming,true) skip-if(!Android) == 1133905-3-vh-rtl.html 1133905-ref-vh-rtl.html
+pref(apz.allow_zooming,true) skip-if(!Android) fails-if(Android) == 1133905-4-vh-rtl.html 1133905-ref-vh-rtl.html # bug 1527511
+pref(apz.allow_zooming,true) skip-if(!Android) fails-if(Android) == 1133905-5-vh-rtl.html 1133905-ref-vh-rtl.html # bug 1527511
+pref(apz.allow_zooming,true) skip-if(!Android) fails-if(Android) == 1133905-6-vh-rtl.html 1133905-ref-vh-rtl.html # bug 1527511
+pref(apz.allow_zooming,true) skip-if(!Android) != 1133905-ref-vh-rtl.html about:blank # make sure it doesn't render blank
 == 1149304-1-transform-change.html 1149304-1-transform-change-ref.html
 == 1150021-1.xul 1150021-1-ref.xul
 == 1151145-1.html 1151145-1-ref.html
 == 1151306-1.html 1151306-1-ref.html
 == 1153845-1.html 1153845-1-ref.html
 == 1155828-1.html 1155828-1-ref.html
 fuzzy-if(skiaContent,0-7,0-84) == 1156129-1.html 1156129-1-ref.html
 pref(dom.use_xbl_scopes_for_remote_xul,true) HTTP(..) == 1157127-1.html 1157127-1-ref.html
--- a/layout/reftests/webm-video/reftest.list
+++ b/layout/reftests/webm-video/reftest.list
@@ -19,18 +19,18 @@ skip-if(Android) == offset-1.xhtml offse
 random skip-if(Android) == object-aspect-ratio-2a.xhtml aspect-ratio-2-ref.html
 random skip-if(Android) == object-aspect-ratio-2b.xhtml aspect-ratio-2-ref.html
 skip-if(Android) fuzzy-if(winWidget,0-1,0-56000) fuzzy-if(cocoaWidget,0-1,0-56000) == zoomed-1.xhtml zoomed-1-ref.html # bug 778995 for fuzzy
 == poster-1.html poster-ref-blue250x200.html
 fails-if(Android) skip-if(Android&&AndroidVersion=='18') == poster-2.html poster-ref-black140x100.html
 random-if(Android) == poster-3.html poster-ref-black140x100.html
 == poster-4.html poster-ref-black140x100.html
 random-if(Android) == poster-5.html poster-ref-black140x100.html
-fails-if(Android&&!release_or_beta) == poster-6.html poster-ref-black140x100.html
-fails-if(Android&&!release_or_beta) == poster-7.html poster-ref-red140x100.html
+fails-if(Android) == poster-6.html poster-ref-black140x100.html
+fails-if(Android) == poster-7.html poster-ref-red140x100.html
 fuzzy-if(Android,0-2,0-14000) == poster-8.html poster-ref-black140x100.html
 random == poster-10.html poster-ref-blue125x100.html
 random == poster-11.html poster-ref-blue140x100.html
 random == poster-12.html poster-ref-blue140x100.html
 random-if(Android) == poster-13.html poster-ref-blue400x300.html
 random-if(Android) == poster-15.html poster-ref-green70x30.html
 random-if(winWidget) random-if(cocoaWidget) skip-if(Android) == bug686957.html bug686957-ref.html # bug 922951 for OS X
 == webm-alpha.html webm-alpha-ref.html
--- a/mobile/android/app/geckoview-prefs.js
+++ b/mobile/android/app/geckoview-prefs.js
@@ -24,25 +24,18 @@ pref("geckoview.console.enabled", false)
 pref("geckoview.logging", "Warn");
 #else
 pref("geckoview.logging", "Debug");
 #endif
 
 // Disable Web Push until we get it working
 pref("dom.push.enabled", false);
 
-// Use containerless scrolling on the Nightly channel.
-// Bug 1137890 tracks letting it ride the trains.
-// For now, on non-Nightly channels we use containerless scrolling with
-// WebRender only (that's what the "2" means).
-#ifdef NIGHTLY_BUILD
+// Use containerless scrolling.
 pref("layout.scroll.root-frame-containers", 0);
-#else
-pref("layout.scroll.root-frame-containers", 2);
-#endif
 
 // Inherit locale from the OS, used for multi-locale builds
 pref("intl.locale.requested", "");
 
 // Enable Safe Browsing blocklist updates
 pref("browser.safebrowsing.features.phishing.update", true);
 pref("browser.safebrowsing.features.malware.update", true);
 
--- a/mobile/android/app/mobile.js
+++ b/mobile/android/app/mobile.js
@@ -533,23 +533,18 @@ pref("layers.low-precision-resolution", 
 pref("layers.low-precision-opacity", "1.0");
 // We want to limit layers for two reasons:
 // 1) We can't scroll smoothly if we have to many draw calls
 // 2) Pages that have too many layers consume too much memory and crash.
 // By limiting the number of layers on mobile we're making the main thread
 // work harder keep scrolling smooth and memory low.
 pref("layers.max-active", 20);
 
-// Use containerless scrolling in nightly builds on Fennec.
-// Bug 1137890 tracks letting containerless scrolling ride the trains.
-#ifdef NIGHTLY_BUILD
+// Use containerless scrolling on Fennec.
 pref("layout.scroll.root-frame-containers", 0);
-#else
-pref("layout.scroll.root-frame-containers", 1);
-#endif
 
 pref("notification.feature.enabled", true);
 pref("dom.webnotifications.enabled", true);
 
 // prevent tooltips from showing up
 pref("browser.chrome.toolbar_tips", false);
 
 // don't allow meta-refresh when backgrounded