bug 1546945: remote: temporarily stop implying --enable-cdp; r=aryx
authorAndreas Tolfsen <ato@sny.no>
Thu, 25 Apr 2019 12:27:46 +0000
changeset 530117 004d050a8ec44987f44fd86c62097266b22b915e
parent 530116 988b90e06a7ad93c32eed60b0f765997d88caffb
child 530118 82a99a3ad6682ed02122d4444795010a691c55e8
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaryx
bugs1546945, 1533831
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1546945: remote: temporarily stop implying --enable-cdp; r=aryx As detailed in https://bugzilla.mozilla.org/show_bug.cgi?id=1546945, enabling the remote agent in the default Firefox Nightly build (https://bugzilla.mozilla.org/show_bug.cgi?id=1533831) caused a leakcheck in M-bc to fail. This patch cuts the remote agent off from the build, by stopping to imply --enable-cdp, until we have had time to fix the leak. Differential Revision: https://phabricator.services.mozilla.com/D28823
toolkit/moz.configure
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -914,24 +914,19 @@ add_old_configure_assignment('FT2_CFLAGS
 
 
 # Remote agent (part of CDP based remote protocol)
 # ==============================================================
 #
 # See https://firefox-source-docs.mozilla.org/remote/ for more.
 # The source code lives under ../remote.
 
-@depends(target, milestone)
-def remote_default(target, milestone):
-    return target.os != 'Android' and milestone.is_nightly
+option('--enable-cdp', help='{Enable|Disable} remote agent')
 
-option('--disable-cdp', default=remote_default,
-       help='{Enable|Disable} remote agent')
-
-@depends('--disable-cdp')
+@depends('--enable-cdp')
 def remote(value):
     if value:
         return True
 
 set_config('ENABLE_REMOTE_AGENT', remote)
 set_define('ENABLE_REMOTE_AGENT', remote)