Bug 1121479 - Part 3: Turn on HEAP_TERMINATE process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
authorBob Owen <bobowencode@gmail.com>
Wed, 21 Jan 2015 07:59:56 +0000
changeset 249378 004776aa9aa52478f842128c0a8e2c36c2b48ed3
parent 249377 cf64f625cd033006eb58427076a41726bcd22a78
child 249379 7b6674e5a437cd681ffba5013108ef497ad8d75e
push id4489
push userraliiev@mozilla.com
push dateMon, 23 Feb 2015 15:17:55 +0000
treeherdermozilla-beta@fd7c3dc24146 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstabraldes, sledru
bugs1121479
milestone37.0a2
Bug 1121479 - Part 3: Turn on HEAP_TERMINATE process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp
--- a/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp
+++ b/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp
@@ -167,16 +167,17 @@ SandboxBroker::SetSecurityLevelForGMPlug
   result = mPolicy->SetIntegrityLevel(sandbox::INTEGRITY_LEVEL_LOW);
   ret = ret && (sandbox::SBOX_ALL_OK == result);
 
   result =
     mPolicy->SetDelayedIntegrityLevel(sandbox::INTEGRITY_LEVEL_UNTRUSTED);
   ret = ret && (sandbox::SBOX_ALL_OK == result);
 
   sandbox::MitigationFlags mitigations =
+    sandbox::MITIGATION_HEAP_TERMINATE |
     sandbox::MITIGATION_SEHOP |
     sandbox::MITIGATION_DEP;
 
   result = mPolicy->SetProcessMitigations(mitigations);
   ret = ret && (sandbox::SBOX_ALL_OK == result);
 
   // Add the policy for the client side of a pipe. It is just a file
   // in the \pipe\ namespace. We restrict it to pipes that start with