Bug 1552191 - Fix webreplay tests using webconsole context menu r=jlast
authorJulian Descottes <jdescottes@mozilla.com>
Fri, 17 May 2019 17:12:52 +0000
changeset 533186 0013ca341d7c9e7dbb6195967002e7b1963da679
parent 533185 695621ee868dc607e49f848c72be87fe7a14c909
child 533187 21607f778c71f98666bd5d5520a3839abc615c29
push id11276
push userrgurzau@mozilla.com
push dateMon, 20 May 2019 13:11:24 +0000
treeherdermozilla-beta@847755a7c325 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjlast
bugs1552191
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1552191 - Fix webreplay tests using webconsole context menu r=jlast 3 webreplay tests regressed while the webreplay test suite was no longer running on try. Differential Revision: https://phabricator.services.mozilla.com/D31482
devtools/client/debugger/test/mochitest/helpers.js
devtools/client/webreplay/mochitest/browser.ini
--- a/devtools/client/debugger/test/mochitest/helpers.js
+++ b/devtools/client/debugger/test/mochitest/helpers.js
@@ -1713,23 +1713,23 @@ async function getDebuggerSplitConsole(d
   await toolbox.openSplitConsole();
   return toolbox.getPanel("webconsole");
 }
 
 async function openConsoleContextMenu(hud, element) {
   const onConsoleMenuOpened = hud.ui.wrapper.once("menu-open");
   synthesizeContextMenuEvent(element);
   await onConsoleMenuOpened;
-  const doc = hud.chromeWindow.document;
-  return doc.getElementById("webconsole-menu");
+  const toolbox = gDevTools.getToolbox(hud.target);
+  return toolbox.topDoc.getElementById("webconsole-menu");
 }
 
 function hideConsoleContextMenu(hud) {
-  const doc = hud.chromeWindow.document;
-  const popup = doc.getElementById("webconsole-menu");
+  const toolbox = gDevTools.getToolbox(hud.target);
+  const popup = toolbox.topDoc.getElementById("webconsole-menu");
   if (!popup) {
     return Promise.resolve();
   }
 
   const onPopupHidden = once(popup, "popuphidden");
   popup.hidePopup();
   return onPopupHidden;
 }
--- a/devtools/client/webreplay/mochitest/browser.ini
+++ b/devtools/client/webreplay/mochitest/browser.ini
@@ -30,17 +30,14 @@ support-files =
 [browser_dbg_rr_stepping-01.js]
 [browser_dbg_rr_stepping-02.js]
 [browser_dbg_rr_stepping-03.js]
 [browser_dbg_rr_stepping-04.js]
 [browser_dbg_rr_replay-01.js]
 [browser_dbg_rr_replay-02.js]
 [browser_dbg_rr_replay-03.js]
 [browser_dbg_rr_console_warp-01.js]
-skip-if = true
 [browser_dbg_rr_console_warp-02.js]
-skip-if = true
 [browser_dbg_rr_logpoint-01.js]
-skip-if = true
 [browser_dbg_rr_logpoint-02.js]
 [browser_rr_inspector-01.js]
 [browser_rr_inspector-02.js]
 [browser_rr_inspector-03.js]