searching for reviewer(yulia)
36629188da45f0fd85746523f7986621839c6f33: Bug 1549397 - add progress indicator to accessibility panel audit. r=yulia,flod
Yura Zenevich <yura.zenevich@gmail.com> - Mon, 13 May 2019 14:01:16 +0000 - rev 532425
Push 11268 by csabou@mozilla.com at Tue, 14 May 2019 15:24:22 +0000
Bug 1549397 - add progress indicator to accessibility panel audit. r=yulia,flod Differential Revision: https://phabricator.services.mozilla.com/D30454
2222d7465ff705104ba61283d0a12302ea332048: bug 1546722: remote: print better errors in browser chrome tests; r=yulia
Andreas Tolfsen <ato@sny.no> - Thu, 25 Apr 2019 15:16:46 +0000 - rev 530141
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1546722: remote: print better errors in browser chrome tests; r=yulia We can reconstruct the CDP error and print a better error message using RemoteAgentError. This is better than the current output, which in a lot of cases will be "CDP Exception: [object Object]". A possible future improvement to this involves extending the CDP protocol to send the individual components of the error individually, so that we don't have to parse the string. Differential Revision: https://phabricator.services.mozilla.com/D28703
da2d4529a200f41df8978b0310f1f1c9d7f9cb4e: bug 1533831: remote: remove browser.fission.simulate pref; r=ochameau,yulia
Andreas Tolfsen <ato@sny.no> - Wed, 24 Apr 2019 17:18:44 +0000 - rev 529996
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1533831: remote: remove browser.fission.simulate pref; r=ochameau,yulia The browser.fission.simulate preference has been split into two preferences: fission.frontend.simulate-events and fission.frontend.simulate-messages. The remote agent briefly used the child actor system from the Firefox frontend code when we prototyped the initial remote agent, but it no longer relies on it. This means we can drop the reference to browser.fission.simulate altogether. DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D27538
c03450df8660750fd81a17f2cf858536572760f7: bug 1533831: remote: remove browser.fission.simulate pref; r=ochameau,yulia
Andreas Tolfsen <ato@sny.no> - Wed, 24 Apr 2019 15:17:50 +0000 - rev 529487
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1533831: remote: remove browser.fission.simulate pref; r=ochameau,yulia The browser.fission.simulate preference has been split into two preferences: fission.frontend.simulate-events and fission.frontend.simulate-messages. The remote agent briefly used the child actor system from the Firefox frontend code when we prototyped the initial remote agent, but it no longer relies on it. This means we can drop the reference to browser.fission.simulate altogether. DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D27538
b818d6ca606d15354929e7c5a65b6448e7d43eef: bug 1533831: remote: remove browser.fission.simulate pref; r=ochameau,yulia
Andreas Tolfsen <ato@sny.no> - Wed, 17 Apr 2019 16:41:29 +0000 - rev 528749
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1533831: remote: remove browser.fission.simulate pref; r=ochameau,yulia The browser.fission.simulate preference has been split into two preferences: fission.frontend.simulate-events and fission.frontend.simulate-messages. The remote agent briefly used the child actor system from the Firefox frontend code when we prototyped the initial remote agent, but it no longer relies on it. This means we can drop the reference to browser.fission.simulate altogether. DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D27538
45358a231fb38928efa37c1fd72cc0d21423ca70: bug 1543676: remote: avoid Preferences.jsm before first paint; r=yulia
Andreas Tolfsen <ato@sny.no> - Mon, 15 Apr 2019 14:41:21 +0000 - rev 528327
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1543676: remote: avoid Preferences.jsm before first paint; r=yulia It is illegal for any code to depend on Preferences.jsm before first paint. This enforced by browser/base/content/test/performance/browser_startup.js, so we must change remote/RemoteAgent.jsm to use an alternate mechanism for getting at the preferences it needs. Differential Revision: https://phabricator.services.mozilla.com/D27246
04185cfeb1ae23cec53a2dadc7d6490022989cda: bug 1543679: remote: remove unused server files; r=ochameau,yulia
Andreas Tolfsen <ato@sny.no> - Mon, 15 Apr 2019 14:06:25 +0000 - rev 528312
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1543679: remote: remove unused server files; r=ochameau,yulia These files became redundant after we started serving WebSocket connections from the HTTPD. This fixes the test browser/base/content/test/static/browser_all_files_referenced.js, which checks for unreferenced JSMs. Differential Revision: https://phabricator.services.mozilla.com/D27247
95f4b83aed87e9d8638987cf30b40f5ac6cd1821: bug 1534827: remote: fix constants in transitionToLoadFlag; r=yulia
Andreas Tolfsen <ato@sny.no> - Wed, 13 Mar 2019 14:35:57 +0000 - rev 521709
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
bug 1534827: remote: fix constants in transitionToLoadFlag; r=yulia The transitionType is converted into undefined because there is a typo in the constants. These should be "FLAGS" rather than "FLAG". Thanks-to: Mark Banner <standard8@mozilla.com> Differential Revision: https://phabricator.services.mozilla.com/D23315
a710a25b6c5d3274fb80cf22af7fcc50ce306256: bug 1534829: remote: map source code to bug components; r=yulia
Andreas Tolfsen <ato@sny.no> - Wed, 13 Mar 2019 14:03:16 +0000 - rev 521708
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
bug 1534829: remote: map source code to bug components; r=yulia DevTools :: Remote Agent was removed in favour of a new product, Remote Protocol. This corrects the file metadata mapping for the agent. The patch also adds mapping for new domains. Not all of the components exist yet, but this is tracked separately in https://bugzilla.mozilla.org/show_bug.cgi?id=1534970. Differential Revision: https://phabricator.services.mozilla.com/D23306
ce4157f3f9673dc0b82f38c94b32a8c27adadbe8: Bug 1533938 - Fix regression from refactor of connect.js page. r=yulia
Logan Smyth <loganfsmyth@gmail.com> - Mon, 11 Mar 2019 10:04:22 +0000 - rev 521430
Push 10866 by nerli@mozilla.com at Tue, 12 Mar 2019 18:59:09 +0000
Bug 1533938 - Fix regression from refactor of connect.js page. r=yulia Looks like this regressed in a patch for bug 1520774. Differential Revision: https://phabricator.services.mozilla.com/D22811
fb3cbe9457a98eddda6488517d6a70ce3ab64a16: Bug 1457109 - Open links in the next tab, in background if Ctrl/Cmd is pressed; r=yulia.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 05 Mar 2019 14:10:19 +0000 - rev 520426
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1457109 - Open links in the next tab, in background if Ctrl/Cmd is pressed; r=yulia. This patch passes the relevant options to the `openDocLink` function, which means now links: - will open right next to the current tab - will open in background if Ctrl/Cmd is pressed. A test case is added to ensures this works as expected. Differential Revision: https://phabricator.services.mozilla.com/D22075
6f356dac426598f80c6ab9d6b4bf983ac8a7f4a1: Bug 1529497 - Remove `promise` and `defer` usage in `devtools/shared/DevToolsUtils.js`; r=yulia.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 27 Feb 2019 13:28:16 +0000 - rev 519319
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1529497 - Remove `promise` and `defer` usage in `devtools/shared/DevToolsUtils.js`; r=yulia. The `yieldingEach` is moved into the only file that is using it, in canvas debugger, and is not migrated as the panel will be removed in a few months. Differential Revision: https://phabricator.services.mozilla.com/D20641
c916eda98b1bb33d1f3aa1a7b92d69eb708a884d: Bug 1524628 - Fix a race condition in a devtools style editor test. r=ntim,yulia,miker.
Jason Orendorff <jorendorff@mozilla.com> - Mon, 04 Feb 2019 08:38:04 +0000 - rev 518368
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524628 - Fix a race condition in a devtools style editor test. r=ntim,yulia,miker. Differential Revision: https://phabricator.services.mozilla.com/D18476
e6a874b75c0bd45b9d782b9edde3bb30c0134d14: Bug 1527830 - Remove unused _filterPrefsPrefix in browser-console.js; r=yulia.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 14 Feb 2019 11:01:36 +0000 - rev 516906
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527830 - Remove unused _filterPrefsPrefix in browser-console.js; r=yulia. This property isn't used anymore, let's delete it. Differential Revision: https://phabricator.services.mozilla.com/D19749
a42ea7bbd5835457630ea50f4d82779163adfed0: Bug 1520774 - Remove TargetFactory.forWorker. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 06 Feb 2019 12:45:31 +0000 - rev 515509
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1520774 - Remove TargetFactory.forWorker. r=yulia Depends on D18539 Differential Revision: https://phabricator.services.mozilla.com/D18540
023ecfc5cf46837719be435324942c5c1532b7a8: Bug 1520774 - Remove TargetFactory.forRemoteTab. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 06 Feb 2019 16:17:15 +0000 - rev 515508
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1520774 - Remove TargetFactory.forRemoteTab. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D18539
aff30c79fa91fa4b444cc76f1d9e2a4ac487b6af: Bug 1465635 - Remove Target.activeTab property. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:24 +0000 - rev 514433
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Remove Target.activeTab property. r=yulia Depends on D15831 Differential Revision: https://phabricator.services.mozilla.com/D16874
1dfe4f2eb472d1dd9251297f9476e786c2cd751a: Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:32 +0000 - rev 514432
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes This patch makes it so that all target fronts inherits from a Target class mixin. We are using a mixin as fronts should inherit from a custom Front class, which is augmented with its own RDP request and events defined in its spec. (This is done via FrontClassWithSpec(spec)) Depends on D15830 Differential Revision: https://phabricator.services.mozilla.com/D15831
fead89ec2d1bb342ed1feb0616ec241411baed8a: Bug 1465635 - Use Target.title to fetch target's title instead of using its form. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:39 +0000 - rev 514431
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Use Target.title to fetch target's title instead of using its form. r=yulia Depends on D15828 Differential Revision: https://phabricator.services.mozilla.com/D15830
e6efb1191ec609df0fa28c0594efbafb3e84eb98: Bug 1465635 - Always consider that Target.activeTab is set. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:41 +0000 - rev 514430
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Always consider that Target.activeTab is set. r=yulia Depends on D15826 Differential Revision: https://phabricator.services.mozilla.com/D15828
9c7fe2ba8434594aa5d49149e74ffba6d21303e2: Bug 1465635 - Convert canvas front instantiation to Target.getFront. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:49 +0000 - rev 514429
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Convert canvas front instantiation to Target.getFront. r=yulia Depends on D15825 Differential Revision: https://phabricator.services.mozilla.com/D15826
2fe3a0ae216beb2ef4ebbb5e02019d41845c4f4a: Bug 1465635 - Convert browser_two_tabs.js to async. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Sat, 02 Feb 2019 11:24:56 +0000 - rev 514428
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Convert browser_two_tabs.js to async. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D15825
11413ebfbcaf5118b933329de3cfb960daaad8ea: Bug 1465635 - Remove Target.activeTab property. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:25 +0000 - rev 513965
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Remove Target.activeTab property. r=yulia Depends on D15831 Differential Revision: https://phabricator.services.mozilla.com/D16874
52728b761d5dd0cc0c73da16b27dd99a7cbb8e22: Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:23 +0000 - rev 513964
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes This patch makes it so that all target fronts inherits from a Target class mixin. We are using a mixin as fronts should inherit from a custom Front class, which is augmented with its own RDP request and events defined in its spec. (This is done via FrontClassWithSpec(spec)) Depends on D15830 Differential Revision: https://phabricator.services.mozilla.com/D15831
734646bf982960999cd89f49e84280677f3a0f07: Bug 1465635 - Use Target.title to fetch target's title instead of using its form. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:15 +0000 - rev 513963
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Use Target.title to fetch target's title instead of using its form. r=yulia Depends on D15828 Differential Revision: https://phabricator.services.mozilla.com/D15830
d9ae7cd34c1a66de8a6426e0dc1a3b772d3738f1: Bug 1465635 - Always consider that Target.activeTab is set. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:13 +0000 - rev 513962
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Always consider that Target.activeTab is set. r=yulia Depends on D15826 Differential Revision: https://phabricator.services.mozilla.com/D15828
00d325ab677ae8ac7b7261e5b9600f9bc7f11581: Bug 1465635 - Convert canvas front instantiation to Target.getFront. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:11 +0000 - rev 513961
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Convert canvas front instantiation to Target.getFront. r=yulia Depends on D15825 Differential Revision: https://phabricator.services.mozilla.com/D15826
a9b181f32189d2dadec53a391e0169a6222952fb: Bug 1465635 - Convert browser_two_tabs.js to async. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 13:28:09 +0000 - rev 513960
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1465635 - Convert browser_two_tabs.js to async. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D15825
820e7e98a4f7beee52772f1ef6b3de38b920927b: Bug 1515290 - Instantiate DebuggerServer in dedicated loader when debugging chrome tabs. r=yulia,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 30 Jan 2019 08:04:50 +0000 - rev 513918
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1515290 - Instantiate DebuggerServer in dedicated loader when debugging chrome tabs. r=yulia,jdescottes When debugging contexts running from the system compartment, the debugger has to be loaded in a dedicated Loader, with invisibleToDebugger flag turned on. This ensures that the Debugger API is going to be used from a distinct system compartment. Otherwise it may be used from the same compartment than the page we are debugging. Differential Revision: https://phabricator.services.mozilla.com/D14957
0b8dbea063541103c759b29e9de24ca9bf0aaa5b: Bug 1520782 - Convert server tests using chrome documents to use content one. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 23 Jan 2019 08:52:54 +0000 - rev 512076
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1520782 - Convert server tests using chrome documents to use content one. r=yulia These tests were using chrome URL for no good reason. With the current bug, the pages running in system principal will be debugged with a special setup. Actors will be run with modules loaded in a distinct loader in order to be executed in a distinct compartment, distinct from the shared system principal compartment. That a prerequisite for the Debugger API. It has to run in a distinct compartment than its debuggee. It makes it harder to reach the actual DebuggerServer being used and register actors. So it is easier to switch to a unprivileged test document loaded in the content process. Differential Revision: https://phabricator.services.mozilla.com/D16824
11325875967aeff353c93e6cfc38fc614ce211b1: Bug 1520772 - Construct the WebExtension target front before instantiating the Target object. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 21 Jan 2019 11:04:31 +0000 - rev 511818
Push 10563 by archaeopteryx@coole-files.de at Thu, 24 Jan 2019 17:31:37 +0000
Bug 1520772 - Construct the WebExtension target front before instantiating the Target object. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D15829
909b904600e079bc0fe2867956f2d067f1f9ec48: Bug 1520773 - Prevent infinite loops in DebuggerClient.close. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 21 Jan 2019 11:04:08 +0000 - rev 511817
Push 10563 by archaeopteryx@coole-files.de at Thu, 24 Jan 2019 17:31:37 +0000
Bug 1520773 - Prevent infinite loops in DebuggerClient.close. r=yulia If any callback fired by DebuggerClient.close ends up calling close again, it will introduce an infinite loop. Depends on D15826 Differential Revision: https://phabricator.services.mozilla.com/D15827
e62e0dfddefe6a582c72c52071742bbc9f3865b0: Bug 1497264 - Split addon/webextension.js into webextension.js and webextension-proxy.js;r=ochameau,yulia
Julian Descottes <jdescottes@mozilla.com> - Tue, 08 Jan 2019 18:18:14 +0000 - rev 510061
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1497264 - Split addon/webextension.js into webextension.js and webextension-proxy.js;r=ochameau,yulia Depends on D15384 Differential Revision: https://phabricator.services.mozilla.com/D15385
033f84c32bce3df3cd0ffd487673463c09bda3cf: Bug 1497264 - Remove references to AddonTargetActor setAddonOptions;r=ochameau,yulia
Julian Descottes <jdescottes@mozilla.com> - Tue, 08 Jan 2019 18:42:44 +0000 - rev 510060
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1497264 - Remove references to AddonTargetActor setAddonOptions;r=ochameau,yulia Depends on D15383 Differential Revision: https://phabricator.services.mozilla.com/D15384
a894d406f4ae900c0dc0f199cfee12082a389def: Bug 1497264 - Remove AddonTargetActor and AddonConsoleActor;r=ochameau,yulia
Julian Descottes <jdescottes@mozilla.com> - Tue, 08 Jan 2019 18:17:17 +0000 - rev 510059
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1497264 - Remove AddonTargetActor and AddonConsoleActor;r=ochameau,yulia This should be rather safe. We can do more refactoring and renaming once LegacyExtension support is fully removed (ie Fx 65 hits release) Differential Revision: https://phabricator.services.mozilla.com/D15383
1399a4ceda2e2f43d1db23aae19d52d8720a4a8d: Bug 1514817 - Convert Target to ES Class. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 07 Jan 2019 11:57:51 +0000 - rev 509802
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514817 - Convert Target to ES Class. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D14842
f5faf952c6d24e59b821018887e355f9af526bf0: Bug 1512154 - Convert protocol.js to es classes. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 02 Jan 2019 13:38:54 +0000 - rev 509529
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512154 - Convert protocol.js to es classes. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D14840
3d30fc6ff7c4c6b007b554ef8c185b6a81ef117e: Bug 1513565 - Remove now-unused form argument from Target. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 23:36:06 +0000 - rev 508385
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513565 - Remove now-unused form argument from Target. r=yulia Depends on D14280 Differential Revision: https://phabricator.services.mozilla.com/D14765
835e98747541301ba1beb317a6ea3fcd7dd0b310: Bug 1513565 - Convert the last manually instantiated fronts to target.getFront. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 23:35:59 +0000 - rev 508384
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513565 - Convert the last manually instantiated fronts to target.getFront. r=yulia Depends on D14279 Differential Revision: https://phabricator.services.mozilla.com/D14280
69c7978b620c3a89b068bcfef8cd69c5c5ada60d: Bug 1513565 - Get rid of all target.form usages. r=yulia,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 23:35:57 +0000 - rev 508383
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513565 - Get rid of all target.form usages. r=yulia,nchevobbe Depends on D14278 Differential Revision: https://phabricator.services.mozilla.com/D14279
af4a0603c641b9235f94af26106557b5538b38a4: Bug 1513565 - Always use Target's WebConsoleClient instead of trying to instantiate it manually. r=yulia,nchevobbe
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 23:35:55 +0000 - rev 508382
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513565 - Always use Target's WebConsoleClient instead of trying to instantiate it manually. r=yulia,nchevobbe This will help getting rid of another usage of Target.form. And also helps instantiating only one WebConsole client. Once WebConsole becomes a front, we can replace all the target.activeTab to target.getFront("console"). Differential Revision: https://phabricator.services.mozilla.com/D14278
e633fd3fbd905d1cbbcd35ed5b888bcfe4e89e7f: Bug 1514819 - Convert RootFront.getWindow to return a front instead of a form. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 18 Dec 2018 08:54:01 +0000 - rev 508381
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514819 - Convert RootFront.getWindow to return a front instead of a form. r=yulia This method is only used by target-from-url, it allows to return a target got one precise top level window and instead of the whole main process. It looks like it was the very last non-front/still-form target codepath. Differential Revision: https://phabricator.services.mozilla.com/D14841
651250445f44db2ac52ca8bf65874491298e8144: Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 17 Dec 2018 11:56:30 +0000 - rev 508015
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes MozReview-Commit-ID: 4CMHJ3tV7Rc Depends on D14174 Differential Revision: https://phabricator.services.mozilla.com/D14175
c4b0f1c1f723aea535b0e07feca1cd0810e791f4: Bug 1508285 - Use RootFront.rootForm instead of listTabs to fetch global actors. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 17 Dec 2018 11:56:28 +0000 - rev 508014
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1508285 - Use RootFront.rootForm instead of listTabs to fetch global actors. r=yulia MozReview-Commit-ID: Ed5SyZbB0kq Depends on D14173 Differential Revision: https://phabricator.services.mozilla.com/D14174
433551bcded4cd57938867322fde5488951a7d83: Bug 1508285 - Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 17 Dec 2018 11:56:26 +0000 - rev 508013
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1508285 - Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form. r=yulia MozReview-Commit-ID: 6TOInM5BmYe Differential Revision: https://phabricator.services.mozilla.com/D14173
265e45e19268cc732255cb731e2d44d1fff6aec2: Bug 1513888 - Remove evaluateJSAsync trait; r=yulia.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 13 Dec 2018 15:45:40 +0000 - rev 507513
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513888 - Remove evaluateJSAsync trait; r=yulia. The trait was added in 37 to handle older server, but given how old it is now, I think it's safe to remove it. Differential Revision: https://phabricator.services.mozilla.com/D14424
943836f5e52865b4c4a39c127cdc274265d0bd72: Bug 1512220 - Convert debugger server test helper to async functions. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 12:14:59 +0000 - rev 507325
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512220 - Convert debugger server test helper to async functions. r=yulia This cleanup will help next refactorings. Note that attachTestThread and attachTestTabAndResume are still using the callback style as it is still being used by tests that aren't using threadClientTest helper. MozReview-Commit-ID: 6FvoDtzEBmL Depends on D13901 Differential Revision: https://phabricator.services.mozilla.com/D13902
9367d35f4dab2c99cf14cdbfe7f5fd6e07c5e4f8: Bug 1512220 - Refactor debugger test using testGlobal to threadClientTest helper. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 15:19:43 +0000 - rev 507324
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512220 - Refactor debugger test using testGlobal to threadClientTest helper. r=yulia This isn't removing listTabs calls as these tests were using attachTestTab, but all these tests are using testGlobal helper whereas they don't have to if they were using threadClientTest helper. MozReview-Commit-ID: FPtYlDvYUeD Depends on D13900 Differential Revision: https://phabricator.services.mozilla.com/D13901
67fb7c7594fcf301bbae0a664d7453a436408617: Bug 1512220 - Refactor promises tests to use the same test helper than memory actor's tests. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 15:58:13 +0000 - rev 507323
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512220 - Refactor promises tests to use the same test helper than memory actor's tests. r=yulia This isn't thread client test, but here we could share some more code with the memory tests and use Target objects to retrieve the fronts. MozReview-Commit-ID: C9S1VjTLrSF Depends on D13899 Differential Revision: https://phabricator.services.mozilla.com/D13900
434525362f73aec285ee22315fe5e6c87e27f04f: Bug 1512220 - Switch devtools/server/tests/unit/test_setBreakpoint* tests to threadClientTest. r=yulia
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Dec 2018 17:46:10 +0000 - rev 507322
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512220 - Switch devtools/server/tests/unit/test_setBreakpoint* tests to threadClientTest. r=yulia All these tests are clearly copy pasting existing threadClientTest helper. They might run as well against workers but today we don't run them there, so I used the doNotRunWorker flag. MozReview-Commit-ID: 7k1lJ06WeGZ Differential Revision: https://phabricator.services.mozilla.com/D13899