searching for reviewer(xidorn)
570065ea87fc4409718c9fd7f950863696fb8518: Bug 1554433 - Move system colors to values::specified::color. r=xidorn, a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 26 May 2019 13:10:00 +0000 - rev 533732
Push 11410 by jcristau@mozilla.com at Mon, 10 Jun 2019 15:05:14 +0000
Bug 1554433 - Move system colors to values::specified::color. r=xidorn, a=jcristau This should be an idempotent patch. The way to come up with this patch has been: * Run the first script attached to the bug and pipe it to xclip, then paste it in color.rs * Add the relevant #[derive] annotations and remove the color.mako.rs definition. * Reorder the values to match the ColorID definition, on which some widget prefs and caching stuff relies on. * Manually port some documentation from nsLookAndFeel.h * Run `rg 'eColorID_' | cut -d : -f 1 | sort | uniq >files` * Run the second script attached to the bug. * Manually fix usage of `LAST_COLOR` (adding the `End` variant), and adding casts to integer as needed. * Add an static assert so that people remember to update the prefs, rather than a comment on the definition :) Differential Revision: https://phabricator.services.mozilla.com/D32610
d7a7edbebd6a08f22d78b5c86b2f2d4573eb77dd: Bug 1552628 - Remove some more dead nsCSSValue code. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 19 May 2019 00:47:18 +0000 - rev 533280
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1552628 - Remove some more dead nsCSSValue code. r=xidorn Most of it is not used at this point, this leaves the parts that are used by MathML, which are minimal. Differential Revision: https://phabricator.services.mozilla.com/D31706
c58def4246acd844cda042938d426a35320eafba: Bug 1546499: Downgrade nsVideoFrame's unexpected-child assertion. r=xidorn
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 23 Apr 2019 20:28:52 +0000 - rev 530597
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546499: Downgrade nsVideoFrame's unexpected-child assertion. r=xidorn Also, make the assertion shorter & more to the point. In particular, I'm removing the note about stray whitespace, which is based on one previous scenario that caused extra child frames; but I don't have much confidence that potential future causes of this assertion-failure will have that specific problem as their root cause. Differential Revision: https://phabricator.services.mozilla.com/D28547
4b227d4b337729892521aaa72cd00f3ef0f75590: Bug 1543808 - Refactor the selector parser to make implementing ::part() easier. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Apr 2019 13:16:56 +0000 - rev 528480
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543808 - Refactor the selector parser to make implementing ::part() easier. r=xidorn ::slotted() is already weird in the sense that it supports a pseudo-element afterwards (so ::slotted(*)::before is valid for example). ::part() is weirder because you are supposed to allow stuff like ::part(foo):hover, ::part(foo):hover::before, etc. In order to avoid making the already-complex parse_compound_selector more complex, shuffle stuff so that we pass the progress of our current compound selector around, and is the parsing code for each selector which decides whether it's ok to parse at the given point. Differential Revision: https://phabricator.services.mozilla.com/D27158
4a73ab981c299d02c3107ace8744e2fcd7c34c5c: Bug 1536584 - Remove bindings.rs. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Mar 2019 18:15:47 +0000 - rev 524958
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536584 - Remove bindings.rs. r=xidorn I kept it building the most straight-forward way possible (pub use) because it seems to me that bindings is not a bad name, and we should probably move structs.rs to be bindings.rs rather than the other way around. But that's a different bug in any case, need to think more about it. Differential Revision: https://phabricator.services.mozilla.com/D24713
7bd834c5800c93f54df331311d726dc571813d7b: Bug 1536584 - Remove bindings.rs. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Mar 2019 13:38:14 +0000 - rev 524920
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536584 - Remove bindings.rs. r=xidorn I kept it building the most straight-forward way possible (pub use) because it seems to me that bindings is not a bad name, and we should probably move structs.rs to be bindings.rs rather than the other way around. But that's a different bug in any case, need to think more about it. Differential Revision: https://phabricator.services.mozilla.com/D24713
0d33ffb859fa4e1ea031c3b2cb3274d71d66a0d5: Bug 1215878 - Optimize cascading of other wide keywords if possible. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Mar 2019 12:48:07 +0000 - rev 520751
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1215878 - Optimize cascading of other wide keywords if possible. r=xidorn The way the copy-on-write stuff works, and the way that we have to apply properties from most specific to less specific guarantees that always that we're going to inherit an inherited property, or reset a reset property, we have already the right value on the style. Revert relies on that, so there doesn't seem to be a reason to not use that fact more often and skip useless work earlier. Font-size is still special of course... I think I have a way to move the specialness outside of the style, but piece by piece. Differential Revision: https://phabricator.services.mozilla.com/D21882
9506816277411c422b23f1b74b2e058dda615d6d: Bug 1532134 - Remove Options from TransformOperation. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:54 +0000 - rev 520058
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532134 - Remove Options from TransformOperation. r=xidorn This may or may not be part of the plan to get rid of nsCSSValue ;) Option is not usable via FFI, and they should not be needed (we should be following the shortest serialization principle instead). These patches also do that, which matches the other transform properties. I think that slight change is fine, if we can make it work, and consistent with other properties. Alternative is adding more TransformOperation variants or such, which I rather not do. Differential Revision: https://phabricator.services.mozilla.com/D21862
2b811ffbed9b8b4c71092e90cbb11201c8d9a7c6: Bug 1532134 - Use contextual_skip_if for background-size. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:40 +0000 - rev 520057
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532134 - Use contextual_skip_if for background-size. r=xidorn Also drive-by cleanup. Differential Revision: https://phabricator.services.mozilla.com/D21861
5a4a2f2465b0142e901d52f1850c2fc1a6e0cc6b: Bug 1532134 - Use skip_if for translate serialization. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:30 +0000 - rev 520056
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532134 - Use skip_if for translate serialization. r=xidorn Trivial drive-by cleanup. Differential Revision: https://phabricator.services.mozilla.com/D21860
7aa72a6aa1b501c6f7a0efc7a4a4ea14d15f0030: Bug 1532134 - When deriving something with an output type, map preconditions as well. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:21 +0000 - rev 520055
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532134 - When deriving something with an output type, map preconditions as well. r=xidorn Otherwise, deriving ToComputedValue and ToAnimatedValue in structs or enums with other where clauses just doesn't work. Differential Revision: https://phabricator.services.mozilla.com/D21859
b5dec9e96f42cd166b4cdaf70b6765be34454aae: Bug 1532134 - Implement a version of #[css(skip_if)] that takes more context. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:06 +0000 - rev 520054
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532134 - Implement a version of #[css(skip_if)] that takes more context. r=xidorn I called it contextual_skip_if, though better names welcome. Differential Revision: https://phabricator.services.mozilla.com/D21858
65ed1a6835b990ddbe99d34279ab2240515c91dc: Bug 1528299 - Make InspectorUtils.getCSStyleRules return a proper CSSStyleRule sequence. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 20 Feb 2019 11:05:30 +0000 - rev 517928
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528299 - Make InspectorUtils.getCSStyleRules return a proper CSSStyleRule sequence. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D20456
7d4f1afbf5f20a2767b2bdee6536b942dd440c65: Bug 1528035 - Improve #[derive(Parse)]. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Feb 2019 20:45:10 +0100 - rev 517767
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528035 - Improve #[derive(Parse)]. r=xidorn I want to do this so that I can get rid of Either<>. The reasons for getting rid of either is multiple: * It doesn't generate as nice C++ code using cbindgen. * It isn't that nice to use either from Rust. * cbindgen has bugs with zero-sized types. I started using this for ColorOrAuto and a few others, for now. Differential Revision: https://phabricator.services.mozilla.com/D19844
96fd408e650f21a4d63ea3ff09f9a3bc25676360: Bug 1524328 - Pass a document instead of a pres context to FinishStyle. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 02 Feb 2019 19:42:25 +0100 - rev 514459
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524328 - Pass a document instead of a pres context to FinishStyle. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D18491
43a3aa2199c12427c9784a9cdbb89f76cf1296a5: Bug 1524328 - Don't resolve counter styles in the style system. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 02 Feb 2019 19:41:44 +0100 - rev 514458
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524328 - Don't resolve counter styles in the style system. r=xidorn Doing it during layout instead. This also has the nice side-effect of no longer needing to do a full restyle when counter-style rules are inserted. Differential Revision: https://phabricator.services.mozilla.com/D18343
fb705f84a7921bd5a77108b99e2ffab51a53c09b: Bug 1519006 - Stop null checking infallible style sheet accessors in nsDocumentViewer::CreateStyleSet r=xidorn
Cameron McCormack <cam@mcc.id.au> - Fri, 11 Jan 2019 03:12:28 +0000 - rev 510533
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1519006 - Stop null checking infallible style sheet accessors in nsDocumentViewer::CreateStyleSet r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D16151
45d4ae4551a1e07cb5fa97d8405e6f9badcf7554: Bug 1519001 - Rename some style sheet accessors on nsLayoutStylesheetCache to indicate they can return null r=xidorn
Cameron McCormack <cam@mcc.id.au> - Fri, 11 Jan 2019 03:12:05 +0000 - rev 510532
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1519001 - Rename some style sheet accessors on nsLayoutStylesheetCache to indicate they can return null r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D16150
a5450f478cd96e5f552a37d6f89c63e671958bdd: Bug 1518992 - Remove unnecessary mem::transmute in MediaListKey r=xidorn
Cameron McCormack <cam@mcc.id.au> - Thu, 10 Jan 2019 06:01:03 +0000 - rev 510452
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1518992 - Remove unnecessary mem::transmute in MediaListKey r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D16147
af22225148f7cb57718a9b3f4428d57ba93f6842: Bug 1516365 - Update the Rust target version for bindgen. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 25 Dec 2018 23:09:29 +0000 - rev 509026
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516365 - Update the Rust target version for bindgen. r=xidorn This brings us alignas support and also associated constants for bitfield enums. Differential Revision: https://phabricator.services.mozilla.com/D15334
6ced915a7d2d241979c9df61b7d42cba0de38c88: Bug 1512597 - Resolve currentcolor in fill and stroke against visited-dependent color r=xidorn
Cameron McCormack <cam@mcc.id.au> - Tue, 18 Dec 2018 09:39:07 +0000 - rev 508296
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512597 - Resolve currentcolor in fill and stroke against visited-dependent color r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D14706
ce1adc43434d07ba32d323756b8b51ebbdb67ad9: Bug 1514449 - Cleanup some conversion code dealing with NonNegative. r=boris,xidorn,#style
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 16 Dec 2018 09:13:49 +0000 - rev 508109
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514449 - Cleanup some conversion code dealing with NonNegative. r=boris,xidorn,#style I'm about to introduce another use of it and I don't want to repeat the same copy-pasta again. Differential Revision: https://phabricator.services.mozilla.com/D14672
3911d8355cbb5ecf55f7f9d38e29f1f84dc9c594: Bug 1512597 - Resolve currentcolor in fill and stroke against visited-dependent color. r=xidorn, a=RyanVM
Cameron McCormack <cam@mcc.id.au> - Tue, 18 Dec 2018 09:39:07 +0000 - rev 506422
Push 10410 by ryanvm@gmail.com at Sun, 30 Dec 2018 23:47:52 +0000
Bug 1512597 - Resolve currentcolor in fill and stroke against visited-dependent color. r=xidorn, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D14706
43dbbb0cce0d823fdac9c9e997b1548d041eb820: Bug 1492958 - Move user-select outside of mako. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 11 Nov 2018 17:57:41 +0100 - rev 502375
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1492958 - Move user-select outside of mako. r=xidorn This is the first step to unprefix user-select. This has no behavior change, it's just a nicer way to do the same thing which allows us to unship individual values more easily using parse(condition). Differential Revision: https://phabricator.services.mozilla.com/D11580
edc955448df6d25bff57269836980bf41c7f7315: Bug 1492958 - Move user-select outside of mako. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 11 Nov 2018 17:57:41 +0100 - rev 502368
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1492958 - Move user-select outside of mako. r=xidorn This is the first step to unprefix user-select. This has no behavior change, it's just a nicer way to do the same thing which allows us to unship individual values more easily using parse(condition). Differential Revision: https://phabricator.services.mozilla.com/D11580
cb6837c0ee5a192ff57bcba2e7dab3a9ff1a5580: Bug 1473184: Remove serialize_basicshape_position. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 12 Nov 2018 09:21:17 +0000 - rev 502290
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1473184: Remove serialize_basicshape_position. r=xidorn Per https://github.com/w3c/csswg-drafts/issues/2274. There's a whole lot of new failures, but those need to be updated along with the spec changes in that issue. We did resolve that position serialized the same everywhere though. Differential Revision: https://phabricator.services.mozilla.com/D1933
9a315872bd6d11ac42871b083961a00fa53ee753: Bug 1505786 - Implement overflow-wrap: anywhere. r=xidorn,jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Nov 2018 22:39:34 +0000 - rev 501674
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505786 - Implement overflow-wrap: anywhere. r=xidorn,jfkthame Per https://github.com/w3c/csswg-drafts/issues/2682 Differential Revision: https://phabricator.services.mozilla.com/D11328
1d6dba09c494831d64a419c0c5258827f839c708: Bug 1505520 - Back out bug 1478455. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Nov 2018 21:03:18 +0000 - rev 501470
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505520 - Back out bug 1478455. r=xidorn It breaks websites. Differential Revision: https://phabricator.services.mozilla.com/D11232
6e528251fad42087432100835b1e3fe8c59f5fec: Bug 1504387 - Remove preference "layout.css.shape-outside.enabled". r=bradwerth,xidorn
Ting-Yu Lin <tlin@mozilla.com> - Mon, 05 Nov 2018 15:27:36 +0000 - rev 500900
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1504387 - Remove preference "layout.css.shape-outside.enabled". r=bradwerth,xidorn shape-outside, shape-margin, shape-image-threshold have been shipped in Firefox 62. We can remove the preference. The change in devtools/shared/css/generated/properties-db.js is generated by "./mach devtools-css-db" The actual shape-image CORS mode tests in file_shape_outside_CORS.html are moved into test_shape_outside_CORS.html because we don't need the <iframe> trick to enable the feature. Differential Revision: https://phabricator.services.mozilla.com/D10804
7945ede7e1b84939c21c78b615810160c8ffd46b: Bug 1462233 - Simplify invalid custom property handling. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 05 Nov 2018 10:42:12 +0000 - rev 500808
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1462233 - Simplify invalid custom property handling. r=xidorn It's a bit useless to keep a set of invalid properties if we're going to use them just to reject lookups into another key. This makes it more consistent with the cascade / no-references code, and should not change behavior. Differential Revision: https://phabricator.services.mozilla.com/D9632
a4e64a2df8a92a1c680497e81b1b7695fa4562d3: Bug 1493976 - Reset the resolution to 1 when entering fullscreen mode. r=kats,xidorn
Botond Ballo <botond@mozilla.com> - Wed, 24 Oct 2018 19:20:05 +0000 - rev 499265
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1493976 - Reset the resolution to 1 when entering fullscreen mode. r=kats,xidorn The previous resolution is restored when exiting fullscreen mode. Depends on D9442 Differential Revision: https://phabricator.services.mozilla.com/D9443
0dac7f40ea5fbdbf0afc927b42ae80551de1e972: Bug 1500885 - Remove some unused keywords. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Oct 2018 13:37:12 +0200 - rev 499195
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500885 - Remove some unused keywords. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D9372
35c3b881583a46085ce6164efcc24448ced3adf6: Bug 1500885 - Serialize text-align with Servo. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Oct 2018 13:37:12 +0200 - rev 499194
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500885 - Serialize text-align with Servo. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D9372
c329b2c093c0ff455a89a5909d577d5f389b20f4: Bug 1505520 - Back out bug 1478455. r=xidorn a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Nov 2018 21:03:18 +0000 - rev 498402
Push 10138 by ebalazs@mozilla.com at Thu, 08 Nov 2018 12:27:01 +0000
Bug 1505520 - Back out bug 1478455. r=xidorn a=jcristau It breaks websites. Differential Revision: https://phabricator.services.mozilla.com/D11232
cbd3baf67f7fe586c281032fe4b2e0ae83b3daa3: Bug 1493976 - Reset the resolution to 1 when entering fullscreen mode. r=kats,xidorn, a=RyanVM
Botond Ballo <botond@mozilla.com> - Wed, 24 Oct 2018 19:20:05 +0000 - rev 498192
Push 10060 by ryanvm@gmail.com at Mon, 29 Oct 2018 16:45:36 +0000
Bug 1493976 - Reset the resolution to 1 when entering fullscreen mode. r=kats,xidorn, a=RyanVM The previous resolution is restored when exiting fullscreen mode. Depends on D9442 Differential Revision: https://phabricator.services.mozilla.com/D9443
1d8eba4911f02fd91a0072bbc12ddbbb70d13b42: Bug 1499778 - Remove StaticId. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Oct 2018 19:48:35 +0000 - rev 497560
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1499778 - Remove StaticId. r=xidorn Destructors in statics are ok now. Differential Revision: https://phabricator.services.mozilla.com/D9004
410f1ce46d58faaa90983efe0805b798df57c43e: Bug 1498148 - Implement text-transform: full-size-kana. r=xidorn
Diego Pino Garcia <dpino@igalia.com> - Sun, 14 Oct 2018 09:42:24 +1100 - rev 496868
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1498148 - Implement text-transform: full-size-kana. r=xidorn
a00b402fb8e82ca4f1c25923be8095b5dfbcf626: Bug 1498148 - Implement text-transform: full-size-kana. r=xidorn
Diego Pino Garcia <dpino@igalia.com> - Sat, 13 Oct 2018 05:03:00 +0300 - rev 496863
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1498148 - Implement text-transform: full-size-kana. r=xidorn
7584ce8674c21dfedc59ecc712eabb94306a2ba2: Bug 1498734 - Always compute angle values to degrees. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 13 Oct 2018 00:41:03 +0000 - rev 496710
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1498734 - Always compute angle values to degrees. r=xidorn This matches the spec, https://drafts.csswg.org/css-values/#angles, which says: > All <angle> units are compatible, and deg is their canonical unit. And https://drafts.csswg.org/css-values/#compat, which says: >When serializing computed values [...], compatible units [...] are converted into a single canonical unit. And also other implementations (Blink always serializes angles as degrees in computed style for example). Also allows us to get rid of quite a bit of code, and makes computed angle value representation just a number, which is nice. Differential Revision: https://phabricator.services.mozilla.com/D8619
876924556630469ef6e9d22837d52818b4ec0edc: Bug 1451169 - Reduce indirection for PseudoParentData::mPseudoType. r=xidorn
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 03 Apr 2018 22:15:31 +1000 - rev 495323
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1451169 - Reduce indirection for PseudoParentData::mPseudoType. r=xidorn
896cf4497b096f6de0230ca1f5d8295529db2397: Bug 1451169 - Reduce indirection for FrameConstructionDataByTag::mTag. r=xidorn
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 03 Apr 2018 22:15:31 +1000 - rev 495322
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1451169 - Reduce indirection for FrameConstructionDataByTag::mTag. r=xidorn
972d5469e2b9d8c945e37446d684ae0b8656dbb5: Bug 1451169 - Reduce indirection for static atom pointers in nsCSSFrameConstructor.h. r=xidorn
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 03 Apr 2018 22:15:30 +1000 - rev 495321
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1451169 - Reduce indirection for static atom pointers in nsCSSFrameConstructor.h. r=xidorn
24bc7799209725693fca6b3833acea40d650edd8: Bug 1494622 - Simplify CSSValue and co a bit more. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Sep 2018 00:25:20 +0200 - rev 494284
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494622 - Simplify CSSValue and co a bit more. r=xidorn Just remove the useless stuff. Differential Revision: https://phabricator.services.mozilla.com/D7071
da3603d0fef2ec5c212e252403636b223603ed43: Bug 1494622 - Remove nsDOMCSSRect. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Sep 2018 23:50:01 +0200 - rev 494283
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494622 - Remove nsDOMCSSRect. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D7070
fb7be8b4ae804709379c35f190708636c49606b1: Bug 1494622 - Serialize -moz-image-region and clip with Servo. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Sep 2018 23:43:22 +0200 - rev 494282
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494622 - Serialize -moz-image-region and clip with Servo. r=xidorn This changes the serialization of -moz-image-region to be consistent with that of clip(), but it's an internal property and the specified value is already serialized by servo so I think it's the right thing to do. There are also no internal callers of the getter. Differential Revision: https://phabricator.services.mozilla.com/D7069
f3bfb76e088a2cbdd944bda1fc4724d18eca2ae4: Bug 1494622 - Remove nsDOMCSSRGBColor. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Sep 2018 23:06:24 +0200 - rev 494281
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494622 - Remove nsDOMCSSRGBColor. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D7068
a05984b5e160b61cc9e7ab8f3a6d28675c019c45: Bug 1473314 - Make nsRange::GetUsedFontFaces accumulate font faces in the order they are encountered in the document. r=xidorn
Jonathan Kew <jkew@mozilla.com> - Thu, 27 Sep 2018 11:33:25 +0100 - rev 494231
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1473314 - Make nsRange::GetUsedFontFaces accumulate font faces in the order they are encountered in the document. r=xidorn
3ef50c7154b81fd2a34795a89d55bb68aeb318f2: Bug 1432198 - Test for minimum rendered width of 0.5ch for the tab character. r=xidorn
Jonathan Kew <jkew@mozilla.com> - Mon, 24 Sep 2018 13:39:17 +0100 - rev 493636
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1432198 - Test for minimum rendered width of 0.5ch for the tab character. r=xidorn
408b85dd564c81643330d69ce37d315d970c6de9: Bug 1432198 - Ensure tab characters are rendered with a minimum advance of 0.5ch. r=xidorn
Jonathan Kew <jkew@mozilla.com> - Mon, 24 Sep 2018 13:38:52 +0100 - rev 493635
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1432198 - Ensure tab characters are rendered with a minimum advance of 0.5ch. r=xidorn
cf4cc2623a5b273ae0672ee83f83a72042652b77: Bug 1493507 - Avoid walking the rule tree three times from apply_declarations. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 24 Sep 2018 08:42:15 +0000 - rev 493589
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1493507 - Avoid walking the rule tree three times from apply_declarations. r=xidorn Just once is slow enough. Differential Revision: https://phabricator.services.mozilla.com/D6574