searching for reviewer(ttaubert)
40444386933a: Bug 1401594 - land NSS NSS_3_34_BETA5 UPGRADE_NSS_RELEASE, r=ttaubert
Franziskus Kiefer <franziskuskiefer@gmail.com> - Thu, 09 Nov 2017 15:17:40 +0100 - rev 441798
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1401594 - land NSS NSS_3_34_BETA5 UPGRADE_NSS_RELEASE, r=ttaubert MozReview-Commit-ID: HdFnjDGJDcJ
af86f905265d: Bug 1415795 - revert name change of NSS API, r=ttaubert
Franziskus Kiefer <franziskuskiefer@gmail.com> - Thu, 09 Nov 2017 13:02:07 +0100 - rev 441797
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1415795 - revert name change of NSS API, r=ttaubert MozReview-Commit-ID: Jj72zkfaRh
98b1272e170c: Bug 1409259 - Add browser console test for the distrust console message r=keeler,ttaubert
J.C. Jones <jjones@mozilla.com> - Wed, 01 Nov 2017 20:59:33 -0700 - rev 440847
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1409259 - Add browser console test for the distrust console message r=keeler,ttaubert There are xpcshell tests to verify that the appropriate distrust flag is set upon reaching an affected end entity certificate; this test checks that the distrust flag prints a warning to console. MozReview-Commit-ID: OMG246WOOT
595e27212723: Bug 1409259 - Add a console warning for soon-to-be-distrusted roots r=keeler,ttaubert
J.C. Jones <jjones@mozilla.com> - Wed, 18 Oct 2017 22:29:42 -0700 - rev 440845
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1409259 - Add a console warning for soon-to-be-distrusted roots r=keeler,ttaubert This patch adds a new diagnostic status flag to nsIWebProgressListener, STATE_CERT_DISTRUST_IMMINENT, which indicates that the certificate chain is going to change validity due to an upcoming distrust event. The first of these events is this bug, affecting various roots from Symantec. The STATE_CERT_DISTRUST_IMMINENT flag is set by nsNSSCallbacks and passed, via nsSecureBrowserUIImpl, to browser.js where it is used to alert the console. Adding this sort of diagnostic printing to be accessible to browser.js is a long-desired goal, as future functionality can start doing more decision-making there. We may, for example, also want to degrade the lock icon, which will be straightforward with this flag. This commit does not implement the IsCertificateDistrustImminent method. That is follow-on work. MozReview-Commit-ID: 75IOdc24XIV
35f1751b91a9: Bug 1381190 - Change to COSE Algorithm identifiers for WebAuthn r=qdot,ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 12 Oct 2017 15:21:06 -0700 - rev 437494
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1381190 - Change to COSE Algorithm identifiers for WebAuthn r=qdot,ttaubert The WD-06 (and later) WebAuthn specs choose to move to integer algorithm identifiers for the signatures [1], with a handful of algorithms identified [2]. U2F devices only support ES256 (e.g., COSE ID "-7"), so that's all that is implemented here. Note that the spec also now requires that we accept empty lists of parameters, and in that case, the RP says they aren't picky, so this changes what happens when the parameter list is empty (but still aborts when the list is non-empty but doesn't have anything we can use) [3]. There's a follow-on to move parameter-validation logic into the U2FTokenManager in Bug 1409220. [1] https://w3c.github.io/webauthn/#dictdef-publickeycredentialparameters [2] https://w3c.github.io/webauthn/#alg-identifier [3] https://w3c.github.io/webauthn/#createCredential bullet #12 MozReview-Commit-ID: KgL7mQ9u1uq
c09ea1671fc3: Bug 1381190 - Remove WebAuthnRequest dead code r=ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 12 Oct 2017 15:17:51 -0700 - rev 437493
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1381190 - Remove WebAuthnRequest dead code r=ttaubert The WebAuthnRequest.h file is no longer used, and it appears we forgot to clean it up. MozReview-Commit-ID: 8Cgh40YxGiY
d8c1c8894971: Bug 1402267 - Add a scalar telemetry probe that tracks SessionFile worker restarts. data-r=liuche, r=chutten,liuche,ttaubert
Mike de Boer <mdeboer@mozilla.com> - Tue, 17 Oct 2017 12:04:37 +0200 - rev 437384
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402267 - Add a scalar telemetry probe that tracks SessionFile worker restarts. data-r=liuche, r=chutten,liuche,ttaubert MozReview-Commit-ID: F3kCfz18kcQ
57bb241801c0: Bug 1402267 - Restart the SessionWorker each time there are failures reported as much as defined in the 'browser.sessionstore.max_write_failures' pref. r=ttaubert
Mike de Boer <mdeboer@mozilla.com> - Tue, 17 Oct 2017 11:59:33 +0200 - rev 437383
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402267 - Restart the SessionWorker each time there are failures reported as much as defined in the 'browser.sessionstore.max_write_failures' pref. r=ttaubert MozReview-Commit-ID: 91vOcbmhFmj
8ebe3f571ab8: Bug 1407829 - WebAuthn: Implement CredMan's Store method r=qdot,ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 12 Oct 2017 17:02:22 -0700 - rev 437240
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1407829 - WebAuthn: Implement CredMan's Store method r=qdot,ttaubert Credential Management defines a Store operation [1], which needs to be implemented for WebAuthn's spec compliance. It only returns a NotSupportedError for WebAuthn [2], so it's pretty simple. [1] https://w3c.github.io/webappsec-credential-management/#dom-credentialscontainer-store [2] https://w3c.github.io/webauthn/#storeCredential MozReview-Commit-ID: KDEB8r5feQt
12c5e82b0240: Bug 1406456 - WebAuthn WebIDL Updates for WD-07 (part 3) r=qdot,ttaubert
J.C. Jones <jjones@mozilla.com> - Mon, 09 Oct 2017 16:48:01 -0700 - rev 436466
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406456 - WebAuthn WebIDL Updates for WD-07 (part 3) r=qdot,ttaubert Reorder WebAuthentication.webidl to match the ordering of the IDL index in the Web Authentication spec. No normative changes. MozReview-Commit-ID: 7qPE60Qh7Ly
dd5ff0119c3f: Bug 1406456 - WebAuthn WebIDL Updates for WD-07 (part 2) r=qdot,ttaubert
J.C. Jones <jjones@mozilla.com> - Mon, 09 Oct 2017 16:28:13 -0700 - rev 436465
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406456 - WebAuthn WebIDL Updates for WD-07 (part 2) r=qdot,ttaubert This covers these renames: * In CollectedClientData, hashAlg => hashAlgorithm * In CollectedClientData, tokenBinding => tokenBindingId * In MakePublicKeyCredentialOptions, parameters => pubKeyCredParams * In MakePublicKeyCredentialOptions, excludeList => excludeCredentials * In PublicKeyCredentialRequestOptions, allowList => allowCredentials * Transport (WebAuthnTransport in Gecko) => AuthenticatorTransport MozReview-Commit-ID: 3FdRnkosy83
bd51b47ccb9b: Bug 1406469 - Handle the WebAuthn "User Verified" flag r=ttaubert
J.C. Jones <jjones@mozilla.com> - Mon, 09 Oct 2017 18:10:31 -0700 - rev 436448
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406469 - Handle the WebAuthn "User Verified" flag r=ttaubert WebAuthn has added a flag UV to indicate the user was biometrically verified. We have to make sure not to set that flag for U2F. Turns out we already do that, but let's add the constant and such. Ref: https://w3c.github.io/webauthn/#authenticator-data MozReview-Commit-ID: 6Qtjdkverls
f2d25c30aaed: Bug 1244959 - Use IsRegistrableDomainSuffixOfOrEqualTo for U2F Facets r=ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 28 Sep 2017 16:45:28 -0700 - rev 435213
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1244959 - Use IsRegistrableDomainSuffixOfOrEqualTo for U2F Facets r=ttaubert In Comment 8 of Bug 1244959 [1], Brad Hill argues that instead of leaving our U2F Facet support completely half-way, that we could use the Public Suffix logic introduced into HTML for W3C Web Authentication (the method named IsRegistrableDomainSuffixOfOrEqualTo) to scope the FIDO AppID to an eTLD+1 hierarchy. This is a deviation from the FIDO specification, but doesn't break anything that currently works with our U2F implementation, and theoretically enables sites that otherwise need an external FacetID fetch which we aren't implementing. The downside to this is that it's then Firefox-specific behavior. But since this isn't a shipped feature, we have more room to experiment. As an additional bonus, it encourages U2F sites to use the upcoming Web Authentication security model, which will help them prepare to adopt the newer standard. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1244959#c8 MozReview-Commit-ID: DzNVhHT9qRL
0902f7275334: Bug 1399334 - Add more debugging to see why certificates aren't valid. r=ttaubert
J.C. Jones <jjones@mozilla.com> - Mon, 18 Sep 2017 21:43:40 -0700 - rev 431238
Push 7781 by ryanvm@gmail.com at 2017-09-20 00:42 +0000
Bug 1399334 - Add more debugging to see why certificates aren't valid. r=ttaubert There's an intermittent that is showing up now that test_register_sign.html checks state.attestationCert.verify(); to ensure hte SoftToken's certificate is valid. This patch prints the offending certificate when it's encountered, to help diagnose the root cause. MozReview-Commit-ID: 4QSobq9fBGK
07b93c7fec6c: Bug 1400066 - Gracefully handle unsupported platforms for U2F HID support r=ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 14 Sep 2017 18:11:47 -0700 - rev 430626
Push 7768 by ryanvm@gmail.com at 2017-09-16 16:13 +0000
Bug 1400066 - Gracefully handle unsupported platforms for U2F HID support r=ttaubert FreeBSD isn't currently support for FIDO U2F support, similar to Android, so this patch [1] from Jan Beich <jbeich@FreeBSD.org> treats Android and FreeBSD the same. With luck, someone will add in the platform support for both, soon! [1] https://github.com/jcjones/u2f-hid-rs/pull/44 MozReview-Commit-ID: DU7Rco2NLb3
0aed7d43efe2: Bug 1400080 - Remove impossible telemetry test from WebAuthn r=ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 14 Sep 2017 19:17:52 -0700 - rev 430625
Push 7768 by ryanvm@gmail.com at 2017-09-16 16:13 +0000
Bug 1400080 - Remove impossible telemetry test from WebAuthn r=ttaubert Now that there are actual hardware devices, this test can't be run: it depended on there being a deliberately-erroring implementation of WebAuthn which would instantly reject promises. Fortunately, this test was really more a test that telemetry scalars work properly than really the functionality of WebAuthn. Sadly, I don't see any way to re-enable this test without adding a new test- only pref to the tree, which doesn't seem worth it for the telemetry. So this patch removes the offending test completely which was backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c115eec567a6 . MozReview-Commit-ID: LiLuQHbPU1z
fd7e4852bd06: Bug 1245527 - Remove NSS U2F SoftToken. r=ttaubert, r=jed
J.C. Jones <jjones@mozilla.com> - Tue, 05 Sep 2017 12:32:42 -0700 - rev 429803
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1245527 - Remove NSS U2F SoftToken. r=ttaubert, r=jed The nsIU2FToken and its implementors are no longer needed; the soft token was re-implemented into dom/webauthn/U2FSoftTokenManager.cpp during the WebAuthn implementation. When the dom/u2f/ code changed to the implementation from WebAuthn, the old synchronous version became dead code. This patch removes the dead code. MozReview-Commit-ID: 2yDD0tccgZr
dd315914f198: Bug 1245527 - Rewrite U2F.cpp to use U2FTokenManager. r=keeler, r=ttaubert
J.C. Jones <jjones@mozilla.com> - Mon, 11 Sep 2017 12:56:59 -0700 - rev 429802
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1245527 - Rewrite U2F.cpp to use U2FTokenManager. r=keeler, r=ttaubert - This patch reworks the U2F module to asynchronously call U2FManager, which in turn handles constructing and managing the U2FTokenManager via IPC. - Add U2FTransaction{Parent,Child} implementations to mirror similar ones for WebAuthn - Rewrite all tests to compensate for U2F executing asynchronously now. - Used async tasks, used the manifest parameters for scheme, and generally made these cleaner. - The mochitest "pref =" functionality from Bug 1328830 doesn't support Android yet, causing breakage on Android. Rework the tests to go back to the old way of using iframes to test U2F. NOTE TO REVIEWERS: Since this is huge, I recommend the following: keeler - please review U2F.cpp/h, the tests, and the security-prefs.js. Most of the U2F logic is still in U2F.cpp like before, but there's been some reworking of how it is called. ttaubert - please review U2FManager, the Transaction classes, build changes, and the changes to nsGlobalWindow. All of these should be very similar to the WebAuthn code it's patterned off. MozReview-Commit-ID: C1ZN2ch66Rm
8ee1f7aebd62: Bug 1245527 - Remove NSS U2F SoftToken. r=ttaubert, r=jed
J.C. Jones <jjones@mozilla.com> - Tue, 05 Sep 2017 12:32:42 -0700 - rev 429377
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1245527 - Remove NSS U2F SoftToken. r=ttaubert, r=jed The nsIU2FToken and its implementors are no longer needed; the soft token was re-implemented into dom/webauthn/U2FSoftTokenManager.cpp during the WebAuthn implementation. When the dom/u2f/ code changed to the implementation from WebAuthn, the old synchronous version became dead code. This patch removes the dead code. MozReview-Commit-ID: 2yDD0tccgZr
e6a5de8d1246: Bug 1245527 - Rewrite U2F.cpp to use U2FTokenManager. r=keeler, r=ttaubert
J.C. Jones <jjones@mozilla.com> - Tue, 05 Sep 2017 12:32:42 -0700 - rev 429376
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1245527 - Rewrite U2F.cpp to use U2FTokenManager. r=keeler, r=ttaubert - This patch reworks the U2F module to asynchronously call U2FManager, which in turn handles constructing and managing the U2FTokenManager via IPC. - Add U2FTransaction{Parent,Child} implementations to mirror similar ones for WebAuthn - Rewrite all tests to compensate for U2F executing asynchronously now. - Used async tasks, used the manifest parameters for prefs and scheme, and generally made these cleaner. NOTE TO REVIEWERS: Since this is huge, I recommend the following: keeler - please review U2F.cpp/h, the tests, and the security-prefs.js. Most of the U2F logic is still in U2F.cpp like before, but there's been some reworking of how it is called. ttaubert - please review U2FManager, the Transaction classes, build changes, and the changes to nsGlobalWindow. All of these should be very similar to the WebAuthn code it's patterned off. MozReview-Commit-ID: C1ZN2ch66Rm
f7a53ff2f8cb: Bug 1383799 - Cancel WebAuthn operations on tab-switch r=ttaubert
J.C. Jones <jjones@mozilla.com> - Fri, 04 Aug 2017 12:34:18 -0700 - rev 423506
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1383799 - Cancel WebAuthn operations on tab-switch r=ttaubert WebAuthn operations that are in-flight with authenticators must be cancelled when switching tabs. There's an Issue [1] opened with the WebAuthn spec for this already, but the language is _not_ in spec. Still, it's necessary for security, spec or not. This also matches how Chromium handles U2F operations during a tab switch. [1] https://github.com/w3c/webauthn/issues/316 MozReview-Commit-ID: 6Qh9oC4pqys
58b579b4ef4e: Bug 1373672 - Part 3: Expose childOffset from nsIDocShell to use in nsSessionStoreUtils, r=ttaubert, r=smaug
Michael Layzell <michael@thelayzells.com> - Wed, 02 Aug 2017 19:08:19 +0200 - rev 421935
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1373672 - Part 3: Expose childOffset from nsIDocShell to use in nsSessionStoreUtils, r=ttaubert, r=smaug The reasoning behind this is that with this change, removing a non-dynamic docshell from the document dynamically shouldn't affect the indexes which we use for both recording and restoring data in child docshells. MozReview-Commit-ID: JIK8GBSWDEF * * * fixup From c2cb8e33211348c36b1ce18bb62e6465fa46d3ae Mon Sep 17 00:00:00 2001
36bb09c4b28e: Bug 1373672 - Part 3: Expose childOffset from nsIDocShell to use in nsSessionStoreUtils, r=ttaubert, r=smaug
Michael Layzell <michael@thelayzells.com> - Tue, 01 Aug 2017 11:22:53 +0200 - rev 420910
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1373672 - Part 3: Expose childOffset from nsIDocShell to use in nsSessionStoreUtils, r=ttaubert, r=smaug The reasoning behind this is that with this change, removing a non-dynamic docshell from the document dynamically shouldn't affect the indexes which we use for both recording and restoring data in child docshells. MozReview-Commit-ID: JIK8GBSWDEF
1f66a39c19f1: Bug 1380529 - Only permit "ES256" as pubkey type for WebAuthn (3/3) r=ttaubert
J.C. Jones <jjones@mozilla.com> - Fri, 14 Jul 2017 09:57:52 -0700 - rev 418942
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1380529 - Only permit "ES256" as pubkey type for WebAuthn (3/3) r=ttaubert Web Authentication uses JWK algorithm names (ES256) instead of WebCrypto names (such as P-256). There are other JWK algorithm names, but our current U2F-backed implementation only can support ES256 anyway, as that's all that FIDO U2F devices understand. This patch limits us to the name ES256 for the "alg" parameter. MozReview-Commit-ID: 3V5DMzVzPad
070367125549: Bug 1380529 - Use CBOR for the Create Credential WebAuthn call (2/3) r=ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 13 Jul 2017 18:12:50 -0700 - rev 418941
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1380529 - Use CBOR for the Create Credential WebAuthn call (2/3) r=ttaubert The WebAuthn Create Credential method should encode its results using CBOR; this patch changes to that format. The CBOR formats for the U2F data are specified in [1][2] The attestation data format is in [3] The high-level layout is in [4] [1] https://w3c.github.io/webauthn/#generating-an-attestation-object [2] https://w3c.github.io/webauthn/#fido-u2f-attestation [3] https://w3c.github.io/webauthn/#sec-attestation-data [4] https://w3c.github.io/webauthn/#sctn-attestation MozReview-Commit-ID: BYoFCJSxlLt
45b4405c24ca: Bug 1380529 - Add a CBOR library for WebAuthn (1/3) r=ttaubert
J.C. Jones <jjones@mozilla.com> - Thu, 13 Jul 2017 18:12:57 -0700 - rev 418940
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1380529 - Add a CBOR library for WebAuthn (1/3) r=ttaubert Web Authentication's WD-05 specification moves to using (CBOR) Concise Binary Object Representation to transmit the binary data... most of it. This lands a subset of the Apache 2-licensed "CBOR C++" serialization library [1] into webauthn's path. It does not add any code to use this library; see patch 2/3. [1] https://github.com/naphaso/cbor-cpp/ MozReview-Commit-ID: Ktj9TgdqElk
0bb5555fa027: bug 1375709 - avoid deadlock when shutting down NSS r=Cykesiopka,ttaubert
David Keeler <dkeeler@mozilla.com> - Mon, 10 Jul 2017 16:25:51 -0700 - rev 417724
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
bug 1375709 - avoid deadlock when shutting down NSS r=Cykesiopka,ttaubert The deadlock fix attempted in bug 1273475 was incomplete. This should prevent the issue by preventing nsNSSShutDownPreventionLocks from attempting to increment the NSS activity state count when shutdown is in progress (this is acceptible because when code that creates any nsNSSShutDownPreventionLocks then checks isAlreadyShutDown(), it will return true because sInShutdown is true, thus preventing that code from unsafely using NSS resources and functions). MozReview-Commit-ID: 4o5DGbU2TCq
9d6095db5090: bug 1344478 - isAlreadyShutDown should return true for nsNSSShutDownObjects created after NSS shut down r=Cykesiopka,ttaubert
David Keeler <dkeeler@mozilla.com> - Mon, 13 Mar 2017 15:26:40 -0700 - rev 396842
Push 7391 by mtabara@mozilla.com at 2017-06-12 13:08 +0000
bug 1344478 - isAlreadyShutDown should return true for nsNSSShutDownObjects created after NSS shut down r=Cykesiopka,ttaubert MozReview-Commit-ID: 5bUTLz6mGKC In general, it is possible to create a new nsNSSShutDownObject after nsNSSShutDownList::shutdown() had been called. Before this patch, at that point, isAlreadyShutDown() would incorrectly return false, which could lead to code calling NSS functions, which would probably lead to a crash (because NSS could be uninitialized at that point). This change merges nsNSSShutDownList::shutdown() with evaporateAllNSSResources() into evaporateAllNSSResourcesAndShutDown() for simplicity and makes it so isAlreadyShutDown() returns true if called after that point.
3dc5c1d37929: Bug 1344595 - Protect against nsIPrincipal.origin throwing for about:blank iframes; r=ttaubert
Ehsan Akhgari <ehsan@mozilla.com> - Sat, 04 Mar 2017 18:31:11 -0500 - rev 394317
Push 7391 by mtabara@mozilla.com at 2017-06-12 13:08 +0000
Bug 1344595 - Protect against nsIPrincipal.origin throwing for about:blank iframes; r=ttaubert
316ec3452a61: Bug 1344478 - isAlreadyShutDown should return true for nsNSSShutDownObjects created after NSS shut down r=Cykesiopka,ttaubert a=gchang
David Keeler <dkeeler@mozilla.com> - Mon, 13 Mar 2017 15:26:40 -0700 - rev 393117
Push 7198 by jlorenzo@mozilla.com at 2017-04-18 12:07 +0000
Bug 1344478 - isAlreadyShutDown should return true for nsNSSShutDownObjects created after NSS shut down r=Cykesiopka,ttaubert a=gchang MozReview-Commit-ID: 5bUTLz6mGKC In general, it is possible to create a new nsNSSShutDownObject after nsNSSShutDownList::shutdown() had been called. Before this patch, at that point, isAlreadyShutDown() would incorrectly return false, which could lead to code calling NSS functions, which would probably lead to a crash (because NSS could be uninitialized at that point). This change merges nsNSSShutDownList::shutdown() with evaporateAllNSSResources() into evaporateAllNSSResourcesAndShutDown() for simplicity and makes it so isAlreadyShutDown() returns true if called after that point.
5f97ca8be2b4: Bug 1329238 - Make public CryptoKey.h methods return UniqueX NSS types instead of raw pointers. r=ttaubert
Cykesiopka <cykesiopka.bmo@gmail.com> - Wed, 25 Jan 2017 00:27:39 +0800 - rev 378299
Push 7198 by jlorenzo@mozilla.com at 2017-04-18 12:07 +0000
Bug 1329238 - Make public CryptoKey.h methods return UniqueX NSS types instead of raw pointers. r=ttaubert The std::unique_ptr based UniqueX types provide better safety over managing raw pointers. MozReview-Commit-ID: EwwOfs6RHqy
1d58dd2e8476: Bug 1325104 - Stop using Scoped.h NSS types in CryptoKey.(cpp|h). r=ttaubert
Cykesiopka <cykesiopka.bmo@gmail.com> - Mon, 02 Jan 2017 14:02:50 +0800 - rev 372775
Push 6996 by jlorenzo@mozilla.com at 2017-03-06 20:48 +0000
Bug 1325104 - Stop using Scoped.h NSS types in CryptoKey.(cpp|h). r=ttaubert Scoped.h is deprecated. MozReview-Commit-ID: HVfrjM2haQf
01aafb2359c9: Bug 1311379 - Stop using Scoped.h NSS types in WebCryptoTask.(cpp|h). r=rbarnes,ttaubert
Cykesiopka <cykesiopka.bmo@gmail.com> - Fri, 18 Nov 2016 00:49:25 +0800 - rev 368361
Push 6996 by jlorenzo@mozilla.com at 2017-03-06 20:48 +0000
Bug 1311379 - Stop using Scoped.h NSS types in WebCryptoTask.(cpp|h). r=rbarnes,ttaubert Scoped.h is deprecated. MozReview-Commit-ID: CAcnrB9v3dH
071d92d89379: Bug 1305970 - Update to latest NSS 3.28, r=ttaubert, a=jcristau
Martin Thomson <martin.thomson@gmail.com> - Mon, 28 Nov 2016 10:54:24 +1100 - rev 365475
Push 6795 by jlund@mozilla.com at 2017-01-23 14:19 +0000
Bug 1305970 - Update to latest NSS 3.28, r=ttaubert, a=jcristau MozReview-Commit-ID: Ah0iKoxgnLe
a5183ca6cbad: Bug 1296266 - NSS 3.27 tip d9f7136f2ae3, r=ttaubert
Franziskus Kiefer <franziskuskiefer@gmail.com> - Fri, 16 Sep 2016 10:00:57 -0700 - rev 357235
Push 6795 by jlund@mozilla.com at 2017-01-23 14:19 +0000
Bug 1296266 - NSS 3.27 tip d9f7136f2ae3, r=ttaubert
d2b50233313c: Bug 1296266 - NSS 3.27 tip d9f7136f2ae3, r=ttaubert
Franziskus Kiefer <franziskuskiefer@gmail.com> - Fri, 16 Sep 2016 10:00:57 -0700 - rev 355588
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1296266 - NSS 3.27 tip d9f7136f2ae3, r=ttaubert
979e180c5045: Bug 1296266, NSS_3_27_BETA3, r=ttaubert
Kai Engert <kaie@kuix.de> - Thu, 08 Sep 2016 17:03:14 +0200 - rev 354608
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1296266, NSS_3_27_BETA3, r=ttaubert
f7e33d3604f5: Bug 1273475 - use release assertions for PSM->NSS shutdown. r=ttaubert
J.C. Jones <jjones@mozilla.com> - Fri, 05 Aug 2016 14:47:23 -0700 - rev 350194
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1273475 - use release assertions for PSM->NSS shutdown. r=ttaubert Update the prior patch to use MOZ_RELEASE_ASSERT so that we cleanly crash if there's still an error somewhere in this logic, instead of deadlocking on beta (but crashing on aurora). MozReview-Commit-ID: InttEcC55Dn
990954b29382: Bug 1273475 - fix deadlock and potential crash when PSM shuts down NSS. r=ttaubert, r=jcj
David Keeler <dkeeler@mozilla.com> - Tue, 02 Aug 2016 12:16:37 -0700 - rev 349943
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1273475 - fix deadlock and potential crash when PSM shuts down NSS. r=ttaubert, r=jcj This fixes two issues: 1. nsNSSShutDownList::evaporateAllNSSResources could deadlock by acquiring sListLock and then the singleton's mNSSActivityStateLock in nsNSSActivityState::restrictActivityToCurrentThread. 2. Calling UnloadLoadableRoots before nsNSSShutDownList::evaporateAllNSSResources could result in removing modules that were still in use, causing assertion failures and potential crashes. MozReview-Commit-ID: 8ZgZTVw7sWh
d52d39c46763: Bug 1273475 - Use release assertions for PSM->NSS shutdown. r=ttaubert, a=lizzard
J.C. Jones <jjones@mozilla.com> - Fri, 05 Aug 2016 14:47:23 -0700 - rev 347940
Push 6389 by raliiev@mozilla.com at 2016-09-19 13:38 +0000
Bug 1273475 - Use release assertions for PSM->NSS shutdown. r=ttaubert, a=lizzard Update the prior patch to use MOZ_RELEASE_ASSERT so that we cleanly crash if there's still an error somewhere in this logic, instead of deadlocking on beta (but crashing on aurora). MozReview-Commit-ID: InttEcC55Dn
97cd2fba07b3: Bug 1273475 - Fix deadlock and potential crash when PSM shuts down NSS. r=ttaubert, r=jcj, a=lizzard
David Keeler <dkeeler@mozilla.com> - Tue, 02 Aug 2016 12:16:37 -0700 - rev 347939
Push 6389 by raliiev@mozilla.com at 2016-09-19 13:38 +0000
Bug 1273475 - Fix deadlock and potential crash when PSM shuts down NSS. r=ttaubert, r=jcj, a=lizzard This fixes two issues: 1. nsNSSShutDownList::evaporateAllNSSResources could deadlock by acquiring sListLock and then the singleton's mNSSActivityStateLock in nsNSSActivityState::restrictActivityToCurrentThread. 2. Calling UnloadLoadableRoots before nsNSSShutDownList::evaporateAllNSSResources could result in removing modules that were still in use, causing assertion failures and potential crashes. MozReview-Commit-ID: 8ZgZTVw7sWh
edcbaa259c11: Bug 1283376 - Land NSS_3_26_RC0, r=ttaubert
Franziskus Kiefer <franziskuskiefer@gmail.com> - Wed, 20 Jul 2016 09:39:08 +0200 - rev 345844
Push 6389 by raliiev@mozilla.com at 2016-09-19 13:38 +0000
Bug 1283376 - Land NSS_3_26_RC0, r=ttaubert
15542167767f: Bug 1279799 - Split WebCryptoAPI generateKey tests into one test file per algorithm name r=ttaubert
James Graham <james@hoppipolla.co.uk> - Fri, 10 Jun 2016 18:05:17 +0100 - rev 342490
Push 6389 by raliiev@mozilla.com at 2016-09-19 13:38 +0000
Bug 1279799 - Split WebCryptoAPI generateKey tests into one test file per algorithm name r=ttaubert MozReview-Commit-ID: FVHQoZDV5eI
e2d17f2657b8: Bug 1273475 - Use release assertions for PSM->NSS shutdown. r=ttaubert, a=lizzard
J.C. Jones <jjones@mozilla.com> - Tue, 30 Aug 2016 16:33:32 -0700 - rev 340533
Push 6359 by ryanvm@gmail.com at 2016-08-31 00:06 +0000
Bug 1273475 - Use release assertions for PSM->NSS shutdown. r=ttaubert, a=lizzard Update the prior patch to use MOZ_RELEASE_ASSERT so that we cleanly crash if there's still an error somewhere in this logic, instead of deadlocking on beta (but crashing on aurora). MozReview-Commit-ID: InttEcC55Dn
2406bffc6370: Bug 1273475 - Fix deadlock and potential crash when PSM shuts down NSS. r=ttaubert, r=jcj, a=lizzard
David Keeler <dkeeler@mozilla.com> - Tue, 30 Aug 2016 16:22:30 -0700 - rev 340532
Push 6359 by ryanvm@gmail.com at 2016-08-31 00:06 +0000
Bug 1273475 - Fix deadlock and potential crash when PSM shuts down NSS. r=ttaubert, r=jcj, a=lizzard This fixes two issues: 1. nsNSSShutDownList::evaporateAllNSSResources could deadlock by acquiring sListLock and then the singleton's mNSSActivityStateLock in nsNSSActivityState::restrictActivityToCurrentThread. 2. Calling UnloadLoadableRoots before nsNSSShutDownList::evaporateAllNSSResources could result in removing modules that were still in use, causing assertion failures and potential crashes. MozReview-Commit-ID: 8ZgZTVw7sWh
5ca8ea4f429a: Bug 1276884 - fix nits in TabAttributes.jsm and TabState.jsm. r=ttaubert
Mike de Boer <mdeboer@mozilla.com> - Wed, 01 Jun 2016 14:48:18 +0200 - rev 338882
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1276884 - fix nits in TabAttributes.jsm and TabState.jsm. r=ttaubert
52e0f82a635e: Bug 1276884 - fix nits in RunState.jsm. r=ttaubert
Mike de Boer <mdeboer@mozilla.com> - Wed, 01 Jun 2016 14:48:16 +0200 - rev 338881
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1276884 - fix nits in RunState.jsm. r=ttaubert
023169ce92ef: Bug 1276884 - fix nits in PrivacyFilter.jsm and PrivacyLevel.jsm. r=ttaubert
Mike de Boer <mdeboer@mozilla.com> - Wed, 01 Jun 2016 14:48:15 +0200 - rev 338880
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1276884 - fix nits in PrivacyFilter.jsm and PrivacyLevel.jsm. r=ttaubert
e1525aa98cd1: bug 1264771 - randomize key IDs in WebCrypto r=ttaubert
David Keeler <dkeeler@mozilla.com> - Wed, 04 May 2016 12:48:37 -0700 - rev 337310
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
bug 1264771 - randomize key IDs in WebCrypto r=ttaubert To import private keys, WebCrypto creates a generic PKCS#11 object with a chosen key ID with PK11_CreateGenericObject and then looks up that object as a SECKEYPrivateKey using PK11_FindKeyByKeyID. It turns out that this is only safe to do as long as the ID is unique. If another SECKEYPrivateKey exists that has the same key ID (realistically this will only happen if an identical key is imported again), PK11_FindKeyByKeyID may return the other key. Since SECKEYPrivateKey objects are unique and not meant to be shared, this causes problems in that when one key is destroyed, the resources backing the other key are no longer valid, and any cryptographic operations using that key will fail. The solution is to use random IDs and check for preexisting keys. NSS doesn't yet expose an elegant API for this, but this patch implements a workaround. MozReview-Commit-ID: EvYMZxnBxTv
e12e9ba1286c: Bug 1250063 - Part 1: Pass userContextId in duplicateTab. r=ttaubert
Yoshi Huang <allstars.chh@mozilla.com> - Fri, 13 May 2016 11:41:00 +0800 - rev 336637
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1250063 - Part 1: Pass userContextId in duplicateTab. r=ttaubert