searching for reviewer(ted.mielczarek)
91b2fc1a6529b25ff73b3c2a14d7add667057155: Bug 1506138 - fix minidump_callback.h for aarch64 windows; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Fri, 16 Nov 2018 10:49:13 -0500 - rev 503210
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506138 - fix minidump_callback.h for aarch64 windows; r=ted.mielczarek
d229433e0f47593f17f8ffd89923fe7e7f1553a1: Bug 1502964 - part 2 - update winapi to froydnj/winapi-rs#aarch64; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Nov 2018 10:56:08 -0400 - rev 500661
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502964 - part 2 - update winapi to froydnj/winapi-rs#aarch64; r=ted.mielczarek
088cccfcaa084873471e6d6096b4c9880c198aab: Bug 1502964 - part 1 - bump the minimum required version of cargo-vendor; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Nov 2018 10:56:08 -0400 - rev 500660
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502964 - part 1 - bump the minimum required version of cargo-vendor; r=ted.mielczarek The newer version features the usual crop of bugfixes we need.
12bca041cda6d2cf14e6d4384703c022237de5bf: Bug 1502964 - part 2 - update winapi to froydnj/winapi-rs#aarch64; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Nov 2018 09:41:41 -0400 - rev 500653
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502964 - part 2 - update winapi to froydnj/winapi-rs#aarch64; r=ted.mielczarek
225f2ad3cf2f422f1500b6f6f67a9dd86514be3b: Bug 1502964 - part 1 - bump the minimum required version of cargo-vendor; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Nov 2018 09:41:42 -0400 - rev 500652
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502964 - part 1 - bump the minimum required version of cargo-vendor; r=ted.mielczarek The newer version features the usual crop of bugfixes we need.
26815a566707e4223602f2ae3d87ac0ad5caa22f: Bug 1502964 - part 2 - update winapi to froydnj/winapi-rs#aarch64; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Wed, 31 Oct 2018 09:50:53 -0400 - rev 500236
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502964 - part 2 - update winapi to froydnj/winapi-rs#aarch64; r=ted.mielczarek It's not clear when upstream will do a new release with the aarch64 changes we need, so to unblock ourselves, let's just use a forked version for now.
6015a119c1547d1e718517201a973459d3e55a54: Bug 1502964 - part 1 - tweak vendoring for pulling in winapi from a git repo branch; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Wed, 31 Oct 2018 09:50:53 -0400 - rev 500235
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1502964 - part 1 - tweak vendoring for pulling in winapi from a git repo branch; r=ted.mielczarek
f9572cfd7bac75d4493f44206cd27958d74269d0: Bug 1494958 - remove linuxgl/accessibility check in old-configure.in; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Tue, 02 Oct 2018 15:41:06 -0400 - rev 495050
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494958 - remove linuxgl/accessibility check in old-configure.in; r=ted.mielczarek linuxgl is not a widget toolkit we support nowadays.
9552949ae7cdec2f6d4cb6be152cc86be993ecf6: Bug 1494717 - fix package name for aarch64 windows; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Thu, 27 Sep 2018 14:35:00 -0400 - rev 494321
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494717 - fix package name for aarch64 windows; r=ted.mielczarek The current code assumes that !x86-64 must be 32-bit. Let's flip that and assume that !x86 is 64-bit.
bd9d6b7b6ab1dce3f8d90cbeb5a91d8b7801ba26: Bug 1494411 - remove MOZ_D3DCOMPILER_XP_CAB; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Wed, 26 Sep 2018 15:28:14 -0400 - rev 494119
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494411 - remove MOZ_D3DCOMPILER_XP_CAB; r=ted.mielczarek This variable is used, but never defined.
273221b765bf304b3f2e0a868f8c7168f5f9e8a6: Bug 1491901 - move MK*SHLIB to moz.configure; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Wed, 19 Sep 2018 10:03:42 -0400 - rev 493033
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1491901 - move MK*SHLIB to moz.configure; r=ted.mielczarek It's nicer to have all that logic in one place, and to be able to common up the Unix-y flags setting. The Makefile constructs in string values is gross, but it's no worse than we had before.
9be13bbe1877d736a656f682b25b49f2b75b69d0: Bug 1480552 - handle aarch64 windows when determining MOZ_D3DCOMPILER_VISTA_DLL; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Tue, 04 Sep 2018 16:41:08 -0400 - rev 490434
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1480552 - handle aarch64 windows when determining MOZ_D3DCOMPILER_VISTA_DLL; r=ted.mielczarek AArch64 Windows includes the necessary DLL in its default configuration, so we don't need to bother locating it in the SDK. We made need to distribute an updated version that won't by on the system by default, though, so we need some extra checking.
ee7a47cc3524aa1de5d70818840e30b477c6aa1d: Bug 1487122 - fix icudata assembly for aarch64 windows; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Tue, 04 Sep 2018 16:41:08 -0400 - rev 490433
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1487122 - fix icudata assembly for aarch64 windows; r=ted.mielczarek Apparently the assembler was willing to accept the previous version, but was unwilling to find the necessary symbols to link some JS code. This version correctly quotes the data symbol and adds a little extra quoting based on examining compiler-generated output.
89e2f1795be7cdb353df6f52ba0b2daa3b28dbb3: Bug 1487449 - stop macro redefinition warning spam for Windows macros; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Thu, 30 Aug 2018 16:09:23 -0400 - rev 489289
Push 9738 by aciure@mozilla.com at Mon, 03 Sep 2018 16:13:51 +0000
Bug 1487449 - stop macro redefinition warning spam for Windows macros; r=ted.mielczarek This warning spam happens particularly with WebRTC, but I can see it happening for any third-party software whose use of WINVER and friends conflicts with our own. Let's just change mozilla-config.h to avoid defining these macros if they're already defined via the command line.
ead8943575c96bf260a5c5b576fa049ec045f971: Bug 1484708 - Update .gitignore rules and add js/src/obj-*. r=ted.mielczarek
Ashley Hauck <khyperia@mozilla.com> - Mon, 20 Aug 2018 09:03:00 +0300 - rev 487721
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1484708 - Update .gitignore rules and add js/src/obj-*. r=ted.mielczarek
42e2eeaca65d313926e962b6583d52d4bcab6d15: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 486027
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant C++ functions are updated to take a typed enum. JavaScript calls are unaffected but they will throw if the string argument does not correspond to one of the known entries in the C++ enum. The existing whitelists and blacklists of annotations are also generated from the YAML file and all duplicate code related to them has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included in the list (and some obsolete ones have been removed) and all call sites have been updated including tests where appropriate.
1e9ecba54e7b1e6ee614e323ece9c98c373311a9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 485191
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.
86471a18672fb8b1c7edf27076f5e2964e2389f9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 485185
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.
f6c28d1e8a4bee80201f26c5a6bf4d007618bd1a: Bug 1478986 - convert rust.configure to use js_option; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Thu, 02 Aug 2018 08:27:11 -0400 - rev 484959
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1478986 - convert rust.configure to use js_option; r=ted.mielczarek This change is necessary for usefully including rust.configure from JS's configure.
9353904b5dbcc54653e9688115fa51175e3d0043: Bug 1477081 - remove TARGET_CPU use from moz.build files; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Tue, 24 Jul 2018 16:08:55 -0400 - rev 483255
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1477081 - remove TARGET_CPU use from moz.build files; r=ted.mielczarek TARGET_CPU is not canonicalized, whereas CPU_ARCH is, so we should be using CPU_ARCH to get consistent values everywhere.
be04a499d0d0e98c735b3152c97ca49c3ec4ecaa: Bug 1472789 - make the windows crashreporter not dependent on libxul files; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Tue, 03 Jul 2018 20:09:37 -0400 - rev 480056
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1472789 - make the windows crashreporter not dependent on libxul files; r=ted.mielczarek This makes one less place where we link code compiled for libxul into a place that doesn't link mozglue, and is cleaner to boot. We don't need the BREAKPAD_NO_TERMINATE_THREAD define that breakpad-windows-libxul defines because we're not including the handler code in the crashreporter binary.
5284d9a25ffb3ec2130f2526f1b8785a9e48e0ba: Bug 1309172 - Updated breakpad to version 69c2c51dd89965d234eec16e3a9353634831916b; r=ted.mielczarek
Gabriele Svelto <gsvelto@mozilla.com> - Tue, 19 Jun 2018 13:47:13 +0200 - rev 478739
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1309172 - Updated breakpad to version 69c2c51dd89965d234eec16e3a9353634831916b; r=ted.mielczarek This includes both the vanilla sources we haven't forked and the client sources that we have. Client patches were applied manually up to version 69c2c51dd89965d234eec16e3a9353634831916b. The following changes were not included as they break merging segments corresponding to libxul.so in the module list: 8915f7be39448d9257b6da3ad0233944d1d9a92a 17ad0c18b179c135fc5a3d2bba199c3fa4276035 94b6309aecaddfcf11672f6cfad9575d68ad3b40 With these changes applied two entries for libxul.so are generated, the second one is bogus and prevents symbolication from working correctly. The build system and some of the tools relying on breakpad were also updated to work with the new version.
07a62b4e792399774c6c056140f1a6bf9102b164: Bug 1309172 - Updated breakpad to version 69c2c51dd89965d234eec16e3a9353634831916b; r=ted.mielczarek
Gabriele Svelto <gsvelto@mozilla.com> - Tue, 19 Jun 2018 13:47:13 +0200 - rev 477371
Push 9382 by cbrindusan@mozilla.com at Thu, 21 Jun 2018 15:23:31 +0000
Bug 1309172 - Updated breakpad to version 69c2c51dd89965d234eec16e3a9353634831916b; r=ted.mielczarek This includes both the vanilla sources we haven't forked and the client sources that we have. Client patches were applied manually up to version 69c2c51dd89965d234eec16e3a9353634831916b. The following changes were not included as they break merging segments corresponding to libxul.so in the module list: 8915f7be39448d9257b6da3ad0233944d1d9a92a 17ad0c18b179c135fc5a3d2bba199c3fa4276035 94b6309aecaddfcf11672f6cfad9575d68ad3b40 With these changes applied two entries for libxul.so are generated, the second one is bogus and prevents symbolication from working correctly. The build system and some of the tools relying on breakpad were also updated to work with the new version.
2491b63fe79aa6113a77c49f2fa9f7c2ed7e59ff: Bug 1417920 - squash pytest warnings about Test* classes; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Fri, 01 Jun 2018 15:39:54 -0400 - rev 475897
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1417920 - squash pytest warnings about Test* classes; r=ted.mielczarek Having an imported class that begins with `Test` causes pytest to warn: =================================== warnings summary ==================================== mozbuild/test/backend/test_recursivemake.py::TestMetadataBackend cannot collect test class 'TestMetadataBackend' because it has a __init__ constructor -- Docs: http://doc.pytest.org/en/latest/warnings.html After seeing this several times and each time wondering what the yellow output in your terminal might mean, the warning starts to get tiresome. A class-scope `__test__` attribute set to `False` makes this warning go away; let's do that and eliminate this papercut.
fb19935b19308a37eccdbd956dc1f6d26ca038dc: Bug 1464773 - Add low-memory event counts to the crash report; r=ted.mielczarek
Gabriele Svelto <gsvelto@mozilla.com> - Mon, 28 May 2018 10:09:20 +0200 - rev 475337
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1464773 - Add low-memory event counts to the crash report; r=ted.mielczarek MozReview-Commit-ID: 9hf31FSigrI
0f0e532db5ecc823a013c5f417d54694d6f38284: Bug 1464128 - Migrate bookmarks.html.in to LOCALIZED_GENERATED_FILES. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Thu, 24 May 2018 11:28:47 -0700 - rev 474001
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1464128 - Migrate bookmarks.html.in to LOCALIZED_GENERATED_FILES. r=ted.mielczarek This one looks to be pretty straight-forward. It irritates me that the jar.mn entry doesn't explicitly say that the result is coming from the object directory, like locale/browser/bookmarks.html (!bookmarks.html) but that's for another day. MozReview-Commit-ID: Cw8E0VJhSxv
e61af28c3143645eb79a8245112863c0b702d7e4: Bug 1460379 - remove --with-pthreads option; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Wed, 09 May 2018 17:26:31 -0400 - rev 471898
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1460379 - remove --with-pthreads option; r=ted.mielczarek This option does nothing if it's provided, and things will probably break in some most peculiar manner if somebody uses --without-pthreads. Given that neither outcome is useful, we should remove the option.
2dd51c7e5789d45631e1e56b59ee02ac81e55b35: Bug 1460373 - move --enable-valgrind to moz.configure; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Wed, 09 May 2018 17:26:31 -0400 - rev 471897
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1460373 - move --enable-valgrind to moz.configure; r=ted.mielczarek
758cb28b70144afa10405624044bec305f101dc2: Bug 1460367 - move audio sample-related settings to moz.configure; r=ted.mielczarek,nalexander
Nathan Froyd <froydnj@mozilla.com> - Wed, 09 May 2018 17:26:31 -0400 - rev 471896
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1460367 - move audio sample-related settings to moz.configure; r=ted.mielczarek,nalexander With moz.configure, it's a little more obvious that MOZ_TREMOR and MOZ_VORBIS are mutually exclusive.
ed0bdeaa6fd4284bf48d9b055148ec0fe308cfcc: Bug 1459993 - remove MSVC 2015 bits from toolchain.configure; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Wed, 09 May 2018 17:26:31 -0400 - rev 471895
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1459993 - remove MSVC 2015 bits from toolchain.configure; r=ted.mielczarek It's unsupported, so we might as well get rid of the bits for it.
bb8e6bef734f562d70737964dd93f417f19e8c1c: Bug 1459988 - disallow MSVC 15.7+ from being used to build Firefox; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Wed, 09 May 2018 17:26:32 -0400 - rev 471894
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1459988 - disallow MSVC 15.7+ from being used to build Firefox; r=ted.mielczarek
1374936db0183b95619f8e312c377f5a784e59bd: Bug 1323557 - preserve vendored crates when re-vendoring; r=ted.mielczarek
Myk Melez <myk@mykzilla.org> - Fri, 20 Apr 2018 11:53:10 -0700 - rev 469072
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1323557 - preserve vendored crates when re-vendoring; r=ted.mielczarek `mach vendor rust` currently removes third_party/rust before `cargo update`, which prevents modifying vendored crates for local testing and try pushes. It's also unnecessary. So this patch removes the code that removes the dir. MozReview-Commit-ID: IE0FZ3of8Py
9f270d21aef58c86b0b6e8fc515f740393fc4439: Bug 1447632 - Make sure that TLB files are included in Windows artifact builds, r=ted.mielczarek
Marco Zehe <mzehe@mozilla.com> - Wed, 21 Mar 2018 14:17:50 -0400 - rev 462817
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447632 - Make sure that TLB files are included in Windows artifact builds, r=ted.mielczarek MozReview-Commit-ID: 6hdEqaJvuZl
7a23c23c732aa7a0f048de4c9f10eb1db693ade5: Bug 1447086 - Return a promise from stop() in httpd.js r=ted.mielczarek
Thom Chiovoloni <tchiovoloni@mozilla.com> - Mon, 19 Mar 2018 11:40:18 -0700 - rev 462632
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447086 - Return a promise from stop() in httpd.js r=ted.mielczarek MozReview-Commit-ID: 7pxiQazBMqg
e001dfa526adfc78f1b9d631468d4254ef448e64: Bug 1443208 - Express Fennec APK with GENERATED_FILES. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Tue, 20 Mar 2018 12:41:49 -0700 - rev 462617
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1443208 - Express Fennec APK with GENERATED_FILES. r=ted.mielczarek This small change is actually very significant. Previously, |mach package| for mobile/android had two jobs: 1) produce a final APK 2) rebuild parts of the APK that might have been silently modified by l10n mechanisms, both from multi-locale builds and single-locale repacks This second part has never been sensible but has been difficult to alter until recently, since the l10n mechanisms have been out of mozilla-central and difficult to modify and test. That's less true now. This patch: a) removes the rebuild parts (the step labeled 2) above (which I generally refer to as the "nodeps mechanism") b) uses the APKs produced by Gradle directly, without the copying indirection from m/a/base/Makefile.in c) does the rebuild for multi-locale builds as an explicit step in the appropriate mozharness script d) does the rebuild for each single-locale repack as another step in the existing `installers-%` target in m/a/locales/Makefile.in (it's not easy to remove this from the Makefile, since the repackage is invoked immediately after (it's the `repackage-zip-$*` target)) The new m/a/gradle.py file will grow additional tasks in tickets to follow, hence the lock file and pre-factored form. MozReview-Commit-ID: IKflLdmHR3P
fe70510127c52b9ac8c1c9287ffc9c7148c414aa: Bug 1443208 - Pre: Add force flag to GENERATED_FILES. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Thu, 08 Mar 2018 16:04:06 -0800 - rev 462616
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1443208 - Pre: Add force flag to GENERATED_FILES. r=ted.mielczarek The forces on the system are such that I really need to be able to FORCE a few RecursiveMake targets in order to make Android and Gradle use GENERATED_FILES and LOCALIZED_GENERATED_FILES. Over time, I hope to avoid FORCE, but that time is not now. MozReview-Commit-ID: 453FpnihSRK
fcf5174ce1a6ef32d639958ee3582aa0d30074a8: Bug 1444534 - Part 2: Fold m/a/base/locales into m/a/base. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Thu, 08 Mar 2018 14:19:13 -0800 - rev 461257
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1444534 - Part 2: Fold m/a/base/locales into m/a/base. r=ted.mielczarek At last, another part of our long nightmare bites the dust. We had a complicated system where m/a/base used a FORCE $(MAKE) to produce l10n-dependent pieces in m/a/base/locales, foiling sensible recursive Make dependencies and causing much pain and suffering. Now that things are in moz.build, we can fold this into m/a/base, simplifying the dependencies. This gets us one step closer to expressing the APK generation that consumes the dependencies in moz.build. MozReview-Commit-ID: FzLtgR8AMue
264a5497622cf6137d2b27a1071cc7fd69530b90: Bug 1444534 - Part 1: Allow "locales/en-US" relative paths in localized inputs. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Thu, 08 Mar 2018 14:12:44 -0800 - rev 461256
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1444534 - Part 1: Allow "locales/en-US" relative paths in localized inputs. r=ted.mielczarek This cleans up a few things, including simplifying the look of backend.mk by keeping the relsrcdir in MERGE_RELATIVE_FILE similar to the source path in the tree. Before, the locales/ floated around, which is hard to understand but doesn't matter, since it's stripped by MERGE_RELATIVE_FILE. This also tests both relative and topsrcdir-absolute paths. MozReview-Commit-ID: 1v3y9xGiNfL
c49612687020f15197ca5024fc562f405c1df127: Bug 1444534 - Pre: Don't generate JNI wrappers for multi-locale builds or single-locale repacks. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Fri, 09 Mar 2018 10:39:46 -0800 - rev 461255
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1444534 - Pre: Don't generate JNI wrappers for multi-locale builds or single-locale repacks. r=ted.mielczarek As the comment says, these aren't useful during the final stage of assembling a multi-locale build (when AB_CD=multi is set -- they're definitely useful for the initial build, when AB_CD is unset and implicitly en-US). And single-locale repacks don't do any compilation, so they're definitely not useful there. By guarding, we avoid having to be specific about what we're building in the build invocations that will be moved out of |mach package| and into different parts of the multi-locale build and single-locale repack processes. Subsequent tickets will migrate this whole JNI wrapper generation mechanism to GENERATED_FILES anyway, moving the JNI wrapper generation closer to the build steps that need the wrappers and avoiding the problem entirely: those build steps won't be invoked at all for multi-locale builds or for single-locale repacks. MozReview-Commit-ID: Lt2d6uFm5Dq
e71baaa6c4b65f6ae14f687e721dd8bdac17993d: Bug 1444534 - Pre: Don't hide l10n Make invocations. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Wed, 07 Mar 2018 12:25:26 -0800 - rev 461254
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1444534 - Pre: Don't hide l10n Make invocations. r=ted.mielczarek There's just no need for this: it makes interpreting build logs that little bit harder. MozReview-Commit-ID: 7gq73I8I3Bt
d2d65d9d57ad9d04a124fe78776426f8273353ff: Bug 1357688 - Clean up and document the crash reporter environment variables; r=ted.mielczarek
Gabriele Svelto <gsvelto@mozilla.com> - Mon, 26 Feb 2018 15:00:58 +0100 - rev 458622
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
Bug 1357688 - Clean up and document the crash reporter environment variables; r=ted.mielczarek This cleans up the way the crash reporter client invokes the minidump analyzer by removing the extra command-line parameter and replacing it with an environment variable. Since I was at it I've also cleaned up other uses of env variables in the code and added documentation for all of them. MozReview-Commit-ID: ATkgsI3L2Md
81c0cc6fe4c46021c8f0c17b2ef6bd482ab95d7f: Bug 1307153 - Add stack traces to the crash pings in Fennec; r=jchen,ted.mielczarek
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 19 Jan 2018 16:48:00 +0100 - rev 458112
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
Bug 1307153 - Add stack traces to the crash pings in Fennec; r=jchen,ted.mielczarek MozReview-Commit-ID: ZJKUwHFsuK
546fb266153eb1757c35d4dfe3a69175fadbc0cd: Bug 1439742 - Allow {AB_CD} and {AB_rCD} in LOCALIZED_GENERATED_FILES. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Wed, 21 Feb 2018 17:12:17 -0800 - rev 458063
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
Bug 1439742 - Allow {AB_CD} and {AB_rCD} in LOCALIZED_GENERATED_FILES. r=ted.mielczarek There are a lot of choices and moving pieces in this commit. I elected to include the mechanics and the target use case in the same commit so that readers can compare and contrast the implementation and final expression in one review window. - Initially, I wanted to make the {AB_CD} substitutions in LOCALIZED_FILES and not in LOCALIZED_GENERATED_FILES. However, I ran into conceptual blockers doing this. Fundamentally, LOCALIZED_FILES is FINAL_TARGET_FILES, and my use case should _not_ be putting files anywhere near dist/bin. In addition, LOCALIZED_FILES (FINAL_TARGET_FILES) is handled using manifests, which would need to grow locale-aware functionality to handle this. That's not desirable. In addition, if we use manifests, then we lose the powerful locality of |mach build mobile/android{/base}| re-generating changed locale-dependent resources. This is similar to how the build system plumbs dist/idl manifest processing throughout the build: we're repairing local workflows after moving work into a global process. For these reasons, this doesn't support {AB_CD} in LOCALIZED_FILES. - There is even another layer of complexity! There are two axes involved with these files: AB_CD controls localization and the Make target controls destination. For the record, it is: regular builds - AB_CD unset multi-locale builds - AB_CD set single-locale repacks - AB_CD set For the record, the existing logic (before any changes) is: regular builds - Make target is `libs` in mobile/android/base/locales multi-locale builds - Make target is `chrome-%` in mobile/android/base/locales single-locale repacks - Make target is `libs` in mobile/android/base/locales This commit adds targets for both destinations, and uses Make chrome-%:: and libs:: magic to control what is invoked in the various situations. Tricky! - I added MERGE_RELATIVE_FILES in order to be able to follow-up this patch with more patches that will get rid of m/a/base/locales/{moz.build,Makefile.in} altogether, and fold this work into m/a/base. As it stands, we're already reaching from m/a/base/locales all the way out to mobile/locales/.../region.properties, so the existing code doesn't follow the layout expected between mozilla-central and l10n-central/$(AB_CD). But that'll impedance will get worse as we improve the build system dependencies, not better, so we should grow support for localized resources that aren't exactly as expected. - I chose to follow Python's syntax for string substitutions. I would have preferred to mark files that should be localized with a leading '%'... but I took that for filesystem absolute paths in moz.build files already. I also considered @AB_CD@ to echo the preprocessor, but didn't want to open the door to an expecation that _all_ preprocessor DEFINEs will work in the way {AB_CD} does. - The generate_*py script changes required a bit of a hack to "turn off" locale dependent resources. This would have been nicer if we had marked localized resources with '%'... but we didn't. See the --fallback flag. The real reason this is needed is that we're doing work which is more like the work of compare-locales (merging locale-dependent resources) at build-time rather than repack time. I don't know why that's the case -- probably when we (I) implemented it, compare-locales and the whole l10n process was entirely opaque. It's not worth changing it now, so we use this --fallback flag approach. - I didn't get to tup support. This should gently fail without breaking tup builds: any {AB_CD} substitutions just won't be expanded. I haven't a clue how this should work in tup in the future (or, more generally, how to make any sense of repacks without declaring the full set of expected locales at configure time.) - strings.xml can't be a LOCALIZED_PP_FILES, since we need to customize the output location based on AB_rCD, and since we need a little more flexibility than PP_FILES gives for our inputs. MozReview-Commit-ID: MyfIkNSEzt
1817640e5a09ab6cc025a30a2e09b8492d990b64: Bug 1439742 - Pre: Lift AB_rCD to ambient Make environment. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Tue, 20 Feb 2018 12:28:21 -0800 - rev 458062
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
Bug 1439742 - Pre: Lift AB_rCD to ambient Make environment. r=ted.mielczarek I wanted to lift this next to the definition of AB_CD, but that doesn't allow to use it in a backend.mk file, due to the order in which Makefile, config.mk, rules.mk, and backend.mk are processed. Therefore, I've put it in a tiny include file, so that it can be used by a Makefile and a backend.mk file. This allows the `RecursiveMake` backend to owning defining AB_rCD in backend.mk files, while not requiring consumers to arrange for AB_rCD in a sibling Makefile.in file. Other build backends will need to arrange for AB_rCD themselves: see following commits. MozReview-Commit-ID: I7GIzRbCCtf
d304b444c23ddc881a57998156a2537f93dbffb5: Bug 1439742 - Pre: Remove unused MERGE_FILES and EN_US_OR_L10N_FILE{S}. r=ted.mielczarek
Nick Alexander <nalexander@mozilla.com> - Mon, 19 Feb 2018 09:50:20 -0800 - rev 458061
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
Bug 1439742 - Pre: Remove unused MERGE_FILES and EN_US_OR_L10N_FILE{S}. r=ted.mielczarek MozReview-Commit-ID: 3jMUXSaooVW
c197ac2299bb624fbf1e28466736391683382162: Bug 1434671 - add a benchmarking macro permitting custom test fixtures; r=ted.mielczarek
Nathan Froyd <froydnj@mozilla.com> - Mon, 26 Feb 2018 17:31:58 -0400 - rev 457942
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
Bug 1434671 - add a benchmarking macro permitting custom test fixtures; r=ted.mielczarek GTest supports the TEST macro, which just runs a bunch of tests, and the TEST_F macro, which enables writing custom test fixtures to perform per-test setup and teardown. The benchmarking framework we have has a corresponding macro for the former, but no corresponding macro for the latter. If there's significant work to be done during setup and teardown, we certainly don't want to be doing that work during the actual benchmarking! So let's introduce a MOZ_GTEST_BENCH_F macro that works similarly to the TEST_F macro.
fab46ed62124c604f5c6445b46502494936c536d: Bug 1424967: Fix remaining lint error in upload_symbols.py; r=ted.mielczarek
Tom Prince <mozilla@hocat.ca> - Tue, 12 Dec 2017 22:42:23 -0700 - rev 451400
Push 8551 by ryanvm@gmail.com at Wed, 17 Jan 2018 15:17:16 +0000
Bug 1424967: Fix remaining lint error in upload_symbols.py; r=ted.mielczarek MozReview-Commit-ID: LsvBXNy1SA6
857bda1e6d53c19b3f9b7de23070d64ab5a84c3e: Bug 1424967: Pass the correct arguments to log in upload_symbols.py; r=ted.mielczarek
Tom Prince <mozilla@hocat.ca> - Tue, 12 Dec 2017 22:26:03 -0700 - rev 451399
Push 8551 by ryanvm@gmail.com at Wed, 17 Jan 2018 15:17:16 +0000
Bug 1424967: Pass the correct arguments to log in upload_symbols.py; r=ted.mielczarek MozReview-Commit-ID: JcicOipqM4Q
02a7d3b84dcd08e6c6a0646c49870306f3d6579a: Bug 1424967: Fix remaining lint error in upload_symbols.py; r=ted.mielczarek
Tom Prince <mozilla@hocat.ca> - Tue, 12 Dec 2017 22:42:23 -0700 - rev 451362
Push 8551 by ryanvm@gmail.com at Wed, 17 Jan 2018 15:17:16 +0000
Bug 1424967: Fix remaining lint error in upload_symbols.py; r=ted.mielczarek MozReview-Commit-ID: LsvBXNy1SA6
e027f4bf3ed2324f094eed7e6fe51a53f05dd355: Bug 1424967: Pass the correct arguments to log in upload_symbols.py; r=ted.mielczarek
Tom Prince <mozilla@hocat.ca> - Tue, 12 Dec 2017 22:26:03 -0700 - rev 451361
Push 8551 by ryanvm@gmail.com at Wed, 17 Jan 2018 15:17:16 +0000
Bug 1424967: Pass the correct arguments to log in upload_symbols.py; r=ted.mielczarek MozReview-Commit-ID: JcicOipqM4Q