searching for reviewer(tabraldes)
387f44470903: Bug 1366701 Part 2: Roll-up patch to apply remaining mozilla changes to chromium sandbox. r=tabraldes,aklotz,jimm,bobowen
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 445173
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1366701 Part 2: Roll-up patch to apply remaining mozilla changes to chromium sandbox. r=tabraldes,aklotz,jimm,bobowen Patches re-applied from security/sandbox/chromium-shim/patches/after_update/. See patch files for additional commit comments.
9af0d458ebcc: Bug 1337331 Part 2: Re-apply - Logging changes to the Chromium interception code. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 398520
Push 7391 by mtabara@mozilla.com at 2017-06-12 13:08 +0000
Bug 1337331 Part 2: Re-apply - Logging changes to the Chromium interception code. r=tabraldes Carrying r=tabraldes from previous changset: https://hg.mozilla.org/mozilla-central/rev/a05726163a79
226c893c5d62: Bug 1337331 Part 2: Re-apply - Logging changes to the Chromium interception code. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 397396
Push 7391 by mtabara@mozilla.com at 2017-06-12 13:08 +0000
Bug 1337331 Part 2: Re-apply - Logging changes to the Chromium interception code. r=tabraldes Carrying r=tabraldes from previous changset: https://hg.mozilla.org/mozilla-central/rev/a05726163a79
a05726163a79: Bug 1287426 Part 5: Re-apply - Logging changes to the Chromium interception code. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 354089
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1287426 Part 5: Re-apply - Logging changes to the Chromium interception code. r=tabraldes Originally landed as changset: https://hg.mozilla.org/mozilla-central/rev/0f763c186855 MozReview-Commit-ID: DtuHfDoB1Dx
00d1d90c348b: Bug 1287426 Part 4: Re-apply pre-vista stdout/err process inheritance change to Chromium code after merge. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 18 Nov 2014 15:11:47 +0000 - rev 354088
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1287426 Part 4: Re-apply pre-vista stdout/err process inheritance change to Chromium code after merge. r=tabraldes Originally landed as changset: https://hg.mozilla.org/mozilla-central/rev/f94a07671389 MozReview-Commit-ID: 2dpjBXkzlze
92029305820c: Bug 1219369: In Windows debug builds allow write access to TEMP for logging purposes. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 09 Feb 2016 08:31:18 +0000 - rev 319942
Push 5913 by jlund@mozilla.com at 2016-04-25 16:57 +0000
Bug 1219369: In Windows debug builds allow write access to TEMP for logging purposes. r=tabraldes
29408f18b82e: Bug 1229804: Use the correct string length in Windows sandbox logging. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Thu, 03 Dec 2015 11:19:14 +0000 - rev 309589
Push 5513 by raliiev@mozilla.com at 2016-01-25 13:55 +0000
Bug 1229804: Use the correct string length in Windows sandbox logging. r=tabraldes
56e6914c51a7: Bug 1207972: Move to using USER_INTERACTIVE and JOB_INTERACTIVE by default for the Windows content sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Mon, 05 Oct 2015 11:10:46 +0100 - rev 299436
Push 5392 by raliiev@mozilla.com at 2015-12-14 20:08 +0000
Bug 1207972: Move to using USER_INTERACTIVE and JOB_INTERACTIVE by default for the Windows content sandbox. r=tabraldes
da4d79a712c6: Bug 1200336: Apply fix for Chromium issue 482784 for sandbox bug when built with VS2015. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Thu, 10 Sep 2015 08:25:20 +0100 - rev 294355
Push 5245 by raliiev@mozilla.com at 2015-10-29 11:30 +0000
Bug 1200336: Apply fix for Chromium issue 482784 for sandbox bug when built with VS2015. r=tabraldes
3b9e3c02a8e4: Bug 1166669: Enable process-level mitigations for the Windows content process sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Wed, 03 Jun 2015 09:13:00 +0100 - rev 277737
Push 4932 by jlund@mozilla.com at 2015-08-10 18:23 +0000
Bug 1166669: Enable process-level mitigations for the Windows content process sandbox. r=tabraldes
0d036289fac1: Bug 1146874 Part 1: Check that Windows sandboxed process starts correctly. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Mon, 11 May 2015 08:24:39 +0100 - rev 274106
Push 4932 by jlund@mozilla.com at 2015-08-10 18:23 +0000
Bug 1146874 Part 1: Check that Windows sandboxed process starts correctly. r=tabraldes
cbf89fb08ec7: Bug 1146874 - Part 1: Check that Windows sandboxed process starts correctly. r=tabraldes, a=lizzard
Bob Owen <bobowencode@gmail.com> - Mon, 11 May 2015 08:24:39 +0100 - rev 273110
Push 4830 by jlund@mozilla.com at 2015-06-29 20:18 +0000
Bug 1146874 - Part 1: Check that Windows sandboxed process starts correctly. r=tabraldes, a=lizzard
486f83a6cde4: Bug 1158773: Use the same initial and delayed integrity level for Windows content sandbox level 0. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Wed, 06 May 2015 10:11:56 +0100 - rev 272437
Push 4830 by jlund@mozilla.com at 2015-06-29 20:18 +0000
Bug 1158773: Use the same initial and delayed integrity level for Windows content sandbox level 0. r=tabraldes
6f8e9bf83767: Bug 1149483: Change content sandbox level 1 to a working low integrity sandbox. r=tabraldes, r=billm
Bob Owen <bobowencode@gmail.com> - Sun, 05 Apr 2015 14:01:38 +0100 - rev 267738
Push 4830 by jlund@mozilla.com at 2015-06-29 20:18 +0000
Bug 1149483: Change content sandbox level 1 to a working low integrity sandbox. r=tabraldes, r=billm
6f78a86e9179: Bug 1146874 - Part 1: Check that Windows sandboxed process starts correctly. r=tabraldes, a=lizzard
Bob Owen <bobowencode@gmail.com> - Mon, 11 May 2015 08:24:39 +0100 - rev 266045
Push 4736 by ryanvm@gmail.com at 2015-05-20 20:27 +0000
Bug 1146874 - Part 1: Check that Windows sandboxed process starts correctly. r=tabraldes, a=lizzard
972321ec7bcd: Bug 1137166: Change the Content moreStrict sandbox pref to an integer to indicate the level of sandboxing. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 10 Mar 2015 08:03:12 +0000 - rev 261548
Push 4718 by raliiev@mozilla.com at 2015-05-11 18:39 +0000
Bug 1137166: Change the Content moreStrict sandbox pref to an integer to indicate the level of sandboxing. r=tabraldes
421446ab2347: Bug 1102195 Part 3: Re-apply logging changes to the Chromium interception code. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 255757
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1102195 Part 3: Re-apply logging changes to the Chromium interception code. r=tabraldes Originally landed as changset: https://hg.mozilla.org/mozilla-central/rev/0f763c186855
efa7518e43b0: Bug 1102195 Part 2: Re-apply pre-vista stdout/err process inheritance change to Chromium code after merge. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 18 Nov 2014 15:11:47 +0000 - rev 255756
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1102195 Part 2: Re-apply pre-vista stdout/err process inheritance change to Chromium code after merge. r=tabraldes Originally landed as changset: https://hg.mozilla.org/mozilla-central/rev/f94a07671389
f83176aaffe9: Bug 1129369 Part 3: Turn on MITIGATION_STRICT_HANDLE_CHECKS process-level mitigation for the GMP sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 10 Feb 2015 09:06:59 +0000 - rev 255529
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1129369 Part 3: Turn on MITIGATION_STRICT_HANDLE_CHECKS process-level mitigation for the GMP sandbox. r=tabraldes
6cb61619e34f: Bug 1129369 Part 2: Turn on BOTTOM_UP_ASLR process-level mitigation for the GMP sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 10 Feb 2015 09:06:59 +0000 - rev 255528
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1129369 Part 2: Turn on BOTTOM_UP_ASLR process-level mitigation for the GMP sandbox. r=tabraldes
bd213a576671: Bug 1129369 Part 1: Turn on DEP_NO_ATL_THUNK process-level mitigation for the GMP sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 10 Feb 2015 09:06:59 +0000 - rev 255527
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1129369 Part 1: Turn on DEP_NO_ATL_THUNK process-level mitigation for the GMP sandbox. r=tabraldes
03ba45deb84f: Bug 1123245 Part 2: Use the USER_NON_ADMIN access token level for Windows NPAPI processes. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Fri, 23 Jan 2015 08:32:21 +0000 - rev 252458
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1123245 Part 2: Use the USER_NON_ADMIN access token level for Windows NPAPI processes. r=tabraldes
3fba7dde5a94: Bug 1123245 Part 1: Enable an open sandbox on Windows NPAPI processes. r=josh, r=tabraldes
Bob Owen <bobowencode@gmail.com> - Fri, 23 Jan 2015 08:32:20 +0000 - rev 252457
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1123245 Part 1: Enable an open sandbox on Windows NPAPI processes. r=josh, r=tabraldes
2a91d4a797df: Bug 1121479 Part 4: Turn on DLL_SEARCH_ORDER process-level mitigation for the GMP sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Wed, 21 Jan 2015 07:59:56 +0000 - rev 251985
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1121479 Part 4: Turn on DLL_SEARCH_ORDER process-level mitigation for the GMP sandbox. r=tabraldes
bec06786b974: Bug 1121479 Part 3: Turn on HEAP_TERMINATE process-level mitigation for the GMP sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Wed, 21 Jan 2015 07:59:56 +0000 - rev 251984
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1121479 Part 3: Turn on HEAP_TERMINATE process-level mitigation for the GMP sandbox. r=tabraldes
4ad3ab545a8b: Bug 1121479 Part 2: Turn on SEHOP process-level mitigation for the GMP sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Wed, 21 Jan 2015 07:59:56 +0000 - rev 251983
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1121479 Part 2: Turn on SEHOP process-level mitigation for the GMP sandbox. r=tabraldes
52463ef12e63: Bug 1121479 Part 1: Turn on DEP process-level mitigation for the GMP sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Wed, 21 Jan 2015 07:59:56 +0000 - rev 251982
Push 4610 by jlund@mozilla.com at 2015-03-30 18:32 +0000
Bug 1121479 Part 1: Turn on DEP process-level mitigation for the GMP sandbox. r=tabraldes
8fd533be98aa: Bug 1129369 - Part 3: Turn on MITIGATION_STRICT_HANDLE_CHECKS process-level mitigation for the GMP sandbox. r=tabraldes, a=lmandel
Bob Owen <bobowencode@gmail.com> - Tue, 10 Feb 2015 09:06:59 +0000 - rev 250087
Push 4500 by ryanvm@gmail.com at 2015-02-27 20:31 +0000
Bug 1129369 - Part 3: Turn on MITIGATION_STRICT_HANDLE_CHECKS process-level mitigation for the GMP sandbox. r=tabraldes, a=lmandel
fa0645acfc44: Bug 1129369 - Part 2: Turn on BOTTOM_UP_ASLR process-level mitigation for the GMP sandbox. r=tabraldes, a=lmandel
Bob Owen <bobowencode@gmail.com> - Tue, 10 Feb 2015 09:06:59 +0000 - rev 250086
Push 4500 by ryanvm@gmail.com at 2015-02-27 20:31 +0000
Bug 1129369 - Part 2: Turn on BOTTOM_UP_ASLR process-level mitigation for the GMP sandbox. r=tabraldes, a=lmandel
56d34ca3b983: Bug 1129369 - Part 1: Turn on DEP_NO_ATL_THUNK process-level mitigation for the GMP sandbox. r=tabraldes, a=lmandel
Bob Owen <bobowencode@gmail.com> - Tue, 10 Feb 2015 09:06:59 +0000 - rev 250085
Push 4500 by ryanvm@gmail.com at 2015-02-27 20:31 +0000
Bug 1129369 - Part 1: Turn on DEP_NO_ATL_THUNK process-level mitigation for the GMP sandbox. r=tabraldes, a=lmandel
f79836f9957e: Bug 1123245 Part 2: Use the USER_NON_ADMIN access token level for Windows NPAPI processes. r=tabraldes, a=sledru
Bob Owen <bobowencode@gmail.com> - Mon, 26 Jan 2015 08:00:40 +0000 - rev 249401
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 1123245 Part 2: Use the USER_NON_ADMIN access token level for Windows NPAPI processes. r=tabraldes, a=sledru
20dbbb1fd98a: Bug 1123245 Part 1: Enable an open sandbox on Windows NPAPI processes. r=josh, r=tabraldes, a=sledru
Bob Owen <bobowencode@gmail.com> - Mon, 26 Jan 2015 08:00:06 +0000 - rev 249400
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 1123245 Part 1: Enable an open sandbox on Windows NPAPI processes. r=josh, r=tabraldes, a=sledru
7b6674e5a437: Bug 1121479 - Part 4: Turn on DLL_SEARCH_ORDER process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
Bob Owen <bobowencode@gmail.com> - Wed, 21 Jan 2015 07:59:56 +0000 - rev 249379
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 1121479 - Part 4: Turn on DLL_SEARCH_ORDER process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
004776aa9aa5: Bug 1121479 - Part 3: Turn on HEAP_TERMINATE process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
Bob Owen <bobowencode@gmail.com> - Wed, 21 Jan 2015 07:59:56 +0000 - rev 249378
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 1121479 - Part 3: Turn on HEAP_TERMINATE process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
cf64f625cd03: Bug 1121479 - Part 2: Turn on SEHOP process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
Bob Owen <bobowencode@gmail.com> - Wed, 21 Jan 2015 07:59:56 +0000 - rev 249377
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 1121479 - Part 2: Turn on SEHOP process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
06da1141e817: Bug 1121479 - Part 1: Turn on DEP process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
Bob Owen <bobowencode@gmail.com> - Wed, 21 Jan 2015 07:59:56 +0000 - rev 249376
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 1121479 - Part 1: Turn on DEP process-level mitigation for the GMP sandbox. r=tabraldes, a=sledru
d58c0218bb55: Bug 1105729: Pre VS2010 SP1 define our own verion of _xgetbv. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Fri, 28 Nov 2014 18:58:33 +0000 - rev 244229
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 1105729: Pre VS2010 SP1 define our own verion of _xgetbv. r=tabraldes
f76fa8396ca8: Bug 1094667: Use the USER_NON_ADMIN access token by default for the Windows content sandbox. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 243941
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 1094667: Use the USER_NON_ADMIN access token by default for the Windows content sandbox. r=tabraldes
0f763c186855: Bug 928044 Part 3: Add logging changes back into the Chromium interception code. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 243940
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 928044 Part 3: Add logging changes back into the Chromium interception code. r=tabraldes
69c15302979a: Bug 928044 Part 2: Enable the content sandbox by default on Windows with an open policy. r=tabraldes,glandium,jimm
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:18 +0000 - rev 243939
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 928044 Part 2: Enable the content sandbox by default on Windows with an open policy. r=tabraldes,glandium,jimm
c2c603abc7bb: Bug 928044 Part 1: Remove Chromium interception logging changes. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Sat, 29 Nov 2014 17:12:17 +0000 - rev 243938
Push 4489 by raliiev@mozilla.com at 2015-02-23 15:17 +0000
Bug 928044 Part 1: Remove Chromium interception logging changes. r=tabraldes
f7b5148c84a1: Bug 1123245 Part 2: Use the USER_NON_ADMIN access token level for Windows NPAPI processes. r=tabraldes, a=sledru
Bob Owen <bobowencode@gmail.com> - Mon, 26 Jan 2015 11:44:27 +0000 - rev 243026
Push 4366 by bobowencode@gmail.com at 2015-01-26 12:06 +0000
Bug 1123245 Part 2: Use the USER_NON_ADMIN access token level for Windows NPAPI processes. r=tabraldes, a=sledru
2ab5add95717: Bug 1123245 Part 1: Enable an open sandbox on Windows NPAPI processes. r=josh, r=tabraldes, a=sledru
Bob Owen <bobowencode@gmail.com> - Mon, 26 Jan 2015 11:44:27 +0000 - rev 243025
Push 4366 by bobowencode@gmail.com at 2015-01-26 12:06 +0000
Bug 1123245 Part 1: Enable an open sandbox on Windows NPAPI processes. r=josh, r=tabraldes, a=sledru
b716e52f2027: Bug 1105729 - Pre VS2010 SP1 define our own verion of _xgetbv. r=tabraldes, a=sledru
Bob Owen <bobowencode@gmail.com> - Fri, 28 Nov 2014 18:58:33 +0000 - rev 242344
Push 4311 by raliiev@mozilla.com at 2015-01-12 19:37 +0000
Bug 1105729 - Pre VS2010 SP1 define our own verion of _xgetbv. r=tabraldes, a=sledru
134dbb88ff88: Bug 1027902: Use an intial integrity level of low for the GMP sandbox on Windows. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Thu, 27 Nov 2014 08:44:45 +0000 - rev 242151
Push 4311 by raliiev@mozilla.com at 2015-01-12 19:37 +0000
Bug 1027902: Use an intial integrity level of low for the GMP sandbox on Windows. r=tabraldes
365d1073111a: Bug 1041775 Part 3: Re-apply pre-vista stdout/err process inheritance change to Chromium code after merge. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 18 Nov 2014 15:11:47 +0000 - rev 241909
Push 4311 by raliiev@mozilla.com at 2015-01-12 19:37 +0000
Bug 1041775 Part 3: Re-apply pre-vista stdout/err process inheritance change to Chromium code after merge. r=tabraldes Originally landed as changsets: https://hg.mozilla.org/mozilla-central/rev/f94a07671389
90ddcaa44959: Bug 1041775 Part 2: Re-apply warn only sandbox changes to Chromium code after merge. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 18 Nov 2014 15:09:55 +0000 - rev 241908
Push 4311 by raliiev@mozilla.com at 2015-01-12 19:37 +0000
Bug 1041775 Part 2: Re-apply warn only sandbox changes to Chromium code after merge. r=tabraldes Originally landed as changsets: https://hg.mozilla.org/mozilla-central/rev/e7eef85c1b0a https://hg.mozilla.org/mozilla-central/rev/8d0aca89e1b2
ebe866ff8a44: Bug 1041775 Part 3: Re-apply pre-vista stdout/err process inheritance change to Chromium code after merge. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 18 Nov 2014 15:11:47 +0000 - rev 240934
Push 4311 by raliiev@mozilla.com at 2015-01-12 19:37 +0000
Bug 1041775 Part 3: Re-apply pre-vista stdout/err process inheritance change to Chromium code after merge. r=tabraldes Originally landed as changsets: https://hg.mozilla.org/mozilla-central/rev/f94a07671389
ec63befb3ad7: Bug 1041775 Part 2: Re-apply warn only sandbox changes to Chromium code after merge. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Tue, 18 Nov 2014 15:09:55 +0000 - rev 240933
Push 4311 by raliiev@mozilla.com at 2015-01-12 19:37 +0000
Bug 1041775 Part 2: Re-apply warn only sandbox changes to Chromium code after merge. r=tabraldes Originally landed as changsets: https://hg.mozilla.org/mozilla-central/rev/e7eef85c1b0a https://hg.mozilla.org/mozilla-central/rev/8d0aca89e1b2
f94a07671389: Bug 1083701: When pre-Vista, for testing purposes allow stdout/err to be inherited by sandboxed process when an env var is set. r=tabraldes
Bob Owen <bobowencode@gmail.com> - Fri, 17 Oct 2014 09:42:09 +0100 - rev 235305
Push 4311 by raliiev@mozilla.com at 2015-01-12 19:37 +0000
Bug 1083701: When pre-Vista, for testing purposes allow stdout/err to be inherited by sandboxed process when an env var is set. r=tabraldes