searching for reviewer(sylvestre)
2a96d8f9339f: Bug 1529504 - Fix two flake8 warnings in static analysis (mach_commands.py) r=sylvestre
Alvaro Serero <alvaroserero@gmail.com> - Sat, 16 Mar 2019 11:53:50 +0100 - rev 522386
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1529504 - Fix two flake8 warnings in static analysis (mach_commands.py) r=sylvestre
a6cadf50156a: Bug 1528643 - Fix mach clang-format -c in mercurial. r=sylvestre
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Feb 2019 08:13:45 +0000 - rev 517617
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528643 - Fix mach clang-format -c in mercurial. r=sylvestre Turns out hg diff works differently, and when Miko tried to use this option last week he realized it didn't work quite as expected. Differential Revision: https://phabricator.services.mozilla.com/D20102
b59977d42a4d: Bug 1521772: Run clang-format in parallel; r=sylvestre
Benjamin Bouvier <benj@benj.me> - Fri, 15 Feb 2019 16:32:48 +0000 - rev 517446
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1521772: Run clang-format in parallel; r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D19943
a273edea702d: Bug 1527286 - For 'mach clang-format' don't pass files that we don't exist on the disk. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 12 Feb 2019 12:54:22 +0000 - rev 516557
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527286 - For 'mach clang-format' don't pass files that we don't exist on the disk. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D19481
5f4630838d46: Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 18 Jan 2019 10:16:18 +0100 - rev 511623
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre # ignore-this-changeset
9916e7d6e327: Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 18 Jan 2019 10:12:56 +0100 - rev 511622
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format r=sylvestre Summary: # ignore-this-changeset Reviewers: sylvestre Reviewed By: sylvestre Subscribers: reviewbot, emilio, jandem, bbouvier, karlt, jya Bug #: 1521000 Differential Revision: https://phabricator.services.mozilla.com/D16936
3bd12b1d762b: Bug 1518959 - Don't format Java files by default; r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 10 Jan 2019 09:05:54 +0000 - rev 510323
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1518959 - Don't format Java files by default; r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D16115
0b5954be5426: Bug 1514341 - mach clang-format - fix path on windows. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Sat, 15 Dec 2018 07:24:18 +0000 - rev 507935
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514341 - mach clang-format - fix path on windows. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D14605
2f15c3366bf0: Bug 1511536 - Restore the comment in nsCSSFrameConstructor::ConstructBlock(), and disable clang-format. r=sylvestre
Ting-Yu Lin <tlin@mozilla.com> - Sat, 01 Dec 2018 13:48:45 +0000 - rev 505525
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1511536 - Restore the comment in nsCSSFrameConstructor::ConstructBlock(), and disable clang-format. r=sylvestre The example frame tree didn't survive the global clang-format change. DONTBUILD because this is a comment-only change. Differential Revision: https://phabricator.services.mozilla.com/D13602
e4712449ba43: Bug 1511383: Update vim modelines after clang-format; r=sylvestre
Benjamin Bouvier <benj@benj.me> - Fri, 30 Nov 2018 16:39:55 +0100 - rev 505464
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1511383: Update vim modelines after clang-format; r=sylvestre - modify line wrap up to 80 chars; (tw=80) - modify size of tab to 2 chars everywhere; (sts=2, sw=2)
3acb179a1759: Bug 1511319 - Ensure that tools/clang-tidy/test doesn't get reformatted using clang-format; r=sylvestre a=Aryx
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 30 Nov 2018 06:32:29 -0500 - rev 505385
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1511319 - Ensure that tools/clang-tidy/test doesn't get reformatted using clang-format; r=sylvestre a=Aryx Reformatting this directory can break some of the tests here. Differential Revision: https://phabricator.services.mozilla.com/D13518
9094a8f08747: Bug 1511176 - Ignore the files used to generate the windows.h STL wrapper in clang-format r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 21:22:51 +0000 - rev 505293
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1511176 - Ignore the files used to generate the windows.h STL wrapper in clang-format r=sylvestre Not doing so causes builds to break. Differential Revision: https://phabricator.services.mozilla.com/D13469
2449004c31ff: Bug 1510535 - Restore a few lines in .clang-format-ignore. r=tcampbell,sylvestre
Jan de Mooij <jdemooij@mozilla.com> - Wed, 28 Nov 2018 09:33:44 +0100 - rev 505165
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510535 - Restore a few lines in .clang-format-ignore. r=tcampbell,sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13205
04f0bbf40bf3: Bug 1508472 - Part 5: Fifth batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 10:30:46 +0000 - rev 505141
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508472 - Part 5: Fifth batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13371
4ecb983c1655: Bug 1510893 - Add the wayland-scanner generated source files to .clang-format-ignore r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 08:25:42 +0000 - rev 505131
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510893 - Add the wayland-scanner generated source files to .clang-format-ignore r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13363
50d1e014826f: Bug 1510787 - Add security/sandbox/chromium-shim/ to the list of third-party sources r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 08:25:27 +0000 - rev 505130
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510787 - Add security/sandbox/chromium-shim/ to the list of third-party sources r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13318
cc9977714e03: Bug 1510765 - Add netwerk/dns/nsIDNKitInterface.h to the list of third-party sources r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 08:25:04 +0000 - rev 505129
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510765 - Add netwerk/dns/nsIDNKitInterface.h to the list of third-party sources r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13306
85b68ee430dc: Bug 1510637 - mach clang-format: when using --assume-filename we don't want to download the actual clang-tools package. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 28 Nov 2018 21:32:05 +0000 - rev 505011
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510637 - mach clang-format: when using --assume-filename we don't want to download the actual clang-tools package. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13254
b4662b6db1b3: Bug 1508472 - Part 4: Fourth batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 28 Nov 2018 09:16:55 +0000 - rev 504917
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508472 - Part 4: Fourth batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13193
628d20bae43f: Bug 1510513 - Retain the formatting of MOZ_DEFINE_ENUM_* macros r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 28 Nov 2018 09:14:19 +0000 - rev 504916
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510513 - Retain the formatting of MOZ_DEFINE_ENUM_* macros r=sylvestre These macros tend to be handled quite poorly since the clang-format tokenizer cannot figure out how to handle them. Differential Revision: https://phabricator.services.mozilla.com/D13179
5992e36db33e: Bug 1510526 - Add a few autogenerated files to .clang-format-ignore r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 28 Nov 2018 07:40:30 +0000 - rev 504914
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510526 - Add a few autogenerated files to .clang-format-ignore r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13194
2d8ce84e0107: Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 28 Nov 2018 00:54:56 +0000 - rev 504836
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13073
2320933cb7bc: Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 21:36:18 +0000 - rev 504814
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13073
11d6688b953f: Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 15:18:32 +0000 - rev 504757
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508472 - Part 2: Second batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13073
fb09acfff168: Bug 1508472 - Part 1: First batch of comment fix-ups in preparation for the tree reformat r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 10:08:58 +0000 - rev 504652
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508472 - Part 1: First batch of comment fix-ups in preparation for the tree reformat r=sylvestre This is a best effort attempt at ensuring that the adverse impact of reformatting the entire tree over the comments would be minimal. I've used a combination of strategies including disabling of formatting, some manual formatting and some changes to formatting to work around some clang-format limitations. Differential Revision: https://phabricator.services.mozilla.com/D13046
c0b875613aa0: Bug 1510130 - Update the third-party directories under media with reality r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 10:07:13 +0000 - rev 504651
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510130 - Update the third-party directories under media with reality r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13045
e23d7926d41e: Bug 1510126 - Add tools/profiler/core/vtune to the list of third-party directories r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 10:06:53 +0000 - rev 504650
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510126 - Add tools/profiler/core/vtune to the list of third-party directories r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D13044
9f44e47ef7b3: Bug 1510124 - Ignore files generated by protobuf in the tree r=sylvestre
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 10:06:05 +0000 - rev 504649
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510124 - Ignore files generated by protobuf in the tree r=sylvestre These are autogenerated files so we shouldn't try to reformat them. Differential Revision: https://phabricator.services.mozilla.com/D13043
5d83d28c9ae5: Bug 1509025 - Remove js/src/jsapi-tests from .clang-format-ignore. r=sylvestre,tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Thu, 22 Nov 2018 14:51:50 +0000 - rev 504140
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509025 - Remove js/src/jsapi-tests from .clang-format-ignore. r=sylvestre,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D12630
a22ad02cbdcc: Bug 1509276 - mach static-analysis install - should accept more flags in order to make it more robust. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 22 Nov 2018 10:47:52 +0000 - rev 504131
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509276 - mach static-analysis install - should accept more flags in order to make it more robust. r=sylvestre Depends on D12599 Differential Revision: https://phabricator.services.mozilla.com/D12635
fd219dda36e8: Bug 1508635 - mach clang-format should be able to print back the file that has been reformatted to stdin, suitable when it ise used with 3rd party tools for merging. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 22 Nov 2018 10:47:50 +0000 - rev 504130
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508635 - mach clang-format should be able to print back the file that has been reformatted to stdin, suitable when it ise used with 3rd party tools for merging. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D12599
ab5ae5f1e381: Bug 1508176 - Some clang-format fixes for generated unicode files. r=tcampbell,sylvestre
Jan de Mooij <jdemooij@mozilla.com> - Wed, 21 Nov 2018 18:30:44 +0000 - rev 504044
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508176 - Some clang-format fixes for generated unicode files. r=tcampbell,sylvestre * Add generated files to .clang-format-ignore. * Remove the "clang-format off/on" annotations from generated files. * Rename FOR_EACH_NON_BMP_CASE_FOLDING argument from macro to MACRO. See bug 1508180. Differential Revision: https://phabricator.services.mozilla.com/D12536
2d8d64aff05a: Bug 1508255 - Merge js/src/.clang-format into top-level r=sylvestre
Ted Campbell <tcampbell@mozilla.com> - Tue, 20 Nov 2018 12:42:30 +0000 - rev 503674
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508255 - Merge js/src/.clang-format into top-level r=sylvestre The style options now match, so remove js/src/.clang-format \o/ Depends on D12391 Differential Revision: https://phabricator.services.mozilla.com/D12392
ba714acdc402: Bug 1508270 - Add libwebp to the list of thirdparty code. r=sylvestre
Andrew Osmond <aosmond@mozilla.com> - Mon, 19 Nov 2018 09:57:43 -0500 - rev 503531
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508270 - Add libwebp to the list of thirdparty code. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D12296
e92a6ab74128: Bug 1508067 - Use clang-format off in vm/Opcodes.h instead of file ignore. r=sylvestre,jandem
Ted Campbell <tcampbell@mozilla.com> - Mon, 19 Nov 2018 09:27:17 +0000 - rev 503466
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508067 - Use clang-format off in vm/Opcodes.h instead of file ignore. r=sylvestre,jandem Differential Revision: https://phabricator.services.mozilla.com/D12240
eb04ab1f698a: Bug 1508160 - Add JS_BEGIN_MACRO to .clang-format r=sylvestre
Ted Campbell <tcampbell@mozilla.com> - Sun, 18 Nov 2018 19:54:59 +0000 - rev 503375
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508160 - Add JS_BEGIN_MACRO to .clang-format r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D12226
95bc945b6cd6: Bug 1500241 - [Clang-Tidy] Disable 'readability-implicit-bool-conversion' check. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 30 Oct 2018 17:11:55 +0000 - rev 499986
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500241 - [Clang-Tidy] Disable 'readability-implicit-bool-conversion' check. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D10264
1635530c393a: Bug 1375861 - [mozlint] Globally exclude paths listed in tools/rewriting/ThirdPartyPaths.txt from our linters, r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 18 Oct 2018 15:27:59 +0000 - rev 497721
Push 10002 by archaeopteryx@coole-files.de at Fri, 19 Oct 2018 23:09:29 +0000
Bug 1375861 - [mozlint] Globally exclude paths listed in tools/rewriting/ThirdPartyPaths.txt from our linters, r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D9126
33692f367564: Bug 1479298 - [Static-Analysis][Clang-Based] Implement the passing of configuration flags to checkers in the configuration file. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 10 Oct 2018 08:01:24 +0000 - rev 496257
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1479298 - [Static-Analysis][Clang-Based] Implement the passing of configuration flags to checkers in the configuration file. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D7997
a243b88f852a: Bug 1487321 - [Static-Analysis][Clang-Tidy] Add new checkers present in 7.0. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 02 Oct 2018 14:10:32 +0000 - rev 495128
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1487321 - [Static-Analysis][Clang-Tidy] Add new checkers present in 7.0. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D7045
741465cf8a3c: Bug 1492770 - Activate google-* checkers that make sense to our code. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 20 Sep 2018 15:29:32 +0000 - rev 493353
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492770 - Activate google-* checkers that make sense to our code. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D6391
1586964885f9: Bug 1485454 - [mozlint] Fix stylish formatter, issues without a column aren't indented enough, r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Mon, 27 Aug 2018 13:40:34 +0000 - rev 488911
Push 9738 by aciure@mozilla.com at Mon, 03 Sep 2018 16:13:51 +0000
Bug 1485454 - [mozlint] Fix stylish formatter, issues without a column aren't indented enough, r=sylvestre After fixing the absolute path issue in codespell, I noticed that the stylish formatter doesn't indent lint issues that don't have a column properly. This was never noticed before since most other linters have a column attribute. Depends on D4012 Differential Revision: https://phabricator.services.mozilla.com/D4013
cb3227f5156c: Bug 1485454 - [lint] Use absolute paths with the codespell linter, r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 29 Aug 2018 13:36:46 +0000 - rev 488907
Push 9738 by aciure@mozilla.com at Mon, 03 Sep 2018 16:13:51 +0000
Bug 1485454 - [lint] Use absolute paths with the codespell linter, r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D4012
adbee46f307f: Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 29 Aug 2018 10:10:54 +0000 - rev 488893
Push 9738 by aciure@mozilla.com at Mon, 03 Sep 2018 16:13:51 +0000
Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D4436
f664646a2e7c: Bug 1460856 - [mozlint] Suppress warnings by default r=Standard8,sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Mon, 27 Aug 2018 13:39:46 +0000 - rev 488702
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1460856 - [mozlint] Suppress warnings by default r=Standard8,sylvestre As of this patch, any lint issue at the "warning" level will *only* be displayed if --warnings is passed in. This gives us some flexibility to track issues that are "recommended to fix" but that aren't required (aka don't cause a backout). I think it would be ideal if the reviewbot ran with warnings enabled, and CI ran without warnings. This way these issues will be surfaced to developers (and hopefully get fixed prior to landing), but developers will always be able to ignore them if the situation warrants it. Since the last change converted everything to use errors, this patch should be a no-op for now. However as we move forward (and potentially decide that certain types of lint issues should result in a backout), this feature will start seeing more and more use. Depends on D3820 Differential Revision: https://phabricator.services.mozilla.com/D3821
88fa28d336fa: Bug 1460856 - [mozlint] Encapsulate all result state in a ResultSummary class r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 28 Aug 2018 13:51:04 +0000 - rev 488689
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1460856 - [mozlint] Encapsulate all result state in a ResultSummary class r=sylvestre Currently there are 3 things that can impact the result of a lint run: 1. The list of lint issues found 2. The set of failures that happened during the setup phase 3. The set of failures that happened during the execution phase All three of these things are stored as instance variables on the LintRoller object, and then passed into a formatter when it comes time to print the results. I'd like to add even more things that can impact the result, and it became clear that the current scenario does not scale well. This patch moves all data that could impact the end result of a lint run off of the LintRoller object and onto a new 'result.ResultSummary' class. To avoid confusion, this patch also renames the 'result.ResultContainer' class to 'result.Issue'. With this new nomenclature: result -> overall state of an entire lint run (can comprise multiple linters) issue -> one specific lint infraction (at either 'warning' or 'error' level) failure -> a non-recoverable error in the linter implementation itself A "result" is comprised of 0 or more "issues" and 0 or more "failures". Differential Revision: https://phabricator.services.mozilla.com/D3819
259675bd67f9: Bug 1486502 - Add widevine CDM headers to third party paths, clang-format ignore. r=sylvestre
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 27 Aug 2018 16:25:54 +0000 - rev 488616
Push 9734 by shindli@mozilla.com at Thu, 30 Aug 2018 12:18:07 +0000
Bug 1486502 - Add widevine CDM headers to third party paths, clang-format ignore. r=sylvestre We wish to keep the widevine headers in the same formatting as upstream to ease comparison and as we do not modify these files. This patch adds the existing headers, as well as another we anticipate pulling down for our next bump (content_decryption_module_proxy.h) to the ignored paths. These files are ignored individually rather than the whole directory they're in, as we also have Mozilla code in that dir. Differential Revision: https://phabricator.services.mozilla.com/D4347
e046ec0ce93d: Bug 1483539 - [mozlint] Log a success message from the treeherder formatter when all lints succeed, r=sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 15 Aug 2018 14:17:06 +0000 - rev 487195
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1483539 - [mozlint] Log a success message from the treeherder formatter when all lints succeed, r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D3415
bc15796e6fa7: Bug 1478644 - [Clang-Tidy] Synchronize run-clang-tidy output with the actual files that are being checked. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 26 Jul 2018 15:29:19 +0200 - rev 486325
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1478644 - [Clang-Tidy] Synchronize run-clang-tidy output with the actual files that are being checked. r=sylvestre MozReview-Commit-ID: LyfcV4oQwyw
34fe97a415e3: Bug 1472502 - fix mach static-analysis clear-cache. r=sylvestre
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Mon, 02 Jul 2018 12:05:07 +0300 - rev 479789
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1472502 - fix mach static-analysis clear-cache. r=sylvestre MozReview-Commit-ID: AUlYNnEAtbS