searching for reviewer(spohl)
ddc559541c7fd00faa5735cd78aae18f30474ae8: Bug 1655655 - Some MP4 Videos Fail to Play on Big Sur. r=spohl, a=jcristau
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 29 Jul 2020 21:59:32 +0000 - rev 606642
Push 13489 by jcristau@mozilla.com at Tue, 04 Aug 2020 15:00:31 +0000
Bug 1655655 - Some MP4 Videos Fail to Play on Big Sur. r=spohl, a=jcristau Allow access to the "com.apple.trustd.agent" service in the content process sandbox. VTDecompressionSessionCreate() fails without it, causing playback failure for some MP4 videos. Translate deprecated OS version numbers so that sandbox version checks don't need to check for 10.16. Differential Revision: https://phabricator.services.mozilla.com/D85213
7e36006e76d07501db910a4073a4dabee58f22a5: Bug 1654117 - prevent osclientcerts from loading on macOS <10.14 r=spohl
Dana Keeler <dkeeler@mozilla.com> - Fri, 24 Jul 2020 16:25:08 +0000 - rev 606447
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1654117 - prevent osclientcerts from loading on macOS <10.14 r=spohl osclientcerts requires functions that are available starting in macOS 10.14, so it shouldn't be possible to enable it in earlier versions. Differential Revision: https://phabricator.services.mozilla.com/D84764
829b72f954a3d64ffec821dbe83700361730074e: Bug 1350875 part 2 - Have cocoa always notify fullscreen will change. r=spohl
Xidorn Quan <me@upsuper.org> - Wed, 15 Jul 2020 11:10:22 +0000 - rev 605035
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1350875 part 2 - Have cocoa always notify fullscreen will change. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D68679
918de9580b2a37f832870b71a7bba2c789981df9: Bug 1635572 - Remove workaround for shared memory security bug in old macOS versions. r=spohl
Jed Davis <jld@mozilla.com> - Mon, 13 Jul 2020 21:35:22 +0000 - rev 604654
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1635572 - Remove workaround for shared memory security bug in old macOS versions. r=spohl CVE-2018-4435 (https://crbug.com/project-zero/1671) was fixed in macOS 10.12 and up, but when we added uses of shm_open that would be affected by it we still supported 10.9, so we added a workaround that tests for the bug (by trying to exploit it) and falls back to the slower alternative of temporary files if necessary. The minimum supported version is now 10.12, and we've already committed changes (e.g., to sandboxing) that would break the browser on older versions, so we can remove this code. Note that we also have cross-platform gtests that check for this type of bug, so we'll have some warning if it's ever reintroduced. Differential Revision: https://phabricator.services.mozilla.com/D83197
e7e5921ff49151bf0031ae9f8b73a2b21e717e5c: Bug 1648881 - Right click submenus opening on the wrong screen r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 01 Jul 2020 14:20:40 +0000 - rev 602712
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1648881 - Right click submenus opening on the wrong screen r=spohl Apply the fix for bug 1592416 to submenus. This adds the NSWindowCollectionBehaviorMoveToActiveSpace behavior to submenu popups so that they override the "Assign To" space setting and display on the active space. And, when mutiple displays are in use, recreates the submenu widget each time it is displayed. Differential Revision: https://phabricator.services.mozilla.com/D81812
58988e0766488698bc824e30020948df61167d38: Bug 1648838 - Remove OS-specific sandboxing code for unsupported macOS versions (up to 10.11 inclusive) r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 01 Jul 2020 14:27:13 +0000 - rev 602652
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1648838 - Remove OS-specific sandboxing code for unsupported macOS versions (up to 10.11 inclusive) r=spohl Remove macOS 10.11 (and earlier) specific rules from the content and Flash sandbox profiles. Differential Revision: https://phabricator.services.mozilla.com/D81813
5804ed97ca7cff73b078e16181372bc51a41948a: Bug 1647816 - Make sandboxing OS version checks aware of major version r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Fri, 26 Jun 2020 19:12:39 +0000 - rev 601729
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647816 - Make sandboxing OS version checks aware of major version r=spohl Fix the content and Flash sandbox policies to use the major and minor number for OS version checks allowing video playback to work properly on macOS 11 Big Sur. Pass the macOS major and minor version to sandbox policies as a combined string. Remove unused OSXVersion methods and members and more minor cleanup in Sandbox.mm. Leave in the checks for unsupported versions (macOS 10.9 - 10.11) for now in case this fix needs to be uplifted. Differential Revision: https://phabricator.services.mozilla.com/D81385
299531010a944c3770818dfd093d4f588b2d1546: Bug 1592739 - Make -moz-appearance: dialog render nothing. r=spohl
Markus Stange <mstange@themasta.com> - Thu, 11 Jun 2020 18:46:53 +0000 - rev 600022
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1592739 - Make -moz-appearance: dialog render nothing. r=spohl The window background will be contributed by the widget itself, which renders them underneath Gecko's rendering. As a result, -moz-appearance: dialog is now equivalent to the combination -moz-appearance: none; background-color: transparent. This change does not turn the widget itself transparent because nsCocoaWindow does not allow top level windows to become transparent (ever since bug 1162649). If we ever add support for top level widgets with transparent backgrounds again, we will probably want to treat -moz-appearance: dialog differently from -moz-appearance: none; background-color: transparent, but for now this is fine. This change means that Gecko's rendering will go into transparent buffers. This may result in some loss of subpixel AA in various cases. In the main browser window, there are CSS backgound colors that cover all the non-vibrant areas of the window, so in that window we still render mostly onto opaque pixels. Differential Revision: https://phabricator.services.mozilla.com/D51461
286c8a68ee03d9fa36fa2695ad423b3b3ce1b036: Bug 1577120 - Use the control accent color for the dock download progress bar. r=spohl
Markus Stange <mstange@themasta.com> - Fri, 12 Jun 2020 17:03:31 +0000 - rev 599678
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1577120 - Use the control accent color for the dock download progress bar. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D79358
4473194f0154b3910049d4a1703cd37820502695: Bug 1644940 - Nest the window's CALayers within another level of CALayers. r=spohl
Markus Stange <mstange@themasta.com> - Thu, 11 Jun 2020 15:13:14 +0000 - rev 599202
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644940 - Nest the window's CALayers within another level of CALayers. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D79239
c30f17a79566cec3d826a93bdd0e444f168b4e04: Bug 1493789 - Render solid colors for the source-list-selection -moz-appearance values on 10.10+ if they're not used in a vibrant context. r=spohl
Markus Stange <mstange@themasta.com> - Tue, 09 Jun 2020 16:26:33 +0000 - rev 599102
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1493789 - Render solid colors for the source-list-selection -moz-appearance values on 10.10+ if they're not used in a vibrant context. r=spohl Depends on D51460 Differential Revision: https://phabricator.services.mozilla.com/D78923
228e65b06c33a0a62f7a0af25ad8d1b09825c9ec: Bug 1632845 - Firefox gets stuck when quit from the dock if the user cancels quitting from a beforeunload prompt r=Gijs,spohl,necko-reviewers,geckoview-reviewers,dragana,agi
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 09 Jun 2020 18:20:36 +0000 - rev 598829
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1632845 - Firefox gets stuck when quit from the dock if the user cancels quitting from a beforeunload prompt r=Gijs,spohl,necko-reviewers,geckoview-reviewers,dragana,agi Return NSTerminateCancel from applicationShouldTerminate when the user chooses to "Stay on Page". Differential Revision: https://phabricator.services.mozilla.com/D78839
98d44dc032a38877cdbeeea7867179deb0038c33: Bug 1644047 - Add some documentation about SDKs and using macOS APIs. r=spohl
Markus Stange <mstange@themasta.com> - Mon, 08 Jun 2020 21:41:04 +0000 - rev 598614
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644047 - Add some documentation about SDKs and using macOS APIs. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D78629
db36e0a20946f2549cc3898506a947cdb9810019: Bug 1577120 - Use the control accent color for the dock download progress bar. r=spohl, a=jcristau
Markus Stange <mstange@themasta.com> - Fri, 12 Jun 2020 17:03:31 +0000 - rev 597210
Push 13299 by jcristau@mozilla.com at Thu, 18 Jun 2020 09:58:53 +0000
Bug 1577120 - Use the control accent color for the dock download progress bar. r=spohl, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D79358
18e6a640ccfe42dcc2f3162211f185c70f87f821: Bug 1549046 - Re-enable the "Set As Desktop Background" test on macOS r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 28 May 2020 14:29:27 +0000 - rev 596582
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1549046 - Re-enable the "Set As Desktop Background" test on macOS r=spohl Refactor the test to use a python program to check that the background was successfully changed and re-enable the test on macOS. For running in automation, this test is dependent on Mac test runner instances being configured to allow users to change the desktop background. A code change to allow this has already been landed. See bug for the additional patches. Differential Revision: https://phabricator.services.mozilla.com/D72456
d7f46110bc8b1de57b95f748b556dc4faacf8302: Bug 1592416 - Right click opens context menu on wrong monitor or virtual desktop (mac OS Catalina) r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 28 May 2020 04:00:02 +0000 - rev 596436
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1592416 - Right click opens context menu on wrong monitor or virtual desktop (mac OS Catalina) r=spohl Add the NSWindowCollectionBehaviorMoveToActiveSpace behavior to nsCocoaWindow popups so that they override the "Assign To" space setting and display on the active space. This also addresses bug 1589893 where, when "Assign To" space is used, popup menus are not visible in full screen mode. With mutiple displays, recreate the popup widget each time it is displayed to workaround a problem where the re-shown popup appears on the "Assign To" display instead of the current display. Differential Revision: https://phabricator.services.mozilla.com/D75419
854feb05fff62990dc8bcc861e58fa5b72999d4d: Bug 1592416 - Right click opens context menu on wrong monitor or virtual desktop (mac OS Catalina) r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 27 May 2020 22:41:34 +0000 - rev 596364
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1592416 - Right click opens context menu on wrong monitor or virtual desktop (mac OS Catalina) r=spohl Add the NSWindowCollectionBehaviorMoveToActiveSpace behavior to nsCocoaWindow popups so that they override the "Assign To" space setting and display on the active space. This also addresses bug 1589893 where, when "Assign To" space is used, popup menus are not visible in full screen mode. With mutiple displays, recreate the popup widget each time it is displayed to workaround a problem where the re-shown popup appears on the "Assign To" display instead of the current display. Differential Revision: https://phabricator.services.mozilla.com/D75419
09ccf334001b34afb2e77743d47655300008229f: Bug 1592416 - Right click opens context menu on wrong monitor or virtual desktop (mac OS Catalina) r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 21 May 2020 00:09:32 +0000 - rev 595134
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1592416 - Right click opens context menu on wrong monitor or virtual desktop (mac OS Catalina) r=spohl Add the NSWindowCollectionBehaviorMoveToActiveSpace behavior to nsCocoaWindow popups so that they override the "Assign To" space setting and display on the active space. This also addresses bug 1589893 where, when "Assign To" space is used, popup menus are not visible in full screen mode. With mutiple displays, recreate the popup widget each time it is displayed to workaround a problem where the re-shown popup appears on the "Assign To" display instead of the current display. Differential Revision: https://phabricator.services.mozilla.com/D75419
b8259db1782b52d2ff53e131b3e531a90927852c: Bug 1638821 - Make the decision to whether paint focus rings depend on the theme, not the platform. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 May 2020 15:46:42 +0000 - rev 594631
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1638821 - Make the decision to whether paint focus rings depend on the theme, not the platform. r=spohl The current code assumes that nsNativeTheme is in use which breaks with the non-native theme. Instead of hackily remove the FOCUS bit, make the theme check for the FOCUSRING bit, which is the right thing to check for anyway. Differential Revision: https://phabricator.services.mozilla.com/D75782
39826e3d41917efa3dd0dd4b040a8d9b69c50c93: Bug 1636723. Have nsPrintSettingsX use the NSPrintInfo methods rather than mess with its internal dictionary. r=spohl
Jonathan Watt <jwatt@jwatt.org> - Fri, 15 May 2020 11:45:28 +0000 - rev 594009
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636723. Have nsPrintSettingsX use the NSPrintInfo methods rather than mess with its internal dictionary. r=spohl It is not obvious that the dict is an internal implementation detail of the NSPrintInfo, so it was confusing to me that in some places setters are using a dict but getters are using NSPrintInfo methods. This hopefully makes the code simpler and easier to understand. Differential Revision: https://phabricator.services.mozilla.com/D74543
6d7fac080dca7f3ec0fdd86c9e84834a7e68a9e3: Bug 1276537 part 2 - Remove nsIWidget::SetShowsFullScreenButton. r=spohl
Xidorn Quan <me@upsuper.org> - Fri, 15 May 2020 06:19:14 +0000 - rev 593972
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1276537 part 2 - Remove nsIWidget::SetShowsFullScreenButton. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D74555
7b2be27b7bb98f63cc72bb64871ca05a239ed782: Bug 1276537 part 1 - Make resizable window on macOS always show full screen button. r=spohl
Xidorn Quan <me@upsuper.org> - Fri, 15 May 2020 06:19:14 +0000 - rev 593971
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1276537 part 1 - Make resizable window on macOS always show full screen button. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D74833
61712ddac4343108711a57549068d6f836f485cc: Bug 1635517 - Update deprecated accessibilityIsIgnored to isAccessibilityElement. r=spohl
Eitan Isaacson <eitan@monotonous.org> - Tue, 12 May 2020 17:39:18 +0000 - rev 593230
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635517 - Update deprecated accessibilityIsIgnored to isAccessibilityElement. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D74431
78ed541858a26f7ebfe55eb05db9c7b1871fc9ba: Bug 1633119 - Use orderFront for force window full screen. r=spohl
Xidorn Quan <me@upsuper.org> - Sat, 09 May 2020 12:04:29 +0000 - rev 592729
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1633119 - Use orderFront for force window full screen. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D74527
546092740e58fe69b912d5dde35f01b3c9326e26: Bug 1635577 - add wakelog log. r=spohl,karlt
alwu <alwu@mozilla.com> - Thu, 07 May 2020 19:51:30 +0000 - rev 592425
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635577 - add wakelog log. r=spohl,karlt Differential Revision: https://phabricator.services.mozilla.com/D73949
01866ba8633840dec6c37acc7518374b3ab1196f: Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Apr 2020 17:45:39 +0000 - rev 588953
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl This is used by platforms with overlay scrollbars, only in order to reserve enough space for the chevron of the `<select>` element. So our general min-widget-size, which is the same as for scrollbars works. Differential Revision: https://phabricator.services.mozilla.com/D71825
a0be8f02af467a49ca3dee204f38d03e0ccc2fb6: Bug 1629313 - Part 1 - Set As Desktop Background fails on macOS r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 21 Apr 2020 19:57:29 +0000 - rev 588785
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1629313 - Part 1 - Set As Desktop Background fails on macOS r=spohl Change the nsMacShellService::SetDesktopBackground() implementation (specifically code in the OnStateChange handler) to use the Apple setDesktopImageURL API instead of Apple Events to allow the "Set As Desktop Background..." context menu option to work again. Alternatively, to allow the AppleEvent-base implementation to work again, Firefox could be signed with the com.apple.security.automation.apple-events entitlement but this would also require the user to grant Firefox permission to control Finder. setDesktopImageURL requires Mac OS 10.6 or newer and hence was not an option originally. The implementation only changes the background of the focused screen in the current workspace (which matches the behavior of Safari). Differential Revision: https://phabricator.services.mozilla.com/D71426
c7623d3b49ec7da3731d77e841217251025f5c16: Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 Apr 2020 20:36:22 +0000 - rev 588783
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl This is used by platforms with overlay scrollbars, only in order to reserve enough space for the chevron of the `<select>` element. So our general min-widget-size, which is the same as for scrollbars works. Differential Revision: https://phabricator.services.mozilla.com/D71825
a6637962605fab6cdba8e230ab275352fd942a3d: Bug 1624786 - Replace "clang-format off" with semicolon workaround for clang-format bug 1629756. r=spohl
Chris Peterson <cpeterson@mozilla.com> - Mon, 20 Apr 2020 12:18:48 +0000 - rev 588542
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1624786 - Replace "clang-format off" with semicolon workaround for clang-format bug 1629756. r=spohl This semicolon workaround is tidier than the `// clang-format off/on` comments and avoids turning off all clang-format checks. The comment also links to clang-format bug 1629756 so future code readers can learn why this extra semicolon exists. And if we find a way to fix this in clang-format, then we can search for this bug number to find and remove these extra semicolons and comments. Differential Revision: https://phabricator.services.mozilla.com/D71504
39ee5303a7e89a03482a9a1cb13a39f3760fff3c: Bug 1623745 - Add a value to the pwmgr.reauthenticated telemetry event to specify if the user was able to authenticate without a password. r=MattN,spohl
Jared Wein <jwein@mozilla.com> - Thu, 16 Apr 2020 21:33:24 +0000 - rev 588009
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1623745 - Add a value to the pwmgr.reauthenticated telemetry event to specify if the user was able to authenticate without a password. r=MattN,spohl Differential Revision: https://phabricator.services.mozilla.com/D70136
a7235bdaa392b40512559d6a4a578adfb4a1fc44: Bug 1627414 - getDisplayMedia does not work when firefox is full screen on macOS r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 14 Apr 2020 20:27:55 +0000 - rev 587519
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1627414 - getDisplayMedia does not work when firefox is full screen on macOS r=spohl Change the GetScreenCapturePermissionState() heuristic to use the full window list instead of just on-screen windows to allow it it to work in full screen mode. Differential Revision: https://phabricator.services.mozilla.com/D70931
81e4b5376ea8e075126f1a1b0b2b66b72bf74b8c: Bug 1624786 - Replace MOZ_MUST_USE with [[nodiscard]] in widget/cocoa. r=spohl
Chris Peterson <cpeterson@mozilla.com> - Wed, 08 Apr 2020 16:41:42 +0000 - rev 586861
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1624786 - Replace MOZ_MUST_USE with [[nodiscard]] in widget/cocoa. r=spohl Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers. Differential Revision: https://phabricator.services.mozilla.com/D68148
b293d01619f7350ee271a8dcaeb15dc6a28da22a: Bug 1610613 - Make Picture-in-Picture window persist across workspaces on macOS. r=spohl
Mike Conley <mconley@mozilla.com> - Tue, 07 Apr 2020 13:28:24 +0000 - rev 586123
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1610613 - Make Picture-in-Picture window persist across workspaces on macOS. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D69932
71ba43d7b2df59cfb55cc085fa602bd809bf322f: Bug 1350875 part 2 - Have cocoa always notify fullscreen will change. r=spohl
Xidorn Quan <me@upsuper.org> - Thu, 02 Apr 2020 11:38:43 +0000 - rev 586080
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1350875 part 2 - Have cocoa always notify fullscreen will change. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D68679
400d3425e48f120a91941154765af33ee7a0349e: Bug 1623745 - Add a value to the pwmgr.reauthenticated telemetry event to specify if the user was able to authenticate without a password. r=MattN,spohl a=RyanVm
Jared Wein <jwein@mozilla.com> - Thu, 16 Apr 2020 21:33:24 +0000 - rev 585576
Push 13021 by dvarga@mozilla.com at Sun, 19 Apr 2020 21:14:11 +0000
Bug 1623745 - Add a value to the pwmgr.reauthenticated telemetry event to specify if the user was able to authenticate without a password. r=MattN,spohl a=RyanVm Differential Revision: https://phabricator.services.mozilla.com/D70136
d324df100e0c3fc565ea08920bf44d17fdc8977e: Bug 1627414 - getDisplayMedia does not work when firefox is full screen on macOS r=spohl a=RyanVM
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 14 Apr 2020 20:27:55 +0000 - rev 585557
Push 13014 by btara@mozilla.com at Fri, 17 Apr 2020 02:03:12 +0000
Bug 1627414 - getDisplayMedia does not work when firefox is full screen on macOS r=spohl a=RyanVM Change the GetScreenCapturePermissionState() heuristic to use the full window list instead of just on-screen windows to allow it it to work in full screen mode. Differential Revision: https://phabricator.services.mozilla.com/D70931
8ba5a8af8cbaf683e5a3fb5ce730d7faf7e3b918: Bug 1610613 - Make Picture-in-Picture window persist across workspaces on macOS. r=spohl a=RyanVM
Mike Conley <mconley@mozilla.com> - Tue, 07 Apr 2020 13:28:24 +0000 - rev 585510
Push 12995 by ccoroiu@mozilla.com at Tue, 14 Apr 2020 23:40:30 +0000
Bug 1610613 - Make Picture-in-Picture window persist across workspaces on macOS. r=spohl a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D69932
0c0f77ca0a7eccbbb91a45df7ee63d687fac88ee: Bug 1611482: Prevent the existance of dangling pointers upon failure of FindDataStart. r=spohl,valentin
Bas Schouten <bschouten@mozilla.com> - Thu, 02 Apr 2020 13:54:55 +0000 - rev 585244
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1611482: Prevent the existance of dangling pointers upon failure of FindDataStart. r=spohl,valentin Differential Revision: https://phabricator.services.mozilla.com/D60997
40fe811eab33812e9536ceaaeeedac0c8be18743: Bug 1624251 - Fix use-after-free in nsMacFinderProgress r=spohl
Christoph Walcher <christoph-wa@gmx.de> - Sat, 28 Mar 2020 01:46:29 +0000 - rev 584294
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1624251 - Fix use-after-free in nsMacFinderProgress r=spohl Differential Revision: https://phabricator.services.mozilla.com/D68667
fcba04973afc0462247576b9a097d972d7294e17: Bug 1624708 - Make non-native theme keyboard navigable. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 22:51:26 +0000 - rev 583548
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1624708 - Make non-native theme keyboard navigable. r=spohl By painting focus colors. I suspect this was mostly an oversight? But it is the most obvious issue I always find with this theme. I followed active > focus > hover, which seems to match what GTK does (and makes sense, generally). Differential Revision: https://phabricator.services.mozilla.com/D68088
e2f021fe0c3e0f3c0653d153ba1448627471edf7: Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 22:51:26 +0000 - rev 583547
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange Only button / menulist-button were missing from the hard-coded if condition. I don't think we ever want to override author padding, and this can cause compat issues as the one in this bug. I'm making HasAuthorSpecifiedRules fast in bug 1624080, btw. Differential Revision: https://phabricator.services.mozilla.com/D68085
0ee82dc106f20c4f207fa33f84e910566b29fa79: Bug 1624708 - Make non-native theme keyboard navigable. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 21:01:34 +0000 - rev 583524
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1624708 - Make non-native theme keyboard navigable. r=spohl By painting focus colors. I suspect this was mostly an oversight? But it is the most obvious issue I always find with this theme. I followed active > focus > hover, which seems to match what GTK does (and makes sense, generally). Differential Revision: https://phabricator.services.mozilla.com/D68088
f3c5f5a1b35dccaf7d301e1a19653e738f327964: Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Mar 2020 21:02:12 +0000 - rev 583523
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange Only button / menulist-button were missing from the hard-coded if condition. I don't think we ever want to override author padding, and this can cause compat issues as the one in this bug. I'm making HasAuthorSpecifiedRules fast in bug 1624080, btw. Differential Revision: https://phabricator.services.mozilla.com/D68085
0dbf5723afe27908bd2f899400fe7ad8eae078ff: Bug 1623695 - Change the asyncReauthenticateUser API to use wide strings to fix encoding issues with user-facing dialog strings. r=agashlin,spohl
Jared Wein <jwein@mozilla.com> - Fri, 20 Mar 2020 18:56:40 +0000 - rev 583136
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1623695 - Change the asyncReauthenticateUser API to use wide strings to fix encoding issues with user-facing dialog strings. r=agashlin,spohl Differential Revision: https://phabricator.services.mozilla.com/D67530
1f21bc6af7282ef11073f7e536e39a1c6fe12dc2: Bug 1602635 - [macOS] Remove security.sandbox.content.mac.earlyinit and the old sandbox startup code paths r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Tue, 17 Mar 2020 18:29:03 +0000 - rev 582464
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1602635 - [macOS] Remove security.sandbox.content.mac.earlyinit and the old sandbox startup code paths r=spohl Remove old content sandbox code paths that allowed the sandbox to be started later during content process startup when the SetProcessSandbox() message was received from the parent process. This older way of starting the sandbox was still in the tree to support WebReplay which is now being removed. With this fix, content processes always use the "earlyinit" sandbox startup like the RDD and GMP processes. Differential Revision: https://phabricator.services.mozilla.com/D64968
b9bf352a94d2d41df26dae4a672daadb5185fdce: Bug 1614983 - Create a new sandbox profile for the socket process r=spohl
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 11 Mar 2020 22:20:13 +0000 - rev 581514
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1614983 - Create a new sandbox profile for the socket process r=spohl Add, but don't enable, a sandbox policy to be used with the socket process. A follow-up fix (bug 1611288) will change the socket process code to use the sandbox. The macOS socket sandbox is similar to the utility sandbox (only used for the RDD process), with additions to allow networking I/O, access to files for DNS resolution, access to certificate stores, and notifications about network configuration changes. Differential Revision: https://phabricator.services.mozilla.com/D64682
35ef92e229230816dff9ba8f826b4b5c6f59a98b: Bug 1615100 - Paint the range thumb using button colors. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 06 Mar 2020 17:54:04 +0000 - rev 580398
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1615100 - Paint the range thumb using button colors. r=spohl This is very basic, and just uses the button colors. Did this because I thought that it was going to help me fix one test but it didn't in the end, feel free to reject, or to tell me to land the cleanup somewhere else :) Depends on D65674 Differential Revision: https://phabricator.services.mozilla.com/D65675
80e3811f81c81b4b9b125685ac82c80b65ec9334: Bug 1620307 - Rename -moz-menulist-button to -moz-menulist-arrow-button. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 05 Mar 2020 21:13:46 +0000 - rev 580093
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1620307 - Rename -moz-menulist-button to -moz-menulist-arrow-button. r=spohl This should be less confusing. This is not supported outside of chrome:// or user-agent stylesheets so we can name this however we want. Differential Revision: https://phabricator.services.mozilla.com/D65605
5a465a76e60f85ebd4361a169b3f65fba3c54767: Bug 1620246 - Fix snapping to avoid also changing coordinate spaces. r=spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 05 Mar 2020 14:43:14 +0000 - rev 580012
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1620246 - Fix snapping to avoid also changing coordinate spaces. r=spohl Bug 1615026 introduced some coordinate space change which I didn't intend. NSRectToSnappedRect does what we want instead. Differential Revision: https://phabricator.services.mozilla.com/D65519
c1e88fa43e7ec5da8e44015fb9cbbcf105178f94: Bug 1619664 - Decide which theme to use per document, not per-process. r=mstange,spohl
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 03 Mar 2020 19:46:41 +0000 - rev 579713
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1619664 - Decide which theme to use per document, not per-process. r=mstange,spohl This allows testing much more easily. There are some edge cases with native theme changes and such (ThemeChanged and co assume there's only one theme per process). But I don't think they matter much for our use cases. Differential Revision: https://phabricator.services.mozilla.com/D65162