searching for reviewer(sotaro)
553ca5e06047: Bug 1465784 - Remove unnecessary render step with async-scene-building. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 06 Jun 2018 16:45:06 -0400 - rev 475865
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1465784 - Remove unnecessary render step with async-scene-building. r=sotaro MozReview-Commit-ID: 8iOQHLhlcjA
bcebfd54b4e1: Bug 1455597 - Flush the transaction to remove the pipeline before shutting down the WebRenderAPI. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Sat, 02 Jun 2018 12:15:15 -0400 - rev 475331
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1455597 - Flush the transaction to remove the pipeline before shutting down the WebRenderAPI. r=sotaro MozReview-Commit-ID: GuQJjMzzQUE
4d7efa2ca9e2: Bug 1452375 - sse3-scaler: make sure iter->x/y is representable. r=sotaro
jmuizelaar@mozilla.com - Tue, 29 May 2018 14:27:09 +0900 - rev 474414
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1452375 - sse3-scaler: make sure iter->x/y is representable. r=sotaro
b0fcf6190c8c: Bug 1452375 - ssse3-scaler: handle init failure r=sotaro
jmuizelaar@mozilla.com - Tue, 29 May 2018 14:26:38 +0900 - rev 474413
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1452375 - ssse3-scaler: handle init failure r=sotaro
d6ea05eb01ac: Bug 1417784 - Properly implement SyncWithCompositor for WebRender. r=froydnj,sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 May 2018 11:29:52 -0400 - rev 474385
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1417784 - Properly implement SyncWithCompositor for WebRender. r=froydnj,sotaro This defines three flushing functions that flush different parts of the WR pipeline. Using all three guarantees that everything sent to WR will have been flushed. This is what we need to do in SyncWithCompositor to ensure that it meets the API contract. In addition, this patch updates the existing FlushRendering function to use the new functions (no functional changes intended here). MozReview-Commit-ID: GzxwpF4JT04
6a1252b68f4f: Bug 1417784 - Shift how the AsyncImagePipelineManager is notified of updates. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 May 2018 11:29:41 -0400 - rev 474384
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1417784 - Shift how the AsyncImagePipelineManager is notified of updates. r=sotaro Instead of notifying the AsyncImagePipelineManager on the compositor thread via the CompositorBridgeParent, we can send it the new pipeline info directly from the RenderThread after the update happens. This effectively splits the AsyncImagePipelineManager update-processing into two parts: one that takes in the new pipeline info and one that process it. This allows us to invoke the processing step from other code running on the compositor thread, which we will need to do in the next patch. MozReview-Commit-ID: 7xhm8I7bY4C
d6fd83af52c3: Bug 1417784 - Use a CompositorBridgeParent* instead of a base class pointer. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 May 2018 11:29:41 -0400 - rev 474383
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1417784 - Use a CompositorBridgeParent* instead of a base class pointer. r=sotaro We do a silent upcast from CompositorBridgeParent* to the base class and pass it around as a CompositorBridgeParentBase* for no reason. Avoiding this simplifies the code slightly and avoids virtual function overhead. We do need to move a couple of functions in CompositorBridgeParent from protected scope to public scope. MozReview-Commit-ID: 9Zq3GwxEXpr
8d9da33b8e4f: Bug 1462903 - Always send a display list for a new async image pipeline so WR doesn't complain. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 24 May 2018 09:59:28 -0400 - rev 474048
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1462903 - Always send a display list for a new async image pipeline so WR doesn't complain. r=sotaro MozReview-Commit-ID: IXM8EhkcdjE
75146e6b8a3b: Bug 1454042 - Allow missing pipeline information for cross-process iframes. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 18 May 2018 10:31:18 -0400 - rev 473195
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1454042 - Allow missing pipeline information for cross-process iframes. r=sotaro We should always have the pipeline information for in-process things like async images, but for cross-process iframes we might not have the information right away if the content process doesn't get around to sending it for a while. MozReview-Commit-ID: 18F5nqilXoV
1232f9a7403c: Bug 1461122 - Clean up the composition flow for empty transactions. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 15 May 2018 08:49:34 -0400 - rev 472546
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1461122 - Clean up the composition flow for empty transactions. r=sotaro This is mostly just refactoring to make the code more understandable. However, there are a couple of functional changes: - If we have scroll offset updates we now schedule a composite instead of sending the DidComposite right away. This is needed because we want to actually composite the scroll offset change. - If there are WebRenderParentCommands provided, we process them and update the epoch in a single transaction, instead of splitting it across two transactions for no good reason. MozReview-Commit-ID: 2HCa19EGxUD
0b04c87960ad: Bug 1461122 - Implement DidComposite(LayersId,...) for CompositorBridgeParent. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 15 May 2018 08:49:29 -0400 - rev 472545
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1461122 - Implement DidComposite(LayersId,...) for CompositorBridgeParent. r=sotaro MozReview-Commit-ID: 5glDqCdvkQG
9f87280ba566: Bug 1461122 - Clean up the composition flow for empty transactions. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 14 May 2018 13:19:13 -0400 - rev 472539
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1461122 - Clean up the composition flow for empty transactions. r=sotaro This is mostly just refactoring to make the code more understandable. However, there are a couple of functional changes: - If we have scroll offset updates we now schedule a composite instead of sending the DidComposite right away. This is needed because we want to actually composite the scroll offset change. - If there are WebRenderParentCommands provided, we process them and update the epoch in a single transaction, instead of splitting it across two transactions for no good reason. MozReview-Commit-ID: 2HCa19EGxUD
0efbd05857c2: Bug 1461122 - Implement DidComposite(LayersId,...) for CompositorBridgeParent. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 14 May 2018 13:19:13 -0400 - rev 472538
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1461122 - Implement DidComposite(LayersId,...) for CompositorBridgeParent. r=sotaro MozReview-Commit-ID: 5glDqCdvkQG
dcdf1e54dc05: Bug 1460988 - Don't hold the layer trees lock while making calls that block on WR threads. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 11 May 2018 16:36:22 -0400 - rev 472158
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1460988 - Don't hold the layer trees lock while making calls that block on WR threads. r=sotaro MozReview-Commit-ID: BKNf5wpG1br
4e38ca9aaa48: Bug 1460495 - When sending a transaction, ensure the new transaction that takes its place has the same async-scene-build flag set. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 10 May 2018 13:05:22 -0400 - rev 472048
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1460495 - When sending a transaction, ensure the new transaction that takes its place has the same async-scene-build flag set. r=sotaro MozReview-Commit-ID: HYwUwqE2P2O
1feb2371c435: Bug 1346291: update code that accidentally assumed libyuv would define things like int32 r=sotaro,jib
Randell Jesup <rjesup@jesup.org> - Wed, 09 May 2018 23:59:16 -0400 - rev 471916
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1346291: update code that accidentally assumed libyuv would define things like int32 r=sotaro,jib
7f2b06896dfd: Bug 1346291: Update libyuv to upstream 98a0a157dcf5dee0882b2dfcc9578ab1f44afb12 rs=jib,sotaro
Randell Jesup <rjesup@jesup.org> - Wed, 09 May 2018 23:59:16 -0400 - rev 471915
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1346291: Update libyuv to upstream 98a0a157dcf5dee0882b2dfcc9578ab1f44afb12 rs=jib,sotaro
fc2188a4b2d9: Bug 1460289 - Reduce scope of indirect layer tree lock in RecvAdoptChild. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 09 May 2018 15:23:30 -0400 - rev 471852
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1460289 - Reduce scope of indirect layer tree lock in RecvAdoptChild. r=sotaro In particular, this change makes it so that we are not holding the lock when we clone the WebRenderAPI, because that can result in a deadlock. MozReview-Commit-ID: 33OGZdFMjEA
7b3c982608df: Bug 1459714 - Use a single transaction for all things associated with a new display list. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 08 May 2018 08:49:44 -0400 - rev 471485
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1459714 - Use a single transaction for all things associated with a new display list. r=sotaro This ensures the commands to delete compositables are received by WR in the same transaction as the updates to the display list that removes the references to those compositables. Otherwise, WR can try to do a scene build on the intermediate state which results in missing pipeline errors. MozReview-Commit-ID: ByOHCFWSSjt
af3758713a44: Bug 1459714 - Make WebRenderBridgeParent::ProcessWebRenderParentCommands callers provide the transaction. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 08 May 2018 08:49:44 -0400 - rev 471484
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1459714 - Make WebRenderBridgeParent::ProcessWebRenderParentCommands callers provide the transaction. r=sotaro MozReview-Commit-ID: FIrA11wgjLI
25652d08b28e: Bug 1459686 - Include async image updates in the displaylist transaction. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 08 May 2018 08:47:02 -0400 - rev 471482
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1459686 - Include async image updates in the displaylist transaction. r=sotaro MozReview-Commit-ID: BUxzRBSWVaU
b27eadf1b8de: Bug 1459686 - Refactor to have the ApplyAsyncImages callsite provide the transaction. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 08 May 2018 08:47:02 -0400 - rev 471481
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1459686 - Refactor to have the ApplyAsyncImages callsite provide the transaction. r=sotaro MozReview-Commit-ID: GVKRcb4r73a
4869243efd9c: Bug 1459686 - Remove WebRenderCommandBuilder::mParentCommands which is always empty. r=sotaro
ffxbld <release@mozilla.com> - Tue, 08 May 2018 08:47:02 -0400 - rev 471480
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1459686 - Remove WebRenderCommandBuilder::mParentCommands which is always empty. r=sotaro MozReview-Commit-ID: FiRw0UlQKwr
56b432712357: Bug 1452375 - sse3-scaler: make sure iter->x/y is representable. r=sotaro, a=RyanVM
jmuizelaar@mozilla.com - Tue, 29 May 2018 14:27:09 +0900 - rev 471106
Push 9300 by ryanvm@gmail.com at 2018-05-31 20:50 +0000
Bug 1452375 - sse3-scaler: make sure iter->x/y is representable. r=sotaro, a=RyanVM
295b7c0fbe99: Bug 1452375 - ssse3-scaler: handle init failure. r=sotaro, a=RyanVM
jmuizelaar@mozilla.com - Tue, 29 May 2018 14:26:38 +0900 - rev 471105
Push 9300 by ryanvm@gmail.com at 2018-05-31 20:50 +0000
Bug 1452375 - ssse3-scaler: handle init failure. r=sotaro, a=RyanVM
704dd8298b15: Bug 1456978 - Ensure that all generate_frame transactions end up clearing the pending frame count. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 27 Apr 2018 07:41:03 -0400 - rev 469612
Push 9174 by archaeopteryx@coole-files.de at 2018-04-30 15:33 +0000
Bug 1456978 - Ensure that all generate_frame transactions end up clearing the pending frame count. r=sotaro This prevents us from getting stuck in the frame throttling code where TooManyPendingFrames always returns true. MozReview-Commit-ID: 92tybPOaOTP
d5e9d984dcc6: Bug 1456978 - Remove redundant construction of WindowId. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 27 Apr 2018 07:41:03 -0400 - rev 469611
Push 9174 by archaeopteryx@coole-files.de at 2018-04-30 15:33 +0000
Bug 1456978 - Remove redundant construction of WindowId. r=sotaro MozReview-Commit-ID: 2XiVcQJotRv
ca63e4de5479: Bug 1456978 - Rename function to a more appropriate name. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 27 Apr 2018 07:41:03 -0400 - rev 469610
Push 9174 by archaeopteryx@coole-files.de at 2018-04-30 15:33 +0000
Bug 1456978 - Rename function to a more appropriate name. r=sotaro MozReview-Commit-ID: 2mVFcPsK6oe
d52b265b6b52: Bug 1457246 - Don't hold the sIndirectLayerTreesLock while making synchronous calls to the RenderBackend thread. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 26 Apr 2018 15:29:21 -0400 - rev 469486
Push 9171 by ryanvm@gmail.com at 2018-04-28 10:35 +0000
Bug 1457246 - Don't hold the sIndirectLayerTreesLock while making synchronous calls to the RenderBackend thread. r=sotaro MozReview-Commit-ID: KzXZxCb2nA6
74de53b433e0: Bug 1455974 - Clear the client-side shared frame metrics data on shutdown with WR as well. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 23 Apr 2018 14:24:36 -0400 - rev 468956
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1455974 - Clear the client-side shared frame metrics data on shutdown with WR as well. r=sotaro There's some cleanup happening in CompositorBridgeChild to release the shared frame metrics when the client side is destroyed. However the code is specific to PLayerTransaction, and is missing for the WR codepath. This patch extracts the code to a helper and ensures that it runs for the WR equivalent codepath. MozReview-Commit-ID: ENJ349u0PTc
c9ee020a4abd: Bug 1455974 - Ensure that mCanSend is cleared at the right time. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 23 Apr 2018 14:24:36 -0400 - rev 468954
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1455974 - Ensure that mCanSend is cleared at the right time. r=sotaro mCanSend was being cleared in ActorDestroy which is fine, but we actually cannot reliably send IPC messages from CompositorBridgeParent after we get a RecvWillClose message, because that's the last thing that the child side sends before it gets destroyed. After the WillClose message there's no guarantee that the child side actor will still be alive. So this patch also sets mCanSend to false in RecvWillClose. mCanSend is only used in two places, both of which have to do with the APZ metrics-sharing code, so this shouldn't have any unexpected side-effects. It is needed for the next patch. MozReview-Commit-ID: 8CuFienWVUU
d1479b21a284: Bug 1453801 - Part 3. Fix race condition shutting down the render thread and shared surfaces. r=sotaro
Andrew Osmond <aosmond@mozilla.com> - Mon, 23 Apr 2018 07:57:17 -0400 - rev 468634
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1453801 - Part 3. Fix race condition shutting down the render thread and shared surfaces. r=sotaro
c9f4fd7170ad: Bug 1453801 - Part 2. Ensure shared surfaces are properly released from render texture cache. r=sotaro
Andrew Osmond <aosmond@mozilla.com> - Mon, 23 Apr 2018 07:57:15 -0400 - rev 468633
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1453801 - Part 2. Ensure shared surfaces are properly released from render texture cache. r=sotaro
f3eeeae62a5a: Bug 1453801 - Part 1. Ensure WebRenderUserData objects are freed after a tab switch. r=sotaro
Andrew Osmond <aosmond@mozilla.com> - Mon, 23 Apr 2018 07:57:13 -0400 - rev 468632
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1453801 - Part 1. Ensure WebRenderUserData objects are freed after a tab switch. r=sotaro
86448c712128: Bug 1454974 - Assert if RecvGetSnapshot ever gets called in a non-root WRBP. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 18 Apr 2018 16:44:03 -0400 - rev 467939
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1454974 - Assert if RecvGetSnapshot ever gets called in a non-root WRBP. r=sotaro MozReview-Commit-ID: L6bUdfEykx7
67fabb2e4990: Bug 1449641 - Always use mDrawTarget when merging the buffered region into the window DrawTarget. r=sotaro
Markus Stange <mstange@themasta.com> - Wed, 28 Mar 2018 13:23:35 -0400 - rev 466017
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1449641 - Always use mDrawTarget when merging the buffered region into the window DrawTarget. r=sotaro If we have a non-null mTarget, we already set mDrawTarget to mTarget. So "mTarget ? mTarget : mDrawTarget" will always evaluate to mDrawTarget. MozReview-Commit-ID: BlGYEdlL50Q
ac980a443965: Bug 1449641 - Remove extraneous "if (mRenderTarget->mDrawTarget != mDrawTarget)". r=sotaro
Markus Stange <mstange@themasta.com> - Wed, 28 Mar 2018 13:13:03 -0400 - rev 466016
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1449641 - Remove extraneous "if (mRenderTarget->mDrawTarget != mDrawTarget)". r=sotaro The same condition is checked just before this if, so it's always true. MozReview-Commit-ID: 9Vscnkz7AoY
cfc4cc67701f: Bug 1449641 - Use the correct parameter when computing the clear rect. r=sotaro
Markus Stange <mstange@themasta.com> - Wed, 28 Mar 2018 13:11:44 -0400 - rev 466015
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1449641 - Use the correct parameter when computing the clear rect. r=sotaro This was incorrectly using the invalid rect, so it was clearing more than necessary and not taking advantage of the opaque region that the caller computes. The idea is that we don't need to clear parts of the invalid region that will be covered by something opaque. MozReview-Commit-ID: LhEkVUMnjC9
d7db6788fe91: Bug 1426199 - Re-enable more crashtests that are now passing. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 09 Apr 2018 08:02:12 -0400 - rev 465913
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1426199 - Re-enable more crashtests that are now passing. r=sotaro
d3f3380c8b1c: Bug 1449242 - Don't delay image key deletions by an extra transaction. r=sotaro
Nicolas Silva <nsilva@mozilla.com> - Wed, 28 Mar 2018 15:33:21 +0200 - rev 464009
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1449242 - Don't delay image key deletions by an extra transaction. r=sotaro
c2bd475a4221: Bug 1440993 - Null-check the GLContext's screen when reading back canvas data. r=sotaro.
Nicolas Silva <nsilva@mozilla.com> - Wed, 14 Mar 2018 13:30:42 +0100 - rev 461691
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1440993 - Null-check the GLContext's screen when reading back canvas data. r=sotaro.
b6d3473bfb80: Bug 1440993 - Null-check the GLContext's screen when reading back canvas data. r=sotaro a=jcristau
Nicolas Silva <nsilva@mozilla.com> - Mon, 19 Mar 2018 19:49:18 +0200 - rev 460197
Push 8874 by archaeopteryx@coole-files.de at 2018-03-19 17:56 +0000
Bug 1440993 - Null-check the GLContext's screen when reading back canvas data. r=sotaro a=jcristau
16fab079284b: Bug 1437949 - Follow-up to make the GL context current before poking the WR renderer. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 15 Feb 2018 04:24:13 -0500 - rev 456428
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1437949 - Follow-up to make the GL context current before poking the WR renderer. r=sotaro MozReview-Commit-ID: DIpnRZcGb3Q
c0a2f744ef5c: Bug 1434996 - Update WebRenderLayerManager::SetTransactionIdAllocator to match ClientLayerManager. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 09 Feb 2018 13:41:18 -0500 - rev 455688
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1434996 - Update WebRenderLayerManager::SetTransactionIdAllocator to match ClientLayerManager. r=sotaro Changing the transaction id allocator is now handled better in ClientLayerManager than before in that it resets the transaction id on the new allocator to match the old allocator and avoid discontinuities in the transaction ids. We should apply this behaviour to WebRenderLayerManager as well, because WebRenderLayerManager was assuming that any time the allocator changed it would automatically start the transaction id at 1, which is not the case. In particular, when navigating to something in the bfcache, we can reuse a pre-existing refresh driver which might have a transaction id already greater than 1. MozReview-Commit-ID: 8IUn1Dhnh7c
64480155967f: Bug 1436832 - Avoid unnecessary casting. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 08 Feb 2018 17:11:45 -0500 - rev 455525
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1436832 - Avoid unnecessary casting. r=sotaro MozReview-Commit-ID: 2MoJv1Wg8g4
6e56d37b2096: Bug 1436832 - Remove unnecessary loop. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 08 Feb 2018 17:11:42 -0500 - rev 455524
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1436832 - Remove unnecessary loop. r=sotaro MozReview-Commit-ID: ehYAwXLecX
9a1800172967: Bug 1435282 - Make SetTestSampleTime force a sync flush. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 02 Feb 2018 10:48:25 -0500 - rev 454858
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1435282 - Make SetTestSampleTime force a sync flush. r=sotaro SetTestSampleTime is called from tests via the advanceTimeAndRefresh API on DOMWindowUtils, and the expectation is that after it is done, the time has been advanced and a composite has happened. So we need to ensure that is the case with WebRender as well. This fixes the issue I was seeing with test_group_hittest.html and makes it pass. MozReview-Commit-ID: 86l9mTTwD2v
cf517d879754: Bug 1435282 - Don't force the render transaction to happen immediately if we're doing an async flush. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 02 Feb 2018 10:48:25 -0500 - rev 454857
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1435282 - Don't force the render transaction to happen immediately if we're doing an async flush. r=sotaro This splits the FlushRendering function into sync and async versions just for a bit more clarity. In the async version we don't want to set the mForceRendering flag at all because we don't need to force a rendering - if there is one already pending then that's good enough. And anyway in practice the async version seems to only ever be invoked by CompositorBridgeParent::SetTestSampleTime which I'll be changing in the next patch. MozReview-Commit-ID: 4cdU0U5B1pp
ed13e2aac8f6: Bug 1435282 - Add a helper FlushPendingComposite function. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 02 Feb 2018 10:48:25 -0500 - rev 454856
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1435282 - Add a helper FlushPendingComposite function. r=sotaro This extracts a code pattern that appears a couple of times in the code. It occurs in CompositorBridgeParent as well but there's some extra stuff involved there with the mOverrideComposeReadiness flag that I don't understand so I'm leaving that as-is for now. MozReview-Commit-ID: 2xqgaQZT4e1
30b7617cb903: Bug 1435282 - Document that function arguments are always null. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 02 Feb 2018 10:48:25 -0500 - rev 454855
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1435282 - Document that function arguments are always null. r=sotaro MozReview-Commit-ID: HOu4fshHSuX