searching for reviewer(snorp)
5442e71d1612be47a8f5460e9601a5b8656c7659: Bug 1651257 - iFLYTEC IME often commits composition string unfortunately. r=geckoview-reviewers,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 21 Jul 2020 13:50:46 +0000 - rev 606538
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651257 - iFLYTEC IME often commits composition string unfortunately. r=geckoview-reviewers,snorp This is timing issue when using iFLYTEC keyboard in Xiaomi App Store. Although replace text transaction often dispatch dummy text change, it may be unnecessary when other text change is already in text change queue. This issue occurs if dummy text change is dispatched in the queue and other text change is also dispatched in the queue. `AddIMETextChange` merges old text change with newer text change when its range is overlapped, but it doesn't consider range is same. So if same range, we should adjust old end simply. GV-junit test case emulates this situation, but since this is timing issue, we won't reproduce this by this test case. But it is useful to check future regressions. Differential Revision: https://phabricator.services.mozilla.com/D84140
695cbcabf7fe8ce0bdb218baccd3758e416b2907: Bug 1358633 - Enable window.find on GeckoView. r=geckoview-reviewers,snorp
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 24 Jul 2020 14:23:14 +0000 - rev 606424
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1358633 - Enable window.find on GeckoView. r=geckoview-reviewers,snorp I just tested it on Fenix nightly and it works great. It better do actually, as most of the code is shared with find-in-page. See bug 750051 for when this was blocked. I don't think that was properly understood at the time, but at this point the divergence from desktop seems gratuitous. This has caused compat issues in the past. Differential Revision: https://phabricator.services.mozilla.com/D84758
be4b0f6e68c9d46ecb15aac5ad87a3a7b8731e57: Bug 1653011 - Simplify and make WeakPtr<Derived> usable and compact. r=froydnj,sg,geckoview-reviewers,jgilbert,kvark,snorp
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 23 Jul 2020 14:51:46 +0000 - rev 606150
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1653011 - Simplify and make WeakPtr<Derived> usable and compact. r=froydnj,sg,geckoview-reviewers,jgilbert,kvark,snorp Having two classes in the inheritance chain inherit from SupportsWeakPtr now won't compile, but you can use WeakPtr<Derived> when any base class inherits from SupportsWeakPtr. Differential Revision: https://phabricator.services.mozilla.com/D83674
2a646a7936e7ffbe168a3a354e3bf31b536ff815: Bug 1651165 - Rename idle service r=Gijs,geckoview-reviewers,snorp
Doug Thayer <dothayer@mozilla.com> - Mon, 20 Jul 2020 16:06:59 +0000 - rev 605765
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651165 - Rename idle service r=Gijs,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D83413
c27434336da3aa3813599fe9bca4925d00f95fa5: Bug 1652870 - use new dump_syms for Android builds; r=geckoview-reviewers,snorp
Nathan Froyd <froydnj@mozilla.com> - Mon, 20 Jul 2020 19:02:30 +0000 - rev 605707
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1652870 - use new dump_syms for Android builds; r=geckoview-reviewers,snorp Faster and more maintainable is good. Differential Revision: https://phabricator.services.mozilla.com/D83561
1d4650fa1b78efefa8acd5e4f397ae7a2944e87e: Bug 1651838 - Don't provide NS_GRE_* paths on Android. r=snorp
Agi Sferro <agi@sferro.dev> - Fri, 17 Jul 2020 16:58:34 +0000 - rev 605324
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651838 - Don't provide NS_GRE_* paths on Android. r=snorp Callers looking for NS_GRE_BIN_DIR and NS_GRE_PATH expect the returned folder to contain native libraries and executables. The corresponding folder for this on Android is inside the APK and at the moment there is no way to return a nsIFile to a zipped folder. Callers already account for Android, either by failing gracefully or by having Android specific code. In this patch we flat out refuse to return these paths to avoid confusion. Differential Revision: https://phabricator.services.mozilla.com/D83670
e831393fd9202d280134f379910267ca2cd4fc03: Bug 1651838 - Use APK file for xreDirectory. r=glandium,snorp
Agi Sferro <agi@sferro.dev> - Fri, 17 Jul 2020 16:58:31 +0000 - rev 605323
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651838 - Use APK file for xreDirectory. r=glandium,snorp xreDirectory is used to determine when the omnijar location changes and for some crash reporter logic that is not used on Android. On Android, this location currently points to the App data folder, something like /data/user/0/org.mozilla.<App identifier> where <App identifier> is the unique App identifier, e.g. org.mozilla.firefox for Firefox for Android. while the omnijar is located inside the APK (which is just a zip file) in a location that looks like this /data/app/org.mozilla.geckoview_example-<base64 string>/base.apk where <base64 string> is a base64-encoded string that's unique to the current APK (it might be a hash of the APK but I'm not sure). This value changes every time the app is updated. Code that uses the StartupCache assumes that whenever the location of the omnijar (and its contents) change, the cache will be invalidated. The assumption is usually true for code that resides inside the omnijar as part of Gecko, as anytime the contents of the omnijar change, the Gecko version changes too, invalidating the cache. There is an exception however, extension built-in scripts are stored in the same path as the omnijar (inside the apk) but can change without a Gecko update. This causes the StartupCache to have invalid data that points to the old apk path. To resolve this proble, we store the apk path as xreDirectory, and the data path as directory, so that if either change, the StartupCache will be invalidated. The new compatibility.ini will look like this: [Compatibility] LastVersion=80.0a1_20200707110539/20200707110539 LastOSABI=Android_x86_64-gcc3 LastPlatformDir=/data/app/org.mozilla.geckoview_example-QyhEDWT7jIwY3rqYDJmCSA==/base.apk LastAppDir=/data/user/0/org.mozilla.geckoview_example where today LastAppDir and LastPlatformDir are both equal to the data path /data/user/0/org.mozilla.geckoview_example Differential Revision: https://phabricator.services.mozilla.com/D83196
558fe8966d863843ca9cc5e4a3d22fbc067bc627: Bug 1651838 - Remove unused --appomni on Android. r=glandium,snorp
Agi Sferro <agi@sferro.dev> - Fri, 17 Jul 2020 16:58:29 +0000 - rev 605322
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651838 - Remove unused --appomni on Android. r=glandium,snorp Differential Revision: https://phabricator.services.mozilla.com/D83195
a24fa4189a91d68028a42af9741c99b2fc69b0fa: Bug 1350875 part 1 - Have android notify fullscreen will change. r=snorp,geckoview-reviewers,agi
Xidorn Quan <me@upsuper.org> - Wed, 15 Jul 2020 14:23:14 +0000 - rev 605034
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1350875 part 1 - Have android notify fullscreen will change. r=snorp,geckoview-reviewers,agi Differential Revision: https://phabricator.services.mozilla.com/D68678
36743e9318e959b5bd8ad46718e4e511892490c5: Bug 1649803 - Added an API stub for the Menus API r=agi,geckoview-reviewers,snorp
Grace Bramley-Simmons <gbramleysimmons@mozilla.com> - Wed, 15 Jul 2020 16:37:28 +0000 - rev 604968
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1649803 - Added an API stub for the Menus API r=agi,geckoview-reviewers,snorp Added private/protected, unimplemented versions of the necessary Java classes for the menus API, set up event dispatching and listening. Differential Revision: https://phabricator.services.mozilla.com/D82383
c279e71779dc38c7cecc4bbf8d434302f02b2a26: Bug 1652870 - use new dump_syms for Android builds; r=geckoview-reviewers,snorp
Nathan Froyd <froydnj@mozilla.com> - Wed, 15 Jul 2020 12:59:00 +0000 - rev 604905
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1652870 - use new dump_syms for Android builds; r=geckoview-reviewers,snorp Faster and more maintainable is good. Differential Revision: https://phabricator.services.mozilla.com/D83561
48a10a9249b0ec8a3f1d7a630063af4ef17d2f54: Bug 1652870 - use new dump_syms for Android builds; r=geckoview-reviewers,snorp
Nathan Froyd <froydnj@mozilla.com> - Tue, 14 Jul 2020 21:33:12 +0000 - rev 604896
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1652870 - use new dump_syms for Android builds; r=geckoview-reviewers,snorp Faster and more maintainable is good. Depends on D83560 Differential Revision: https://phabricator.services.mozilla.com/D83561
e34785ffe0ed472731d2c3235f2578f513664ae4: Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
Frederik Braun <fbraun@mozilla.com> - Wed, 15 Jul 2020 11:20:45 +0000 - rev 604889
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp Differential Revision: https://phabricator.services.mozilla.com/D83490
d0ff30e1d8301a84ef672115a0e8694a6c0fba16: Bug 1650692 - ImageDecoder improvements, r=agi,geckoview-reviewers,snorp
Tiger Oakes <contact@tigeroakes.com> - Wed, 15 Jul 2020 03:14:54 +0000 - rev 604856
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1650692 - ImageDecoder improvements, r=agi,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D82308
1e893a16cad367334736a622478d131a2b501efa: Bug 725231 - Stop reporting library mappings to the crash reporter. r=snorp
Mike Hommey <mh+mozilla@glandium.org> - Mon, 06 Jul 2020 14:38:29 +0000 - rev 603350
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 725231 - Stop reporting library mappings to the crash reporter. r=snorp This is a rebase of a 7-year-old patch that was r=taras. Back then it was waiting for breakpad changes that never were reviewed. However, since then, bug 1486524 made the linker always map uncompressed files directly, making it less necessary to report the library mappings to the crash reporter, and bug 1291377 disabled the linker altogether on Android 6.0+, which makes report_mapping unused at all in that case. Differential Revision: https://phabricator.services.mozilla.com/D81025
b12036a85308bad86fb8549ab23519aa6713dbb6: Bug 1602072 - Add a gfxInfo flag determine Firefox is embedded by FxR for telemetry. r=thomasmo,chutten,froydnj,jrmuizel,geckoview-reviewers,rbarker,snorp
Daosheng Mu <daoshengmu@gmail.com> - Thu, 25 Jun 2020 17:22:20 +0000 - rev 601565
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1602072 - Add a gfxInfo flag determine Firefox is embedded by FxR for telemetry. r=thomasmo,chutten,froydnj,jrmuizel,geckoview-reviewers,rbarker,snorp Differential Revision: https://phabricator.services.mozilla.com/D56233
cac6157a808b9329e36dc24769259f5e5e9034a1: Bug 1624993 - Expose a GeckoView API for Gecko Profiler markers r=geckoview-reviewers,agi,snorp
Nazım Can Altınova <canaltinova@gmail.com> - Thu, 25 Jun 2020 14:30:48 +0000 - rev 601508
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1624993 - Expose a GeckoView API for Gecko Profiler markers r=geckoview-reviewers,agi,snorp Differential Revision: https://phabricator.services.mozilla.com/D79125
b95162bf0644d8eb9a9ff1f4af761b8ff0427e5f: Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 22 Jun 2020 09:00:40 +0000 - rev 600824
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp `charsetMenu.properies` was for "Text Encoding" menu in Fennec (bug 611580). EN was off as default, but some language such JA turned on this menu. Since Fennec is gone, it is unnecessary now, so let's remove this resource. Differential Revision: https://phabricator.services.mozilla.com/D79634
0238d868b580e773cd6ac568bc71407a0dc8b81a: Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 22 Jun 2020 09:00:40 +0000 - rev 600808
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1645725 - Remove chatsetMenu.properties l10n resource from GeckoView. r=geckoview-reviewers,Pike,snorp `charsetMenu.properies` was for "Text Encoding" menu in Fennec (bug 611580). EN was off as default, but some language such JA turned on this menu. Since Fennec is gone, it is unnecessary now, so let's remove this resource. Differential Revision: https://phabricator.services.mozilla.com/D79634
c165c77e4d2444da99cb93c33804c27cd9652098: Bug 1643464 - Part 3: Rename LEFT/RIGHT_BUTTON as PRIMARY/SECONDARY_BUTTON r=masayuki,geckoview-reviewers,snorp
Kagami Sascha Rosylight <saschanaz@outlook.com> - Fri, 19 Jun 2020 17:50:43 +0000 - rev 600775
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643464 - Part 3: Rename LEFT/RIGHT_BUTTON as PRIMARY/SECONDARY_BUTTON r=masayuki,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D80333
ba4656e730c420d7621460e40a9a052669961599: Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Kris Maglione <maglione.k@gmail.com> - Wed, 17 Jun 2020 17:17:16 +0000 - rev 600231
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp Differential Revision: https://phabricator.services.mozilla.com/D75429
9a3a87c7c7bf250be4db8d5875e241e8f7dc9e80: Bug 1644021 - StreamingTelemetryDelegates need threadsafe ref counting r=snorp
Chris H-C <chutten@mozilla.com> - Mon, 15 Jun 2020 15:55:06 +0000 - rev 599797
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644021 - StreamingTelemetryDelegates need threadsafe ref counting r=snorp Differential Revision: https://phabricator.services.mozilla.com/D79708
561694a246a0e12f9c261fca58ce26b8767e6e3b: Bug 1645770 - Fix dark mode settings on GeckoView's content processes. r=geckoview-reviewers,snorp
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Jun 2020 15:55:23 +0000 - rev 599786
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1645770 - Fix dark mode settings on GeckoView's content processes. r=geckoview-reviewers,snorp GeckoRuntime is not around in content processes so we need to remote it like we remote the prefers-reduced-motion values. Differential Revision: https://phabricator.services.mozilla.com/D79670
bd1e6309d1fc862044781ef8ba1035d2509df2ae: Bug 1627523 - Disable test_selectevents.html on android for intermittent failures; r=snorp
Geoff Brown <gbrown@mozilla.com> - Wed, 10 Jun 2020 19:44:56 +0000 - rev 599041
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1627523 - Disable test_selectevents.html on android for intermittent failures; r=snorp In addition to the failures tracked by this bug and its dups for many months, there are likely many other Android test_selectevents.html failures going unnoticed or reported to random bugs because the failure message generated here is not picked up by treeherder bug suggestions (separate issue tracked by bug 1407293). Note that this test has traditionally been skipped on Android; I enabled it in bug 1585119, thinking that it was running reliably. Differential Revision: https://phabricator.services.mozilla.com/D79139
9ba8b78124a9a6d3f399b53a19e8749ab7a26905: Bug 1643129 - Skip countLogins calls in _doAsyncPrompt if the MP isn't currently showing. r=geckoview-reviewers,snorp
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 10 Jun 2020 19:42:37 +0000 - rev 599034
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643129 - Skip countLogins calls in _doAsyncPrompt if the MP isn't currently showing. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D78141
02e2cc3bd51141003734ce1146612bf17948bafc: Bug 1644297 - Re enable old browser.storage.sync on Android. r=rpl,snorp
Agi Sferro <agi@sferro.dev> - Wed, 10 Jun 2020 17:19:56 +0000 - rev 599007
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644297 - Re enable old browser.storage.sync on Android. r=rpl,snorp This also adds a smoke test which runs on all platforms to avoid regressions. Differential Revision: https://phabricator.services.mozilla.com/D78987
245776c0b467e1792a66fa1ffa683975b8e9071e: Bug 1643656 - Fix GeckoRuntimeSettings color scheme configuration. r=geckoview-reviewers,snorp
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jun 2020 22:40:22 +0000 - rev 598875
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643656 - Fix GeckoRuntimeSettings color scheme configuration. r=geckoview-reviewers,snorp So as to not use a pref with an invalid value, which I would've changed the behavior of with the previous patch. Differential Revision: https://phabricator.services.mozilla.com/D78957
8ec34ae7484d1a1039cdc72e6173e9a3788bc7f4: Bug 1628762 - Fix tree column header color to follow theme. r=geckoview-reviewers,snorp
Colomban Wendling <cwendling@hypra.fr> - Wed, 03 Jun 2020 20:52:55 +0000 - rev 598679
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1628762 - Fix tree column header color to follow theme. r=geckoview-reviewers,snorp The background color for the tree column headers is drawn using the system APIs, but the foreground uses custom colors, which didn't follow theme. This can lead to unreadable text with specific colors, e.g. leading to black on black. Fix this by using system colors for the foreground as well. It also adds on-hover styling to match possible background change on hover. Differential Revision: https://phabricator.services.mozilla.com/D78073
d8b68a88624b6058d0e0ecfb162f0e2a9a40ff44: Bug 1638672 - Use shaders to clear texture cache regions r=geckoview-reviewers,gw,snorp
Dzmitry Malyshau <dmalyshau@mozilla.com> - Mon, 08 Jun 2020 21:05:03 +0000 - rev 598599
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1638672 - Use shaders to clear texture cache regions r=geckoview-reviewers,gw,snorp This is a suggested workaround for an interesting visual bug that we see on some platforms with Intel Broadwell GPUs. Also reverts https://phabricator.services.mozilla.com/D57100 Differential Revision: https://phabricator.services.mozilla.com/D78705
447cbc28fda3f04d5b322cee1a07f2c4e41bb88e: Bug 1641948: remove android opt builds from non-mozilla-central branches; reduce frequency of fat-aar builds r=snorp,Callek
Ben Hearsum <bhearsum@mozilla.com> - Wed, 03 Jun 2020 20:52:38 +0000 - rev 597982
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641948: remove android opt builds from non-mozilla-central branches; reduce frequency of fat-aar builds r=snorp,Callek snorp - I'm not sure if you want/need to review this yourself so I'm flagging you as optional. Differential Revision: https://phabricator.services.mozilla.com/D77834
d29525eebe79ccc056a9e7bb668fd1007934f731: Bug 1642429 - Use checkstyle to enforce that all API methods have docs. r=esawin,snorp
Agi Sferro <agi@sferro.dev> - Tue, 02 Jun 2020 15:05:13 +0000 - rev 597608
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1642429 - Use checkstyle to enforce that all API methods have docs. r=esawin,snorp Differential Revision: https://phabricator.services.mozilla.com/D77693
f7aedc92d396d9170c88af862ec0871bf4a0f6cd: Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Kris Maglione <maglione.k@gmail.com> - Mon, 01 Jun 2020 17:59:01 +0000 - rev 597439
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp Differential Revision: https://phabricator.services.mozilla.com/D75429
cc5f9b171fd9a81ebfcd82839cadf2d327f4e985: Bug 1641983 - Update apilint to 0.3.0. r=snorp
Agi Sferro <agi@sferro.dev> - Mon, 01 Jun 2020 15:58:01 +0000 - rev 597408
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641983 - Update apilint to 0.3.0. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D77534
eb654059cd8baa99ade5008b2b5bd93166604c44: Bug 1641711 - Make javadoc output parsing more resilient. r=snorp
Agi Sferro <agi@sferro.dev> - Mon, 01 Jun 2020 15:58:05 +0000 - rev 597406
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641711 - Make javadoc output parsing more resilient. r=snorp As it turns out, javadoc output is not stable across platforms / OSs / versions (not a big suprise). E.g. in try this is an example line: ``` /builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:1124: warning - Tag @link: reference not found: Autocomplete.LoginStorageDelegate.onLoginFetch onLoginFetch ``` on my mac, this is the same error: ``` /Users/asferro/workspace/mozilla-central/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:1118: error: reference not found * {@link Autocomplete.LoginStorageDelegate.onLoginFetch onLoginFetch}. ``` Notice the `-` character after `warning` in the first example and the `:` character after the second example. To be able to parse both this patch simiplifies the regex and also adds a failsafe that will mark anything that contains the string "error" and "warning" as such. Differential Revision: https://phabricator.services.mozilla.com/D77545
f7b9cdfbc377dcbfc2c5c4e77411d4dbe965acfc: Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp,esawin
Agi Sferro <agi@sferro.dev> - Mon, 01 Jun 2020 15:58:13 +0000 - rev 597404
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp,esawin `|mach lint -f treeherder|` expects lint to not fail ever, if a lint fails it's just ignored. This means that when our javadoc errors out and fails the build all lints are ignored. To avoid that we add `failOnError = false` to the javadoc job so that we can finish the build and actually report the errors. This patch also adds gradle output `|mach lint|` to make it easier to diagnose errors in the lint. Differential Revision: https://phabricator.services.mozilla.com/D77373
dce83a6b19e2922f8fe025d5e13690b11c9b229e: Bug 1644297 - Re enable old browser.storage.sync on Android. r=rpl,snorp, a=jcristau
Agi Sferro <agi@sferro.dev> - Wed, 10 Jun 2020 17:19:56 +0000 - rev 597174
Push 13288 by jcristau@mozilla.com at Tue, 16 Jun 2020 19:10:09 +0000
Bug 1644297 - Re enable old browser.storage.sync on Android. r=rpl,snorp, a=jcristau This also adds a smoke test which runs on all platforms to avoid regressions. Differential Revision: https://phabricator.services.mozilla.com/D78987
2548f39e1751f10df77ccae8c42702d6ef9bbd7d: Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp
Agi Sferro <agi@sferro.dev> - Fri, 29 May 2020 00:24:22 +0000 - rev 596678
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp `|mach lint -f treeherder|` expects lints to not fail ever, if a lint fails it's just ignored. This means that when our javadoc errors out and fails the build all lints are ignored. To avoid that we add `failOnError = false` to the javadoc job so that we can finish the build and actually report the errors. This patch also adds gradle output `|mach lint|` to make it easier to diagnose errors in the lint. Differential Revision: https://phabricator.services.mozilla.com/D77373
f0de352a865b371e5d757cbef4b2b4216ab8a805: Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r=Gijs,nika,geckoview-reviewers,snorp
Anny Gakhokidze <agakhokidze@mozilla.com> - Wed, 27 May 2020 18:15:36 +0000 - rev 596299
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630323 - Do not override user preferences when clicking on a service worker notification to open a new document, r=Gijs,nika,geckoview-reviewers,snorp In Bug 1622749 a user preference for where to open new documents (from a service worker notification) was temporarily overriden in order to quickly fix a crash that was happening in mozilla::dom::ClientOpenWindow. The crash was ocurring when the pref "browser.link.open_newwindow" was set to 2, meaning new documents are opened in a new window, instead of a new tab. The reason the browser crashed is because the path for opening a new document is different depending on the current user setting, and in NEWWINDOW case we did not get a browsing context returned when calling mozilla::dom::OpenWindow which resulted in a failed assertion. The solution is to pass in a callback to mozilla::dom::OpenWindow as part of nsOpenWindowInfo object, and invoke that callback with a corresponding BrowsingContext in nsFrameLoader when that browsing context is ready. After we call mozilla::dom::OpenWindow, we wait on a promise, that will be resolved when the callback is invoked, before executing the rest of the code that depends on the browsing context for a newly opened document being available. Differential Revision: https://phabricator.services.mozilla.com/D72745
00082591503eb5e57cce27f722b8a45c943c7034: Bug 1640990 - [1.1] Add login autofill runtime setting. r=geckoview-reviewers,MattN,snorp
Eugen Sawin <esawin@mozilla.com> - Wed, 27 May 2020 14:04:52 +0000 - rev 596242
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1640990 - [1.1] Add login autofill runtime setting. r=geckoview-reviewers,MattN,snorp Differential Revision: https://phabricator.services.mozilla.com/D76891
53cc0d95ca87299bdfb71351de4a4a006c9ea4a4: Bug 1640743 - Update WebExtension example links. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 19:31:01 +0000 - rev 595995
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1640743 - Update WebExtension example links. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D76756
534e2eb7eaaedd53196fdba7d138bfb7f7a25d41: Bug 1629113 - Use |class| in GeckoViewPrompt.jsm r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 07:44:49 +0000 - rev 595969
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1629113 - Use |class| in GeckoViewPrompt.jsm r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75879
86df4717f1e5b57d24ebd29a7357ef63d1ce6f89: Bug 1629113 - Move remaining services to components.conf. r=snorp,baku
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 07:44:52 +0000 - rev 595968
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1629113 - Move remaining services to components.conf. r=snorp,baku Differential Revision: https://phabricator.services.mozilla.com/D75878
96c247dac742ef0ba8196e536475671c14f677e9: Bug 1629113 - Move prompt classes to its own modules. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 16:35:28 +0000 - rev 595967
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1629113 - Move prompt classes to its own modules. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75877
c60451dacf684f9bf7811f3a89f2efac317055dd: Bug 1629113 - Use |class| more in GeckoViewPrompt. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 16:33:21 +0000 - rev 595966
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1629113 - Use |class| more in GeckoViewPrompt. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75876
5cf3ae77ccb3d6eb8604c74a0413b5c5384439bb: Bug 1640387 - Only set HitResult::mTargetIsRoot for confirmed-root targets. r=snorp,botond
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 26 May 2020 16:30:12 +0000 - rev 595960
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1640387 - Only set HitResult::mTargetIsRoot for confirmed-root targets. r=snorp,botond Differential Revision: https://phabricator.services.mozilla.com/D76594
cd5c87a1700881582a938bff5d653b48eb82d0bc: Bug 1629113 - Use |class| in GeckoViewPrompt.jsm r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 04:14:15 +0000 - rev 595872
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1629113 - Use |class| in GeckoViewPrompt.jsm r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75879
3729b2c288ba46c7d48f5a2bca68f5faafafd60b: Bug 1629113 - Move remaining services to components.conf. r=snorp,baku
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 04:14:12 +0000 - rev 595871
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1629113 - Move remaining services to components.conf. r=snorp,baku Differential Revision: https://phabricator.services.mozilla.com/D75878
2cd92d6c2998f8ab81e6b14540bec17c15227950: Bug 1629113 - Move prompt classes to its own modules. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 04:14:05 +0000 - rev 595870
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1629113 - Move prompt classes to its own modules. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75877
6d7c87f3c329bd3aeb32bd9fdffbfc3af1255c60: Bug 1629113 - Use |class| more in GeckoViewPrompt. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 26 May 2020 04:14:05 +0000 - rev 595869
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1629113 - Use |class| more in GeckoViewPrompt. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D75876
106285c88a8504c4460d72b4c4d1eebd78d309f8: Bug 1618058 - [3.3] Rename and extend LoginStorage tests to Autocomplete tests. r=geckoview-reviewers,agi,snorp
Eugen Sawin <esawin@mozilla.com> - Mon, 25 May 2020 18:46:15 +0000 - rev 595823
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1618058 - [3.3] Rename and extend LoginStorage tests to Autocomplete tests. r=geckoview-reviewers,agi,snorp Differential Revision: https://phabricator.services.mozilla.com/D73060