searching for reviewer(smaug)
34a4398b67fee5d5542c638b02fb239d4c1f1596: Bug 1704948 - Forward mouse button to menuitem command event. r=smaug,robwu a=pascalc
Markus Stange <mstange.moz@gmail.com> - Tue, 20 Apr 2021 17:44:16 +0000 - rev 644326
Push 15388 by pchevrel@mozilla.com at Mon, 03 May 2021 09:37:36 +0000
Bug 1704948 - Forward mouse button to menuitem command event. r=smaug,robwu a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D111956
96a00e46c8dde51bfdcdf0b908201862c00a2923: Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers a=pascalc
Markus Stange <mstange.moz@gmail.com> - Tue, 20 Apr 2021 17:44:16 +0000 - rev 644325
Push 15388 by pchevrel@mozilla.com at Mon, 03 May 2021 09:37:36 +0000
Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D111955
3fbae6868228073db7922f2f51a6698f7aa885f8: Bug 1705946 - Add some prefs for datetime-local. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 18 Apr 2021 18:05:54 +0000 - rev 644042
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1705946 - Add some prefs for datetime-local. r=smaug This is a bit subtler than needed (ideally we'd just need one pref) because android enables the support for the type even if it only creates a textbox. Co-Authored-By: Fernando GarcĂ­a <fernando.garciagomez.01@telefonica.com> Differential Revision: https://phabricator.services.mozilla.com/D112488
054bef15c8aa0d87cf913d067cce0a6899d64130: Bug 1705547 - Null check the SessionHistory object before attempting to collect, r=smaug
Kashav Madan <kshvmdn@gmail.com> - Fri, 16 Apr 2021 12:02:17 +0000 - rev 643909
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1705547 - Null check the SessionHistory object before attempting to collect, r=smaug Differential Revision: https://phabricator.services.mozilla.com/D112290
089fd9e33fe26d5b4215692f84493b2026a071f2: Bug 1700051: part 29) Refactor `TextNodeContainsDOMWordSeparator` to `FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug
Mirko Brodesser <mbrodesser@mozilla.com> - Fri, 16 Apr 2021 08:10:11 +0000 - rev 643902
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700051: part 29) Refactor `TextNodeContainsDOMWordSeparator` to `FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug More descriptive and separates input- from output-arguments. Differential Revision: https://phabricator.services.mozilla.com/D112180
1271c319a2a15f8144e37a771864be1a8afd5026: Bug 1705443 - Use vsync priority in PIntrPriority::Msg r=smaug
Sean Feng <sefeng@mozilla.com> - Thu, 15 Apr 2021 19:07:06 +0000 - rev 643841
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1705443 - Use vsync priority in PIntrPriority::Msg r=smaug We've renamed the `high` priority to `vsync` in bug 1697585, this is just adapting the change. Differential Revision: https://phabricator.services.mozilla.com/D112198
aae7f01be659723e4c571a6d1f4bb0f226ddfb65: Bug 1700051: part 28) Refactor `WordSplitState<T>::GetDOMWordSeparatorOffset` to `WordSplitState<T>::FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug
Mirko Brodesser <mbrodesser@mozilla.com> - Thu, 15 Apr 2021 08:38:42 +0000 - rev 643629
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700051: part 28) Refactor `WordSplitState<T>::GetDOMWordSeparatorOffset` to `WordSplitState<T>::FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug The method name is clearer and input and ouput are separated more clearly. Differential Revision: https://phabricator.services.mozilla.com/D112026
a43a8ef206ea16598e73871c7c9e731865efa5d6: Bug 1704948 - Forward mouse button to menuitem command event. r=smaug,robwu
Markus Stange <mstange.moz@gmail.com> - Wed, 14 Apr 2021 21:23:28 +0000 - rev 643571
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1704948 - Forward mouse button to menuitem command event. r=smaug,robwu Differential Revision: https://phabricator.services.mozilla.com/D111956
2369e321069e5b347eefb7b2616ff8965e224d46: Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Markus Stange <mstange.moz@gmail.com> - Wed, 14 Apr 2021 21:23:27 +0000 - rev 643570
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers Differential Revision: https://phabricator.services.mozilla.com/D111955
0ce8cafaccaf1ffe8daba0460f0b523454179a1f: Bug 1697585 - Prevent starting scrolling again in the child process if preventClickEvent has been called r=masayuki,smaug
Sean Feng <sefeng@mozilla.com> - Wed, 14 Apr 2021 19:56:44 +0000 - rev 643560
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Prevent starting scrolling again in the child process if preventClickEvent has been called r=masayuki,smaug Currently, for auto scroller, when a `mousedown` happens, a possible run order is that `mousedown(parent process)` -> `scroll stopped (parent process)` -> `mousedown(child process)`, so that the last mousedown(child process) would start the scrolling again. This patch adds a new check to the last `mousedown(child process)` handler, to not starting the scrolling again if preventClickEvent has been called on this event. Differential Revision: https://phabricator.services.mozilla.com/D111885
eebe83ba4c974b56eb65853fe9b6b814662b3a75: Bug 1697585 - Ask some tests to wait for a tick in browser_click_event_during_autoscrolling.js r=smaug
Sean Feng <sefeng@mozilla.com> - Wed, 14 Apr 2021 19:56:43 +0000 - rev 643559
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Ask some tests to wait for a tick in browser_click_event_during_autoscrolling.js r=smaug Some tests need to wait for a full tick cycle to ensure the expected input tasks are run. Differential Revision: https://phabricator.services.mozilla.com/D110848
ca2243d8f5653096d57794ad8e1edd965d950121: Bug 1697585 - Add a test to ensure the correct order between input tasks and normal tasks when there's no pending vsync r=smaug
Sean Feng <sefeng@mozilla.com> - Wed, 14 Apr 2021 19:56:43 +0000 - rev 643558
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Add a test to ensure the correct order between input tasks and normal tasks when there's no pending vsync r=smaug Differential Revision: https://phabricator.services.mozilla.com/D110281
c206669072a4ddb69c6faa11b4e81b5ab00a8180: Bug 1697585 - Make input tasks can be more strictly aligned with Vsync r=smaug
Sean Feng <sefeng@mozilla.com> - Wed, 14 Apr 2021 19:56:42 +0000 - rev 643557
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Make input tasks can be more strictly aligned with Vsync r=smaug This patch introduces a new way to way to schedule input tasks, such that input tasks remain at `InputHigh` priority normally, however, when there's a pending `Vsync` priority task in the task queue, we increase the priority of input tasks from `InputHigh` to `InputHighest` to rush processing the pending input tasks. There are two restrictions to ensure we don't delay vsync too much: - There's a hard limit duration - We won't process the input tasks that are newly added after we've started to process the current number of input tasks Differential Revision: https://phabricator.services.mozilla.com/D109499
4031cca20f280570abbea22b9d85baa02141be3c: Bug 1697585 - Add VsyncTaskManager r=bas,smaug
Sean Feng <sefeng@mozilla.com> - Wed, 14 Apr 2021 19:56:42 +0000 - rev 643556
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Add VsyncTaskManager r=bas,smaug Introduce a new TaskManager called VsyncTaskManager for EventQueuePriority::Vsync tasks. Differential Revision: https://phabricator.services.mozilla.com/D109498
8ed6175e0c7b05b6dc5c8d989195239fb8b677fd: Bug 1697585 - Rename high priority to vsync priority r=smaug
Sean Feng <sefeng@mozilla.com> - Wed, 14 Apr 2021 19:56:42 +0000 - rev 643555
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Rename high priority to vsync priority r=smaug `High` priority is being used for vsync tasks, so we should rename it to make it clear, and renaming it also makes our priority naming less confusing. Differential Revision: https://phabricator.services.mozilla.com/D109536
472077cb1e3827a16c4939ec5cb2dc207629b409: Bug 1699844 - Make promiseDocumentFlushed handle presshell destruction correctly. r=smaug,botond
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Apr 2021 19:34:23 +0000 - rev 643551
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1699844 - Make promiseDocumentFlushed handle presshell destruction correctly. r=smaug,botond By resolving the relevant promises, instead of crashing (and if we didn't crash we'd leave the window registered as a refresh driver observer, which would be bad). I wanted to reject them, since that's what we do when the page has no pres shell, but that'd make this test fail: https://searchfox.org/mozilla-central/rev/d8194cbbeaec11962ed67f83aea9984bf38f7c63/dom/base/test/browser_promiseDocumentFlushed.js#165-186 For this, we modify the OneShotPostRefreshObserver API to be more generic (and rename it OneShotManagedRefreshObserver). We fix APZ's usage of this API, which was doing something extremely weird (returning a refcounted object in a UniquePtr). This seems like an artifact from recent OneShotPostRefreshObserver cleanup. Differential Revision: https://phabricator.services.mozilla.com/D111851
1abffab5d5e96214fffe239a6f9af8692da4d0de: Bug 1697256 - Check docshell existence in SetFocusInner r=smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Wed, 14 Apr 2021 11:02:16 +0000 - rev 643442
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697256 - Check docshell existence in SetFocusInner r=smaug Differential Revision: https://phabricator.services.mozilla.com/D111950
6728affb29230e4814378f0b7adadd9d4435dc8c: Bug 1684842 - Enable implicit pointer capture for touch on early Beta; r=smaug
Edgar Chen <echen@mozilla.com> - Tue, 13 Apr 2021 22:10:19 +0000 - rev 643345
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1684842 - Enable implicit pointer capture for touch on early Beta; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D111745
d3ff81521b1766d420d9a0d14f85b5e1cabc7e06: Bug 1697769 - Apply implicit pointer capture only for pointer events that are generated from the touch events; r=smaug
Edgar Chen <echen@mozilla.com> - Tue, 13 Apr 2021 13:14:12 +0000 - rev 643203
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697769 - Apply implicit pointer capture only for pointer events that are generated from the touch events; r=smaug Pointer capture would override the capturing content set in PresShell for mouse event, it isn't affect touch event because dispatching touch event would take the capturing content in PresShell into account, i.e. https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/layout/base/PresShell.cpp#8712-8719 Touch input isn't always generating a touch event, but a compabitility mouse event with the touch as inputsource, e.g. chrome popup window on Windows platform, see https://searchfox.org/mozilla-central/rev/3de2db87f3c9001ae478318d47a2ca3427574382/widget/windows/nsWindow.cpp#8130-8134 In such case, we don't apply implicit pointer capture to prevent the capturing content set in PresShell being overried which could cause the drag to scroll doesn't work. Differential Revision: https://phabricator.services.mozilla.com/D111085
590b23237958c8a77a9dc161500f714c888afad5: Bug 1704551 - Make nsMappedAttributes more similar to AttrArray. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 13 Apr 2021 10:53:40 +0000 - rev 643195
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1704551 - Make nsMappedAttributes more similar to AttrArray. r=smaug I need to use these from Rust to insert mapped attribute names in the bloom filter, and this would save me handrolling even more bindings :) Differential Revision: https://phabricator.services.mozilla.com/D111731
cdcdad0c6c5f417568a899a7728a787b04e26273: Bug 1704650 - PrototypeDocumentContentSink::mContextSink should be cycle collected. r=smaug
Andrew McCreight <continuation@gmail.com> - Mon, 12 Apr 2021 23:07:29 +0000 - rev 643134
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1704650 - PrototypeDocumentContentSink::mContextSink should be cycle collected. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D111732
d54f14759b8618ca1780a86d3a90d3a8f320bd63: Bug 1703289 - Make mixed content blocker use a session-persistent permission rather than ad-hoc code. r=ckerschb,smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 12 Apr 2021 18:04:12 +0000 - rev 643077
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703289 - Make mixed content blocker use a session-persistent permission rather than ad-hoc code. r=ckerschb,smaug This is more fission-compatible, and a lot simpler. Differential Revision: https://phabricator.services.mozilla.com/D111480
d0d082585f008d14509fac2e56e6c4e32cd06ef8: Bug 1704553 - Fix browser_frametree.js and browser_sessionHistory.js for BFCache+Fission, r=smaug
Kashav Madan <kshvmdn@gmail.com> - Mon, 12 Apr 2021 17:05:29 +0000 - rev 643063
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1704553 - Fix browser_frametree.js and browser_sessionHistory.js for BFCache+Fission, r=smaug Differential Revision: https://phabricator.services.mozilla.com/D111685
abfde00b332239db55492652c6e72b17404ac050: Bug 1703291 - Update root bc state when the root bc changes in the session history. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 10 Apr 2021 03:29:36 +0000 - rev 642919
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703291 - Update root bc state when the root bc changes in the session history. r=smaug Otherwise when navigating to a replaced browsing context we might have an incorrect "is single top-level in history". Fixes test_window_close.html with Fission+bfcache. Differential Revision: https://phabricator.services.mozilla.com/D111458
73004945dd3eac7c5517177c133f2db71aa36801: Bug 1703291 - Run test_window_close with bfcacheInParent enabled. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 10 Apr 2021 03:29:36 +0000 - rev 642918
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703291 - Run test_window_close with bfcacheInParent enabled. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D111459
4d216ecbacd95e3dce2f8934da5e4beaaf2a2f3c: Bug 1703291 - Run test_window_close with bfcacheInParent enabled. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Apr 2021 18:01:43 +0000 - rev 642855
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703291 - Run test_window_close with bfcacheInParent enabled. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D111459
edfb69ecfb0638ab330c7c3497a6306cce8e197f: Bug 1698601 - Part 2: Carry over restore data to new context after a process swap, r=smaug
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 09 Apr 2021 17:46:52 +0000 - rev 642853
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1698601 - Part 2: Carry over restore data to new context after a process swap, r=smaug Also, make sure we update layout history state from docshell before we load a new URI, as it might be our last chance to do so before a process swap. Differential Revision: https://phabricator.services.mozilla.com/D110994
55b243205236be4c0ed2897cb2c4e72302c701be: Bug 1698601 - Part 1: Extend existing session store test files with COOP document testing, r=smaug
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 09 Apr 2021 17:46:52 +0000 - rev 642852
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1698601 - Part 1: Extend existing session store test files with COOP document testing, r=smaug Modify related test files to test documents with COOP headers enabled. There are some tests that fail when run with new COOP configurations without Fission enabled, prior to fixes that come in part 2. This means that some of the COOP behaviour was already broken. Since fixing non-Fission COOP behaviour prior to this patch is out of scope, I skipped calling `addCoopTask` to test COOP documents in non Fission cases for such tests. Even with COOP headers disabled, some tests fail when the document they load is served over httpS and not http. For a single test where this behaviour was occuring prior to fixes in part 2, I skipped testing an HTTPS non-COOP document and filed 1703351 to fix such behaviour. Differential Revision: https://phabricator.services.mozilla.com/D110993
51d244d886aa2c037503df5f276d8cc0930f0b24: Bug 1703291 - Update root bc state when the root bc changes in the session history. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Apr 2021 17:33:50 +0000 - rev 642849
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703291 - Update root bc state when the root bc changes in the session history. r=smaug Otherwise when navigating to a replaced browsing context we might have an incorrect "is single top-level in history". Fixes test_window_close.html with Fission+bfcache. Differential Revision: https://phabricator.services.mozilla.com/D111458
aa3365ae22d92008492b53194f7eec047a293610: Bug 1702670 - Fix state management for "last value change was interactive" for inputs / textareas. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Apr 2021 16:02:17 +0000 - rev 642647
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1702670 - Fix state management for "last value change was interactive" for inputs / textareas. r=smaug This and "value changed" affect the "too long" and "too short" validity states. The validity state tracking code is quite messy... Differential Revision: https://phabricator.services.mozilla.com/D111254
2f021db40245d9fc05299b37f9f1cc1a2467eda4: Bug 1689348 - Remove unused JSExecutionContext::SetScopeChain code. r=smaug,nbp
Ted Campbell <tcampbell@mozilla.com> - Thu, 08 Apr 2021 15:35:52 +0000 - rev 642641
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1689348 - Remove unused JSExecutionContext::SetScopeChain code. r=smaug,nbp The last use of this method was the NSPAPI plugin code which has now been removed. These non-syntactic exotic environments were used for non-standard situations and suffered numerous performance and correctness issues so are deprecated in general. Differential Revision: https://phabricator.services.mozilla.com/D111260
306a4c2820ef22db3b93132191c719371117c725: Bug 1622846 - Update wgpu and WebGPU IDL for the new copy views API r=webidl,jgilbert,smaug
Dzmitry Malyshau <dmalyshau@mozilla.com> - Thu, 08 Apr 2021 14:35:42 +0000 - rev 642629
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1622846 - Update wgpu and WebGPU IDL for the new copy views API r=webidl,jgilbert,smaug Updates wgpu, WebGPU IDL, in particular the ImageCopyXxx types and render pass attachments. Adds explicit mapping of the GPUTextureFormat enum. Our old casting was incorrect, because the enums diverged a bit. Differential Revision: https://phabricator.services.mozilla.com/D110997
1c4034b17df33d155b0b89bb41380750f218a19e: Bug 1700004 - Make `FuzzingFunctions::SynthesizeKeyboardEvents` synthesize keyboard events in in-process top window rather than active window r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 08 Apr 2021 00:11:26 +0000 - rev 642473
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700004 - Make `FuzzingFunctions::SynthesizeKeyboardEvents` synthesize keyboard events in in-process top window rather than active window r=smaug Currently, it tries to synthesize keyboard events on active window for emulating user input as far as possible. However, in the Fission world, it cannot retrieve active window from a content process for OOP iframe. And current behavior does not allow to emulate synthesizing keyboard events in inactive window which may be caused by 3rd party apps like IME. Therefore, this patch makes it synthesize keyboard events in in-process top window from the caller's global object. If we support synthesizing keyboard events via main process, we can change the behavior better. But for now, this must be enough for the Fuzzing API users. Differential Revision: https://phabricator.services.mozilla.com/D111040
5b033d5d6e6d1dcab03863b56c14cfaaf06ce7b3: Bug 1622846 - Update wgpu and WebGPU IDL for the new copy views API r=webidl,jgilbert,smaug
Dzmitry Malyshau <dmalyshau@mozilla.com> - Wed, 07 Apr 2021 22:46:47 +0000 - rev 642468
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1622846 - Update wgpu and WebGPU IDL for the new copy views API r=webidl,jgilbert,smaug Updates wgpu, WebGPU IDL, in particular the ImageCopyXxx types and render pass attachments. Adds explicit mapping of the GPUTextureFormat enum. Our old casting was incorrect, because the enums diverged a bit. Differential Revision: https://phabricator.services.mozilla.com/D110997
cc986541595b2cbad3631854db03056be997bbab: Bug 1703472 - Add an automated test for this. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Apr 2021 16:03:11 +0000 - rev 642409
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703472 - Add an automated test for this. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D111119
db92ea730300b6e9f4dd49075437e866190ee9e3: Bug 1703472 - For window.focus, popup abuse level should be checked on the caller. r=smaug,hsivonen
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Apr 2021 16:03:11 +0000 - rev 642408
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1703472 - For window.focus, popup abuse level should be checked on the caller. r=smaug,hsivonen Just like how for window.open() it's checked on the opener, of course. Note that when sending the focus request via IPC, we trust the check done on the child (bug 1677899). Do we have a good test to extend to cover this case? Differential Revision: https://phabricator.services.mozilla.com/D111107
824c61d6f3df36ac20138aaa29e53613c47906b4: Bug 1702867 - Static print documents do have a browsing context and are loaded as data. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 06 Apr 2021 19:29:49 +0000 - rev 642183
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1702867 - Static print documents do have a browsing context and are loaded as data. r=smaug Document::CrossOriginIsolated() was assuming this wasn't possible, so when you print from an isolated page from a different site, then we end up with the wrong docgroup. Differential Revision: https://phabricator.services.mozilla.com/D110988
e9e4a710e7d15a3ace7764483a5cfceb6e2713c9: Bug 1697585 - Ask some tests to wait for a tick in browser_click_event_during_autoscrolling.js r=smaug
Sean Feng <sefeng@mozilla.com> - Tue, 06 Apr 2021 13:10:52 +0000 - rev 642065
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Ask some tests to wait for a tick in browser_click_event_during_autoscrolling.js r=smaug Some tests need to wait for a full tick cycle to ensure the expected input tasks are run. Differential Revision: https://phabricator.services.mozilla.com/D110848
bc271f42bcb71ec425214f34a13b727e3d1e82ce: Bug 1697585 - Add a test to ensure the correct order between input tasks and normal tasks when there's no pending vsync r=smaug
Sean Feng <sefeng@mozilla.com> - Tue, 06 Apr 2021 13:10:51 +0000 - rev 642064
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Add a test to ensure the correct order between input tasks and normal tasks when there's no pending vsync r=smaug Differential Revision: https://phabricator.services.mozilla.com/D110281
d8516aec6a5e0b90ab850073d8b20a4140b4cb6e: Bug 1697585 - Make input tasks can be more strictly aligned with Vsync r=smaug
Sean Feng <sefeng@mozilla.com> - Tue, 06 Apr 2021 13:10:51 +0000 - rev 642063
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Make input tasks can be more strictly aligned with Vsync r=smaug This patch introduces a new way to way to schedule input tasks, such that input tasks remain at `InputHigh` priority normally, however, when there's a pending `Vsync` priority task in the task queue, we increase the priority of input tasks from `InputHigh` to `InputHighest` to rush processing the pending input tasks. There are two restrictions to ensure we don't delay vsync too much: - There's a hard limit duration - We won't process the input tasks that are newly added after we've started to process the current number of input tasks Differential Revision: https://phabricator.services.mozilla.com/D109499
0b1bc6cb84af5930615de50823527b74872d4918: Bug 1697585 - Add VsyncTaskManager r=bas,smaug
Sean Feng <sefeng@mozilla.com> - Tue, 06 Apr 2021 13:10:51 +0000 - rev 642062
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Add VsyncTaskManager r=bas,smaug Introduce a new TaskManager called VsyncTaskManager for EventQueuePriority::Vsync tasks. Differential Revision: https://phabricator.services.mozilla.com/D109498
074ebebaee27545a70e221e8a5c2ad9dc7a2533b: Bug 1697585 - Rename high priority to vsync priority r=smaug
Sean Feng <sefeng@mozilla.com> - Tue, 06 Apr 2021 13:10:50 +0000 - rev 642061
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1697585 - Rename high priority to vsync priority r=smaug `High` priority is being used for vsync tasks, so we should rename it to make it clear, and renaming it also makes our priority naming less confusing. Differential Revision: https://phabricator.services.mozilla.com/D109536
7341db1e3d21bd229c95c06b8ca04b40a67f2cbf: Bug 1702862. Allow nsICotent::List and friends in --enable-dump-painting builds. r=smaug
Timothy Nikkel <tnikkel@gmail.com> - Mon, 05 Apr 2021 10:49:40 +0000 - rev 641889
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1702862. Allow nsICotent::List and friends in --enable-dump-painting builds. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D110743
8bfe6426b2de41ed59ee332bfcb895cf7053a31a: Bug 1037709 - Part 2: Make element in a shadow DOM also handling accesskey; r=smaug
Edgar Chen <echen@mozilla.com> - Thu, 01 Apr 2021 17:52:40 +0000 - rev 641609
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1037709 - Part 2: Make element in a shadow DOM also handling accesskey; r=smaug This is tracked by https://github.com/whatwg/html/issues/4385 standards-wise and the tentative outcome from the standards discussion is that accesskey should work across tree boundaries. Differential Revision: https://phabricator.services.mozilla.com/D110426
36d3002f77b6d0966d0bf70da1795ebdd119b0c4: Bug 1037709 - Part 1: Remove nsGenericHTMLElement::RegAccessKey/UnregAccessKey; r=smaug
Edgar Chen <echen@mozilla.com> - Thu, 01 Apr 2021 17:52:39 +0000 - rev 641608
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1037709 - Part 1: Remove nsGenericHTMLElement::RegAccessKey/UnregAccessKey; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D110425
eabdf687b343cbdf681bdef93c3ad12b8ba9daef: Bug 1700051: part 27) Rename `mozInlineSpellWordUtil::BuildSoftText` to `mozInlineSpellWordUtil::AdjustSoftBeginAndBuildSoftText`. r=smaug
Mirko Brodesser <mbrodesser@mozilla.com> - Wed, 31 Mar 2021 09:04:46 +0000 - rev 641425
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700051: part 27) Rename `mozInlineSpellWordUtil::BuildSoftText` to `mozInlineSpellWordUtil::AdjustSoftBeginAndBuildSoftText`. r=smaug Ideally, the method itself should be refactored. I'll need to think about how to properly do that. For now, the new name reflects more clearly what the method does. Depends on D110242 Differential Revision: https://phabricator.services.mozilla.com/D110243
d7fb747c6ea9e80b056149e8c3a17ca740c73c6d: Bug 1700051: part 26) Correct typo in comment of `mozInlineSpellWordUtil::BuildSoftText`. r=smaug
Mirko Brodesser <mbrodesser@mozilla.com> - Wed, 31 Mar 2021 09:04:46 +0000 - rev 641424
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700051: part 26) Correct typo in comment of `mozInlineSpellWordUtil::BuildSoftText`. r=smaug Depends on D110241 Differential Revision: https://phabricator.services.mozilla.com/D110242
dd781a9ee853ba378230c27a5d5b981628431842: Bug 1700051: part 25) Change `mozInlineSpellWordUtil::BuildRealWords` to return the built words. r=smaug
Mirko Brodesser <mbrodesser@mozilla.com> - Wed, 31 Mar 2021 09:04:45 +0000 - rev 641423
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700051: part 25) Change `mozInlineSpellWordUtil::BuildRealWords` to return the built words. r=smaug Depends on D110240 Differential Revision: https://phabricator.services.mozilla.com/D110241
f17876cf4cd554763546ee2309ea380a971c0f83: Bug 1700051: part 24) Refactor `mozInlineSpellWordUtil::SplitDOMWord` to `mozInlineSpellWordUtil::SplitDOMWordAndAppendTo`. r=smaug
Mirko Brodesser <mbrodesser@mozilla.com> - Wed, 31 Mar 2021 08:33:09 +0000 - rev 641420
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700051: part 24) Refactor `mozInlineSpellWordUtil::SplitDOMWord` to `mozInlineSpellWordUtil::SplitDOMWordAndAppendTo`. r=smaug More explicit and preparation for further `const`-correctness. Depends on D110090 Differential Revision: https://phabricator.services.mozilla.com/D110240
1c180c9324beb0d501212da0dca779cc1004fe84: Bug 1700871 - Only allow focus move for links / form submission iff actually handling user input. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 31 Mar 2021 01:51:46 +0000 - rev 641410
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700871 - Only allow focus move for links / form submission iff actually handling user input. r=smaug The other navigation that allows focus moves (window.open) already goes through the popup blocker, so that one is fine. I think given how weird yet conservative other browsers are, this should be a good trade-off to avoid false positives. Differential Revision: https://phabricator.services.mozilla.com/D110196