searching for reviewer(smaug)
02a07fe87808: Bug 1482425 - PresShell::PageMove() should use different rules to look for a container element for aExtend value r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 18 Oct 2018 04:42:53 +0000 - rev 497602
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1482425 - PresShell::PageMove() should use different rules to look for a container element for aExtend value r=smaug PresShell::PageMove() climbs up to parent document when there is no scrollable parent in current document. However, if aExtend is true, it should expand Selection in the document itself. Therefore, it needs different rules to look for container of expanding Selection from scrollable element to scroll. Additionally, old rules (i.e., before the fix of bug 1369072 which caused this regression) were also buggy. It used parent scrollable element or root scrollable element simply. Therefore, if found scrollable element is ancestor of selection limiter, it didn't work as expected. This patch creates nsFrameSelection::GetFrameToPageSelect() to retrieve per-page selection container element with the following rules: - look for a scrollable element in selection limiter. - if there is no scrollable element, use selection limiter. - if there is no selection limiter, use the root frame. So, nsFrameSelection::CommonPageMove() should take nsIFrame rather than nsIScrollableFrame since container of per-page selection may be used in non-scrollable contenteditable element. If it's called with non-scrollable frame, it needs to compute the expanding range with the frame size. Differential Revision: https://phabricator.services.mozilla.com/D8954
1249680014b0: Bug 1499473: Simplify TabGroup a bit, now that ThrottledEventQueue::Create is infallible. r=smaug
Jim Blandy <jimb@mozilla.com> - Wed, 17 Oct 2018 20:41:59 +0000 - rev 497565
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1499473: Simplify TabGroup a bit, now that ThrottledEventQueue::Create is infallible. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8915
7b427b166742: Bug 1498860 - Add window.screenLeft / window.screenTop as aliases of screenX / screenY. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Oct 2018 02:20:15 +0000 - rev 497327
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1498860 - Add window.screenLeft / window.screenTop as aliases of screenX / screenY. r=smaug Tests are at https://github.com/web-platform-tests/wpt/pull/13543. Spec is waiting on those, but this matches all other browsers. Differential Revision: https://phabricator.services.mozilla.com/D8917
f2e35ed6a692: Bug 1497601 - Use a xul:description instead of a xul:label for tooltips;r=smaug
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 16 Oct 2018 13:54:07 +0000 - rev 497205
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1497601 - Use a xul:description instead of a xul:label for tooltips;r=smaug We'd like to be able to implement label features with a Custom Element, and we don't want to run CE reactions inside of NAC. Differential Revision: https://phabricator.services.mozilla.com/D8241
9508a03be7c2: Bug 1258143 - Remove LocalMediaStream. r=jib,smaug
Andreas Pehrson <apehrson@mozilla.com> - Mon, 15 Oct 2018 08:17:07 +0000 - rev 497044
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1258143 - Remove LocalMediaStream. r=jib,smaug Differential Revision: https://phabricator.services.mozilla.com/D8064
b32ff85f2224: Bug 1435789: implement relayProtocol for localcandidate stats r=smaug,ng
Philipp Hancke <fippo@appear.in> - Sun, 07 Oct 2018 07:42:48 +0000 - rev 496892
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1435789: implement relayProtocol for localcandidate stats r=smaug,ng relayProtocol is the standardized variant of mozLocalTransport. Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-relayprotocol IDL: https://w3c.github.io/webrtc-stats/#icecandidate-dict* Differential Revision: https://phabricator.services.mozilla.com/D3428
905c871bcf03: Bug 1258143 - Remove LocalMediaStream. r=jib,smaug
Andreas Pehrson <apehrson@mozilla.com> - Thu, 11 Oct 2018 12:43:34 +0000 - rev 496610
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1258143 - Remove LocalMediaStream. r=jib,smaug Differential Revision: https://phabricator.services.mozilla.com/D8064
bb32faa290f0: Bug 1377146 - Remove AudioStreamTrack and VideoStreamTrack from js. r=jib,smaug
Andreas Pehrson <apehrson@mozilla.com> - Thu, 11 Oct 2018 15:36:11 +0000 - rev 496593
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1377146 - Remove AudioStreamTrack and VideoStreamTrack from js. r=jib,smaug Differential Revision: https://phabricator.services.mozilla.com/D8063
ccdfe4ca1f88: Bug 1498445 - Stop creating a style attribute for invalid property values. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 12 Oct 2018 09:07:00 +0000 - rev 496588
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1498445 - Stop creating a style attribute for invalid property values. r=smaug This matches all other browsers, and the spec. Added an explicit test for this, and a test that tests what cssstyledeclaration-mutationrecord-002.html wanted to test, which is that changing an existing declaration doesn't generate a mutation record. Differential Revision: https://phabricator.services.mozilla.com/D8500
8aef0f43b2d8: Bug 934425 - Add SinkId in webidl for HTMLMediaElement. r=smaug
Alex Chronopoulos <achronop@gmail.com> - Fri, 12 Oct 2018 08:44:55 +0000 - rev 496578
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 934425 - Add SinkId in webidl for HTMLMediaElement. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D5873
858b41d7b9ed: Bug 1484849 - history.go(0) should reload the current page and not involve the entire session history r=smaug
Perry Jiang <perry@mozilla.com> - Thu, 11 Oct 2018 15:43:25 +0000 - rev 496500
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1484849 - history.go(0) should reload the current page and not involve the entire session history r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8322
cecf523a14b1: Bug 1263734: Implement ServiceWorkerContainer.startMessages() r=asuth,smaug
Yaron Tausky <ytausky@mozilla.com> - Thu, 11 Oct 2018 12:37:37 +0000 - rev 496432
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1263734: Implement ServiceWorkerContainer.startMessages() r=asuth,smaug Differential Revision: https://phabricator.services.mozilla.com/D4237
55588bdd2ee8: Bug 1497831 - Use nsTArray instead of nsIArray for nsIFormatConverter. r=smaug
Tom Schuster <evilpies@gmail.com> - Wed, 10 Oct 2018 20:26:06 +0000 - rev 496359
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497831 - Use nsTArray instead of nsIArray for nsIFormatConverter. r=smaug Depends on D8194 Differential Revision: https://phabricator.services.mozilla.com/D8195
2852663b840e: Bug 1497831 - Use nsTArray instead of nsIArray for nsITransferable. r=smaug
Tom Schuster <evilpies@gmail.com> - Wed, 10 Oct 2018 20:25:54 +0000 - rev 496358
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497831 - Use nsTArray instead of nsIArray for nsITransferable. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8194
2c01f22661fa: Bug 1263734: Implement ServiceWorkerContainer.startMessages() r=asuth,smaug
Yaron Tausky <ytausky@mozilla.com> - Wed, 10 Oct 2018 13:55:23 +0000 - rev 496266
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1263734: Implement ServiceWorkerContainer.startMessages() r=asuth,smaug Differential Revision: https://phabricator.services.mozilla.com/D4237
d56cf859abf7: Bug 1363508 - Part 3: Spoofing navigator.maxTouchPoints into 0 if fingerprinting resistance is enabled r=arthuredelstein,masayuki,smaug
Tim Huang <tihuang@mozilla.com> - Tue, 09 Oct 2018 11:50:03 +0000 - rev 496260
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1363508 - Part 3: Spoofing navigator.maxTouchPoints into 0 if fingerprinting resistance is enabled r=arthuredelstein,masayuki,smaug The maxTouchPoints is going to review the detail of users' hardware. So, we will spoof it into 0 if fingerprinting resistance is on. Depends on D6004 Differential Revision: https://phabricator.services.mozilla.com/D6005
3e9933f36e45: Bug 1363508 - Part 1: Spoofing pen/touch pointer events into mouse pointer events when fingerprinting resistance is on r=arthuredelstein,masayuki,smaug
Tim Huang <tihuang@mozilla.com> - Tue, 09 Oct 2018 11:55:43 +0000 - rev 496258
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1363508 - Part 1: Spoofing pen/touch pointer events into mouse pointer events when fingerprinting resistance is on r=arthuredelstein,masayuki,smaug The pointerType field in the pointer event will reveal the details of users' hardware; this is a fingerprinting vector. So, we would spoof all types of pointer events into mouse type pointer events for protecting users from browser fingerprinting when fingerprinting resistance is on. In this patch, we would spoof the pointerType as well as other fields that mouse pointer events don't support, like pressure, tiltX/Y and so on when fingerprinting resistance is on. Differential Revision: https://phabricator.services.mozilla.com/D6003
9e84f8d5b086: Bug 1461708 - part 8: Make EventStateManager handle middle click paste as a default action of mouseup event r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:06:17 +0000 - rev 496187
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1461708 - part 8: Make EventStateManager handle middle click paste as a default action of mouseup event r=smaug This patch makes EventStateManager handle middle click paste as a default action. Unfortunately, we cannot remove the call of HandleMiddleClickPaste() in EditorEventListener because it's important to consume middle click event before any elements in the editor. For example, if clicked HTMLEditor has non-editable <a href> element, middle click event needs to be handled by the editor rather than contentAreaUtils which handles click events of <a href> elements. The cause of this kind of issues is, any click event handlers which handle non-primary button events still listen to "click" events. Therefore, this patch makes HandleMiddleClickPaste() do nothing if the mouseup event is fired on an editor. Differential Revision: https://phabricator.services.mozilla.com/D7855
0f2549de4e47: Bug 1461708 - part 7: Make EventStateManager::HandleMiddleClickPaste() dispatch ePaste event by itself r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:05:39 +0000 - rev 496186
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1461708 - part 7: Make EventStateManager::HandleMiddleClickPaste() dispatch ePaste event by itself r=smaug This is preparation of the last patch. Even if no editor is clicked with middle button, we need to do: - collapse Selection at the clicked point. - dispatch "paste" event. Therefore, HandleMiddleClickPaste() should dispatch ePaste event by itself and each editor methods should have a bool argument which the caller wants ePaste event automatically. Note that Chromium dispatches "paste" event and pastes clipboard content into clicked editor even if preceding "auxclick" event is consumed. However, our traditional behavior is not dispatching "paste" event nor pasting clipboard content. Unless Chromium developer keeps their odd behavior, we should keep our traditional behavior since our behavior is conforming to DOM event model. Differential Revision: https://phabricator.services.mozilla.com/D7854
95d15775e123: Bug 1461708 - part 5: Move EditorEventListener::HandleMiddleClickPaste() to EventStateManager r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:04:17 +0000 - rev 496184
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1461708 - part 5: Move EditorEventListener::HandleMiddleClickPaste() to EventStateManager r=smaug EventStateManager needs to handle middle click paste without editor. Therefore, the handler should be in EventStateManager. Differential Revision: https://phabricator.services.mozilla.com/D7852
219527f4c312: Bug 1461708 - part 4: Move implementation of UIEvent::GetRangeParent() and UIEvent::RangeOffset() to nsLayoutUtils r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:03:34 +0000 - rev 496183
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1461708 - part 4: Move implementation of UIEvent::GetRangeParent() and UIEvent::RangeOffset() to nsLayoutUtils r=smaug We need to move EditorEventListener::HandleMiddleClickPaste() into EventStateManager to handle middle click paste after all click events are dispatched. This is preparation of the change. HandleMiddleClickPaste() uses UIEvent::GetRangeParent() and UIEvent::RangeOffset() to collapse Selection at clicked point. However, EventStateManager cannot access them since EventStateManager can handle it with WidgetMouseEvent. Fortunately, only WidgetMouseEvent is necessary for implementing them. Therefore, we can move the implementation into nsLayoutUtils and merge them. Differential Revision: https://phabricator.services.mozilla.com/D7851
d61721276fcc: Bug 1461708 - part 3: EventStateManager::InitAndDispatchClickEvent() shouldn't overwrite nsEventStatus with nsEventStatus_eIgnore r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:02:50 +0000 - rev 496182
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1461708 - part 3: EventStateManager::InitAndDispatchClickEvent() shouldn't overwrite nsEventStatus with nsEventStatus_eIgnore r=smaug EventStateManager::InitAndDispatchClickEvent() sends given nsEventStatus to nsIPresShell::HandleEventWithTarget(). Then, it sends the status to EventStateManager::PreHandleEvent() before dispatching the event. At this time, EventStateManager::PreHandleEvent() resets the state to nsEventStatus_eIgnore. Therefore, for example, if eMouseClick event is consumed but eMouseAuxClick is ignored, the event status result is nsEventStatus_eIgnore. So, neither DispatchClickEvents() nor PostMouseUpEventHandler() cannot check whether at least one click event is consumed. This patch makes EventStateManager::InitAndDispatchClickEvent() sends local variable of nsEventStatus to nsIPresShell::HandleEventWithTarget(). Then, merge the result with current status. If we'd change nsEventStatus to enum class, we could make this change as custom "operator|=" or something. Differential Revision: https://phabricator.services.mozilla.com/D7850
588859b2d5cc: Bug 1461708 - part 2: Split EventStateManager::CheckForAndDispatchClick() r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:01:57 +0000 - rev 496181
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1461708 - part 2: Split EventStateManager::CheckForAndDispatchClick() r=smaug This patch splits EventStateManager::CheckForAndDispatchClick(). One is for handling default action of eMouseUp, the other is for dispatching click events. This makes it easier to add other default actions after dispatching click events. Differential Revision: https://phabricator.services.mozilla.com/D7849
973ea1694606: Bug 1461708 - part 1: Clean up EventStateManager::CheckForAndDispatchClick() with early-return style r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:01:18 +0000 - rev 496180
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1461708 - part 1: Clean up EventStateManager::CheckForAndDispatchClick() with early-return style r=smaug Differential Revision: https://phabricator.services.mozilla.com/D7848
18d88d24495a: Bug 1491403 - Part 3: Propagate the user input event handling state to the promise resolve handlers in case the promise creator requests it r=smaug,arai,baku
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 09 Oct 2018 21:42:22 +0000 - rev 496072
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1491403 - Part 3: Propagate the user input event handling state to the promise resolve handlers in case the promise creator requests it r=smaug,arai,baku Depends on D7004 Differential Revision: https://phabricator.services.mozilla.com/D7005
ecce651fad51: Bug 1473108 - Part 2: Make PresShell not point to unbound NAC in event content stack; r=smaug
Edgar Chen <echen@mozilla.com> - Tue, 09 Oct 2018 12:16:15 +0000 - rev 495980
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1473108 - Part 2: Make PresShell not point to unbound NAC in event content stack; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8042
b38223cb4fd1: Bug 1473108 - Part 1: Devirtualize nsIPresShell::GetCurrentEventFrame/GetEventTargetContent; r=smaug
Edgar Chen <echen@mozilla.com> - Tue, 09 Oct 2018 09:47:58 +0000 - rev 495979
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1473108 - Part 1: Devirtualize nsIPresShell::GetCurrentEventFrame/GetEventTargetContent; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8041
550aa5330baf: Bug 1497546 - Disable new behavior of keyCode and charCode of keypress event r=smaug a=Aryx
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 09 Oct 2018 21:04:37 +0300 - rev 495978
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497546 - Disable new behavior of keyCode and charCode of keypress event r=smaug a=Aryx Summary: The fix of bug 1479964 breaks some web apps using Google Closure including Google's apps. So, for Nightly testers, we should disable the new behavior until Google Closure fixes it or we can disable the new behavior per web apps. Reviewers: smaug Reviewed By: smaug Bug #: 1497546 Differential Revision: https://phabricator.services.mozilla.com/D8090
a9db3033d9cb: Bug 1479964 - Set KeyboardEvent.keyCode and KeyboardEvent.charCode to same value if the event is "keypress" event r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 09 Oct 2018 04:43:37 +0000 - rev 495858
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1479964 - Set KeyboardEvent.keyCode and KeyboardEvent.charCode to same value if the event is "keypress" event r=smaug Chrome sets both KeyboardEvent.keyCode and KeyboardEvent.charCode of "keypress" event to same value. On the other hand, our traditional behavior is, sets one of them to 0. Therefore, we need to set keyCode value to charCode value if the keypress event is caused by a non-function key, i.e., it may be a printable key with specific modifier state and/or different keyboard layout for compatibility with Chrome. Similarly, we need to set charCode value to keyCode value if the keypress event is caused by a function key which is not mapped to producing a character. Note that this hack is for compatibility with Chrome. So, for now, it's enough to change the behavior only for "keypress" event handlers in web content. If we completely change the behavior, we need to fix a lot of default handlers and mochitests too. However, it's really difficult because default handlers check whether keypress events are printable or not with following code: > if (event.charCode && > !event.altKey && !event.ctrlKey && !event.metaKey) { or > if (!event.keyCode && > !event.altKey && !event.ctrlKey && !event.metaKey) { So, until we stop dispatching "keypress" events for non-printable keys, we need complicated check in each of them. And also note that this patch changes the behavior of KeyboardEvent::KeyCode() when spoofing is enabled and the instance is initialized by initKeyEvent() or initKeyboardEvent(). That was changed by bug 1222285 unexpectedly and keeping the behavior makes patched code really ugly. Therefore, this takes back the old behavior even if spoofing is enabled. Differential Revision: https://phabricator.services.mozilla.com/D7974
70f63648a0f6: Bug 1497126 - Fix WPTs for 1 level of recursion when loading nested iframes with same URL, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 08 Oct 2018 16:04:57 +0200 - rev 495726
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497126 - Fix WPTs for 1 level of recursion when loading nested iframes with same URL, r=smaug
dc46a5f43a47: Bug 1497126 - Allow 1 level of recursion when loading nested iframes with same URL, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 08 Oct 2018 16:04:56 +0200 - rev 495725
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497126 - Allow 1 level of recursion when loading nested iframes with same URL, r=smaug
15fe5851f113: Bug 1310193 - Remove wrapping of nsISupports as nsISupportsInterfacePointer in transferables. r=smaug
Neil Deakin <enndeakin@gmail.com> - Sun, 07 Oct 2018 16:33:07 +0200 - rev 495696
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1310193 - Remove wrapping of nsISupports as nsISupportsInterfacePointer in transferables. r=smaug
fd12d054f76c: Bug 1495364 - FeaturePolicy: geolocation, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 06 Oct 2018 13:10:30 +0200 - rev 495641
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1495364 - FeaturePolicy: geolocation, r=smaug
de02c78c82b7: Bug 1495272 Part 2 - Use DeferredFinalize in SweepTearOffs when recording/replaying, r=smaug.
Brian Hackett <bhackett1024@gmail.com> - Wed, 03 Oct 2018 15:03:37 -1000 - rev 495438
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1495272 Part 2 - Use DeferredFinalize in SweepTearOffs when recording/replaying, r=smaug.
cafd172dc48a: Bug 1495362 - FeaturePolicy: fullscreen, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 04 Oct 2018 14:34:37 +0200 - rev 495400
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1495362 - FeaturePolicy: fullscreen, r=smaug
e6cfd555f0d1: Bug 1290420 Part 4: Make the PresShell create a MobileViewportManager on demand. r=botond,smaug
Brad Werth <bwerth@mozilla.com> - Thu, 04 Oct 2018 03:28:40 +0000 - rev 495379
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1290420 Part 4: Make the PresShell create a MobileViewportManager on demand. r=botond,smaug Depends on D3376 Differential Revision: https://phabricator.services.mozilla.com/D3377
ec06f75313de: Bug 1290420 Part 1: Add a docshell flag for overriding meta viewport handling. r=smaug
Botond Ballo <botond@mozilla.com>, Brad Werth <bwerth@mozilla.com> - Thu, 04 Oct 2018 00:19:40 +0000 - rev 495376
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1290420 Part 1: Add a docshell flag for overriding meta viewport handling. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3373
37fcdbb6756c: Bug 1495983: Assert system privileged about: pages have CSP. r=smaug
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 03 Oct 2018 09:47:08 +0200 - rev 495350
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1495983: Assert system privileged about: pages have CSP. r=smaug
1873f93e51a6: Bug 1496284 - Drop Etherpad instances from "dom.keyboardevent.keypress.hack.dispatch_non_printable_keys" r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 04 Oct 2018 09:19:49 +0000 - rev 495294
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496284 - Drop Etherpad instances from "dom.keyboardevent.keypress.hack.dispatch_non_printable_keys" r=smaug Etherpad fixed the bug with new Gecko behavior and has already released it in this August. So, even if some instances still use older versions, we can request them to update the version. This patch removes all Etherpad instances we know from the blacklist of strict keypress dispatching. So, Nightly testers can find old instances easier. Differential Revision: https://phabricator.services.mozilla.com/D7694
2d5a7c965683: Bug 1461798 - Migrate <tooltip> to a C++ implementation. r=smaug
Brendan Dahl <bdahl@mozilla.com> - Wed, 03 Oct 2018 20:42:19 +0000 - rev 495205
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1461798 - Migrate <tooltip> to a C++ implementation. r=smaug Move the implementation of the XBL tooltip to C++ so the element can safely be created during native anonymous content creation. The 'mouseover' and 'mouseout' event handlers were not moved as they appear to be legacy code that is no longer needed. A number of tests started perma-failing after this patch. Most failures were caused by a timing change where plugins sometimes load after the document "load" event. Many of the failures had intermittents associated with them and the tests were not waiting for plugins to load before starting. The test "test_weakmap_keys_preserved2.xul" had a bug where it was possible for it to finish before all the tests were run. Differential Revision: https://phabricator.services.mozilla.com/D5065
7b44294e3037: Bug 1495912- Remove more trivial calls to do_QueryInterface r=smaug
Andrew McCreight <continuation@gmail.com> - Wed, 03 Oct 2018 19:52:01 +0000 - rev 495201
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1495912- Remove more trivial calls to do_QueryInterface r=smaug MozReview-Commit-ID: 34BAwt3SAJk Differential Revision: https://phabricator.services.mozilla.com/D7640
edfd1b8910f6: Bug 1495588 - Prevent the parent frame from getting handled UA Widget events r=kmag,smaug
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 03 Oct 2018 15:14:46 +0000 - rev 495151
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1495588 - Prevent the parent frame from getting handled UA Widget events r=kmag,smaug This can happen when the message manager is associated to an embedded frame, like an <iframe mozbrowser>. Differential Revision: https://phabricator.services.mozilla.com/D7362
ade489313a3d: Bug 1343955 - part 4: Implement static API to synthesize keyboard events into FuzzingFunctions r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 02 Oct 2018 12:16:45 +0000 - rev 495140
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1343955 - part 4: Implement static API to synthesize keyboard events into FuzzingFunctions r=smaug Synthesizing keyboard events is dangerous and such API is requested only by fuzzing test. So, we should add it into FuzzingFunctions which is built only when |ac_add_options --enable-fuzzing| is specified and enabled by the pref. This patch implements the API as synthesizing keyboard events in the focused widget and the synthesized events are propagated as native key events except APZ (because keyboard events are synthesized only in the process). This behavior allows to test including any default action handlers such as EventStateManager and setting WidgetGUIEvent::mWidget since some C++ handler checks if it's nullptr. Differential Revision: https://phabricator.services.mozilla.com/D5516
4a3ba199155a: Bug 1343955 - part 3: Implement similar C++ utility of _computeKeyCodeFromChar() in EventUtils.js and make it accssible with nsITextInputProcessor for EventUtils.js r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 03 Oct 2018 09:24:15 +0000 - rev 495139
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1343955 - part 3: Implement similar C++ utility of _computeKeyCodeFromChar() in EventUtils.js and make it accssible with nsITextInputProcessor for EventUtils.js r=smaug This implement a helper API to guess keyCode value of a printable key with assuming active keyboard layout is US-English. The reason why this stops computing key value from key value is, most users of such API probably want to emulate input from US-English keyboard layout if they don't specify the detail. Therefore, the new API simply maps each ASCII character to a DOM keyCode which is usually mapped in US-English keyboard layout. Differential Revision: https://phabricator.services.mozilla.com/D5515
fea8e039767a: Bug 1343955 - part 2: Implement _guessCodeFromKeyName() in EventUtils.js with C++ and make it accessible with nsITextInputProcessor for EventUtils.js r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 03 Oct 2018 09:21:47 +0000 - rev 495138
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1343955 - part 2: Implement _guessCodeFromKeyName() in EventUtils.js with C++ and make it accessible with nsITextInputProcessor for EventUtils.js r=smaug We need to port synthesizeKey() of EventUtils.js to FuzzingFunctions. So, its helper function, _guessCodeFromKeyName() in EventUtils.js needs to be accessible from FuzzingFunctions. Therefore, we need to reimplement it with C++ and make it accessible via nsITextInputProcessor for EventUtils.js for making easier to maintain. This patch moves _guessCodeFromKeyName() into TextInputProcessor and WidgetKeyboardEvent. Non-printable key part of _guessCodeFromKeyName() is moved to WidgetKeyboardEvent::ComputeCodeNameIndexFromKeyNameIndex() because of not depending on active keyboard layout. On the other hand, printable key part needs to assume that active keyboard layout is en-US keyboard layout. Therefore, it's moved to TextInputProcessor::GuessCodeValueOfPrintableKeyInUSEnglishKeyboardLayout() because any Core code shouldn't refer it as utility method for keeping that we're i18n-aware. Differential Revision: https://phabricator.services.mozilla.com/D5514
1a1ef374eba6: Bug 1343955 - part 1: Add automated tests for synthesizeKey() of EventUtils.js r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 02 Oct 2018 14:31:56 +0000 - rev 495137
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1343955 - part 1: Add automated tests for synthesizeKey() of EventUtils.js r=smaug For preventing regressions of the following patches, test_sanityEventUtils.html should have more tests of syntheiszeKey(). Differential Revision: https://phabricator.services.mozilla.com/D5513
f54d08819067: Bug 1343955 - part 0: Fix bug of browser_panel_keyboard_navigation.js r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 02 Oct 2018 14:21:11 +0000 - rev 495136
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1343955 - part 0: Fix bug of browser_panel_keyboard_navigation.js r=smaug browser_panel_keyboard_navigation.js sets "Tab" to first argument of EventUtils.synthesizeKey(). However, this causes inputting "T", "a", "b" with a key press. The test intended to emulate pressing the "Tab" key. So, it should be "KEY_Tab". Note that this will cause permanent orange with the following patches since synthesizeKey() will detect this kind of mistake. Differential Revision: https://phabricator.services.mozilla.com/D7412
fc316e011bb6: Bug 1322096 - Don't special-case rp in innerText. r=smaug
Simon Pieters <zcorpan@gmail.com> - Wed, 03 Oct 2018 12:20:32 +0000 - rev 495094
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1322096 - Don't special-case rp in innerText. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D7420
7da26bb326de: Bug 1322096 - Don't special-case rp in innerText. r=smaug
Simon Pieters <zcorpan@gmail.com> - Wed, 03 Oct 2018 08:12:08 +0000 - rev 495089
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1322096 - Don't special-case rp in innerText. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D7420
07184f24860b: Bug 1494127 - Fix trivial calls to do_QueryInterface that return an nsresult r=smaug
Andrew McCreight <continuation@gmail.com> - Mon, 01 Oct 2018 21:38:43 +0000 - rev 494941
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1494127 - Fix trivial calls to do_QueryInterface that return an nsresult r=smaug Calls to do_QueryInterface to a base class can be replaced by a static cast, which is faster. Differential Revision: https://phabricator.services.mozilla.com/D7224