searching for reviewer(smaug)
1879534289a4: Bug 1511138 - Fix / update tests. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:02:33 +0100 - rev 506128
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1511138 - Fix / update tests. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13550
7159c6b7e745: Bug 1511138 - Never return styles for disconnected elements. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:01:48 +0100 - rev 506127
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1511138 - Never return styles for disconnected elements. r=smaug https://drafts.csswg.org/cssom/#dom-window-getcomputedstyle says: > If elt is connected, part of the flat tree, and its shadow-including root... WebKit and Blink already do this, and we do it already except for cross-document situations, where we can end up with a PresShell even if GetPresShellForContent returns null. The style system should be able to rely on ShadowRoots having a non-null shadow host. Differential Revision: https://phabricator.services.mozilla.com/D13472
4ef293b90887: Bug 1511138 - Fix / update tests. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:02:33 +0100 - rev 506121
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1511138 - Fix / update tests. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13550
4df286b234b3: Bug 1511138 - Never return styles for disconnected elements. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:01:48 +0100 - rev 506120
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1511138 - Never return styles for disconnected elements. r=smaug https://drafts.csswg.org/cssom/#dom-window-getcomputedstyle says: > If elt is connected, part of the flat tree, and its shadow-including root... WebKit and Blink already do this, and we do it already except for cross-document situations, where we can end up with a PresShell even if GetPresShellForContent returns null. The style system should be able to rely on ShadowRoots having a non-null shadow host. Differential Revision: https://phabricator.services.mozilla.com/D13472
d2d3e7a822b5: Bug 1511138 - Fix / update tests. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:02:33 +0100 - rev 505988
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1511138 - Fix / update tests. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13550
e601a2fbd077: Bug 1511138 - Never return styles for disconnected elements. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 30 Nov 2018 18:01:48 +0100 - rev 505987
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1511138 - Never return styles for disconnected elements. r=smaug https://drafts.csswg.org/cssom/#dom-window-getcomputedstyle says: > If elt is connected, part of the flat tree, and its shadow-including root... WebKit and Blink already do this, and we do it already except for cross-document situations, where we can end up with a PresShell even if GetPresShellForContent returns null. The style system should be able to rely on ShadowRoots having a non-null shadow host. Differential Revision: https://phabricator.services.mozilla.com/D13472
dc7076b4b610: Bug 1511237 - Store a TabChild reference in cached docshells, r=bzbarsky, r=smaug
Nika Layzell <nika@thelayzells.com> - Thu, 29 Nov 2018 20:27:08 -0500 - rev 505912
Push 10301 by archaeopteryx@coole-files.de at Thu, 06 Dec 2018 16:36:14 +0000
Bug 1511237 - Store a TabChild reference in cached docshells, r=bzbarsky, r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13489
788d4d999843: Bug 1511237 - Store a TabChild reference in cached docshells, r=bzbarsky, r=smaug
Nika Layzell <nika@thelayzells.com> - Thu, 29 Nov 2018 20:27:08 -0500 - rev 505836
Push 10301 by archaeopteryx@coole-files.de at Thu, 06 Dec 2018 16:36:14 +0000
Bug 1511237 - Store a TabChild reference in cached docshells, r=bzbarsky, r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13489
cfb1a45b322e: Bug 1510985 - Remove Event.returnValue temporarily in 64. r=smaug a=jcristau on a CLOSED TREE FIREFOX_64b_RELBRANCH FENNEC_64_0b15_BUILD2 FENNEC_64_0b15_RELEASE
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Dec 2018 15:24:39 -0500 - rev 505666
Push 10294 by jcristau@mozilla.com at Mon, 03 Dec 2018 20:33:19 +0000
Bug 1510985 - Remove Event.returnValue temporarily in 64. r=smaug a=jcristau on a CLOSED TREE Event.returnValue causes breaking a bank application. The reason of the breakage is, the web app assumes that Event.returnValue is available only on IE and it hits same incompatibility issue with window.event (bug 1479964). Additionally, the app may be used in various domains including in intranet. Therefore, we cannot disable it with blacklist of domains like other similar changes. Fortunately, we can ship new keypress event behaviors which is tracked by bug 1479964 in 65. So, for backward compatibility with 62 or earlier, we should temporarily disable Event.returnValue in 64. But unfortunately, this was introduced in 63. So, if some web apps have started to use this legacy attribute, we need to contact their vendors, though.
71f7e3ce93e2: Bug 1510985 - Remove Event.returnValue temporarily in 64. r=smaug a=jcristau FIREFOX_64b_RELBRANCH
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Dec 2018 11:23:38 -0500 - rev 505656
Push 10292 by jcristau@mozilla.com at Mon, 03 Dec 2018 16:57:32 +0000
Bug 1510985 - Remove Event.returnValue temporarily in 64. r=smaug a=jcristau Event.returnValue causes breaking a bank application. The reason of the breakage is, the web app assumes that Event.returnValue is available only on IE and it hits same incompatibility issue with window.event (bug 1479964). Additionally, the app may be used in various domains including in intranet. Therefore, we cannot disable it with blacklist of domains like other similar changes. Fortunately, we can ship new keypress event behaviors which is tracked by bug 1479964 in 65. So, for backward compatibility with 62 or earlier, we should temporarily disable Event.returnValue in 64. But unfortunately, this was introduced in 63. So, if some web apps have started to use this legacy attribute, we need to contact their vendors, though.
870d4a920aed: Bug 1508310 - Implement Report-to header support - part 13 - Test for header in workers, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:10 +0100 - rev 505587
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 13 - Test for header in workers, r=smaug
77156cbacc33: Bug 1508310 - Implement Report-to header support - part 12 - Cleanup out-of-date endpoints, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:10 +0100 - rev 505586
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 12 - Cleanup out-of-date endpoints, r=smaug
ec7421212c22: Bug 1508310 - Implement Report-to header support - part 11 - Limit the number of reports, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:10 +0100 - rev 505585
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 11 - Limit the number of reports, r=smaug
1d09c38b173c: Bug 1508310 - Implement Report-to header support - part 10 - delivering tests, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:10 +0100 - rev 505584
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 10 - delivering tests, r=smaug
c0e1002895a6: Bug 1508310 - Implement Report-to header support - part 9 - cleanup tests, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:10 +0100 - rev 505583
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 9 - cleanup tests, r=smaug
33bb5a1368e8: Bug 1508310 - Implement Report-to header support - part 8 - ChromeUtils methods for testing, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:10 +0100 - rev 505582
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 8 - ChromeUtils methods for testing, r=smaug
696af9c24623: Bug 1508310 - Implement Report-to header support - part 7 - site-data cleanups endpoints, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:09 +0100 - rev 505581
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 7 - site-data cleanups endpoints, r=smaug
f2492c852777: Bug 1508310 - Implement Report-to header support - part 6 - Remove endpoints, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:09 +0100 - rev 505580
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 6 - Remove endpoints, r=smaug
a00225dfc414: Bug 1508310 - Implement Report-to header support - part 5 - Report delivering, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:09 +0100 - rev 505579
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 5 - Report delivering, r=smaug
ad2c155ce351: Bug 1508310 - Implement Report-to header support - part 4 - IPC to get endpoint from content process, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:09 +0100 - rev 505578
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 4 - IPC to get endpoint from content process, r=smaug
bbcbf470d213: Bug 1508310 - Implement Report-to header support - part 3 - JSON serialization of ReportBody, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:09 +0100 - rev 505577
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 3 - JSON serialization of ReportBody, r=smaug
b8e709a8076f: Bug 1508310 - Implement Report-to header support - part 2 - Header parser gtest, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:09 +0100 - rev 505576
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 2 - Header parser gtest, r=smaug
c435d7c0173e: Bug 1508310 - Implement Report-to header support - part 1 - Header parser, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 21:26:08 +0100 - rev 505575
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508310 - Implement Report-to header support - part 1 - Header parser, r=smaug
2f92fd614d56: Bug 1496288 - part 2: Stop dispatching non-printable "keypress" events, set keyCode or charCode value to the other value when it's zero, start to dispatch "keydown" and "keyup" events during composition, and enable window.event by default r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 29 Nov 2018 15:18:17 +0000 - rev 505320
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1496288 - part 2: Stop dispatching non-printable "keypress" events, set keyCode or charCode value to the other value when it's zero, start to dispatch "keydown" and "keyup" events during composition, and enable window.event by default r=smaug First one is for bug 968056. UI Events declares that "keypress" events should be dispatched only when a key press produces one or more characters (and also discussing about Enter key press for backward compatibility). Therefore, we should stop dispatching "keypress" events for non-printable keys (like arrow keys, Ctrl + A, etc) in the default group on content for conforming to UI Events, but keep dispatching them in chrome and in the system group on content. Next one is for bug 1479964. No spec declares that what value should be set to keyCode and charCode value of "keypress" events because declaring that would break existing web apps which handle them with UA string. However, some web apps assume that if window.event is available, keyCode value of "keypress" event is set to a Unicode code point of inputting character. We set only charCode to it, but the other browsers sets both keyCode and charCode to a Unicode code point of inputting character. Therefore, we need to follow the other browsers' behavior for this because changing value from zero to non-zero is safer than non-zero to non-zero or zero. And also next one is for bug 354358. UI Events declares that "keydown" and "keyup" events represent physical key state and should be fired even during composition. As far as the reported issues, this behavior is expected mainly by Korean web developers and some web apps depend on the behavior. Therefore, we need to start to dispatch them during composition. Finally, for bug 218415, we should enable window.event. This is declared by the Living DOM Standard. A lot of web apps depend on window.event and the last blocker, bug 1479964 was fixed so that it is the time to enable this. Differential Revision: https://phabricator.services.mozilla.com/D13376
f854c2a5429c: Bug 1496288 - part 1: Make blacklist prefs for keypress event behavior changes ride the train r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 29 Nov 2018 15:04:18 +0000 - rev 505319
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1496288 - part 1: Make blacklist prefs for keypress event behavior changes ride the train r=smaug Basically, we shouldn't have blacklist to disable web API. However, the keypress event behavior changes are not standardized things. Therefore, if some web developers realize that they need to change their apps when it's too late for them, Firefox users need to use another browser for such web apps for several weeks or more, and such things may make the users switch their default browser. For avoiding such worst scenario, we should take the blacklists and if we get such compatibility reports, we should add the domains into the blacklist even in release channel. Differential Revision: https://phabricator.services.mozilla.com/D13374
49b56d4d7faf: Bug 1510111 - Remove www.rememberthemilk.com from the blacklist of keyCode/charCode mirroring of keypress events r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 29 Nov 2018 21:32:27 +0000 - rev 505318
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510111 - Remove www.rememberthemilk.com from the blacklist of keyCode/charCode mirroring of keypress events r=smaug Remember The Milk have upgraded their Google Closure Library and the bug has gone now. Let's remove www.rememberthemilk.com from the blacklist. Differential Revision: https://phabricator.services.mozilla.com/D13373
531d30645f38: Bug 1509795 - Add UseCounter telemetry for Shadow DOM API; r=smaug
Edgar Chen <echen@mozilla.com> - Wed, 28 Nov 2018 15:11:38 +0000 - rev 505298
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509795 - Add UseCounter telemetry for Shadow DOM API; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13250
0a0c7f90e571: Bug 1498816 - part 1: Make nsFrameSelection::CommonPageMove() emulate click in current selection limiter r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 29 Nov 2018 06:16:15 +0000 - rev 505117
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1498816 - part 1: Make nsFrameSelection::CommonPageMove() emulate click in current selection limiter r=smaug nsFrameSelection::CommonPageMove() is called only by nsTextInputSelectionImpl::PageMove() and PresShell::PageMove(). So, this is the only implementation of (Shift+) PageDown and (Shift+) PageUp. This scrolls down/up the specific frame. However, this allows to scroll outside of selection limiter, for example, even when an editing host is focused, its parent scrollable element may be scrolled. This is same behavior as Blink so that we should keep this behavior. However, it also emulates to click same position after scroll and this behavior is different from Blink. At this time, it does not check selection limiter and then, nsFrameSelection::HandleClick() may reset selection limiter the scrolled frame is a parent frame of the limiter. Therefore, this patch makes it check if the scrolled frame is a parent of the limiter, and if so, use result of GetFrameToPageSelect() to emulate a click instead. The result won't be a parent of the limiter because it is used when handling Shift + PageDown and Shift + PageUp which are always handled in the limiter. Differential Revision: https://phabricator.services.mozilla.com/D13202
3ea2a2c78bf4: Bug 1498816 - part 0: Add automated tests of PageDown/PageUp key handling in an editing host r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 28 Nov 2018 11:04:09 +0000 - rev 505116
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1498816 - part 0: Add automated tests of PageDown/PageUp key handling in an editing host r=smaug Even if there is no scrollable element is in focused editing host, its parent scrollable element should be scrolled. However, focus shouldn't be moved and selection ranges should be kept in the editing host. Differential Revision: https://phabricator.services.mozilla.com/D13201
e5c59d7e5a55: Bug 1324788 - Bug 1324688 - Bring RTCIceCandidateStats up to spec r=mjf,jib,smaug
Nico Grunbaum <na-g@nostrum.com> - Wed, 28 Nov 2018 20:30:07 +0000 - rev 505034
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1324788 - Bug 1324688 - Bring RTCIceCandidateStats up to spec r=mjf,jib,smaug Bug 1324788 - P1 - rename RTCIceCandidate stat "portNumber" to spec "port" Bug 1324788 - P2 - update RTCIceCandidateStats candidateType enum to spec Bug 1324788 - P3 - add RTCIceCandidatePair.priority stat Bug 1324788 - P4 - update WebRTC ICE candidate stats field componentId to spec name transportId Bug 1324788 - P5 - remove deprecated RTCIceCandidateStats.mozLocalTransport field Bug 1324788 - P6 - update WebRTC ICE candidate stats field transport to spec name, protocol Bug 1324788 - P7 - remove deprecated RTCIceCandidateStats.candidateId Bug 1324788 - P8 - reorder RTCIceCandidateStats dictionary members to match the spec Bug 1324788 - P9 - make RTCIceCandidateStats.transportId ChromeOnly Differential Revision: https://phabricator.services.mozilla.com/D12953
e0e1a14b592f: Bug 1488993 - Fix PreallocatedProcessManager blocker management (v2). r=mconley,smaug
Jed Davis <jld@mozilla.com> - Wed, 28 Nov 2018 20:42:00 +0000 - rev 505018
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1488993 - Fix PreallocatedProcessManager blocker management (v2). r=mconley,smaug This fixes/adjusts two things about how content process preallocation is blocked: 1. Processes aren't registered as blockers until after they launch successfully. The main goal is to not leak a blocker if launch fails, but we don't need to block *while* launching synchronously, because this all happens on the main thread. 2. Preallocated processes themselves aren't blockers. The main goal here is so that async preallocation doesn't need extra complexity to avoid being blocked by itself when launch completes. This mostly doesn't affect actual behavior, because we currently support at most one preallocated process. The difference is the window from when the process is sent its first PBrowserConstructor until when it's next idle, where there is now no longer a blocker, but this seems to be relatively short (~100ms) and we don't even try to launch a new process until at least 1s + an idle runnable. This patch does not explicitly RemoveBlocker in ActorDestroy like the first attempt did, because it's unnecessary: this is handled in the ipc:content-shutdown observer. Differential Revision: https://phabricator.services.mozilla.com/D8939
8c72e35255c5: Bug 1509378 - Make test_input_number_mouse_events.html refer evt in checkInputEvent() rather than window.event r=smaug
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 28 Nov 2018 10:39:59 +0000 - rev 504980
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509378 - Make test_input_number_mouse_events.html refer evt in checkInputEvent() rather than window.event r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13226
cd922858805d: Bug 1507894 - Enable UA Widget in beta/release r=smaug
Timothy Guan-tin Chien <timdream@gmail.com> - Tue, 27 Nov 2018 21:00:07 +0000 - rev 504816
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507894 - Enable UA Widget in beta/release r=smaug Differential Revision: https://phabricator.services.mozilla.com/D13014
9fa6d8be9e01: Bug 1507209 - Don't fire 'onLoadError' if Firefox wouldn't show an error page r=smaug
James Willcox <snorp@snorp.net> - Thu, 15 Nov 2018 17:55:55 +0000 - rev 504768
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507209 - Don't fire 'onLoadError' if Firefox wouldn't show an error page r=smaug Differential Revision: https://phabricator.services.mozilla.com/D11911
851764905339: Bug 1509958, bug 1508734 - Give up on an assert that doesn't hold because of bug 1510208. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Nov 2018 13:12:44 +0000 - rev 504745
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509958, bug 1508734 - Give up on an assert that doesn't hold because of bug 1510208. r=smaug Can't land the test-case from bug 1510208 as a crashtest because it needs you to move the mouse around, and as such it doesn't crash in the crashtest harness. Differential Revision: https://phabricator.services.mozilla.com/D13054
07789ba4c3d7: Bug 1505887 - Fix FindChromeAccessOnlySubtreeOwner so that we handle UA widget being ChromeOnlyAccess root. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Nov 2018 22:28:56 +0100 - rev 504727
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505887 - Fix FindChromeAccessOnlySubtreeOwner so that we handle UA widget being ChromeOnlyAccess root. r=smaug A single video controls test crashed without this, while dereferencing a null anonOwnerRelated in: https://searchfox.org/mozilla-central/rev/c0b26c40769a1e5607a1ae8be37fe64df64fc55e/dom/base/FragmentOrElement.cpp#964 I think this is the right fix for it, but the code that uses this is kind of complex, so worth double-checking... :)
490a99122a7f: Bug 1505887 - Fix FindChromeAccessOnlySubtreeOwner so that we handle UA widget being ChromeOnlyAccess root. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Nov 2018 22:28:56 +0100 - rev 504715
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505887 - Fix FindChromeAccessOnlySubtreeOwner so that we handle UA widget being ChromeOnlyAccess root. r=smaug A single video controls test crashed without this, while dereferencing a null anonOwnerRelated in: https://searchfox.org/mozilla-central/rev/c0b26c40769a1e5607a1ae8be37fe64df64fc55e/dom/base/FragmentOrElement.cpp#964 I think this is the right fix for it, but the code that uses this is kind of complex, so worth double-checking... :)
8be20508c9d5: Bug 1288640 - Make TextComposition not dispatch eCompositionChange events (DOM "text" event) in the default group of web content r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 27 Nov 2018 13:26:51 +0000 - rev 504703
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1288640 - Make TextComposition not dispatch eCompositionChange events (DOM "text" event) in the default group of web content r=smaug The usage of our specific "text" event is enough low (0.0003%). So, let's stop dispatching the event in the default group of web content. Once we release this new behavior, we can get rid of dispatching the event even in chrome. Then, we can optimize the event order for new specs. Differential Revision: https://phabricator.services.mozilla.com/D13034
ce0cebad842b: Bug 1510081 - Remove docs.google.com from "dom.keyboardevent.keypress.hack.use_legacy_keycode_and_charcode" r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 27 Nov 2018 13:10:31 +0000 - rev 504701
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510081 - Remove docs.google.com from "dom.keyboardevent.keypress.hack.use_legacy_keycode_and_charcode" r=smaug It seems that Google Docs have already been fixed their bugs of mirroring keyCode and charCode values of our keypress events. Therefore, we should remove docs.google.com from the blacklist and collect new feedback from Nightly testers. Differential Revision: https://phabricator.services.mozilla.com/D13035
d61b59d39b4a: Bug 1509794 - Add UseCounter telemetry for Custom Elements API; r=smaug
Edgar Chen <echen@mozilla.com> - Mon, 26 Nov 2018 16:59:55 +0000 - rev 504646
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509794 - Add UseCounter telemetry for Custom Elements API; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D12886
cea43bc88c7a: Bug 1488993 - Fix PreallocatedProcessManager blocker management (v2). r=mconley,smaug
Jed Davis <jld@mozilla.com> - Thu, 22 Nov 2018 00:06:07 +0000 - rev 504599
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1488993 - Fix PreallocatedProcessManager blocker management (v2). r=mconley,smaug This fixes/adjusts two things about how content process preallocation is blocked: 1. Processes aren't registered as blockers until after they launch successfully. The main goal is to not leak a blocker if launch fails, but we don't need to block *while* launching synchronously, because this all happens on the main thread. 2. Preallocated processes themselves aren't blockers. The main goal here is so that async preallocation doesn't need extra complexity to avoid being blocked by itself when launch completes. This mostly doesn't affect actual behavior, because we currently support at most one preallocated process. The difference is the window from when the process is sent its first PBrowserConstructor until when it's next idle, where there is now no longer a blocker, but this seems to be relatively short (~100ms) and we don't even try to launch a new process until at least 1s + an idle runnable. This patch does not explicitly RemoveBlocker in ActorDestroy like the first attempt did, because it's unnecessary: this is handled in the ipc:content-shutdown observer. Differential Revision: https://phabricator.services.mozilla.com/D8939
1df9d08586c5: Bug 1509378 - Make test_input_event.html refer aEvent in checkIfInputIsEvent() rather than window.event r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Nov 2018 15:46:43 +0000 - rev 504585
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509378 - Make test_input_event.html refer aEvent in checkIfInputIsEvent() rather than window.event r=smaug This is an idiot mistake. It refers window.event accidentally and it's still disabled on Beta and Release channel. Therefore, we should make it refer aEvent instead. On the other hand, it might be better to make our lint check whether test refers window.event directly or not because it may check odd result accidentally. Differential Revision: https://phabricator.services.mozilla.com/D12870
2c4f0bf2be1c: Bug 1509872 - Fix the JavaScript error in 1017798-1.html that is introduced by bug 1416999; r=smaug
Edgar Chen <echen@mozilla.com> - Mon, 26 Nov 2018 21:27:06 +0000 - rev 504578
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509872 - Fix the JavaScript error in 1017798-1.html that is introduced by bug 1416999; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D12941
d3b2f0ffd271: Bug 1507604 - Remove nsPIDOMWindowInner::IsTopLevelWindowActive. r=smaug
Peter Van der Beken <peterv@propagandism.org> - Fri, 23 Nov 2018 15:33:11 +0000 - rev 504297
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507604 - Remove nsPIDOMWindowInner::IsTopLevelWindowActive. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D12141
8546188a9614: Bug 1507604 - Remove nsPIDOMWindowInner::GetPrivateRoot. r=smaug
Peter Van der Beken <peterv@propagandism.org> - Fri, 23 Nov 2018 15:39:54 +0000 - rev 504296
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507604 - Remove nsPIDOMWindowInner::GetPrivateRoot. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D12140
e5445a98098f: Bug 1507604 - Remove nsPIDOMWindowInner::GetAudioCaptured. r=smaug
Peter Van der Beken <peterv@propagandism.org> - Fri, 23 Nov 2018 15:31:39 +0000 - rev 504295
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507604 - Remove nsPIDOMWindowInner::GetAudioCaptured. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D12139
48d962c4e1ed: Bug 1507604 - Remove unused nsXMLNameSpaceMap. r=smaug
Peter Van der Beken <peterv@propagandism.org> - Fri, 23 Nov 2018 15:28:07 +0000 - rev 504294
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507604 - Remove unused nsXMLNameSpaceMap. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D12138
93bf8d17f265: Bug 1507604 - Remove unused GetSerial methods. r=smaug
Peter Van der Beken <peterv@propagandism.org> - Fri, 23 Nov 2018 15:14:23 +0000 - rev 504293
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507604 - Remove unused GetSerial methods. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D12137
61ae20a33f32: Bug 1507604 - Remove nsINetworkProperties. r=smaug
Peter Van der Beken <peterv@propagandism.org> - Fri, 23 Nov 2018 15:53:01 +0000 - rev 504292
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507604 - Remove nsINetworkProperties. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D12135
8c69ece51451: Bug 1507604 - Remove nsPIDOMWindowInner::SetOpenerWindow. r=smaug
Peter Van der Beken <peterv@propagandism.org> - Fri, 23 Nov 2018 15:17:01 +0000 - rev 504291
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507604 - Remove nsPIDOMWindowInner::SetOpenerWindow. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D12134