searching for reviewer(smacleod)
6c67c4f0bf30: Bug 1358540 - Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting. r=smacleod
Mark Banner <standard8@mozilla.com> - Fri, 21 Apr 2017 17:31:15 +0100 - rev 402871
Push 7391 by mtabara@mozilla.com at 2017-06-12 13:08 +0000
Bug 1358540 - Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting. r=smacleod MozReview-Commit-ID: 4KK2GZK7xul
eec770d062b4: Bug 1358540 - Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting. r=smacleod
Mark Banner <standard8@mozilla.com> - Fri, 21 Apr 2017 17:31:15 +0100 - rev 402857
Push 7391 by mtabara@mozilla.com at 2017-06-12 13:08 +0000
Bug 1358540 - Change the *.lint files to be *.lint.py to better support editor integration & flake8 linting. r=smacleod MozReview-Commit-ID: 4KK2GZK7xul
1ea8f04d9266: Bug 1340162 - Add task for running mozlint unitttests on Linux (and pull old tests out of make check), r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 02 Feb 2017 11:08:41 -0500 - rev 390304
Push 7198 by jlorenzo@mozilla.com at 2017-04-18 12:07 +0000
Bug 1340162 - Add task for running mozlint unitttests on Linux (and pull old tests out of make check), r=smacleod MozReview-Commit-ID: 3XCWMJtQMvZ
43556298f164: Bug 1318488 - [mozlint] Use sys.stdout.encoding when printing formatter's output, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 17 Nov 2016 17:36:34 -0500 - rev 368618
Push 6996 by jlorenzo@mozilla.com at 2017-03-06 20:48 +0000
Bug 1318488 - [mozlint] Use sys.stdout.encoding when printing formatter's output, r=smacleod This fixes a UnicodeDecodeError when sys.stdout's encoding can't handle unicode. MozReview-Commit-ID: 3INna8MRje5
68d9ee399317: Bug 1300779 - [mozlint] Redirect stderr when detecting version control root, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 06 Sep 2016 10:36:45 -0400 - rev 354283
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1300779 - [mozlint] Redirect stderr when detecting version control root, r=smacleod This avoids printing harmless (but confusing) errors to the log. For instance, git users will see a '.hg not found!' error in the output even though not finding an hg repo is expected in that case. MozReview-Commit-ID: DBPOabcV7PA
eeba75f09439: Bug 1299618 - [mozlint] Encode results to utf-8 before printing to stdout, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 31 Aug 2016 17:18:52 -0400 - rev 353611
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1299618 - [mozlint] Encode results to utf-8 before printing to stdout, r=smacleod MozReview-Commit-ID: 93RAqIRKAHc
737088027e68: Bug 1299540 - Fix WindowsError when running eslint from msys, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 31 Aug 2016 14:32:44 -0400 - rev 353554
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1299540 - Fix WindowsError when running eslint from msys, r=smacleod This fixes a regression from bug 1258341 where the eslint binary no longer gets run from a shell on msys. Without this, a WindowsError [Error 139] is thrown. MozReview-Commit-ID: FQ3LhTzd8nL
a2518f96d221: Bug 1258341 - Rewrite eslint taskcluster task to use |mach lint| instead of |mach eslint|, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 25 Aug 2016 10:00:51 -0400 - rev 353276
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1258341 - Rewrite eslint taskcluster task to use |mach lint| instead of |mach eslint|, r=smacleod This also renames the tasks: eslint-gecko -> mozlint-eslint flake8-gecko -> mozlint-flake8 MozReview-Commit-ID: KYhC6SEySC3
f5c7a3d60bd9: Bug 1258341 - Modify 'eslint' implementation to work with the mozlint framework, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 30 Aug 2016 14:28:56 -0400 - rev 353275
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1258341 - Modify 'eslint' implementation to work with the mozlint framework, r=smacleod This integrates 'eslint' with the mozlint framework. The old |mach eslint| command is kept around for backwards compatibility and will simply dispatch to |mach lint|. But |mach lint| should be preferred as the old command may eventually be removed. The old |mach eslint| command should be mostly backwards compatible with a few exceptions: 1. Can no longer define --extensions on the command line, this is instead hardcoded into eslint.lint. 2. No longer using eslint formatters. However, the default mozlint formatter should be identical to the default eslint formatter, so developers should not notice a change. This does mean that non-default eslint formatters can no longer be used unless a mozlint copy of them is created. 3. Installs dependencies automatically without prompting the user. This was necessary due to python multiprocessing limitations, but is actually also a better UX. Because the npm dependencies aren't global anymore, there isn't really any reason *not* to install them automatically. Apart from that, any difference from the old |mach eslint| I'd consider a bug. The main eslint implementation now lives in tools/lint/eslint.lint instead of tools/lint/mach_commands.py. MozReview-Commit-ID: KYhC6SEySC3
64ed3dc696df: Bug 1258341 - [mozlint] Add ability to forward miscellaneous command line arguments to the underlying linter, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 25 Aug 2016 09:52:50 -0400 - rev 353274
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1258341 - [mozlint] Add ability to forward miscellaneous command line arguments to the underlying linter, r=smacleod This is mostly to maintain backwards compatibility with the |mach eslint| command. But it's also going to be used in automation. The 'mozlint-eslint' task will need to pass in --quiet to eslint. Maybe in the future we should remove this ability and only allow well-defined arguments in mozlint. But for now it's convenient and allows us to land the eslint->mozlint patch series quicker. MozReview-Commit-ID: KYhC6SEySC3
d1e75d7e9889: Bug 1297699 - Mozlint tests should run with test directory as the "project root", r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 24 Aug 2016 09:55:04 -0400 - rev 352169
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1297699 - Mozlint tests should run with test directory as the "project root", r=smacleod MozReview-Commit-ID: 9sbhlc11YF5
23e3bb6e8e93: Bug 1288425 - Make sure we skip invalid extensions when linting with --rev or --workdir, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 09 Aug 2016 16:24:04 -0400 - rev 351896
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1288425 - Make sure we skip invalid extensions when linting with --rev or --workdir, r=smacleod Some linters, such as flake8, will lint invalid file extensions if you explicitly pass them in. E.g, |flake8 foobar.js| will result in flake8 attempting to lint a JS file. This is a problem because passing in files explicitly is exactly what the --rev/--workdir options do. If a developer modifies a JS file then runs |mach lint -l flake8 -w|, that JS file will get linted. To prevent this, mozlint needs to handle file extensions instead of relying on the underlying linter to do it. This patch adds an "extensions" config option to the LINTER dict, and will filter these files out as part of the 'filterpaths' steps. MozReview-Commit-ID: KYhC6SEySC3
ee76e6c52088: Bug 1289805 - Properly normalize all paths so they are absolute, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 19 Jul 2016 13:09:38 -0400 - rev 351169
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1289805 - Properly normalize all paths so they are absolute, r=smacleod It's important to use absolute paths so lint errors for the same files don't show up in two different places. For example, eslint will absolutize a relative path, whereas flake8 will not. This patch also makes sure all include/exclude paths are joined to the mozlint 'root' that was previously calculated from vcs. MozReview-Commit-ID: KYhC6SEySC3
f01fdb750198: Bug 1289805 - Resolve vcs arguments directly in LintRoller class, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 10 Aug 2016 10:21:43 -0400 - rev 351168
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1289805 - Resolve vcs arguments directly in LintRoller class, r=smacleod Previously, vcs related stuff was resolved in the cli.py module. But it's possible for consumers to bypass the cli and instantiate a LintRoller directly. In fact this is what the mozlint tests do. Now that we always try to find the vcs root, calling into vcs is no longer optional. This patch moves the VCSFiles class to a new vcs.py module and makes LintRoller responsible for instantiating it instead of cli.py. MozReview-Commit-ID: 5yA3gDZ1UGM
5e14767aa060: Bug 1289805 - Ensure the VCSFiles class returns paths that have been absolutized to the repository root, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 09 Aug 2016 14:49:41 -0400 - rev 351167
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1289805 - Ensure the VCSFiles class returns paths that have been absolutized to the repository root, r=smacleod This makes sure we return absolute paths from the VCSFiles class. This is done so we don't accidentally normalize the relative paths onto $CWD in the event the relative path is valid in both places. MozReview-Commit-ID: 2QIuR2YqFos
fff9177fcfe4: Bug 1289805 - Refactor filterpaths to accept all lintargs, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 09 Aug 2016 15:29:49 -0400 - rev 351166
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1289805 - Refactor filterpaths to accept all lintargs, r=smacleod This makes it easier to pass configuration to the filterpaths method. In the future, 'root' and 'extensions' will both be used here. MozReview-Commit-ID: KYhC6SEySC3
98876f70367e: Bug 1289805 - Don't pass in --exclude to flake8 paths that contain custom configuration, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 09 Aug 2016 16:28:13 -0400 - rev 351165
Push 6570 by raliiev@mozilla.com at 2016-11-14 12:26 +0000
Bug 1289805 - Don't pass in --exclude to flake8 paths that contain custom configuration, r=smacleod This fixes a bug in flake8, where if you pass in --exclude to a path with a custom .flake8 file, that configuration will be ignored. I'm not sure why this happens. Prior to this commit series, the 'exclude' paths weren't being passed on to the flake8 linter properly. This is why the problems hasn't surfaced until now. This is a band-aid fix until a proper (likely upstream) fix can be landed. MozReview-Commit-ID: KYhC6SEySC3
2141360b4137: Bug 1288425 - Make sure we skip invalid extensions when linting with --rev or --workdir, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 19 Jul 2016 13:50:25 -0400 - rev 346779
Push 6389 by raliiev@mozilla.com at 2016-09-19 13:38 +0000
Bug 1288425 - Make sure we skip invalid extensions when linting with --rev or --workdir, r=smacleod Some linters, such as flake8, will lint invalid file extensions if you explicitly pass them in. E.g, |flake8 foobar.js| will result in flake8 attempting to lint a JS file. This is a problem because passing in files explicitly is exactly what the --rev/--workdir options do. If a developer modifies a JS file then runs |mach lint -l flake8 -w|, that JS file will get linted. To prevent this, mozlint needs to handle file extensions instead of relying on the underlying linter to do it. This patch adds an "extensions" config option to the LINTER dict, and will filter these files out as part of the 'filterpaths' steps. MozReview-Commit-ID: KYhC6SEySC3
81925c21719e: Bug 1287834 - [mozlint] Fix regression preventing specific linters from being run, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 19 Jul 2016 11:50:33 -0400 - rev 345550
Push 6389 by raliiev@mozilla.com at 2016-09-19 13:38 +0000
Bug 1287834 - [mozlint] Fix regression preventing specific linters from being run, r=smacleod MozReview-Commit-ID: KYhC6SEySC3
6984d7cf65bb: Bug 1281899 - [mozlint] Add ability to lint files touched by revisions and/or the working directory, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 24 Jun 2016 14:09:58 -0400 - rev 343852
Push 6389 by raliiev@mozilla.com at 2016-09-19 13:38 +0000
Bug 1281899 - [mozlint] Add ability to lint files touched by revisions and/or the working directory, r=smacleod This adds two parameters, --rev and --workdir. Each works both with mercurial and git (though the syntax for specifying revisions is different between them). The value is simply forwarded to either |hg log| or |git diff| so syntax like |mach lint -r .~4::.| or |mach lint -r "HEAD~4 HEAD"| will work as expected. MozReview-Commit-ID: aOGp2Yrncs
eaaff060e865: Bug 1281899 - [mozlint] Create cli module and move logic from tools/lint/mach_commands.py there, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 24 Jun 2016 14:06:22 -0400 - rev 343851
Push 6389 by raliiev@mozilla.com at 2016-09-19 13:38 +0000
Bug 1281899 - [mozlint] Create cli module and move logic from tools/lint/mach_commands.py there, r=smacleod There is currently no built-in user interface to mozlint. The only existing interface is the external cli provided by |mach lint|. However, in the future mozlint may need to be used in a context where mach isn't readily available (i.e version-control-tools). This patch basically just moves the cli logic out of mach_commands.py, and into mozlint core. That way it can be re-used in other places without needing to be re-implemented. The |mach lint setup| subcommand was removed because apparently subcommands don't work with the parser attribute. Nothing was using it yet anyway, so I removed it for now. It may get re-added in some form in the future. MozReview-Commit-ID: aOGp2Yrncs
259c39227fd6: Bug 1277641 - [mozlint] Add --no-filter option to make experimenting locally easier, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 02 Jun 2016 15:14:07 -0400 - rev 341611
Push 6389 by raliiev@mozilla.com at 2016-09-19 13:38 +0000
Bug 1277641 - [mozlint] Add --no-filter option to make experimenting locally easier, r=smacleod This makes it easier to lint a path that otherwise wouldn't have been linted due to the include/exclude directives. Now, you can pass in -n/--no-filter instead of needing to modify the linter configuration file. MozReview-Commit-ID: GMJuE2C1NyY
74e536857786: Bug 1267781 - Bump minimum Mercurial version on a number of extensions; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 26 Apr 2016 12:14:40 -0700 - rev 338047
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1267781 - Bump minimum Mercurial version on a number of extensions; r=smacleod Our policy is to support the last 4 releases of Mercurial. 3.8 is out. So we bump the minimum version to 3.5. MozReview-Commit-ID: 9cftV7CscRL
f3c508b62921: Bug 1267781 - Bump modern Mercurial version to 3.7.3; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 26 Apr 2016 12:11:29 -0700 - rev 338046
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1267781 - Bump modern Mercurial version to 3.7.3; r=smacleod These variables specify a version of Mercurial that is considered modern and won't trigger giant warnings about being out of date. We bump to 3.7.3 because 3.7.3 contains security fixes and it is important for as many users as possible to get these security fixes. We also update the messaging to indicate security issues with older releases. MozReview-Commit-ID: H4utKINrW0V
a3a5b2614b5d: Bug 1275105 - Remove references to MQ from `mach mercurial-setup`; r=smacleod
Gregory Szorc <gps@mozilla.com> - Mon, 23 May 2016 14:24:14 -0700 - rev 338025
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1275105 - Remove references to MQ from `mach mercurial-setup`; r=smacleod MQ isn't recommended for modern Mercurial development. Stop advertising it. MozReview-Commit-ID: IOx3A5ZeJnJ
971d076cfe29: Bug 1270506 - [mozlint] Add python flake8 linter, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 05 May 2016 17:21:12 -0400 - rev 336654
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1270506 - [mozlint] Add python flake8 linter, r=smacleod For now, only the following two directories will be linted: python/mozlint tools/lint New directories can be added by adding them to the 'include' directive in tools/lint/flake8.lint. They all default to the configuration specified in topsrcdir/.flake8. Subdirectories can override this configuration by creating their own .flake8 file. MozReview-Commit-ID: Eag48Lnkp3l
a2d21e14d40c: Bug 1270506 - [mozlint] Refactor the include/exclude path filtering algorithm, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 05 May 2016 17:20:33 -0400 - rev 336653
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1270506 - [mozlint] Refactor the include/exclude path filtering algorithm, r=smacleod The current algorithm for filtering down tests is too naive. For example, given the following directory structured: parent - foo - bar - baz And the following include/exclude directives: include = ['foo'] exclude = ['foo/bar'] Then running ./mach lint parent and ./mach lint foo/baz should both lint all files in baz but no files in bar. This provides a nice way to include/exclude directories, while allowing the underlying linters to find appropriate files to lint *within* those directories. tl;dr - Straight file paths (no globs) will be passed straight to the underlying linter as is. While paths with globs will first be resolved to a list of matching file paths. MozReview-Commit-ID: Eag48Lnkp3l
b8c6b6769bf6: Bug 1230962 - Create mach/build system integration for mozlint, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Fri, 18 Mar 2016 13:54:07 -0400 - rev 335259
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1230962 - Create mach/build system integration for mozlint, r=smacleod MozReview-Commit-ID: 74ma5uMOphe
6b825d526501: Bug 1230962 - Add python/mozlint for running several linters at once, r=smacleod
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 16 Mar 2016 14:55:21 -0400 - rev 335258
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1230962 - Add python/mozlint for running several linters at once, r=smacleod Mozlint provides two main benefits: 1. A common system for defining lints across multiple languages 2. A common interface and result format for running them This commit only adds the core library, it does not add any consumers of mozlint just yet. MozReview-Commit-ID: CSQzq5del5k
018829387025: Bug 1268573 - Pin revision in hgwatchman repo; r=smacleod
Gregory Szorc <gps@mozilla.com> - Thu, 28 Apr 2016 10:20:25 -0700 - rev 334332
Push 6249 by jlund@mozilla.com at 2016-08-01 13:59 +0000
Bug 1268573 - Pin revision in hgwatchman repo; r=smacleod Per https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-April/083649.html the hgwatchman repo has been blanked. We should pin to the last changeset before the blanking so people can still run hgwatchman. We'll also need to teach `mach mercurial-setup` to install the fsnotifier extension. That's for a different patch and bug. DONTBUILD (NPOTB) MozReview-Commit-ID: GyuDMTwARqo
b75960b9d195: Bug 1132556 - Replace runInContent() with ContentTask.spawn(). r=smacleod
AJ Kerrigan <ajkerrigan@computer.org> - Thu, 07 Jan 2016 03:26:31 -0500 - rev 314424
Push 5703 by raliiev@mozilla.com at 2016-03-07 14:18 +0000
Bug 1132556 - Replace runInContent() with ContentTask.spawn(). r=smacleod
093210ae72ec: Bug 1231192 - Only install host fingerprints if not running secure Python+hg; r=smacleod
Gregory Szorc <gps@mozilla.com> - Mon, 07 Dec 2015 13:15:24 -0800 - rev 310129
Push 5513 by raliiev@mozilla.com at 2016-01-25 13:55 +0000
Bug 1231192 - Only install host fingerprints if not running secure Python+hg; r=smacleod See inline comment.
4b0aa51b8b60: Bug 1231192 - Offer to install `hg wip`; r=smacleod
Gregory Szorc <gps@mozilla.com> - Mon, 07 Dec 2015 13:22:49 -0800 - rev 310128
Push 5513 by raliiev@mozilla.com at 2016-01-25 13:55 +0000
Bug 1231192 - Offer to install `hg wip`; r=smacleod
6791163296c1: Bug 1231192 - Support clonebundles feature; r=smacleod
Gregory Szorc <gps@mozilla.com> - Mon, 07 Dec 2015 13:03:17 -0800 - rev 310127
Push 5513 by raliiev@mozilla.com at 2016-01-25 13:55 +0000
Bug 1231192 - Support clonebundles feature; r=smacleod bundleclone is the Mozilla-specific precursor to the "clonebundles" feature in Mercurial 3.6. Change the wizard to recognize when clonebundles is available and to favor it. Activating clonebundles will also disable bundleclone, as bundleclone is redundant with clonebundles. (If both are enabled, bundleclone detects this and gets out of the way.)
f70eb7c9c9f1: Bug 1231192 - Bump some minimum Mercurial version; r=smacleod
Gregory Szorc <gps@mozilla.com> - Mon, 07 Dec 2015 12:23:56 -0800 - rev 310126
Push 5513 by raliiev@mozilla.com at 2016-01-25 13:55 +0000
Bug 1231192 - Bump some minimum Mercurial version; r=smacleod We only support the last 4 releases of Mercurial. 3.6 is out, which means we only support down to 3.3.
60f724e4f82d: Bug 1231192 - Mark Mercurial 3.5.2 as oldest non-legacy version; r=smacleod
Gregory Szorc <gps@mozilla.com> - Mon, 07 Dec 2015 12:20:50 -0800 - rev 310125
Push 5513 by raliiev@mozilla.com at 2016-01-25 13:55 +0000
Bug 1231192 - Mark Mercurial 3.5.2 as oldest non-legacy version; r=smacleod Main reason for recommending 3.5 is bundle2. The protocol is faster and we can do things like put extra data in the server exchange. It also enables generaldelta to be exchanged without pain. And of course there are tons of performance improvements and bug fixes.
9c23f4fdd401: Bug 1200461 - Prompt for Bugzilla API Key instead of password; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 15 Sep 2015 15:57:40 -0700 - rev 295298
Push 5245 by raliiev@mozilla.com at 2015-10-29 11:30 +0000
Bug 1200461 - Prompt for Bugzilla API Key instead of password; r=smacleod All extensions in version-control-tools should support Bugzilla API Keys now. MozReview requires them. We'll likely remove support for passwords and cookie auth in the future. This commit transitions the Mercurial setup wizard to API Keys exclusively. DONTBUILD (NPOTB)
87c2a6949c17: Bug 1190525 - Print path to mach; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 18 Aug 2015 17:04:57 -0700 - rev 290907
Push 5245 by raliiev@mozilla.com at 2015-10-29 11:30 +0000
Bug 1190525 - Print path to mach; r=smacleod
4beff7208d94: Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r=smacleod
Gregory Szorc <gps@mozilla.com> - Mon, 27 Jul 2015 13:44:39 -0700 - rev 286479
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1184229 - Detect multiple version-control-tools repos in Mercurial config; r=smacleod Having multiple version-control-tools repositories references in your hgrc could lead to one repository importing code from another, depending on how sys.path modification works from version-control-tools repositories. Detect it and issue a warning.
65cbcf817e98: Bug 1185557 - Print relevant config options; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 21 Jul 2015 10:11:09 -0700 - rev 285619
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1185557 - Print relevant config options; r=smacleod Users may want to know what the wizard is changing before they answer prompts. Add the names of impacted config options to messages so people can make more informed decisions.
6de7988b45c4: Bug 1185557 - Prompt about bzexport after reviewboard; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 21 Jul 2015 10:10:54 -0700 - rev 285618
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1185557 - Prompt about bzexport after reviewboard; r=smacleod We want to encourage people to use reviewboard over bzexport.
819fa1eb6e6d: Bug 1185557 - Only prompt to install progress on Mercurial <3.5; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 21 Jul 2015 10:10:38 -0700 - rev 285617
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1185557 - Only prompt to install progress on Mercurial <3.5; r=smacleod Progress is enabled by default in Mercurial 3.5. extensions.progress no-ops. Don't prompt for it on newer Mercurial versions.
136d1ba3e828: Bug 1185557 - Clarify that `mach mercurial-setup` doesn't make changes without prompting; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 21 Jul 2015 10:10:22 -0700 - rev 285616
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1185557 - Clarify that `mach mercurial-setup` doesn't make changes without prompting; r=smacleod It's been clear from user feedback that people don't realize that `mach mercurial-setup` doesn't make any changes unless they tell it to. Reinforce this message in the prompts printed by mach_boostrap.py.
e8b16203fdb2: Bug 1185562 - Print message saying the mercurial-setup failures unblock mach; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 21 Jul 2015 10:09:49 -0700 - rev 285615
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1185562 - Print message saying the mercurial-setup failures unblock mach; r=smacleod The messaging on this could be bikeshedded. Something is better than nothing, that's for sure.
617fdd373154: Bug 1185112 - Don't prompt for Bugzilla username/password if cookies defined; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 21 Jul 2015 10:09:15 -0700 - rev 285614
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1185112 - Don't prompt for Bugzilla username/password if cookies defined; r=smacleod Before, we prompted for Bugzila username/password if the hgrc contained credentials in cookie form. Don't do that.
0f6e5f117e03: Bug 1185113 - Support setting more secure file permissions; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 21 Jul 2015 10:08:24 -0700 - rev 285613
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1185113 - Support setting more secure file permissions; r=smacleod ~/.hgrc files are likely created with the user's default umask, which commonly gives default permissions of 644. If the hgrc config contains sensitive information (such as Bugzilla credentials), these file permissions could result in others stealing sensitive data. Detect when the group and other file mode bits are set and prompt to remove these permissions.
6b3d31c8610b: Bug 1185113 - Clarify language around Bugzilla credentials; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 21 Jul 2015 10:08:02 -0700 - rev 285612
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1185113 - Clarify language around Bugzilla credentials; r=smacleod Bugzilla credentials are optional. Make this more obvious by adding "optional" to the prompt. Bugzilla credentials are stored in plain text. Explicitly call this out in the help text so users can make informed decisions about whether to capture the credentials.
5db9b72d15c2: Bug 1184030 - Avoid implicit unicode <-> str conversion; r=smacleod
Gregory Szorc <gps@mozilla.com> - Fri, 17 Jul 2015 11:25:49 -0700 - rev 285132
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1184030 - Avoid implicit unicode <-> str conversion; r=smacleod CalledProcessError.output and subprocess.check_output's return value are str types. This file uses unicode_literals. If we do something like `if 'foo' in e.output`, there will be a mix of str and unicode types and Python will do implicit conversion. If the strings aren't ASCII, we'll likely encounter a UnicodeDecodeError. Use b'' literals around all strings to prevent this coercion from occurring.
07e78b13095d: Bug 1178955 - Print line number for parse errors; r=smacleod
Gregory Szorc <gps@mozilla.com> - Fri, 17 Jul 2015 10:29:22 -0700 - rev 285131
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1178955 - Print line number for parse errors; r=smacleod It helps users debug problems.
4bb683c801a3: Bug 1178955 - Error when semicolon comments are seen; r=smacleod
Gregory Szorc <gps@mozilla.com> - Fri, 17 Jul 2015 10:29:09 -0700 - rev 285130
Push 5067 by raliiev@mozilla.com at 2015-09-21 14:04 +0000
Bug 1178955 - Error when semicolon comments are seen; r=smacleod configobj doesn't support semicolon comments. Why, I don't know, since they are pretty common in ini files. Do a static check for semicolon comments and print a more actionable error message.