searching for reviewer(robcee)
a18bcb21d735f295b2079d8d6fe9086892459f75: Bug 1005870 - Adding a copy() command to the console;r=robcee
David Rajchenbach-Teller <dteller@mozilla.com> - Wed, 04 Feb 2015 18:53:40 -0800 - rev 254685
Push 4610 by jlund@mozilla.com at Mon, 30 Mar 2015 18:32:55 +0000
Bug 1005870 - Adding a copy() command to the console;r=robcee
fada58fb0996a728440726b41ec8b7918a799e58: Bug 1001090 - Part 5: Fix errors in tests throughout the tree. (r=robcee,gavin)
Shu-yu Guo <shu@rfrn.org> - Mon, 15 Sep 2014 16:30:47 -0700 - rev 228629
Push 4187 by bhearsum@mozilla.com at Fri, 28 Nov 2014 15:29:12 +0000
Bug 1001090 - Part 5: Fix errors in tests throughout the tree. (r=robcee,gavin)
cd997ef8a2adf1b4960bfd7ea6f186d4d2d5cc38: Bug 1050654: Replace "flex: 0 0 main-size" with equivalent & more concise "none" keyword, in webconsole.inc.css. r=robcee
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 14 Aug 2014 10:38:38 -0700 - rev 221185
Push 3979 by raliiev@mozilla.com at Mon, 13 Oct 2014 16:35:44 +0000
Bug 1050654: Replace "flex: 0 0 main-size" with equivalent & more concise "none" keyword, in webconsole.inc.css. r=robcee
f0e6f82eefd0dcbedbc30c483835ade1d609f5d5: Bug 967044 - Make Home and End keys scroll console output area and autocomplete popup. r=robcee
Veeti Paananen <veeti.paananen@rojekti.fi> - Wed, 16 Jul 2014 22:15:03 +0300 - rev 218113
Push 3979 by raliiev@mozilla.com at Mon, 13 Oct 2014 16:35:44 +0000
Bug 967044 - Make Home and End keys scroll console output area and autocomplete popup. r=robcee
01d60712d7a44eb4c7a9b28a87b1e056ae58b97f: Ensure that the debugger client doesn't try to call a callback, when one is not provided (bug 1042761). r=robcee
Panos Astithas <past@mozilla.com> - Wed, 23 Jul 2014 19:42:16 +0300 - rev 217388
Push 3979 by raliiev@mozilla.com at Mon, 13 Oct 2014 16:35:44 +0000
Ensure that the debugger client doesn't try to call a callback, when one is not provided (bug 1042761). r=robcee
1006faf779585133ee80643e634387e2783dbb15: Bug 1035198 - VariablesView: handle instances of nsIDOMNode.DOCUMENT_NODE without URLs properly. r=robcee
Sami Jaktholm <sjakthol@outlook.com> - Sat, 19 Jul 2014 00:17:00 +0200 - rev 217035
Push 3979 by raliiev@mozilla.com at Mon, 13 Oct 2014 16:35:44 +0000
Bug 1035198 - VariablesView: handle instances of nsIDOMNode.DOCUMENT_NODE without URLs properly. r=robcee
cebc0f24e83973a8232422e6c8d6d74a41a55acc: Properly handle unsupported value types in the console (bug 1039686). r=robcee
Panos Astithas <past@mozilla.com> - Mon, 21 Jul 2014 16:06:02 +0300 - rev 216940
Push 3979 by raliiev@mozilla.com at Mon, 13 Oct 2014 16:35:44 +0000
Properly handle unsupported value types in the console (bug 1039686). r=robcee
b452f0ac8a41b8241c8c428eb55679ece48f8680: Bug 1039686 - Properly handle unsupported value types in the console. r=robcee, a=sledru
Panos Astithas <past@mozilla.com> - Mon, 21 Jul 2014 16:06:02 +0300 - rev 216116
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 1039686 - Properly handle unsupported value types in the console. r=robcee, a=sledru
d12fab26162e00015f627b2a8212ea2a7308ce0c: Bug 1039457 - Allow yelling in Scratchpad (Shift-Space). r=robcee
J. Ryan Stinnett <jryans@gmail.com> - Wed, 16 Jul 2014 07:11:00 +0200 - rev 215404
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 1039457 - Allow yelling in Scratchpad (Shift-Space). r=robcee
85aa99c0b4b7e94de78d0bf8d9b1c147cfcd6a46: Bug 977273 - Set aria-pressed state on Console filter buttons. r=robcee f=marcoz
Athena <athena@fastmail.fm> - Mon, 07 Jul 2014 19:55:00 +0200 - rev 213604
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 977273 - Set aria-pressed state on Console filter buttons. r=robcee f=marcoz
161b47c4a8adca4040222460eb01b8a020ce1932: Bug 1005870 - Adding a copy() command to the console. r=robcee
David Rajchenbach-Teller <dteller@mozilla.com> - Fri, 04 Jul 2014 08:10:00 +0200 - rev 213398
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 1005870 - Adding a copy() command to the console. r=robcee
f007a1c34042d1c0b14500b25adc5544677c6e54: Bug 1005870 - Add a copy() command to the console. r=robcee
David Rajchenbach-Teller <dteller@mozilla.com> - Thu, 03 Jul 2014 06:40:00 -0400 - rev 213098
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 1005870 - Add a copy() command to the console. r=robcee
ef6fcda84ce40a1c61a61166c1a76e63a52b97ff: Bug 1003761 - Fix clicking on shortcuts in GCLI output. r=robcee
Joe Walker <jwalker@mozilla.com> - Fri, 27 Jun 2014 11:44:00 +0200 - rev 212940
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 1003761 - Fix clicking on shortcuts in GCLI output. r=robcee
24d194587ab58506b7a818ee173fe14366b93798: Bug 999236 - Webconsole - Ensure anchors with a URL have a click callback defined. r=robcee
Sami Jaktholm <sjakthol@outlook.com> - Thu, 01 May 2014 10:06:00 -0400 - rev 211970
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 999236 - Webconsole - Ensure anchors with a URL have a click callback defined. r=robcee
759429576b4baa003eb6080526d9987af53a8c47: Bug 967468 - Webconsole - autocompletion: Consider underscore and dollar as alphanumeric when determining a prefix filter to use. r=robcee
Sami Jaktholm <sjakthol@outlook.com> - Fri, 09 May 2014 09:15:00 -0400 - rev 211948
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 967468 - Webconsole - autocompletion: Consider underscore and dollar as alphanumeric when determining a prefix filter to use. r=robcee
55b0aa2da501b7999b09e168f203cad29f7233ca: Bug 1026811 - Update to CodeMirror 4.2.0. r=robcee
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 19 Jun 2014 06:56:00 -0400 - rev 210980
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 1026811 - Update to CodeMirror 4.2.0. r=robcee
03aa92ba77e30adfad9f157d5823a7d361346097: Bug 998344 - Console input is slow when accessing large Uint8Array object properties. r=robcee
Brian Grinstead <bgrinstead@mozilla.com> - Thu, 15 May 2014 12:07:00 -0400 - rev 202761
Push 3741 by asasaki@mozilla.com at Mon, 21 Jul 2014 20:25:18 +0000
Bug 998344 - Console input is slow when accessing large Uint8Array object properties. r=robcee
b8533fbcc8116d7bf6888756961d979d2d5158aa: Bug 1007383 - Include asm.js frames in JS::DescribeStack (r=jandem,robcee)
Luke Wagner <luke@mozilla.com> - Thu, 15 May 2014 12:30:45 -0500 - rev 202619
Push 3741 by asasaki@mozilla.com at Mon, 21 Jul 2014 20:25:18 +0000
Bug 1007383 - Include asm.js frames in JS::DescribeStack (r=jandem,robcee)
ce34c13388f2e45d763ad017b757d4ce965bd93f: Bug 1007383 - Include asm.js frames in JS::DescribeStack (r=jandem,robcee)
Luke Wagner <luke@mozilla.com> - Thu, 15 May 2014 12:30:45 -0500 - rev 202615
Push 3741 by asasaki@mozilla.com at Mon, 21 Jul 2014 20:25:18 +0000
Bug 1007383 - Include asm.js frames in JS::DescribeStack (r=jandem,robcee)
ee05aeba30f7fe5d3a41d322e4e73397ce7bdfff: Bug 998597 - Add icon for Web Audio Editor tool in developer tools. r=robcee
Jordan Santell <jsantell@gmail.com> - Wed, 14 May 2014 11:37:00 -0400 - rev 202429
Push 3741 by asasaki@mozilla.com at Mon, 21 Jul 2014 20:25:18 +0000
Bug 998597 - Add icon for Web Audio Editor tool in developer tools. r=robcee
edbab1ddf49fdba2f898cc4887db72c7046148fd: Bug 998302 - Connect to about:config instead of about:credits to avoid accessing mozilla.org when the test runs. r=robcee
Rob Campbell <rcampbell@mozilla.com> - Wed, 07 May 2014 10:38:00 -0400 - rev 201223
Push 3741 by asasaki@mozilla.com at Mon, 21 Jul 2014 20:25:18 +0000
Bug 998302 - Connect to about:config instead of about:credits to avoid accessing mozilla.org when the test runs. r=robcee
1ef41f4b806d9723e609fa04a6f86ac48df70afc: Bug 997285 part 4. Drop the custom stringifier from DOMException in favor of the default one on Error.prototype. r=peterv,robcee
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 05 May 2014 16:01:57 -0400 - rev 201084
Push 3741 by asasaki@mozilla.com at Mon, 21 Jul 2014 20:25:18 +0000
Bug 997285 part 4. Drop the custom stringifier from DOMException in favor of the default one on Error.prototype. r=peterv,robcee
6864eb782522e5670617dd20e5637bd1c6365d90: Bug 998302 - Connect to about:config instead of about:credits to avoid accessing mozilla.org when the test runs. r=robcee, a=test-only
Rob Campbell <rcampbell@mozilla.com> - Wed, 07 May 2014 10:38:00 -0400 - rev 199100
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 998302 - Connect to about:config instead of about:credits to avoid accessing mozilla.org when the test runs. r=robcee, a=test-only
1c12ded4cd82065787ddebedc35f7bfadc2a506c: Bug 920116 - Show full stack traces for console logged messages; r=robcee
Mihai Sucan <mihai.sucan@gmail.com> - Tue, 22 Apr 2014 21:45:04 +0300 - rev 198185
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 920116 - Show full stack traces for console logged messages; r=robcee
7b43671588648971a7c7db2dae6f336f25fed0f8: Bug 984365 - Refactor and split out BuiltinCommands.jsm; r=mratcliffe,robcee,panos
Joe Walker <jwalker@mozilla.com> - Sun, 13 Apr 2014 07:47:27 +0100 - rev 196653
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 984365 - Refactor and split out BuiltinCommands.jsm; r=mratcliffe,robcee,panos BuiltinCommands.jsm was huge to avoid slowing things down by having many modules loading. To avoid splitting it up from slowing things down we want to delay loading commands. Create [add|remove]ItemsByModule to allow us to lazily add modules, and convert all command modules to use this. Then break up BuiltinCommands into a set of files, for each command, and do some refactoring to use JS files rather than JSMs and use "use strict".
0341229bbac4503750d4129282b9200b477567fc: Bug 987784 - Update the browser console default prefs to match those of the web console; r=robcee
Mihai Sucan <mihai.sucan@gmail.com> - Wed, 26 Mar 2014 13:43:27 +0200 - rev 194585
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 987784 - Update the browser console default prefs to match those of the web console; r=robcee
852fe5a5434dd6a3598902c1115e63dd32b8566c: Bug 965362 - Part 2: Do not assume that all of the contents of the HTTP channel will be available by the time we decide to read it synchronously in devtools tests; r=robcee
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 27 Mar 2014 11:20:16 -0400 - rev 194141
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 965362 - Part 2: Do not assume that all of the contents of the HTTP channel will be available by the time we decide to read it synchronously in devtools tests; r=robcee
d43267eaf5284001e6214be0c2973b18f28e921e: Bug 998302 - Connect to about:config instead of about:credits to avoid accessing mozilla.org when the test runs. r=robcee, a=test-only
Rob Campbell <rcampbell@mozilla.com> - Wed, 07 May 2014 10:38:00 -0400 - rev 192227
Push 3532 by ryanvm@gmail.com at Thu, 08 May 2014 15:27:35 +0000
Bug 998302 - Connect to about:config instead of about:credits to avoid accessing mozilla.org when the test runs. r=robcee, a=test-only
226f250570a26e1c1c679776bcdf732e5c431bb1: Bug 965362 - Do not assume that all of the contents of the HTTP channel will be available by the time we decide to read it synchronously in devtools tests. r=robcee, a=test-only
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 27 Mar 2014 11:20:16 -0400 - rev 191495
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 965362 - Do not assume that all of the contents of the HTTP channel will be available by the time we decide to read it synchronously in devtools tests. r=robcee, a=test-only
485a6d64cca2efd7a28ab8ef2ceddfb4af1aa442: Bug 983955 - Increase the timeout in browser_inspector_markup_add_attributes.js; r=robcee
Ehsan Akhgari <ehsan@mozilla.com> - Sun, 16 Mar 2014 19:26:10 -0400 - rev 191046
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 983955 - Increase the timeout in browser_inspector_markup_add_attributes.js; r=robcee
8106dd48d2e850d144225d9c15f7be10c4524f2f: Bug 976738 - Devtools Themes - use light theme as default theme; r=robcee
Heather Arthur <fayearthur@gmail.com> - Fri, 14 Mar 2014 15:04:09 -0700 - rev 190925
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 976738 - Devtools Themes - use light theme as default theme; r=robcee
8bf094fdb4f0f8a4fd5c3b06c02e09f89b1cbbba: Bug 884796 - Scale deltas in EventUtils.js::synthesizeWheel() on HiDPI screens r=robcee
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 06 Mar 2014 09:38:09 +0000 - rev 189469
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 884796 - Scale deltas in EventUtils.js::synthesizeWheel() on HiDPI screens r=robcee
3065c1488d1d76691262e714eccdc31d3a92f0ee: Bug 977345 - Editor should refresh when font size changes. r=robcee
Anton Kovalyov <anton@mozilla.com> - Wed, 26 Feb 2014 14:50:26 -0800 - rev 188010
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 977345 - Editor should refresh when font size changes. r=robcee
9a30d2ed15978b06f5cb78c5fa3551f1f3e70870: Bug 974065 - Add async function helpers to devtools. r=fitzgen, r=robcee
Brandon Benvie <bbenvie@mozilla.com> - Wed, 19 Feb 2014 14:08:36 -0800 - rev 186842
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 974065 - Add async function helpers to devtools. r=fitzgen, r=robcee
393c539741f2fc982824f566094ef85857359ca7: Bug 955820 - console.group doesn't group messages when timestamps are disabled; r=robcee
Mihai Sucan <mihai.sucan@gmail.com> - Tue, 18 Feb 2014 22:10:41 +0200 - rev 186706
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 955820 - console.group doesn't group messages when timestamps are disabled; r=robcee
a1b47aeca0cee75fcddeb19553a45ca79bb11b48: Bug 966308 - DevTools Themes - Make dark theme the default;r=robcee
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 10 Feb 2014 09:33:47 -0600 - rev 185027
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 966308 - DevTools Themes - Make dark theme the default;r=robcee
cd69b4b6d5443b537815cd745184e3e703cc96ef: Bug 957072 - Add Pretty Print to Scratchpad Menu. r=robcee
Vikneshwar <lviknesh1993@gmail.com> - Sat, 08 Feb 2014 21:02:11 -0500 - rev 184933
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 957072 - Add Pretty Print to Scratchpad Menu. r=robcee
0e38a95ffbfeedfb54c3e666bbf417ffb0c188f8: Bug 965362 - Do not assume that all of the contents of the HTTP channel will be available by the time we decide to read it synchronously in devtools tests. r=robcee, a=test-only
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 27 Mar 2014 11:20:16 -0400 - rev 183605
Push 3419 by ryanvm@gmail.com at Wed, 02 Apr 2014 16:42:40 +0000
Bug 965362 - Do not assume that all of the contents of the HTTP channel will be available by the time we decide to read it synchronously in devtools tests. r=robcee, a=test-only
8b6f12987aa14f3974463b27d1c2d0eb61b2ec60: Bug 976738 - Devtools Themes - use light theme as default theme; r=robcee a=Sylvestre
Heather Arthur <fayearthur@gmail.com> - Sun, 16 Mar 2014 23:09:42 -0700 - rev 183407
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 976738 - Devtools Themes - use light theme as default theme; r=robcee a=Sylvestre
801ada2044a253a78b9de38d8c7ad03ee51e0b12: Bug 955820 - console.group doesn't group messages when timestamps are disabled. r=robcee, a=sledru
Mihai Sucan <mihai.sucan@gmail.com> - Tue, 18 Feb 2014 22:10:41 +0200 - rev 182942
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 955820 - console.group doesn't group messages when timestamps are disabled. r=robcee, a=sledru
5dd0dfa084cb5285eedff63e383f1ecb8242740a: Bug 966308 - DevTools Themes - Make dark theme the default. r=robcee, a=sledru
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 10 Feb 2014 09:33:47 -0600 - rev 182770
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 966308 - DevTools Themes - Make dark theme the default. r=robcee, a=sledru
777869c35c0d9339d5cf2f73a0a193d18412d28e: Disable auto-pretty-print by default until we fix the heuristics (bug 962857). r=robcee
Panos Astithas <past@mozilla.com> - Fri, 31 Jan 2014 18:30:27 +0200 - rev 182359
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Disable auto-pretty-print by default until we fix the heuristics (bug 962857). r=robcee
ea49291871ef8e22ef8ba632787779c5df834a92: Bug 961431 - Autocomplete suggestions in split console are sliding down. r=robcee
Mihai Sucan <mihai.sucan@gmail.com> - Tue, 28 Jan 2014 15:55:19 +0200 - rev 181642
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 961431 - Autocomplete suggestions in split console are sliding down. r=robcee
59cc8ecd78d3204acd5c70eb745a2a2d62428d7e: Bug 717369 - Autocomplete CSS properties and values in the Style Editor - Part 3 - Style editor tests, r=harth, robcee
Girish Sharma <scrapmachines@gmail.com> - Tue, 28 Jan 2014 20:41:22 +0530 - rev 181584
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 717369 - Autocomplete CSS properties and values in the Style Editor - Part 3 - Style editor tests, r=harth, robcee
fcbf8c877de97d3a9206e6e4a6a309f0af2c8f18: Bug 717369 - Autocomplete CSS properties and values in the Style Editor - Part 1 - No tests, r=anton, msucan, dcamp, robcee, harth
Girish Sharma <scrapmachines@gmail.com> - Tue, 28 Jan 2014 20:38:41 +0530 - rev 181582
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 717369 - Autocomplete CSS properties and values in the Style Editor - Part 1 - No tests, r=anton, msucan, dcamp, robcee, harth
2552d554372d96baf3e26ddaf66468886b51cbb9: Bug 939783 - console.trace() group traces even if part of trace is different; r=robcee
Mihai Sucan <mihai.sucan@gmail.com> - Thu, 23 Jan 2014 23:37:32 +0200 - rev 181107
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 939783 - console.trace() group traces even if part of trace is different; r=robcee
7d4182792214622a7e2c8b3b333433cd016df5ca: Bug 922835 - Fix the operator of an if conditional in the debugger server; r=robcee
Nick Fitzgerald <fitzgen@gmail.com> - Mon, 06 Jan 2014 17:21:53 -0800 - rev 178274
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 922835 - Fix the operator of an if conditional in the debugger server; r=robcee
841238b6a1077dbb111e8a2d2e3f845a8c057afd: Bug 956757 - JavaScript Error: 'this.readAndConvertFromStream is not a function' in network-helper.js, line: 258. r=robcee
Mihai Sucan <mihai.sucan@gmail.com> - Mon, 06 Jan 2014 18:44:41 +0200 - rev 178265
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 956757 - JavaScript Error: 'this.readAndConvertFromStream is not a function' in network-helper.js, line: 258. r=robcee
1627332b2e7f9be3859dc3539a15c37116ac6760: Bug 950739 - Don't scroll toolbox on raise. r=robcee
Paul Rouget <paul@mozilla.com> - Tue, 17 Dec 2013 11:05:13 -0500 - rev 176876
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 950739 - Don't scroll toolbox on raise. r=robcee
81dd3e01279a656ad0bf19b003da6c467e26b9e4: Bug 773563 - Cleanup BTA_detach callers to avoid redundant state checks; r=robcee
Panos Astithas <past@mozilla.com> - Mon, 16 Dec 2013 21:27:00 +0200 - rev 176715
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 773563 - Cleanup BTA_detach callers to avoid redundant state checks; r=robcee