Bug 1555627 - Set a learn more link on net error pages. r=prathiksha a=ritu Bug 1284835 removed the hard-coded learn more link on cert and net error pages, which worked for cert error pages because they explicitly set their own learn more links, but net error pages were relying on the default href to be set. This wasn't revealed until bug 1530348 made about:neterror part of the new error pages. The solution is simply to explicitly set the correct learn more link to net error pages. Note that in the case of PR_END_OF_FILE errors, we were not previously showing a "learn more" link. That was not intentional, as far as I can tell, but was caused by the bug fixed in bug 1477875. Differential Revision: https://phabricator.services.mozilla.com/D35163

Bug 1559317 - ensure outline is not visible when tbody gets focus on :active. r=mtigley a=ritu Depends on D35065 Differential Revision: https://phabricator.services.mozilla.com/D35066

Bug 1559316 - ensure badge background does not turn white when tbody gets focus on :active. r=mtigley a=ritu Differential Revision: https://phabricator.services.mozilla.com/D35065

Bug 1559094 - Restore old behavior for background-size: cover + zero-sized background positioning area. r=dholbert a=ritu This restores our previous and per-spec behavior. Comparing only ratios was not correct in the case one of the dimensions was zero and thus not scaled. Differential Revision: https://phabricator.services.mozilla.com/D35571

Bug 1557056 - Use extended function only for self-hosted function that needs to store canonical name in extended slot. r=jandem a=ritu Differential Revision: https://phabricator.services.mozilla.com/D34983

Bug 1559264 - Quantumbar: Don't call setValueFromResult when opening the history popup. r=dao a=ritu The problem is that on switching back to the first tab (see the bug), userTypedValue is non-null when URLBarSetURI is called. Therefore the proxy state can't be valid. Something about bug 1529931 caused userTypedValue to go from null to non-null in this case. Details below, but the summary is that we shouldn't be calling UrlbarInput.setValueFromResult when opening the history popup, because setValueFromResult sets userTypedValue. Before bug 1529931, result.autofill would always be undefined for the first result in the history popup, because we didn't allow UnifiedComplete to return an autofill result for the search triggered by the history popup. After that bug, UnifiedComplete could return an autofill result in that case -- and it likely would since the first result in the history popup has a very high frecency, which also makes it eligible for autofill. The problem with having an autofill result in the history popup is that it triggers the input.setValueFromResult() call in UrlbarController.receiveResults [1], and setValueFromResult sets userTypedValue. So when the user opens the history popup, userTypedValue gets set to a non-null value (input._lastSearchString). The fix is to not allow autofill for the history popup. After making that fix on revision https://hg.mozilla.org/mozilla-central/rev/5e2a3b886e64, the bug went away. However, after I made that fix on a fresh tree, the bug still happened. It turns out that input.setValueFromResult still ends up getting called, by UrlbarView._selectItem [2], which is called when results are received [3]. The fix for this afaict is just to pass `updateInput: false` to _selectItem. The autofill-related fix doesn't seem to be necessary at all anymore (likely due to the substantial changes to autofill since that bug landed), but I left it in anyway since it seems right to not allow autofill results for the history popup. One other useful bit of info is that userTypedValue is set to null by tabbrowser on page load [4], so that's how userTypedValue has a null value when the bug manifests and it goes from null to non-null. [1] https://hg.mozilla.org/mozilla-central/file/5e2a3b886e647af1968b9e52a6672bdeee2a0d6f/browser/components/urlbar/UrlbarController.jsm#l150 [2] https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/components/urlbar/UrlbarView.jsm#685 [3] https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/components/urlbar/UrlbarView.jsm#220 [4] https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/base/content/tabbrowser.js#5118 Differential Revision: https://phabricator.services.mozilla.com/D35505

Bug 1528481 - Possible use after free in Http2Session::RecvPushPromise() if we have a usable entry in the cache for the resource. r=dragana, a=ritu If we find a usable cache entry, the stream is closed and release in CachePushCheckCallback::OnCacheEntryCheck(). This patch converts raw pointer to a weak pointer, so we can simply check if the object still exists after AsyncOpenURI() finishes. Differential Revision: https://phabricator.services.mozilla.com/D33945

Bug 1547266 - Make sure Http2PushedStream is used only on socket thread. r=dragana, a=ritu Raw pointer to Http2PushedStream is passed to nsHttpChannel and nsHttpTransaction to get it back to a new Http2Stream in the Http2Session. As a result Http2PushedStream's methods can be called on a wrong thread and possibly on already freed object. This patch uses Http2PushedStreamWrapper instead, which takes care about thread safety and checks if the object is still alive. Differential Revision: https://phabricator.services.mozilla.com/D33511

Bug 1558549 - Update to NSS_3_44_1_RTM. a=ritu UPGRADE_NSS_RELEASE

Bug 1560527 - Enable make backend verbose mode automatically rather than relying on mach setting it. r=froydnj a=ritu This makes running without mach more consistent. e.g. running `make -C $objdir/toolkit/library/rust target` makes the cargo log verbose, and adding `-s` makes it less verbose. Differential Revision: https://phabricator.services.mozilla.com/D35521

Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs a=ritu Differential Revision: https://phabricator.services.mozilla.com/D35434

Bug 1559686 - Reimplement the inputHistory feature in the Quantum Bar. r=adw a=ritu Differential Revision: https://phabricator.services.mozilla.com/D35364

Bug 1549061 - Add intermediate certificate [release]. r=kmag a=ritu CLOSED TREE Summary: This patch relies on a schema bump in a previous commit Reviewers: kmag Reviewed By: kmag Bug #: 1549061 Differential Revision: https://phabricator.services.mozilla.com/D29949

Bug 1513737 - Stop using Array.shift when mapping pause points. r=dwalsh, a=ritu Reviewers: davidwalsh Reviewed By: davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D14346

Bug 1502410 - Don't use deleteBranch in Normandy. r=Gijs,adw, a=ritu nsIPrefBranch.deleteBranch doesn't work as documented when the preference's default value was set very early after Firefox has started, such as when Normandy sets startup branches. This is filed as bug 1505941. In order to work around this problem, this patch makes Normandy never use deleteBranch, except in tests where it is safe to do so. With this patch, an experiment that is run on the default branch for a preference that does not have a default value in the tree cannot be promptly unenrolled, instead we must wait until the preference is naturally cleared when Firefox restarts. This is better than never unenrolling though. Differential Revision: https://phabricator.services.mozilla.com/D11383

Bug 1497259 - 3. Control GV logging through pref; r=droeh, a=ritu Use the "geckoview.logging" pref to control GV logging. Differential Revision: https://phabricator.services.mozilla.com/D8052

Bug 1497259 - 2. Don't log auto-fill values; r=droeh, a=ritu Auto-fill values can contain personal information and must not appear in the log. Differential Revision: https://phabricator.services.mozilla.com/D8051

Bug 1497259 - 1. Fix log module names; r=droeh, a=ritu Fix the GV log module names so they are all under the GeckoView group. Differential Revision: https://phabricator.services.mozilla.com/D8050

Bug 1475325 - 2. Add tests for hiding selection action in different cases; r=jchen a=ritu Add some tests for hiding selection action during navigation, blurring, or clearing delegate.

Bug 1475325 - Hide selection action in some scenarios; r=droeh a=ritu Hide the selection action toolbar when the session is unfocused, or when changing the selection action delegate. Differential Revision: https://phabricator.services.mozilla.com/D5807

Bug 1486970 - Create revision and pushlog-id index routes for cron decision tasks. r=dustin,aki a=ritu This hardcodes the push info in .taskgraph.yml for cron so that we don't break Chain Of Trust (signing) on other branches (uplifts) when we adjust scriptworker to start passing in this data to json-e. This allows us to incrementally roll this out without needing a flag day, and will be needed on all production branches. Differential Revision: https://phabricator.services.mozilla.com/D4501

Bug 1475325 - 2. Add tests for hiding selection action in different cases; r=jchen a=ritu Add some tests for hiding selection action during navigation, blurring, or clearing delegate.

Bug 1470394 - Increase bookmark panel width to provide enough area for text in other localizations. r=mak a=ritu

Bug 1468249 - Avoid resizing the TP toggle in the main menu in touch mode. r=dao, a=ritu This also fixes bug 1468311, because it made the touch control significantly more annoying. Now, the TP toggle in the main menu has the right size, but tapping outside of it still doesn't trigger it, though at least the menu is not closed so the user can easily tap again. MozReview-Commit-ID: eRfAEwXype

Bug 1470306 - More assertions in MessagePort, r=qdot a=ritu Still trying to understand why we have MessagePort::CloseInternal crashes, here I introduce more assertions and a security check in case PBackground initialization fails.

Bug 1470306 - Ensure MessagePort is in the right state if the connection to PBackground fails, r=qdot a=ritu

Bug 1470306 - Adding some MOZ_DIAGNOSTIC_ASSERT in MessagePort, r=smaug a=ritu

Bug 1470306 - MessagePort unlinked should start the cleanup/close/shutdown procedure of the object, r=smaug a=ritu

Bug 1480144: Let Windows Restart Manager ride the trains. r=jimm a=ritu Summary: The plan is to study the "restart manager" in 62 with a pref flip, and if that goes well enable it on release in 63. If it is to be enabled for the whole population in 63 it needs to ride the trains, so we'll let it be enabled by default as 63 goes to beta. There will be time to uplift a backout so it won't reach the release population, if the 62 study indicates problems. Reviewers: jmathies Reviewed By: jmathies Bug #: 1480144 Differential Revision: https://phabricator.services.mozilla.com/D2620

Bug 1479536 - Fix SessionFinder.clear(); r=droeh a=ritu Fix the clear() call to clear highlights in addition to the selection. MozReview-Commit-ID: 1DNXa8fIGTP

Bug 1478800 - Fix find-in-page display flags; r=droeh a=ritu Make the display flags actually work. MozReview-Commit-ID: 1fw9Oa0IaGc

Bug 1479631 - Fix media.memory_caches_combined_limit_kb value on Android. r=drno a=ritu It was accidentally changed from 524288 to 32768 on Android by bug 1448222. This commit changes it back.

Bug 1477539 - Sanitizer.jsm must cleanup content preferences, r=Gijs a=ritu

Bug 1472140 - 3. Remove ForceIsFirstPaint ipdl call; r=kats a=ritu Remove the PCompositorBridge::ForceIsFirstPaint call that's no longer used anywhere.

Bug 1472140 - 2. Set text input / accessibility views with the session; r=esawin a=ritu Instead of changing the text input / accessibility views during window attachment / detachment, we should change them during session attachment / detachment because those views are associated with the session. MozReview-Commit-ID: G89rnc9ySS1

Bug 1472140 - 1. Set first paint flag when resuming and resizing composition; r=rbarker a=ritu When resuming composition in a new GeckoView, we wait for the first paint signal in order to uncover the SurfaceView. This patch makes sure that we always send the first paint signal. MozReview-Commit-ID: EZeOR80d8HY

Bug 1478883 - Tagging operations should use DONTBUILD in commit message r=Callek a=ritu MozReview-Commit-ID: 6QBQG3m907I

Bug 1476605 - Fix Error rep failure when stacktrace is a longString; r=sole. a=ritu The actual fix for this issue will come in a future reps bundle when https://github.com/devtools-html/debugger.html/pull/6705 gets merged. But, I do want this change to be uplifted to release, and it should be easier to only apply this simple change than the whole next release which would contain unrelated code changes. Also, this patch introduces a test to make sure we don't ever regress this. MozReview-Commit-ID: 3QPrx3TLln0

Bug 1477684 - rcwn blocking some xmlHttpRequests, r=valentin a=ritu Remove conditional and byte range headers when network won the race for case we send the request again due to 401 response.

Bug 1437988 - [2.0] Use progress tracking events for custom tabs progress bar. r=droeh a=ritu

Bug 1437988 - [1.5] Add progress tracking and expose progress via a delegate callback. r=jchen,snorp,droeh a=ritu

Bug 1477458 - Add test for XML Pretty Print with restrictive CSP. r=bz a=ritu MozReview-Commit-ID: 3OkdYbkci40

Bug 1477458 - Use <link/> instead of <style/> to insert CSS for XML Pretty Printing to avoid site CSP. r=bz a=ritu This only works because the Gecko CSP implementation special-cases linked stylesheets with chrome:// URLs. See https://hg.mozilla.org/mozilla-central/file/085cdfb90903d4985f0de1dc7786522d9fb45596/dom/security/nsCSPService.cpp#l92 MozReview-Commit-ID: EvFTgVObCiS

Bug 1464461 - Fix talos failure; r=nchevobbe a=ritu l10n=ritu MozReview-Commit-ID: 9v9lRZjzacs

Bug 1464461 - Add back mochitests for screenshot command; r=nchevobbe,ochameau a=ritu MozReview-Commit-ID: 4yGM74AXwoP

Bug 1464461 - Implement unix style syntax for console commands; r=nchevobbe,ochameau a=ritu MozReview-Commit-ID: 8rQ9IQdsZkm

Bug 1464461 - Make dispatchMessagesAdd use batching; r=nchevobbe a=ritu MozReview-Commit-ID: 7sCFIfC2ovi

Bug 1464461 - Implement screenshot command in console panel; r=nchevobbe,ochameau a=ritu MozReview-Commit-ID: 8MDZglPqTz9

Bug 1478051 - Skip using stylesheet from Netmonitor if its content size is zero. r=jdescottes a=ritu MozReview-Commit-ID: 6A1YbwDmBVj

Bug 1471894 Part 3: Update expectation to pass for parts of a WPT test. r=dholbert a=ritu MozReview-Commit-ID: K6nU6C76gZg