searching for reviewer(peterv)
9cdcc170dc1a51fc14a10d38f8aa2237d9928ba4: Bug 1563542 - Correctly align usage of mIsDiscarded and mClosed for BrowsingContext, r=peterv a=RyanVM DEVEDITION_69_0b3_BUILD1 DEVEDITION_69_0b3_RELEASE FIREFOX_69_0b3_BUILD1 FIREFOX_69_0b3_RELEASE
Nika Layzell <nika@thelayzells.com> - Mon, 08 Jul 2019 17:27:27 +0000 - rev 541249
Push 11534 by archaeopteryx@coole-files.de at Mon, 08 Jul 2019 18:25:49 +0000
Bug 1563542 - Correctly align usage of mIsDiscarded and mClosed for BrowsingContext, r=peterv a=RyanVM In the bug which introduced mIsDiscarded, the code was changed to not set mClosed during Detach, and only set mIsDiscarded. This was a mistake because a bunch of places are only reading mClosed. Specifically when creating a BrowsingContext for an iframe, we check GetClosed() to see whether to skip creating it. Not doing this check can lead to assertions like the one in this bug. This patch changes the behaviour to continue setting `mClosed`, and also updates the relevant `GetClosed()` checks to correctly check `IsDiscarded()` Differential Revision: https://phabricator.services.mozilla.com/D37267
59c08b215af55370b0a8eef16528e99654ffa558: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 03 Jul 2019 07:52:35 +0000 - rev 540782
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv `= {}` can now be used to indicate that an optional dictionary should have the default value of 'default-initialized dictionary' Differential Revision: https://phabricator.services.mozilla.com/D36504
8e16f13a88c856819d8ca6ace8ccb32b852361f7: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 03 Jul 2019 06:44:36 +0000 - rev 540721
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv `= {}` can now be used to indicate that an optional dictionary should have the default value of 'default-initialized dictionary' Differential Revision: https://phabricator.services.mozilla.com/D36504
12653dd76667080596c6d71f01d4bc6457bb4527: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 03 Jul 2019 06:15:54 +0000 - rev 540717
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv `= {}` can now be used to indicate that an optional dictionary should have the default value of 'default-initialized dictionary' Differential Revision: https://phabricator.services.mozilla.com/D36504
eec541e479b2d0380374191b6fdd83bb5a6765a5: Bug 1562008. Update the grammar for IDL union types to exclude Promise types. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 02 Jul 2019 22:17:40 +0000 - rev 540684
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1562008. Update the grammar for IDL union types to exclude Promise types. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D36238
a77d24d3de6401fc7f226540fd7ccb56570a58c5: Bug 1562004. Disallow specifying [Global] and [Constructor] or [NamedConstructor] on the same interface. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 02 Jul 2019 07:56:26 +0000 - rev 540683
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1562004. Disallow specifying [Global] and [Constructor] or [NamedConstructor] on the same interface. r=peterv See https://github.com/heycam/webidl/issues/744 Differential Revision: https://phabricator.services.mozilla.com/D36236
72051a14f93ee1b0fc57fee1eff0ebd7178a6127: Bug 1561058 - Null check ContentParent within ContentParent::RecvPostMessage, r=peterv
Nika Layzell <nika@thelayzells.com> - Thu, 27 Jun 2019 15:03:24 +0000 - rev 540049
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1561058 - Null check ContentParent within ContentParent::RecvPostMessage, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D35878
0b533d8d086e4828cb712061ff95e5ee1527bbd5: Bug 1560553 part 2. Improve the assertions in MaybeWrapNonDOMObjectValue. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 27 Jun 2019 16:13:32 +0000 - rev 540039
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1560553 part 2. Improve the assertions in MaybeWrapNonDOMObjectValue. r=peterv We don't need to worry about JSCLASS_PRIVATE_IS_NSISUPPORTS, because the only work we're really skipping here compared to MaybeWrapObjectValue is the TryToOuterize call, and that only matters for Window objects, which always have a DOM class. Differential Revision: https://phabricator.services.mozilla.com/D35534
1bf78850148bd7dd06e451ae9a60c627c7066b88: Bug 1560553 part 1. Simplify the TryToOuterize callers a bit. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 27 Jun 2019 15:03:20 +0000 - rev 540038
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1560553 part 1. Simplify the TryToOuterize callers a bit. r=peterv TryToOuterize fast-path bails out if a bit-check on the JSClass fails. Trying to avoid that bit-check by checking for a DOM class, which is also a bit-check on the JSClass doesn't really make sense. Differential Revision: https://phabricator.services.mozilla.com/D35533
e65bee2165ec5b7db8e2a5fa6422a001eac25324: Bug 1559008. Load catalog DTDs even if we don't have a useful DTD URI, since we ignore that URI anyway when we find a catalog DTD. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 24 Jun 2019 12:45:22 +0000 - rev 539590
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1559008. Load catalog DTDs even if we don't have a useful DTD URI, since we ignore that URI anyway when we find a catalog DTD. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D34815
5a2114b7f34004218d948bfe62b95b1e17e2f23c: Bug 1555488 - Part 1: Clear WindowProxy cache when flipping processes, r=peterv,mccr8
Nika Layzell <nika@thelayzells.com> - Thu, 06 Jun 2019 14:57:18 +0000 - rev 537292
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555488 - Part 1: Clear WindowProxy cache when flipping processes, r=peterv,mccr8 This is sorta-part of the work for bug 1510760. Currently if you do a process switch, the window proxy state is completely borked, and a lot of stuff doesn't work. This patch aims to make it so that, while not transplanted correctly, methods generally don't return the wrong WindowProxy object anymore after a process swap. Differential Revision: https://phabricator.services.mozilla.com/D33082
d7d0c0a328f62917a650f581f2e518d75da254c2: Bug 1555085. Don't assume that objects whose DOMObjectType is eInterface have a DOMIfaceAndProtoJSClass JSClass. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 04 Jun 2019 09:49:24 +0000 - rev 536458
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555085. Don't assume that objects whose DOMObjectType is eInterface have a DOMIfaceAndProtoJSClass JSClass. r=peterv Named constructors are eInterface but are plain Function objects, without a DOMIfaceAndProtoJSClass class. Differential Revision: https://phabricator.services.mozilla.com/D32941
1bef4720c4eea94a8f420ba7d6a037cc67518e8e: Bug 1555488 - Part 1: Clear WindowProxy cache when flipping processes, r=peterv,mccr8
Nika Layzell <nika@thelayzells.com> - Mon, 03 Jun 2019 20:03:15 +0000 - rev 536313
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555488 - Part 1: Clear WindowProxy cache when flipping processes, r=peterv,mccr8 This is sorta-part of the work for bug 1510760. Currently if you do a process switch, the window proxy state is completely borked, and a lot of stuff doesn't work. This patch aims to make it so that, while not transplanted correctly, methods generally don't return the wrong WindowProxy object anymore after a process swap. Differential Revision: https://phabricator.services.mozilla.com/D33082
1bec5b571ed1d86f15386e0fedb187319e199d4a: Bug 1121623 part 10. Use a more-accurate default value for 'concrete' in Web IDL bindings. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 10:43:37 +0000 - rev 535039
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1121623 part 10. Use a more-accurate default value for 'concrete' in Web IDL bindings. r=peterv The idea is that we should only generate concreate-binding (wrap methods, etc) machinery for an interface by default if we have reason to expect that the interface is used as the primary interface for some objects. Two clear signals that would indicate that are the interface being a leaf interface (with no descendants) and the interface having a constructor. Other cases would require a 'concrete' annotation in Bindings.conf. Differential Revision: https://phabricator.services.mozilla.com/D32208
99d7cbadce926aad011bc60980eadb87bfa11f81: Bug 1121623 part 9. Change example codegen to not spit out WrapObject bits for non-concrete interfaces. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:34:33 +0000 - rev 535038
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1121623 part 9. Change example codegen to not spit out WrapObject bits for non-concrete interfaces. r=peterv This should keep people from marking things concrete unnecessarily just so their example-generated WrapObject works. Differential Revision: https://phabricator.services.mozilla.com/D32207
b5e4781f21b39dc662549e551580300537b3460f: Bug 1121623 part 7. Remove AuthenticatorResponse::WrapObject. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:23:54 +0000 - rev 535036
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1121623 part 7. Remove AuthenticatorResponse::WrapObject. r=peterv It's dead code because we never create AuthenticatorResponse objects directly, and all subclasses override WrapObject. Differential Revision: https://phabricator.services.mozilla.com/D32205
1e7a53dbff7b0a55633a7b57c4229259f47cd492: Bug 1121623 part 5. Remove PerformanceEntry::WrapObject. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:23:47 +0000 - rev 535034
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1121623 part 5. Remove PerformanceEntry::WrapObject. r=peterv It's dead code, because we never create PerformanceEntry objects directly and subclasses override WrapObject. Differential Revision: https://phabricator.services.mozilla.com/D32203
8e672b4e0a3e3ed151a91abbca41cebf2692dd4f: Bug 1121623 part 3. Switch WebrtcGlobalInformation to being a namespace. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:22:22 +0000 - rev 535032
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1121623 part 3. Switch WebrtcGlobalInformation to being a namespace. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D32201
5d10803def3ee7f35ee69f4a67870e7f9885e79a: Bug 1121623 part 2. Switch AddonManagerPermissions to being a namespace. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:19:58 +0000 - rev 535031
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1121623 part 2. Switch AddonManagerPermissions to being a namespace. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D32200
08973de3de9ec12109ad5101d24f79ff710b6da8: Bug 1121623 part 1. Switch PromiseDebugging to being a namespace, since that's how we use it. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 24 May 2019 07:13:16 +0000 - rev 535030
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1121623 part 1. Switch PromiseDebugging to being a namespace, since that's how we use it. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D32199
bc517e65f14efda9a149410692057c1500dcb0e1: Bug 1549973 - Force tabState flush from C++ listener before tab is closed r=peterv
Alphan Chen <alchen@mozilla.com> - Wed, 22 May 2019 09:06:14 +0000 - rev 534540
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1549973 - Force tabState flush from C++ listener before tab is closed r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30475
bf656a3314e93271eaa946c029648ba70aba1460: Bug 1546887 - If requesting window.closed during teardown, return true instead of throwing. r=peterv
Mike Conley <mconley@mozilla.com> - Thu, 16 May 2019 12:34:57 +0000 - rev 532899
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1546887 - If requesting window.closed during teardown, return true instead of throwing. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30435
7d2d7b47ec349aa71ab0a49a18cfced4b92b7189: Bug 1551335 - Update comment on RemoteOuterWindowProxy. r=peterv
Andrew McCreight <continuation@gmail.com> - Tue, 14 May 2019 09:13:20 +0000 - rev 532609
Push 11270 by rgurzau@mozilla.com at Wed, 15 May 2019 15:07:19 +0000
Bug 1551335 - Update comment on RemoteOuterWindowProxy. r=peterv The second patch in bug 1518202 made it so that the reference to the browsing context is declared to the cycle collector after all. Differential Revision: https://phabricator.services.mozilla.com/D31001
b0c2270a44f33555ee54c4708f4b35a039375696: Bug 1550928 part 2. Stop using [array] in nsIPluginHost. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 14 May 2019 09:11:45 +0000 - rev 532586
Push 11270 by rgurzau@mozilla.com at Wed, 15 May 2019 15:07:19 +0000
Bug 1550928 part 2. Stop using [array] in nsIPluginHost. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30767
aa417164d4c7beb948c37df4b6d57986548a00ca: Bug 1550928 part 1. Stop using [array] in nsIPluginTag. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 14 May 2019 09:11:37 +0000 - rev 532585
Push 11270 by rgurzau@mozilla.com at Wed, 15 May 2019 15:07:19 +0000
Bug 1550928 part 1. Stop using [array] in nsIPluginTag. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D30766
3288c43195a26565edec3d59a8f8bce6018be592: Bug 1474130 - Implement ScrollPosition/Privacy/DocCapability listeners in C++ r=peterv
Alphan Chen <alchen@mozilla.com> - Sat, 04 May 2019 10:42:52 +0000 - rev 531583
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1474130 - Implement ScrollPosition/Privacy/DocCapability listeners in C++ r=peterv Differential Revision: https://phabricator.services.mozilla.com/D23057
03166449953fbcaaf6c66d2c3b358319781a0e52: Bug 1539759 - improve DTD entity handling, r=peterv
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 03 May 2019 09:13:58 +0000 - rev 531259
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539759 - improve DTD entity handling, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D27904
4c6e2e3f23f9adc7c89e8c500a14ec9cd9f074bd: Bug 1539759 - improve DTD entity handling, r=peterv
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 02 May 2019 09:22:10 +0000 - rev 531063
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539759 - improve DTD entity handling, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D27904
5f451bcec20508390823a0a3244ff7301fdafa6e: Bug 1539759 - improve DTD entity handling, r=peterv
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 02 May 2019 08:19:08 +0000 - rev 531056
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539759 - improve DTD entity handling, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D27904
11b4d70a2b5d6373f5ec8fa01ca48a1c7bc1829e: Bug 1547911 - Only restore non-empty browsing context children. r=peterv
Andreas Farre <farre@mozilla.com> - Tue, 30 Apr 2019 16:11:03 +0000 - rev 530798
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547911 - Only restore non-empty browsing context children. r=peterv Also, make sure to evict the right browsing contexts from the cache. Differential Revision: https://phabricator.services.mozilla.com/D29349
3073770e06f157040f4c64951b7e8425e1ad7bbe: Bug 1535403 - Take indirection into account for the CC optimizations for the outer window wrapper. r=peterv
Andrew McCreight <continuation@gmail.com> - Mon, 22 Apr 2019 16:34:51 +0000 - rev 529183
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1535403 - Take indirection into account for the CC optimizations for the outer window wrapper. r=peterv Most wrapper cached C++ objects are held alive by their wrapper. The cycle collector takes advantage of this in many classes and ignores the C++ object if the wrapper is marked black. However, this is not true for the outer window's wrapper. Instead, the outer window's wrapper keeps the inner window alive. The inner window usually keeps its outer window alive, but not after it has been unlinked. For reasons I do not yet understand, the outer window's wrapper can be kept alive after the inner window it is a proxy for is unlinked. This patch fixes the cycle collector optimization for the outer window by only applying it if the outer window still has a weak reference to the inner window, which it will until the inner no longer holds the outer alive. This in turn fixes, or at least helps fix, window leaks seen intermittently when the lifetime of outer windows and docshells are tied together. The code comment is based on a review comment by peterv. Differential Revision: https://phabricator.services.mozilla.com/D27981
607e1bc95c9bd82cbf4dc5426cfa66147f1d9458: Bug 1542790 - Part 2: Use BC::GetParent and BC::GetTop for local windows, r=peterv
Nika Layzell <nika@thelayzells.com> - Wed, 17 Apr 2019 00:53:09 +0000 - rev 528644
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542790 - Part 2: Use BC::GetParent and BC::GetTop for local windows, r=peterv This is required to support getting the `parent` and `top` properties from within remote subframes. Differential Revision: https://phabricator.services.mozilla.com/D26559
5fde2cc9277a3d4bb73d859ba571c84fdc2ead9b: Bug 1542790 - Part 1: BC::GetParent on toplevel windows should be self, r=peterv
Nika Layzell <nika@thelayzells.com> - Wed, 17 Apr 2019 00:53:05 +0000 - rev 528643
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542790 - Part 1: BC::GetParent on toplevel windows should be self, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26558
ca2c4053e33c353f361daa7036ebf7a9a960c50a: Bug 1542787 - Support getting contentWindow on out-of-process frames, r=peterv
Nika Layzell <nika@thelayzells.com> - Thu, 11 Apr 2019 18:56:48 +0000 - rev 528338
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542787 - Support getting contentWindow on out-of-process frames, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26556
0b0a39e79b6e4c96aede5823b97ceb9b66e8e010: Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv
André Bargull <andre.bargull@gmail.com> - Thu, 11 Apr 2019 21:07:00 +0000 - rev 527912
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26144
b69cb7f4f3059c56434b82641db3ae813e7f9036: Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv
André Bargull <andre.bargull@gmail.com> - Wed, 10 Apr 2019 10:29:49 +0000 - rev 527881
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539694 - Part 3: Update xray tests for Promise. r=peterv Depends on D25209 Differential Revision: https://phabricator.services.mozilla.com/D26144
e251a566abb693ee0f12419bf52b39fe4df7a7f3: bug 1524359 - 49,600 instances of "NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005" emitted from docshell/shistory/nsSHistory.cpp during linux64 debug testing r=peterv
Khyati Agarwal <f20160385@hyderabad.bits-pilani.ac.in> - Thu, 11 Apr 2019 12:11:05 +0000 - rev 527812
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1524359 - 49,600 instances of "NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005" emitted from docshell/shistory/nsSHistory.cpp during linux64 debug testing r=peterv Replaced "NS_ENSURE_SUCCESS" with 'if' condition Differential Revision: https://phabricator.services.mozilla.com/D25529
e93e17bb399ae84a0f80ab7e3974cd0495d13cdf: Bug 1543461. Add the missing newline after a static assert in Web IDL codegen. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 10 Apr 2019 19:05:15 +0000 - rev 527720
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543461. Add the missing newline after a static assert in Web IDL codegen. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D26960
65f7904484c803a15084966557ca68bb0856a0f1: Bug 1507004, get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv
Neil Deakin <neil@mozilla.com> - Mon, 01 Apr 2019 09:09:04 -0400 - rev 525915
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1507004, get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv
77f9f813184572c571dec58fec3c6e0d3961fd04: Bug 1507004, get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv a=test-only
Neil Deakin <neil@mozilla.com> - Mon, 01 Apr 2019 09:09:04 -0400 - rev 523123
Push 11063 by apavel@mozilla.com at Thu, 11 Apr 2019 07:09:50 +0000
Bug 1507004, get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv a=test-only
95f9efbbf8051d65db8e0c77aa3eda4893786a12: Bug 1533413 - Add Symbol.matchAll to list of expected RegExp methods. r=peterv
Jason Orendorff <jorendorff@mozilla.com> - Mon, 11 Mar 2019 10:20:38 +0000 - rev 521332
Push 10866 by nerli@mozilla.com at Tue, 12 Mar 2019 18:59:09 +0000
Bug 1533413 - Add Symbol.matchAll to list of expected RegExp methods. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D22583
60142f1fcb4c417e648e11875b4ada3720d5a2e8: Bug 1527277 - Part 4: Add crashtest. r=peterv
Eric Rahm <erahm@mozilla.com> - Wed, 06 Mar 2019 18:54:27 +0000 - rev 520556
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527277 - Part 4: Add crashtest. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20581
b4fef176bc8fde4e580823740639f51c6e43c58f: Bug 1527277 - Part 3: Validate usage of string iterator. r=peterv
Eric Rahm <erahm@mozilla.com> - Wed, 06 Mar 2019 18:55:54 +0000 - rev 520555
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527277 - Part 3: Validate usage of string iterator. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20580
7ce2309548dab8af0285f3224cb344640089f59b: Bug 1527277 - Part 2: Use unique pointer to manage buffer lifetime. r=peterv
Eric Rahm <erahm@mozilla.com> - Thu, 21 Feb 2019 23:06:04 +0000 - rev 520554
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527277 - Part 2: Use unique pointer to manage buffer lifetime. r=peterv Switch to managing the buffer lifetime with a UniquePtr. This will make handling errors simpler in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D20579
62aba7d6d779e6a5e3a088b94ea0df7eef2d92bd: Bug 1527277 - Part 1: Refactor error reporting logic. r=peterv
Eric Rahm <erahm@mozilla.com> - Thu, 21 Feb 2019 23:07:05 +0000 - rev 520553
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527277 - Part 1: Refactor error reporting logic. r=peterv Add a common function for reporting an invalid argument. Differential Revision: https://phabricator.services.mozilla.com/D20578
d7d6b249119a5c8a8b179407f801152f09acb0b3: Bug 1497147 - Rewrite "mapFrameTree" implementation to C++ r=peterv
Alphan Chen <alchen@mozilla.com> - Thu, 28 Feb 2019 13:09:54 +0000 - rev 519608
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1497147 - Rewrite "mapFrameTree" implementation to C++ r=peterv Get rid of mapFrameTree() implementation Differential Revision: https://phabricator.services.mozilla.com/D17149
fcf3d5468b1f1838504b2b75f856f2beff73fab7: Bug 1525101 - adjust nsIFormFillController to make custom elements popup working, r=peterv
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 25 Feb 2019 20:02:35 +0000 - rev 518850
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525101 - adjust nsIFormFillController to make custom elements popup working, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20505
bea571f9708b466869f9032e2faedac64e62f05b: Bug 1525101 - adjust nsIAutoCompletePopup to make custom element popups working, r=peterv
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 25 Feb 2019 20:02:17 +0000 - rev 518849
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525101 - adjust nsIAutoCompletePopup to make custom element popups working, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D20504
996e8765c85a16605c098144e8e95f97e89b70ea: Bug 1515646 - Test BrowsingContext::FindWithName. r=peterv
Andreas Farre <farre@mozilla.com> - Fri, 15 Feb 2019 11:17:50 +0000 - rev 517292
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1515646 - Test BrowsingContext::FindWithName. r=peterv Test that BrowsingContext::FindWithName finds the expected BrowsingContexts and also that BrowsingContext::FindWithName finds the same browsing contexts as if nsIDocShellTreeItem::FindItemWithName had been used. Differential Revision: https://phabricator.services.mozilla.com/D15191
9243ddacadcca22365599b018d279a026cc51b8c: Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext. r=peterv
Andreas Farre <farre@mozilla.com> - Fri, 15 Feb 2019 09:59:21 +0000 - rev 517289
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext. r=peterv This implements the step of choosing a browsing context with FindWithName, which should be equivalent to calling nsIDocShellTreeItem.findItemWithName passing null for 'aRequestor' and 'aOriginalRequestor' and false for 'aSkipTabGroup'. Differential Revision: https://phabricator.services.mozilla.com/D15190