searching for reviewer(padenot)
f798e09dc294fd2c86f67489ac5b1bbf5195f07d: Bug 1546865 - Retry gUM on mic process limit collision after 200 ms. r=padenot
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 10 May 2019 16:06:09 +0000 - rev 532239
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546865 - Retry gUM on mic process limit collision after 200 ms. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D30290
7f32b838169018a9355ccba9a243bd311e319aed: Bug 1548816 be consistent about number of frames copied r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 07 May 2019 11:17:54 +0000 - rev 531793
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548816 be consistent about number of frames copied r=padenot Differential Revision: https://phabricator.services.mozilla.com/D30159
c386ebfd9c6bdcf77162391848b32f143561b67f: Bug 1542674 - Make Media debug info machine parsable r=padenot,smaug
Tarek Ziadé <tarek@mozilla.com> - Mon, 06 May 2019 16:39:58 +0000 - rev 531579
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542674 - Make Media debug info machine parsable r=padenot,smaug This patch structurizes the media debug information via webidl dictionaries that are returned by HTMLMediaElement::GetMozRequestDebugInfo() and MediaSource::GetMozDebugReaderData(). Differential Revision: https://phabricator.services.mozilla.com/D27893
cf38c251e2e643abd7b4bbc994f141a5dd174c5b: Bug 1547381 - Call StopTrack() in the right order. r=padenot
Jan-Ivar Bruaroey <jib@mozilla.com> - Mon, 06 May 2019 09:14:38 +0000 - rev 531541
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547381 - Call StopTrack() in the right order. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D29924
6b2c2ad50bd0ae8ae58d1202e5d37a6611a697a9: Bug 1546655 - Skip 'flac-s24.flac' and 'opus-mapping2.webm' in test_streams_element_capture.html r=padenot
Alastor Wu <alwu@mozilla.com> - Thu, 02 May 2019 17:48:33 +0000 - rev 531152
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546655 - Skip 'flac-s24.flac' and 'opus-mapping2.webm' in test_streams_element_capture.html r=padenot Differential Revision: https://phabricator.services.mozilla.com/D29594
bfebd4300498feec18eab878c5fecf005d468d13: Bug 1530178 - Update WPT expectations. r=padenot
Valentin Millet <valentin.millet39@gmail.com> - Thu, 02 May 2019 09:24:57 +0000 - rev 531067
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1530178 - Update WPT expectations. r=padenot https://github.com/WebAudio/web-audio-api/issues/1004 Differential Revision: https://phabricator.services.mozilla.com/D26474
fe9afae0f868666eec95b151b50d5c6783c3cd91: Bug 1530178 - copyFromChannel/copyToChannel until end of buffer when destination/source is longer r=padenot,karlt
Valentin Millet <valentin.millet39@gmail.com> - Thu, 02 May 2019 09:24:57 +0000 - rev 531065
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1530178 - copyFromChannel/copyToChannel until end of buffer when destination/source is longer r=padenot,karlt than available space, as clarified in https://github.com/WebAudio/web-audio-api/issues/1004 Differential Revision: https://phabricator.services.mozilla.com/D25791
a885e5f28d3141921d9235adfdd0b88552e507a2: Bug 1546872 - Update cubeb from upstream to 64aa80f. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 25 Apr 2019 20:14:32 +0300 - rev 530245
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546872 - Update cubeb from upstream to 64aa80f. r=padenot Pick commit: 64aa80f - wasapi: notify when a device is disabled. BMO 1546872
c0e459d136243e309fba76dccefc45ac2de6afa4: Bug 1545133 - Avoid trying to double-suspend a MediaStream if external code makes the suspendCount negative. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 25 Apr 2019 16:41:15 +0000 - rev 530172
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545133 - Avoid trying to double-suspend a MediaStream if external code makes the suspendCount negative. r=padenot We don't currently know any ways in which external code can make the suspendCount negative, but this will keep us safe should a future bug enable it. Depends on D28805 Differential Revision: https://phabricator.services.mozilla.com/D28806
158a9ef03153ceef4b9a097e087860f8e1712d2d: Bug 1545133 - Add crashtest. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 25 Apr 2019 16:41:33 +0000 - rev 530171
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545133 - Add crashtest. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D28805
3ba614682b62df868e89da1d7705b3191954f0fc: Bug 1545279 - Update cubeb from upstream to 3570749. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Thu, 25 Apr 2019 09:22:35 +0000 - rev 530077
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545279 - Update cubeb from upstream to 3570749. r=padenot Pick commits: 3570749 - wasapi: tie monitor lifetime with notification client lifetime. BMO 1545279 (#505) 162625a - test: add option to get the posotion of a stream (#504) Differential Revision: https://phabricator.services.mozilla.com/D28796
eecfddb57e5598e319c5ec4a93bbb07a47821262: Bug 1546655 - Fix test filtering in test_streams_element_capture.html. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 24 Apr 2019 14:49:23 +0000 - rev 529482
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546655 - Fix test filtering in test_streams_element_capture.html. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D28666
69e2758dbbad1423d57f8067499786451d9695b3: Bug 1546655 - Skip ambisonics.mp4 in test_streams_element_capture.html. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 24 Apr 2019 14:00:53 +0000 - rev 529471
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546655 - Skip ambisonics.mp4 in test_streams_element_capture.html. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D28651
eab0e21e5347199b24d3eaf17669c2a8efb38781: Bug 1544650 - Always pre-create MediaStreamTracks for DecodedStream in MediaDecoder. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Tue, 23 Apr 2019 16:46:30 +0000 - rev 529452
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544650 - Always pre-create MediaStreamTracks for DecodedStream in MediaDecoder. r=padenot This moves the responsibility for creating MediaStreamTracks from DecodedStream::Start to MediaDecoder. This let's MediaDecoder create them as soon as metadata is known. This gives the application guarantees on when tracks can be expected to exist, and aligns with the spec that says they should be created when metadata is known. Differential Revision: https://phabricator.services.mozilla.com/D28473
284e4c610279c7cc676e80ff6c500315aacc15e3: Bug 1544650 - Add mochitest. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Tue, 23 Apr 2019 16:46:45 +0000 - rev 529451
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544650 - Add mochitest. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D28472
e2a82cb2f43cd5735be7d2baa411b32be57b8ee3: Bug 1536766 - Update WPT expectations. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 24 Apr 2019 10:56:18 +0000 - rev 529450
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Update WPT expectations. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D28604
2787160c8537aa22a3c20ab22b3f1febe4d51715: Bug 1536766 - End a track only after the graph has reported reaching its end time in DecodedStream. r=jya,padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 24 Apr 2019 10:56:16 +0000 - rev 529449
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - End a track only after the graph has reported reaching its end time in DecodedStream. r=jya,padenot This gives us a guarantee that the first frame of a media file can be rendered with a second media element and mozCaptureStream(), even if the file is very very short. With longer video-only files there were also cases where nothing ended up being rendered. Probably because the MediaStreamGraph ended up switching from an AudioCallbackDriver to a SystemClockDriver and this took enough time to put the SourceMediaStream::EndTrack and the SourceMediaStream::AddTrackListener calls for this video track to be processed in the same iteration. The listener would then always lose to the ending track and update main thread state too late, leading to its media element not rendering any frames and nasty intermittent failures. Differential Revision: https://phabricator.services.mozilla.com/D27270
93eb3684768757b78558d261f0db56aea2b797bd: Bug 1536766 - Drop frames more accurately when ending and interrupting video track playback. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 24 Apr 2019 10:56:11 +0000 - rev 529448
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Drop frames more accurately when ending and interrupting video track playback. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D27269
8b2771254100edaff6d738f1335d4253f9ede203: Bug 1536766 - Make NotifyOutput from SourceMediaStream tracks reflect amount of data in the track. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 24 Apr 2019 10:56:04 +0000 - rev 529447
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Make NotifyOutput from SourceMediaStream tracks reflect amount of data in the track. r=padenot `streamCurrentTime` is relative to the start of the stream, as is the track's segment. We need to account for the track's start time in the stream when notifying of output. Differential Revision: https://phabricator.services.mozilla.com/D27268
ea1f424b6c7d84e478cd349091a951d1a9383c51: Bug 1536766 - Remove unused MediaStream::HasCurrentData. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 24 Apr 2019 10:55:50 +0000 - rev 529445
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Remove unused MediaStream::HasCurrentData. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D27266
32d459a421329ef10b8b609795053d4debcea408: Bug 1536766 - Handle DecodedStream's resets when calculating VideoChunk durations in the MSG. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 24 Apr 2019 10:55:46 +0000 - rev 529443
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Handle DecodedStream's resets when calculating VideoChunk durations in the MSG. r=padenot This is necessary to get an accurate total track duration in case DecodedStream does a lot of seeking and pausing. This also removes previous code for avoiding blocking a video track, as this new code handles that case too. Differential Revision: https://phabricator.services.mozilla.com/D27264
46eb056738352e581e6e334ce4ad0f84fd4a0f07: Bug 1536766 - Don't ignore null frames in MediaStreamGraph. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 24 Apr 2019 10:55:41 +0000 - rev 529442
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Don't ignore null frames in MediaStreamGraph. r=padenot Null frames could still be valid. It's how DecodedStream signals a pause. They could also be valid and have an intrinsic size and the force-black flag set. Differential Revision: https://phabricator.services.mozilla.com/D27263
db146a70077d0fef30987a87e7835e81fd6c5c54: Bug 1544023 - let AudioNode keep the reference of all AudioParams which belong to itself. r=padenot
Alastor Wu <alwu@mozilla.com> - Tue, 23 Apr 2019 17:50:54 +0000 - rev 529339
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544023 - let AudioNode keep the reference of all AudioParams which belong to itself. r=padenot When we suspend or resume the `AudioContext`, it should affect ALL media streams which belong to or are related to the `AudioNode` that are created by this `AudioContext`. As `AudioNode::OutputParams()` can only return the connected AudioParams, it doesn't return the AudioParams which are belong to itself. That means we would miss to apply the suspend/resume operation for those streams, and it would cause imbalancing suspended count. Therefore, we let `AudioNode` to keep the reference of all its AudioParam, and return them to `AudioContext` in order to do the operation for all streams. Differential Revision: https://phabricator.services.mozilla.com/D28008
4e29ffe20754681357353e3be5521f0cb200f544: Bug 1546012 - Avoid slow sleeps on Android in TestSPSCQueue; r=padenot
Geoff Brown <gbrown@mozilla.com> - Tue, 23 Apr 2019 13:39:36 +0000 - rev 529309
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546012 - Avoid slow sleeps on Android in TestSPSCQueue; r=padenot Reducing the sleep to 0 on Android results in a dramatic reduction in run time, and the test passes consistently. Differential Revision: https://phabricator.services.mozilla.com/D28296
510178f0dc32ee3c768c6c8f413bf16905c3e422: Bug 1541290 - Restart driver properly on revive method. r=padenot
Alex Chronopoulos <achronop@gmail.com> - Fri, 19 Apr 2019 08:34:22 +0000 - rev 528999
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541290 - Restart driver properly on revive method. r=padenot Revive method of AudioCallbackDriver was wrong because it was re-initializing an already initialized driver. That was hitting an assert. Instead of that it should stop the drained stream and start it again. Also, mStarted member should be reset properly on the stop method. Differential Revision: https://phabricator.services.mozilla.com/D26678
72d37a08f281c24833d1c49e947fb6db4df2fb87: Bug 1536766 - End a track only after the graph has reported reaching its end time in DecodedStream. r=jya,padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 18 Apr 2019 15:25:54 +0000 - rev 528922
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - End a track only after the graph has reported reaching its end time in DecodedStream. r=jya,padenot This gives us a guarantee that the first frame of a media file can be rendered with a second media element and mozCaptureStream(), even if the file is very very short. With longer video-only files there were also cases where nothing ended up being rendered. Probably because the MediaStreamGraph ended up switching from an AudioCallbackDriver to a SystemClockDriver and this took enough time to put the SourceMediaStream::EndTrack and the SourceMediaStream::AddTrackListener calls for this video track to be processed in the same iteration. The listener would then always lose to the ending track and update main thread state too late, leading to its media element not rendering any frames and nasty intermittent failures. Differential Revision: https://phabricator.services.mozilla.com/D27270
63fc8588506005ac9eb0f1ec45ed34e430c6cf4a: Bug 1536766 - Drop frames more accurately when ending and interrupting video track playback. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 18 Apr 2019 15:24:27 +0000 - rev 528921
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Drop frames more accurately when ending and interrupting video track playback. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D27269
addbb04415cb8b82b5cdd5ff8a3905cafa6221fb: Bug 1536766 - Make NotifyOutput from SourceMediaStream tracks reflect amount of data in the track. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 18 Apr 2019 15:25:51 +0000 - rev 528920
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Make NotifyOutput from SourceMediaStream tracks reflect amount of data in the track. r=padenot `streamCurrentTime` is relative to the start of the stream, as is the track's segment. We need to account for the track's start time in the stream when notifying of output. Differential Revision: https://phabricator.services.mozilla.com/D27268
25f3a33ec51b06b14d8f5eef12ebc3afe4c21e88: Bug 1536766 - Remove unused MediaStream::HasCurrentData. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 18 Apr 2019 15:24:12 +0000 - rev 528918
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Remove unused MediaStream::HasCurrentData. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D27266
f9d1f1bfe2b126dc1588e56724b860674519805a: Bug 1536766 - Handle DecodedStream's resets when calculating VideoChunk durations in the MSG. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 18 Apr 2019 15:23:59 +0000 - rev 528916
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Handle DecodedStream's resets when calculating VideoChunk durations in the MSG. r=padenot This is necessary to get an accurate total track duration in case DecodedStream does a lot of seeking and pausing. This also removes previous code for avoiding blocking a video track, as this new code handles that case too. Differential Revision: https://phabricator.services.mozilla.com/D27264
87616997f16017b85f463691262261db6490c30b: Bug 1536766 - Don't ignore null frames in MediaStreamGraph. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Thu, 18 Apr 2019 15:23:46 +0000 - rev 528915
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536766 - Don't ignore null frames in MediaStreamGraph. r=padenot Null frames could still be valid. It's how DecodedStream signals a pause. They could also be valid and have an intrinsic size and the force-black flag set. Differential Revision: https://phabricator.services.mozilla.com/D27263
fbd1effe6fe48bd57abbeaaa36b445bfb74e0194: Bug 1543032 - Extend metrics for dropped frames - r=padenot
Tarek Ziadé <tarek@mozilla.com> - Tue, 16 Apr 2019 11:50:38 +0000 - rev 528517
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543032 - Extend metrics for dropped frames - r=padenot This patch adds the number of dropped frames for each step of the process (read/sink/compositor) and gives us more insight about where frames are dropped, as opposed to the getVideoPlaybackQuality() API which gives the grand total. Differential Revision: https://phabricator.services.mozilla.com/D27488
b8855a45d798aac9bdf82cd328eb17375c5510e5: Bug 1542685 - Avoid integer overflows by multiplying doubles. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Mon, 08 Apr 2019 14:27:13 +0000 - rev 527169
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542685 - Avoid integer overflows by multiplying doubles. r=padenot SaferMultDiv(time, audioScale, videoScale) could easily result in overflow because all three args are roughly equal, and SaferMultDiv would always do the multiplication first. The worst-case is then multiplying an int64_t to another int64_t that have very similar values. Since we represent time here in microseconds, this would overflow after only 50 minutes. Differential Revision: https://phabricator.services.mozilla.com/D26494
2f1f6fd32a0dd97ea36df58e187bd94be9d65fc1: Bug 1541311 add support for AudioWorkletNode.numberOfInputs/Outputs r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 03 Apr 2019 13:38:10 +0000 - rev 526681
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541311 add support for AudioWorkletNode.numberOfInputs/Outputs r=padenot There is no specified limit on the number of inputs or outputs, except that the webidl parameter is unsigned long, but Gecko has an implementation-defined limit. Differential Revision: https://phabricator.services.mozilla.com/D25898
f3098fb60d80e9de86714d5f14f12fb2e55351e8: Bug 1539039 shutdown worklet from AudioContext::Shutdown() r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 29 Mar 2019 16:11:59 +0000 - rev 526328
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539039 shutdown worklet from AudioContext::Shutdown() r=padenot On process shutdown, the MSG is shut down (and so are other threads) before the final main thread cycle collection, and so we can't depend on unlink to notify the worklet before MSG shutdown. Depends on D25351 Differential Revision: https://phabricator.services.mozilla.com/D25352
973f69d0a81036de9a73b4980755b9bfaa1873f1: Bug 1539039 finish worklet before destination stream is destroyed r=padenot
Karl Tomlinson <karlt+@karlt.net> - Fri, 29 Mar 2019 16:12:08 +0000 - rev 526327
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539039 finish worklet before destination stream is destroyed r=padenot AudioDestinationNode, AudioContext, and Worklet are part of the same cycle. Any of these may be unlinked before another. The unlink process for this cycle is the notification that the worklet will no longer be used, but the worklet uses the destination stream to send a message to release graph thread objects and so must do this before the stream is destroyed. Differential Revision: https://phabricator.services.mozilla.com/D25351
6de9b9ab5d2278200c89bf91300e3f05802a5b81: Bug 1506884 - Remove capture_delay pref; r=padenot
Dan Minor <dminor@mozilla.com> - Tue, 26 Mar 2019 14:12:00 -0400 - rev 525646
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1506884 - Remove capture_delay pref; r=padenot This is no longer used. Differential Revision: https://phabricator.services.mozilla.com/D25057
938699e324d1e7aa5d26e8a2e5ffbf31c896f30f: Bug 1506884 - Document member thread access in AudioConduit; r=padenot
Dan Minor <dminor@mozilla.com> - Thu, 15 Nov 2018 13:24:05 -0500 - rev 525645
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1506884 - Document member thread access in AudioConduit; r=padenot This also removes some unused member variables. Differential Revision: https://phabricator.services.mozilla.com/D25056
a8af6b72513d2e81cb6e3fddab94d02055dcbeaf: Bug 1506884 - Document thread usage of mRtpPacketQueue in VideoConduit; r=padenot
Dan Minor <dminor@mozilla.com> - Mon, 19 Nov 2018 10:12:50 -0500 - rev 525644
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1506884 - Document thread usage of mRtpPacketQueue in VideoConduit; r=padenot This was added during the branch 64 update, but was not documented at that time. Differential Revision: https://phabricator.services.mozilla.com/D25054
be0fbe76851f6b09f56744a245cf633d40c85fa4: Bug 1494675 - Merge SourceListener::Remove into SourceListener::Stop. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Fri, 29 Mar 2019 16:12:20 +0000 - rev 525609
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1494675 - Merge SourceListener::Remove into SourceListener::Stop. r=padenot Depends on: D24903 Differential Revision: https://phabricator.services.mozilla.com/D25114
1248d2f659a9f341f0de5d6558eecf364fc6f0a2: Bug 1494675 - Remove windowID to MediaEngineSource mappings from MediaEngines. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 27 Mar 2019 14:10:10 +0000 - rev 525607
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1494675 - Remove windowID to MediaEngineSource mappings from MediaEngines. r=padenot These once served a caching-and-reuse purpose it seems, but it makes less sense when sources are not shared. There seems to still be functioning code to re-use fake audio devices, but this seems like premature optimization. Especially since we don't care much about fake devices in release. This patch removes it all, together with some plumbing around the mechanism. Differential Revision: https://phabricator.services.mozilla.com/D24902
20543d03a4cda05c785011a25079aa42aec8b2ba: Bug 1494675 - Remove AllocationHandle. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 27 Mar 2019 14:10:24 +0000 - rev 525606
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1494675 - Remove AllocationHandle. r=padenot The handle was used to keep separate allocations of the same source in a single process apart. Sources no longer use sharing, so we no longer need allocations or their handles even as a concept. Differential Revision: https://phabricator.services.mozilla.com/D24901
9e7832fee028f5de447c95bc0d88ddea5b09ab37: Bug 1494675 - Remove MediaEngineSource::RequiresSharing. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 27 Mar 2019 14:10:27 +0000 - rev 525605
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1494675 - Remove MediaEngineSource::RequiresSharing. r=padenot Sources are no longer shared. Differential Revision: https://phabricator.services.mozilla.com/D24900
1f79ed91a20bbe91ced53c1fe3c70fafd6272fd5: Bug 1525323 - Remove SourceTrackListener from MediaManager. r=padenot
Andreas Pehrson <apehrson@mozilla.com> - Wed, 27 Mar 2019 18:05:56 +0000 - rev 525604
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1525323 - Remove SourceTrackListener from MediaManager. r=padenot This moves the responsibility of forwarding NotifyPull() from the graph thread to MediaEngineSources out of MediaManager and into the sources themselves. This is better aligned with how the sources work, since not all sources need pulling. This also clarifies lifetime management of these listeners in relation to when pulling is enabled for a track, since the sources are already handling enabling pulling themselves. Differential Revision: https://phabricator.services.mozilla.com/D24896
93aafd0255fe21edea2aac8ebb4d6e4379d6963b: Bug 1481745 exercise ConvolverNode memory reporting r=padenot
Karl Tomlinson <karlt+@karlt.net> - Thu, 21 Mar 2019 19:36:34 +0000 - rev 525491
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1481745 exercise ConvolverNode memory reporting r=padenot The bug is detected by only NT ASAN builds. Differential Revision: https://phabricator.services.mozilla.com/D7389
a51041f61c2ce198f022551dc09b0052d785b052: bug 1539045 use AppendMessage() for ForceShutDown() r=padenot
Karl Tomlinson <karlt+@karlt.net> - Tue, 26 Mar 2019 12:41:05 +0000 - rev 525289
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1539045 use AppendMessage() for ForceShutDown() r=padenot instead of special signaling, which can get out of order with other messages. Using AppendMessage() provides that control messages sent to the graph before shutdown are run on the graph thread. Differential Revision: https://phabricator.services.mozilla.com/D24856
6c126334dae394145b53bdfc8ca684b89b949bd1: Bug 1539045 remove unnecessary !mRealtime checks with mForcedShutDown r=padenot
Karl Tomlinson <karlt+@karlt.net> - Wed, 27 Mar 2019 14:11:33 +0000 - rev 525288
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539045 remove unnecessary !mRealtime checks with mForcedShutDown r=padenot These are unnecessary because non-empty !mRealtime graphs also set mForcedShutDown before progressing to LIFECYCLE_WAITING_FOR_MAIN_THREAD_CLEANUP. This reverts some of https://hg.mozilla.org/mozilla-central/rev/d0d427badc22afa7d5406e4e376bf27df0c0aaba#l1.72 which is possible because a non-realtime graph no longer progresses to LIFECYCLE_WAITING_FOR_MAIN_THREAD_CLEANUP when it reaches mEndTime since https://hg.mozilla.org/mozilla-central/rev/61d08765489c#l1.41 Differential Revision: https://phabricator.services.mozilla.com/D24855
c1e32495cfa21fd094896d0c12201c06a33120a8: Bug 1506884 - Remove capture_delay pref; r=padenot
Dan Minor <dminor@mozilla.com> - Wed, 27 Mar 2019 16:55:13 +0000 - rev 525221
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1506884 - Remove capture_delay pref; r=padenot This is no longer used. Differential Revision: https://phabricator.services.mozilla.com/D25057
0182d6543001d10fc7504518df4a487c444d1e7a: Bug 1506884 - Document member thread access in AudioConduit; r=padenot
Dan Minor <dminor@mozilla.com> - Wed, 27 Mar 2019 16:55:04 +0000 - rev 525220
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1506884 - Document member thread access in AudioConduit; r=padenot This also removes some unused member variables. Differential Revision: https://phabricator.services.mozilla.com/D25056
5837db3740b54ff6e34d90ee0da41fe909022e06: Bug 1506884 - Use DeleteStreams in AudioConduit; r=padenot
Dan Minor <dminor@mozilla.com> - Wed, 27 Mar 2019 16:54:52 +0000 - rev 525219
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1506884 - Use DeleteStreams in AudioConduit; r=padenot This makes the shutdown behaviour of AudioConduit consistent with VideoConduit which should make the conduit code easier to read and reason about. Differential Revision: https://phabricator.services.mozilla.com/D25055