searching for reviewer(ochameau)
1650924d892cc2c6f31e85aec6acd3376865147e: Bug 1776167 - [devtools] Fix chromeContext for the legacy-listeners codepath r=ochameau, a=dmeehan
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 27 Jun 2022 13:22:16 +0000 - rev 693022
Push 16807 by dmeehan@mozilla.com at Wed, 29 Jun 2022 17:01:04 +0000
Bug 1776167 - [devtools] Fix chromeContext for the legacy-listeners codepath r=ochameau, a=dmeehan browser_console_enable_network_monitoring.js is failing on beta because MBT is not enabled by default so the the leagcy-listener copepath is used. This adds `chromeContext` to the network resource and fixes the issue. Differential Revision: https://phabricator.services.mozilla.com/D150328
92862991e711e3e9ac6a57645244b112f460ec4a: Bug 1776144 - [devtools] Remove unused TARGET_AVAILABLE action in WebConsole. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 23 Jun 2022 08:29:44 +0000 - rev 692730
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1776144 - [devtools] Remove unused TARGET_AVAILABLE action in WebConsole. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D150084
e77c68a3da9a7377d8f26e03c345d2827ef70e3c: Bug 1775411 - [devtools] Fix append new stylesheet link. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 22 Jun 2022 09:30:05 +0000 - rev 692584
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1775411 - [devtools] Fix append new stylesheet link. r=ochameau. The link was missing an event listener, that we add in this patch. A test case is added to make sure the link does work. Differential Revision: https://phabricator.services.mozilla.com/D149953
b54af8bf56142f765f8c48b5c5e188c466d7291e: Bug 1775113 - Make Loader.jsm honour ac_add_options --enable-debug-js-modules r=devtools-reviewers,ochameau
Michael Ratcliffe <mratcliffe@mozilla.com> - Wed, 22 Jun 2022 08:34:21 +0000 - rev 692542
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1775113 - Make Loader.jsm honour ac_add_options --enable-debug-js-modules r=devtools-reviewers,ochameau Differential Revision: https://phabricator.services.mozilla.com/D149778
bc573f999f803cf82221d0a55b473d5d834502e3: Bug 1775084 - [devtools] Support clearing of root-resources r=ochameau,devtools-backward-compat-reviewers
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 20 Jun 2022 15:32:16 +0000 - rev 692326
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1775084 - [devtools] Support clearing of root-resources r=ochameau,devtools-backward-compat-reviewers Differential Revision: https://phabricator.services.mozilla.com/D149635
7f9d6652f16ad436552bf892eb5af670bc1b74dc: Bug 1775084 - [devtools] Add framework capabilities to clear resources r=ochameau,devtools-backward-compat-reviewers,jdescottes
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 20 Jun 2022 15:32:15 +0000 - rev 692325
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1775084 - [devtools] Add framework capabilities to clear resources r=ochameau,devtools-backward-compat-reviewers,jdescottes Add support for clearing resources to the framework A resource command test is added in D148694 after clearing for network events is added Differential Revision: https://phabricator.services.mozilla.com/D148139
487946273b1065df84ec08088c3f5f1463500634: Bug 1775078 - [devtools] Don't await in for loop in NodePicker.#stop. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 20 Jun 2022 14:55:21 +0000 - rev 692320
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1775078 - [devtools] Don't await in for loop in NodePicker.#stop. r=ochameau. Instead, populate an array of Promise we can await on outside of the loop. Differential Revision: https://phabricator.services.mozilla.com/D149751
d9270fca4a3ffb6b33b0ecd30fc7d694ec6ca227: Bug 1744240 - [devtools] Set navigation message source to CONSOLE_FRONTEND. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 20 Jun 2022 14:03:18 +0000 - rev 692312
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1744240 - [devtools] Set navigation message source to CONSOLE_FRONTEND. r=ochameau. This fixes an intermittent on browser_webconsole_warn_about_replaced_api.js where an assertion was failing because the navigation message had the `console-api` class. We take this as an opportunity to add a navigation marker specific component instead of reusing the ConsoleApiCall one. Differential Revision: https://phabricator.services.mozilla.com/D149739
b2776977a909759b47b0e3be6c72b8ae00973f24: Bug 1771249 - [devtools] Fix priviledged requests showing as content messages r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 20 Jun 2022 13:48:26 +0000 - rev 692308
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1771249 - [devtools] Fix priviledged requests showing as content messages r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D147684
2528596d754a942edeec559f57f5caa688eda93e: Bug 1742979 - [bidi] Implement basic support for "script.evaluate" command r=webdriver-reviewers,whimboo,ochameau
Julian Descottes <jdescottes@mozilla.com> - Thu, 16 Jun 2022 19:44:43 +0000 - rev 692069
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1742979 - [bidi] Implement basic support for "script.evaluate" command r=webdriver-reviewers,whimboo,ochameau Adds a new root script module, and a new windowglobal script module. The root script module supports the public command evaluate, with the following limitations: - awaitPromise is not supported - the RealmTarget type is not supported - sandbox is not supported for the ContextTarget type - evaluation return values are not supported - exception handling is not supported - ownership model is not supported wdspec tests will be added via https://github.com/web-platform-tests/wpt/pull/34162 Differential Revision: https://phabricator.services.mozilla.com/D148907
034347a53a0209052ebeab15f5338b08d5dd98cc: Bug 1773994 - [devtools] Remove unnecessary code for network messages in MESSAGE_OPEN. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 15 Jun 2022 12:57:08 +0000 - rev 691856
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1773994 - [devtools] Remove unnecessary code for network messages in MESSAGE_OPEN. r=ochameau. With the changes from Bug 1686440, there's no benefit keeping this code around. Differential Revision: https://phabricator.services.mozilla.com/D149139
1a2b8a3c8055176bd4d681efd819072ecf8247b9: Bug 1773993 - [devtools] Remove unused removeIds variable in addMessage. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 15 Jun 2022 12:57:08 +0000 - rev 691855
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1773993 - [devtools] Remove unused removeIds variable in addMessage. r=ochameau. Nothing was added to the array, so we can remove it. Differential Revision: https://phabricator.services.mozilla.com/D149138
c678f72199826ead4f936cf173b32ba216618a24: Bug 1764501 - [devtools] Speedup adding messages out of order. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 15 Jun 2022 12:57:07 +0000 - rev 691854
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1764501 - [devtools] Speedup adding messages out of order. r=ochameau. In the console we might receive messages that need to be inserted at a specific position in the output to respect the chronological order. This is very visible when evaluating an expression in the console while we are fetching cached messages, or when the expression is logging lots of messages, since the evaluation result doesn't go through the ResourceCommand itself. Since we were relying on the order of insertion in `mutableMessagesById` for the order of messages in the output, we had no choice but clone the Map to insert the new message at the specific position. With lots of messages, this can be utterly slow, and is something people are experiencing. To fix this, we're adding a new state property, `mutableMessagesOrder`, which holds message ids in the chronological order. It's then used to compute `visibleMessages`. As we don't have to clone the Map anymore, it makes reordering as fast as looking for an index in the array and splicing it (which is fast). We also take this opportunity to switch away from our `findIndex` usage; most often than not, the messages will be reinserted at the end of the array, so we can loop through it backward to find the index faster. We still keep `mutableMessagesById` as a Map so lookup are fast, and we don't have to deal with impacts we'd have if we'd switch to an object. The existing node test helper to get a message at a specific index are migrated to make use of `mutableMessagesOrder`, and a few test cases and assertions are added to check that the new property is handled correctly. Differential Revision: https://phabricator.services.mozilla.com/D148658
657af115a0b736c258f062ed78b2a02e12196ea0: Bug 1773986 - [devtools] Add DAMP test case to cover adding out-of-order messages. r=ochameau,perftest-reviewers,sparky.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 15 Jun 2022 12:57:07 +0000 - rev 691853
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1773986 - [devtools] Add DAMP test case to cover adding out-of-order messages. r=ochameau,perftest-reviewers,sparky. This test demonstrates that the patch in Bug 1764501 does fix the performance issue we were seeing. Having it in tree will ensure we don't regress this. Differential Revision: https://phabricator.services.mozilla.com/D149110
6be112a33fb5ba5af477ae94678f01b23235c0c4: Bug 1772363 - [devtools] Ensure actually watching resources before pause/resume UI is updated r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Tue, 14 Jun 2022 15:38:07 +0000 - rev 691744
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772363 - [devtools] Ensure actually watching resources before pause/resume UI is updated r=ochameau Changing the pattern for toggling recording to ensure that pause/resumes actually start or stops watching resources before the ui states gets updated. Differential Revision: https://phabricator.services.mozilla.com/D148953
5092df1913d5091b814b9b98fa617921702f8ed4: Bug 1753048 - [devtools] Include the fallback window to the docShells array for webextension targets r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Tue, 14 Jun 2022 06:52:49 +0000 - rev 691665
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1753048 - [devtools] Include the fallback window to the docShells array for webextension targets r=ochameau Depends on D148489 This allows to properly set the cssErrorReportingEnabled flag on its docShell. While we are not interested in css errors for this fallback window, the windowglobal target actor will automatically set the flag on new root browsing contexts only if the previous one had the flag set. This way when we switch to a valid webextension document (eg a popup), the flag will be set and CSS errors will be reported. Differential Revision: https://phabricator.services.mozilla.com/D148836
845c0d85f221d7d52795f4fa186c7d6791ba7e88: Bug 1753048 - [devtools] Append the addonId to the DevTools fallback window URL r=ochameau
Julian Descottes <jdescottes@mozilla.com> - Tue, 14 Jun 2022 06:52:49 +0000 - rev 691664
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1753048 - [devtools] Append the addonId to the DevTools fallback window URL r=ochameau This window does not share the regular extension principal so we cannot fetch the addonId from the principal in the same way as we do for other documents. Instead we append the addonId to the URL and provide a new helper in browser-context-helpers to extract the addonId from a browsingContext. This helper should work transparently from the parent process and the content process, and should support browsing context for regular extension documents as well as browsing contexts for fallback windows. Differential Revision: https://phabricator.services.mozilla.com/D148489
e0d328cd054ba7ea7e131aa5b0a24d486b3ff643: Bug 1772363 - [devtools] Fix intermittent on browser_net_pause.js r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Thu, 09 Jun 2022 09:34:31 +0000 - rev 691149
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772363 - [devtools] Fix intermittent on browser_net_pause.js r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D148674
d193aa033e1e6bdcad73c87b4211774d817eedc0: Bug 1771277 - [devtools] Remove the websocket and server sent events prefs r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Tue, 07 Jun 2022 12:18:49 +0000 - rev 690823
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1771277 - [devtools] Remove the websocket and server sent events prefs r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D147413
e9828113f050abbc521e5aa58c491b926c170032: Bug 1764348 - Pause / Resume should toggle listening to network resources r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Tue, 07 Jun 2022 12:18:49 +0000 - rev 690822
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1764348 - Pause / Resume should toggle listening to network resources r=ochameau With this patch Pause and Resume, now stop and start listening to network requests. Differential Revision: https://phabricator.services.mozilla.com/D148488
e440a0831a58b4ea86124bea3197264f0eb6f0dd: Bug 1771659 - [devtools] Fix perma failure in BETA r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Tue, 07 Jun 2022 07:39:42 +0000 - rev 690797
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1771659 - [devtools] Fix perma failure in BETA r=ochameau The multiprocess browser toolbox is on by default in BETA, so we need to switch it on explicitly for the addon extensions to be listed. Differential Revision: https://phabricator.services.mozilla.com/D148392
d4191d470750ee1b00010bc99a88d63fbbfa420c: Bug 1772093 - Part 9: Use plain object for lazy getter in devtools/startup/. r=devtools-reviewers,ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:55 +0000 - rev 690657
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 9: Use plain object for lazy getter in devtools/startup/. r=devtools-reviewers,ochameau Differential Revision: https://phabricator.services.mozilla.com/D147905
5d2ed8641b200d02c238c0ba7f98182b2d061635: Bug 1772093 - Part 8: Use plain object for lazy getter in devtools/shared/loader/. r=devtools-reviewers,ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:54 +0000 - rev 690656
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 8: Use plain object for lazy getter in devtools/shared/loader/. r=devtools-reviewers,ochameau Differential Revision: https://phabricator.services.mozilla.com/D147904
39176a410dc894623770d3ddd607a03998bfa8b4: Bug 1772093 - Part 7: Use plain object for lazy getter in devtools/server/connectors/. r=devtools-reviewers,ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:54 +0000 - rev 690655
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 7: Use plain object for lazy getter in devtools/server/connectors/. r=devtools-reviewers,ochameau Differential Revision: https://phabricator.services.mozilla.com/D147903
60b22cd1f3bb1ec1eb75e5ed9b130929b4dcd04a: Bug 1772093 - Part 6: Use plain object for lazy getter in devtools/server/actors/. r=devtools-reviewers,ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:54 +0000 - rev 690654
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 6: Use plain object for lazy getter in devtools/server/actors/. r=devtools-reviewers,ochameau Differential Revision: https://phabricator.services.mozilla.com/D147902
69abd3204293a6c9a5c457ff076d856105e5a5be: Bug 1772093 - Part 5: Use plain object for lazy getter in devtools/client/styleeditor/. r=devtools-reviewers,ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:53 +0000 - rev 690653
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 5: Use plain object for lazy getter in devtools/client/styleeditor/. r=devtools-reviewers,ochameau Differential Revision: https://phabricator.services.mozilla.com/D147901
5c3774a15e991f4e09ff975ba5a2aca60fbb9e5d: Bug 1772093 - Part 4: Use plain object for lazy getter in devtools/client/storage/. r=devtools-reviewers,ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:53 +0000 - rev 690652
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 4: Use plain object for lazy getter in devtools/client/storage/. r=devtools-reviewers,ochameau Differential Revision: https://phabricator.services.mozilla.com/D147900
1b43ca2a6774bb42f82830c11470c669194f09ae: Bug 1772093 - Part 3: Use plain object for lazy getter in devtools/client/shared/. r=devtools-reviewers,ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:53 +0000 - rev 690651
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 3: Use plain object for lazy getter in devtools/client/shared/. r=devtools-reviewers,ochameau Differential Revision: https://phabricator.services.mozilla.com/D147899
e531a1b64b4e1a5c72a3388e19c415f162e33dea: Bug 1772093 - Part 2: Use plain object for lazy getter in devtools/client/jsonview/. r=ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:52 +0000 - rev 690650
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 2: Use plain object for lazy getter in devtools/client/jsonview/. r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D147898
5913f29e0b783d3dce96d11b48aa3a3161698d9f: Bug 1772093 - Part 1: Use plain object for lazy getter in devtools/client/framework/. r=ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:52 +0000 - rev 690649
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 1: Use plain object for lazy getter in devtools/client/framework/. r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D147897
569af989260a57e1acacfef2e487ce7a1d3c4016: Bug 1772093 - Part 0: Eagerly import some modules in devtools/. r=ochameau
Tooru Fujisawa <arai_a@mac.com> - Mon, 06 Jun 2022 07:09:51 +0000 - rev 690648
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772093 - Part 0: Eagerly import some modules in devtools/. r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D148178
176c288277f4fba9ded850f635f18c25f7049cb8: Bug 1772239 - [devtools] Stop reading client preference devtools.browsertoolbox.fission in the devtools server r=ochameau,devtools-backward-compat-reviewers,bomsy
Julian Descottes <jdescottes@mozilla.com> - Fri, 03 Jun 2022 16:51:51 +0000 - rev 690546
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1772239 - [devtools] Stop reading client preference devtools.browsertoolbox.fission in the devtools server r=ochameau,devtools-backward-compat-reviewers,bomsy The devtools.browsertoolbox.fission should not be read on the server but should instead be provided to the server by the client. The breakage can be reproduced if you try to debug a Firefox desktop with devtools.browsertoolbox.fission = false from a Firefox with devtools.browsertoolbox.fission = true. Differential Revision: https://phabricator.services.mozilla.com/D148129
21c03813c9d0790422129c332a0c797d4aec6380: Bug 1771277 - [devtools] Remove the websocket and server sent events prefs r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Thu, 02 Jun 2022 14:35:25 +0000 - rev 690451
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1771277 - [devtools] Remove the websocket and server sent events prefs r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D147413
0ee89f81d7da0bad363aab7527fb4ac122f13972: Bug 1764348 - Pause / Resume should toggle listening to network resources r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Thu, 02 Jun 2022 14:35:24 +0000 - rev 690450
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1764348 - Pause / Resume should toggle listening to network resources r=ochameau With this patch Pause and Resume, now stop and start listening to network requests Differential Revision: https://phabricator.services.mozilla.com/D146445
d7c44ddd5e6ff764a7007a2df88eedbf91236716: Bug 1770869 - remove unused client certificate authentication for remote devtools r=ochameau
Dana Keeler <dkeeler@mozilla.com> - Wed, 01 Jun 2022 23:20:57 +0000 - rev 690369
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1770869 - remove unused client certificate authentication for remote devtools r=ochameau Client certificate authentication for remote devtools was used in WebIDE, which was removed from Firefox 71 in bug 1539462. Differential Revision: https://phabricator.services.mozilla.com/D147121
5a138d047be11719557da49970087039aa233aba: Bug 1770869 - remove unused client certificate authentication for remote devtools r=ochameau
Dana Keeler <dkeeler@mozilla.com> - Wed, 01 Jun 2022 20:00:57 +0000 - rev 690348
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1770869 - remove unused client certificate authentication for remote devtools r=ochameau Client certificate authentication for remote devtools was used in WebIDE, which was removed from Firefox 71 in bug 1539462. Differential Revision: https://phabricator.services.mozilla.com/D147121
922dc4e167b7362c10c1781f500755664b43282b: Bug 1753048 - [devtools] Include the fallback window to the docShells array for webextension targets r=ochameau a=pascalc
Julian Descottes <jdescottes@mozilla.com> - Tue, 14 Jun 2022 06:52:49 +0000 - rev 689981
Push 16777 by pchevrel@mozilla.com at Wed, 15 Jun 2022 07:15:21 +0000
Bug 1753048 - [devtools] Include the fallback window to the docShells array for webextension targets r=ochameau a=pascalc Depends on D148489 This allows to properly set the cssErrorReportingEnabled flag on its docShell. While we are not interested in css errors for this fallback window, the windowglobal target actor will automatically set the flag on new root browsing contexts only if the previous one had the flag set. This way when we switch to a valid webextension document (eg a popup), the flag will be set and CSS errors will be reported. Differential Revision: https://phabricator.services.mozilla.com/D148836
5c712672d2d21dfd060c26ca825eef27fbe4b0fe: Bug 1753048 - [devtools] Append the addonId to the DevTools fallback window URL r=ochameau a=pascalc
Julian Descottes <jdescottes@mozilla.com> - Tue, 14 Jun 2022 06:52:49 +0000 - rev 689980
Push 16777 by pchevrel@mozilla.com at Wed, 15 Jun 2022 07:15:21 +0000
Bug 1753048 - [devtools] Append the addonId to the DevTools fallback window URL r=ochameau a=pascalc This window does not share the regular extension principal so we cannot fetch the addonId from the principal in the same way as we do for other documents. Instead we append the addonId to the URL and provide a new helper in browser-context-helpers to extract the addonId from a browsingContext. This helper should work transparently from the parent process and the content process, and should support browsing context for regular extension documents as well as browsing contexts for fallback windows. Differential Revision: https://phabricator.services.mozilla.com/D148489
5bb63a5b39bdd3c3b7e72bd41743b0e5ddd93af3: Bug 1772239 - [devtools] Stop reading client preference devtools.browsertoolbox.fission in the devtools server r=ochameau,devtools-backward-compat-reviewers,bomsy a=pascalc
Julian Descottes <jdescottes@mozilla.com> - Fri, 03 Jun 2022 16:51:51 +0000 - rev 689882
Push 16729 by pchevrel@mozilla.com at Tue, 07 Jun 2022 09:12:46 +0000
Bug 1772239 - [devtools] Stop reading client preference devtools.browsertoolbox.fission in the devtools server r=ochameau,devtools-backward-compat-reviewers,bomsy a=pascalc The devtools.browsertoolbox.fission should not be read on the server but should instead be provided to the server by the client. The breakage can be reproduced if you try to debug a Firefox desktop with devtools.browsertoolbox.fission = false from a Firefox with devtools.browsertoolbox.fission = true. Differential Revision: https://phabricator.services.mozilla.com/D148129
a71be00e24970e7139225fd13511e788bc9ca6e4: Bug 1770160 - [devtools] Don't filter out platform-specific errors in Browser Console/Browser Toolbox. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 20 May 2022 05:47:23 +0000 - rev 688995
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1770160 - [devtools] Don't filter out platform-specific errors in Browser Console/Browser Toolbox. r=ochameau. This is as simple as checking the session context type. Differential Revision: https://phabricator.services.mozilla.com/D146818
79b0fc57aff3e7ca985068f4a8ec3d2968d50ec8: Bug 1761554 - Use a Map-based cache for ResourceCommand r=ochameau
Doug Thayer <dothayer@mozilla.com> - Thu, 19 May 2022 16:39:14 +0000 - rev 688930
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1761554 - Use a Map-based cache for ResourceCommand r=ochameau This just intends to alleviate the more noticeable problem when the cache grows too large by avoiding iterating through the array every time something changes. There still remains the work of limiting the size of this based on what the UI is capped at, but that can come later. Differential Revision: https://phabricator.services.mozilla.com/D142279
ea32c4c1d987ddef9f831edbb1c4cb187930dc16: Bug 1700092 - [devtools] Add supported targets and resources to session context. r=bomsy,ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 19 May 2022 05:24:53 +0000 - rev 688865
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1700092 - [devtools] Add supported targets and resources to session context. r=bomsy,ochameau. This allows us to simplify and fix `hasStyleSheetWatcherSupportForTarget`. In the browser toolbox, since we're in a "all" session context type, `TargetActorRegistry.getTargetActors` would only return an array of a single element, the parent process target. In case of window global targets, in the browser toolbox context, we wouldn't find the target we're looking for, which was making `hasStyleSheetWatcherSupportForTarget` return false. We can now simply look into the targetActor session context. Depends on D146584 Differential Revision: https://phabricator.services.mozilla.com/D146193
597785337a95b29ebbc11ed3c1834653e2552acd: Bug 1766237 - [devtools] Get the WebExtensionPolicy from the ExtensionProcessScript global r=jdescottes,rpl,ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Wed, 18 May 2022 08:56:13 +0000 - rev 688761
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1766237 - [devtools] Get the WebExtensionPolicy from the ExtensionProcessScript global r=jdescottes,rpl,ochameau The issue here is it seems like WebExtensionPolicy is not always available on the Cu global, therefore failing when trying to get the extension policy name. in this example when adding sources from the browser toolbox (i'm still not completely sure why) The solution here is changing to using the ExtensionProcessScript which works for the web and browser toolbox. Also added a `console.warn` so we get some notification when this fails. Differential Revision: https://phabricator.services.mozilla.com/D144787
e7bc7584f0c21b0b12847b6d180b3e5008fe5689: Bug 1755197 - [devtools] Remove breakpoint shifting on breakpoint syncing r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Fri, 13 May 2022 03:35:18 +0000 - rev 687824
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1755197 - [devtools] Remove breakpoint shifting on breakpoint syncing r=ochameau This patch focuses on removing breakpoint shifting which is mostly used in non-sourcemapping scenarios. Differential Revision: https://phabricator.services.mozilla.com/D138625
bc3ad1de463538b2da49c35a1923b19d8aa99d8b: Bug 1762865 - [devtools] Add assertion for server breakpoints in breakpoints tests r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Fri, 29 Apr 2022 14:23:51 +0000 - rev 686152
Push 16598 by ffxbld-merge at Mon, 02 May 2022 14:23:32 +0000
Bug 1762865 - [devtools] Add assertion for server breakpoints in breakpoints tests r=ochameau This patch also adds assertions for breakpoints on the server to the breakpoints reload tests. This also asserts that the breakpoint is not removed on the server when related source no longer exists after a reload Differential Revision: https://phabricator.services.mozilla.com/D142545
c8fee25f3eab73612c88bb831493db08842b5ce0: Bug 1764055 - [devtools] Add tests for breakpoints in original source whose generated source content changes on reload r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Fri, 29 Apr 2022 14:23:51 +0000 - rev 686151
Push 16598 by ffxbld-merge at Mon, 02 May 2022 14:23:32 +0000
Bug 1764055 - [devtools] Add tests for breakpoints in original source whose generated source content changes on reload r=ochameau Updating the bug id Differential Revision: https://phabricator.services.mozilla.com/D142047
87cb99924fc44a0a599b8119a977b36486331eef: Bug 1762865 - [devtools] Add assertion for server breakpoints in breakpoints tests r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 25 Apr 2022 11:46:23 +0000 - rev 685661
Push 16598 by ffxbld-merge at Mon, 02 May 2022 14:23:32 +0000
Bug 1762865 - [devtools] Add assertion for server breakpoints in breakpoints tests r=ochameau This patch also adds assertions for breakpoints on the server to the breakpoints reload tests. This also asserts that the breakpoint is not removed on the server when related source no longer exists after a reload Differential Revision: https://phabricator.services.mozilla.com/D142545
83c8bb7087f50dec500df7ddd6e353b13483b964: Bug 1764055 - [devtools] Add tests for breakpoints in original source whose generated source content changes on reload r=ochameau
Hubert Boma Manilla <hmanilla@mozilla.com> - Mon, 25 Apr 2022 11:46:22 +0000 - rev 685660
Push 16598 by ffxbld-merge at Mon, 02 May 2022 14:23:32 +0000
Bug 1764055 - [devtools] Add tests for breakpoints in original source whose generated source content changes on reload r=ochameau Updating the bug id Differential Revision: https://phabricator.services.mozilla.com/D142047
ae9861178cd12cf79fc2460bcdacc6bd47b13e5e: Bug 1765748 - [devtools] Remove SplitView active summary getter and rename setter. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 22 Apr 2022 13:56:01 +0000 - rev 685574
Push 16598 by ffxbld-merge at Mon, 02 May 2022 14:23:32 +0000
Bug 1765748 - [devtools] Remove SplitView active summary getter and rename setter. r=ochameau. Differential Revision: https://phabricator.services.mozilla.com/D144302
1d349aa089bc8c90539ca0f70854148617a4c324: Bug 1765748 - [devtools] Merge SplitView appendTemplateItem and appendItem. r=ochameau.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 22 Apr 2022 13:56:01 +0000 - rev 685573
Push 16598 by ffxbld-merge at Mon, 02 May 2022 14:23:32 +0000
Bug 1765748 - [devtools] Merge SplitView appendTemplateItem and appendItem. r=ochameau. The template nodes are retrieved and cached from the constructor so we don't have to do it for every item we add. Differential Revision: https://phabricator.services.mozilla.com/D144269