searching for reviewer(nical)
522a5434e0a4: Bug 1503082 - Clear CanvasShutdownObserver::mCanvas when the canvas goes away. r=nical, a=RyanVM
Andrew McCreight <continuation@gmail.com> - Mon, 05 Nov 2018 21:35:44 -0500 - rev 498377
Push 10130 by ryanvm@gmail.com at Wed, 07 Nov 2018 20:03:30 +0000
Bug 1503082 - Clear CanvasShutdownObserver::mCanvas when the canvas goes away. r=nical, a=RyanVM It is possible for the CanvasRenderingContext2D to be destroyed while we're in the middle of the call to nsObserverService::NotifyObservers() for shutdown. This leaves the shutdown observer with a dangling pointer to the canvas, so this patch explicitly clears the pointer when the context goes away. Differential Revision: https://phabricator.services.mozilla.com/D10777
7400b733b50f: Bug 1499186 Part 3 - Don't show out of order graphics in the middleman, r=nical.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:43:32 -0600 - rev 497798
Push 10002 by archaeopteryx@coole-files.de at Fri, 19 Oct 2018 23:09:29 +0000
Bug 1499186 Part 3 - Don't show out of order graphics in the middleman, r=nical.
b341213ecf95: Bug 1499186 Part 2 - Only allow one in flight paint at a time, r=nical.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:32:13 -0600 - rev 497797
Push 10002 by archaeopteryx@coole-files.de at Fri, 19 Oct 2018 23:09:29 +0000
Bug 1499186 Part 2 - Only allow one in flight paint at a time, r=nical.
0fba5665bc65: Bug 1499186 Part 1 - Allow recording/replaying processes to ignore vsyncs, r=nical.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:18:50 -0600 - rev 497796
Push 10002 by archaeopteryx@coole-files.de at Fri, 19 Oct 2018 23:09:29 +0000
Bug 1499186 Part 1 - Allow recording/replaying processes to ignore vsyncs, r=nical.
7f2e0b3603b4: Bug 1488808 Part 17 - Allow paints to happen at the normal time when recording/replaying, r=nical.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:16:30 -0600 - rev 497795
Push 10002 by archaeopteryx@coole-files.de at Fri, 19 Oct 2018 23:09:29 +0000
Bug 1488808 Part 17 - Allow paints to happen at the normal time when recording/replaying, r=nical.
9b5b68080ee6: Bug 1488808 Part 13 - Avoid blocking the main thread when painting, and allow repaints after diverging from the recording, r=nical.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:06:43 -0600 - rev 497791
Push 10002 by archaeopteryx@coole-files.de at Fri, 19 Oct 2018 23:09:29 +0000
Bug 1488808 Part 13 - Avoid blocking the main thread when painting, and allow repaints after diverging from the recording, r=nical.
52a35a1526e7: Bug 1497910 - Call wr_renderer_readback() before calling RenderCompositor::EndFrame() r=nical
sotaro <sotaro.ikeda.g@gmail.com> - Wed, 17 Oct 2018 07:54:01 +0900 - rev 497338
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1497910 - Call wr_renderer_readback() before calling RenderCompositor::EndFrame() r=nical
085738995db1: Bug 1498982 - Use GL/WebRender compatible visual only when it is necessary necessary r=nical
sotaro <sotaro.ikeda.g@gmail.com> - Tue, 16 Oct 2018 21:14:52 +0900 - rev 497211
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1498982 - Use GL/WebRender compatible visual only when it is necessary necessary r=nical
3ad88a9f8f35: Bug 1498092 - Add necessary forced frame rendering r=nical
sotaro <sotaro.ikeda.g@gmail.com> - Mon, 15 Oct 2018 20:28:01 +0900 - rev 497020
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1498092 - Add necessary forced frame rendering r=nical
da3c96e21a15: Bug 1497294 - P2. Move type related constant methods to Types.h r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 09 Oct 2018 12:56:25 +0000 - rev 496483
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497294 - P2. Move type related constant methods to Types.h r=nical The methods BytesPerPixel, SurfaceFormatForColorDepth, BitDepthForColorDepth, ColorDepthForBitDepth and RescalingFactorForColorDepth all directly depends on the types defined in Types.h, they also return constant values. As such it makes more sense to have them defined at the same level where the types themselves are declared. Depends on D8065 Differential Revision: https://phabricator.services.mozilla.com/D8073
a6481e1de633: Bug 1497294 - P1. Remove duplicated method. r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 09 Oct 2018 13:07:58 +0000 - rev 496482
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497294 - P1. Remove duplicated method. r=nical Additionally, add info for the following type: R8G8B8 B8G8R8 R8G8 HSV Lab DEPTH Differential Revision: https://phabricator.services.mozilla.com/D8065
d85e5fb4421c: Bug 1494994 - Disable WebRender when recording/replaying, r=nical.
Brian Hackett <bhackett1024@gmail.com> - Tue, 09 Oct 2018 14:31:49 -1000 - rev 496238
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494994 - Disable WebRender when recording/replaying, r=nical.
bc87d3ddef61: Bug 1461239 - Use InvalidateRenderedFrame() when necessary r=nical
Sotaro Ikeda <sotaro.ikeda.g@gmail.com> - Tue, 09 Oct 2018 23:20:23 -0400 - rev 496210
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1461239 - Use InvalidateRenderedFrame() when necessary r=nical
9818fa498ba5: Bug 1495025 - P4. Add COLOR_16 type r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 04 Oct 2018 09:47:57 +0000 - rev 495700
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1495025 - P4. Add COLOR_16 type r=nical Depends on D7296 Differential Revision: https://phabricator.services.mozilla.com/D7316
9f59a50dcc6d: Bug 1495025 - P4. Add COLOR_16 type r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 04 Oct 2018 09:47:57 +0000 - rev 495656
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1495025 - P4. Add COLOR_16 type r=nical Depends on D7296 Differential Revision: https://phabricator.services.mozilla.com/D7316
c1354102f8a8: Bug 1494222: set XYZ PCS on internal RGB profiles. r=nical
Thomas P. <pdknsk+mozilla@gmail.com> - Wed, 26 Sep 2018 08:38:24 +0000 - rev 495643
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494222: set XYZ PCS on internal RGB profiles. r=nical
4869ae749ced: Bug 1494222: don't check bogosity of profiles with LUT-types mAB/mBA. r=nical
Thomas P. <pdknsk+mozilla@gmail.com> - Wed, 26 Sep 2018 08:43:33 +0000 - rev 495642
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494222: don't check bogosity of profiles with LUT-types mAB/mBA. r=nical
25895d283d47: Bug 1495025 - P4. Add COLOR_16 type r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 04 Oct 2018 09:47:57 +0000 - rev 495281
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1495025 - P4. Add COLOR_16 type r=nical Depends on D7296 Differential Revision: https://phabricator.services.mozilla.com/D7316
aa6baa1cd577: Bug 1495352 - Make wr_notifier_nop_frame_done() notify DidComposite r=nical
sotaro <sotaro.ikeda.g@gmail.com> - Tue, 02 Oct 2018 12:13:22 +0900 - rev 494866
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1495352 - Make wr_notifier_nop_frame_done() notify DidComposite r=nical
238fb42f209e: Bug 1494533 - Fix log message of copy-paste error r=nical
sotaro <sotaro.ikeda.g@gmail.com> - Fri, 28 Sep 2018 14:36:30 +0900 - rev 494404
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494533 - Fix log message of copy-paste error r=nical
4ee1e1103a82: Bug 1438171 - Re-enable passing reftest. r=nical
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 27 Sep 2018 13:04:27 -0400 - rev 494309
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1438171 - Re-enable passing reftest. r=nical
1dde355c049c: Bug 1493088 - Use non low priority transaction for async pipline with ImageBridge r=nical
sotaro <sotaro.ikeda.g@gmail.com> - Wed, 26 Sep 2018 11:45:30 +0900 - rev 494014
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1493088 - Use non low priority transaction for async pipline with ImageBridge r=nical
b571f960e636: Bug 1493198 - P3. Fix typo and use move semantics. r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 25 Sep 2018 12:18:58 +0000 - rev 493940
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1493198 - P3. Fix typo and use move semantics. r=nical Depends on D6663 Differential Revision: https://phabricator.services.mozilla.com/D6764
fa105d110671: Bug 1493198 - P1. Make ImageDescriptor::is_opaque an enum and rename accordingly. r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 24 Sep 2018 14:24:30 +0000 - rev 493938
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1493198 - P1. Make ImageDescriptor::is_opaque an enum and rename accordingly. r=nical Prevent future ambiguous conversion once a bit depth int is added. Also more self-explanatory Differential Revision: https://phabricator.services.mozilla.com/D6662
6d5ef8a0aab8: Bug 1492930 - Part 5. Integrate extra shared surface memory reporting with gfx. r=nical
Andrew Osmond <aosmond@mozilla.com> - Tue, 25 Sep 2018 09:13:51 -0400 - rev 493907
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492930 - Part 5. Integrate extra shared surface memory reporting with gfx. r=nical This patch enables the compositor process memory reporting for both the dedicated GPU process case, and the integrated with the main process case. This will simply cause us to list all of the entries in the shared surfaces cache to show what is presently mapped in.
2fe085ff6677: Bug 1492930 - Part 2. Expose the external image ID for surfaces' memory reporting. r=nical
Andrew Osmond <aosmond@mozilla.com> - Tue, 25 Sep 2018 09:13:51 -0400 - rev 493904
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492930 - Part 2. Expose the external image ID for surfaces' memory reporting. r=nical
df5f3e347750: Bug 1492930 - Part 1. Expose composition of shared surfaces cache to allow memory reporting. r=nical
Andrew Osmond <aosmond@mozilla.com> - Tue, 25 Sep 2018 09:13:51 -0400 - rev 493903
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492930 - Part 1. Expose composition of shared surfaces cache to allow memory reporting. r=nical This exposes methods to capture a snapshot of the SharedSurfacesParent cache for memory reporting purposes. It yields the identifiers, image properties and references to images mapped in the cache. This will be used by the compositor process to list everything it has mapped into its memory space. It will also be used by the content processes / main process to list images that specific process had mapped into the compositor process. This will allow us to easily identify what images remain in the compositor process, but are missing from the surface cache.
bdb1bf2d8062: Bug 1492930 - Part 5. Integrate extra shared surface memory reporting with gfx. r=nical
Andrew Osmond <aosmond@mozilla.com> - Tue, 25 Sep 2018 06:18:06 -0400 - rev 493891
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492930 - Part 5. Integrate extra shared surface memory reporting with gfx. r=nical This patch enables the compositor process memory reporting for both the dedicated GPU process case, and the integrated with the main process case. This will simply cause us to list all of the entries in the shared surfaces cache to show what is presently mapped in.
1a6b422c5a90: Bug 1492930 - Part 2. Expose the external image ID for surfaces' memory reporting. r=nical
Andrew Osmond <aosmond@mozilla.com> - Tue, 25 Sep 2018 06:18:06 -0400 - rev 493888
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492930 - Part 2. Expose the external image ID for surfaces' memory reporting. r=nical
a3b3f4cdc9fa: Bug 1492930 - Part 1. Expose composition of shared surfaces cache to allow memory reporting. r=nical
Andrew Osmond <aosmond@mozilla.com> - Tue, 25 Sep 2018 06:18:06 -0400 - rev 493887
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492930 - Part 1. Expose composition of shared surfaces cache to allow memory reporting. r=nical This exposes methods to capture a snapshot of the SharedSurfacesParent cache for memory reporting purposes. It yields the identifiers, image properties and references to images mapped in the cache. This will be used by the compositor process to list everything it has mapped into its memory space. It will also be used by the content processes / main process to list images that specific process had mapped into the compositor process. This will allow us to easily identify what images remain in the compositor process, but are missing from the surface cache.
1330a9eb3da5: Bug 1486959 - Remove bogus assertion in ContentClient. r=nical
Ryan Hunt <rhunt@eqrion.net> - Thu, 20 Sep 2018 10:54:19 -0500 - rev 493435
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1486959 - Remove bogus assertion in ContentClient. r=nical It's possible to trigger this assertion with asyncPaint = true and bufferRotation != (0, 0). In this case though everything should work fine, because we didn't start a new paint task, and we should be able to copy over buffers. So we should be able to remove this assertion.
6bdb27c174e9: Bug 1492323 - Make explicit that WebRenderBridgeParent::MaybeGenerateFrame() is called if it is root WRBP r=nical
sotaro <sotaro.ikeda.g@gmail.com> - Thu, 20 Sep 2018 17:47:05 +0900 - rev 493154
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492323 - Make explicit that WebRenderBridgeParent::MaybeGenerateFrame() is called if it is root WRBP r=nical
a79ed7cdda37: Bug 1488585 - Use ImageRendering property to provide proper filtering for list-style-image on WR. r=nical
Henrik Winnemöller <h.winnemoeller@web.de> - Fri, 07 Sep 2018 22:29:36 +0200 - rev 491014
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488585 - Use ImageRendering property to provide proper filtering for list-style-image on WR. r=nical Use the ImageRendering needed for Bug 1488555 to provide the correct ImageRendering argument for the PushImage call at the end of CreateWebRenderCommandsForImage instead of always using Auto filtering.
723580244cfb: Bug 1488555 - Use ImageRendering property to provide proper filtering support for AsyncImage. r=nical
Henrik Winnemöller <h.winnemoeller@web.de> - Fri, 07 Sep 2018 22:28:41 +0200 - rev 491013
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488555 - Use ImageRendering property to provide proper filtering support for AsyncImage. r=nical Introduce an ImageRendering argument for CreateImageKey which is then used at the CreateAsyncImageWebRenderCommands call to provide the proper filtering instead of using always Auto filtering. Update all calls to CreateImageKey to use the new interface.
5d90cbaeceb8: Bug 1452979 - Update reftest expectations. r=nical
Henrik Winnemöller <h.winnemoeller@web.de> - Mon, 03 Sep 2018 21:46:32 +0200 - rev 490776
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1452979 - Update reftest expectations. r=nical
65002b9b5bca: Bug 1452979 - Use ImageRendering property to provide proper filtering on NativeTexture external images. r=nical
Henrik Winnemöller <h.winnemoeller@web.de> - Mon, 03 Sep 2018 21:43:31 +0200 - rev 490775
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1452979 - Use ImageRendering property to provide proper filtering on NativeTexture external images. r=nical Introduce an ImageRendering argument to the lock call to external images. In case of NativeTexture external images, this ImageRendering argument is used to set the GL_TEXTURE_MIN/MAG_FILTER on texture creation. The filtering is also updated when a lock call is used on an existing texture with a different ImageRendering argument. The WR bindings and auto generated files have been updated.
1ff28f2b711f: Bug 1473890 - Verify that CompositorAnimations come from the content process that they claim. r=nical
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 06 Sep 2018 02:36:10 +0000 - rev 490764
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1473890 - Verify that CompositorAnimations come from the content process that they claim. r=nical MozReview-Commit-ID: AqcezlMQXE4 Differential Revision: https://phabricator.services.mozilla.com/D4840
36c326e6058b: Bug 1488498 - expand comment in CompositorBridgeChild::Get(); r=nical
Alex Gaynor <agaynor@mozilla.com> - Tue, 04 Sep 2018 12:58:34 -0400 - rev 490579
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488498 - expand comment in CompositorBridgeChild::Get(); r=nical
e4f3b85bc61b: Bug 1488403 - Make sticky legend reftest not depend on groove border antialising. r=nical
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 04 Sep 2018 15:17:04 +0000 - rev 490319
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488403 - Make sticky legend reftest not depend on groove border antialising. r=nical This reftest fails with my changes from https://github.com/servo/webrender/pull/3010. I tried to debug locally but it passes here. The reason it fails is because WebRender does distance AA between the segments of a ridge / groove border, and there's a subpixel difference so we get the AA slightly different in the test. Gecko on the other hand represents these borders as different composed solid segments, so it can't have this problem, since it doesn't do AA across the segments. We may want to change that, but it's not clear to me it's wanted, since rounded corners for these look much better on WR, for example. Rather than fuzzing the test or something like that, make the test not rely on that, given it's testing the position of the legend. Differential Revision: https://phabricator.services.mozilla.com/D4934
5830b5e072d0: Bug 1486619 - Handle empty regions when drawing in recording/replaying processes, r=nical.
Brian Hackett <bhackett1024@gmail.com> - Fri, 31 Aug 2018 05:36:12 -1000 - rev 489563
Push 9738 by aciure@mozilla.com at Mon, 03 Sep 2018 16:13:51 +0000
Bug 1486619 - Handle empty regions when drawing in recording/replaying processes, r=nical.
d4cb5a2697e5: Bug 1485937 - Avoid a useless allocation in wr_dp_define_clipchain. r=nical
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 24 Aug 2018 12:03:23 +0000 - rev 488415
Push 9723 by archaeopteryx@coole-files.de at Sat, 25 Aug 2018 16:16:06 +0000
Bug 1485937 - Avoid a useless allocation in wr_dp_define_clipchain. r=nical Differential Revision: https://phabricator.services.mozilla.com/D4196
a77c322a5422: Bug 1485371 - Re-enable tiling for OpenBSD. r=nical
Ryan Hunt <rhunt@eqrion.net> - Wed, 22 Aug 2018 09:34:22 -0500 - rev 487989
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1485371 - Re-enable tiling for OpenBSD. r=nical
3ef0a3315910: Bug 1245400 - P5. Report frames dropped with WebRender. r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 17 Jul 2018 01:12:35 +0200 - rev 487985
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1245400 - P5. Report frames dropped with WebRender. r=nical Differential Revision: https://phabricator.services.mozilla.com/D2182
cfd2152bd331: Bug 1245400 - P4. Remove no longer used class member. r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 16 Jul 2018 23:25:12 +0200 - rev 487984
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1245400 - P4. Remove no longer used class member. r=nical Also speed up compositing videos as there's no longer need to check every single frames twice to determine if they were composited or not. Differential Revision: https://phabricator.services.mozilla.com/D2178
49ca44a69f9f: Bug 1245400 - P3. Report number of frames dropped by compositor back to VideoSink. r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 16 Jul 2018 23:19:09 +0200 - rev 487983
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1245400 - P3. Report number of frames dropped by compositor back to VideoSink. r=nical We report the number of frames dropped by the compositor because they were too late through: ImageComposite -> ImageHost -> CompositableTransactionParent -> ImageBridgeParent -> IPDL -> ImageBridgeChild -> ImageContainerListener -> ImageContainer -> VideoSink Differential Revision: https://phabricator.services.mozilla.com/D2177
3e0995cbb3df: Bug 1245400 - P2. Keep track of frames that should have been painted but didn't. r=nical, r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 16 Jul 2018 14:52:41 +0200 - rev 487982
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1245400 - P2. Keep track of frames that should have been painted but didn't. r=nical, r=mattwoodrow We can't rely on the FrameID continuity to determine if a frame has been dropped due to timing or not. The reason being that the VideoSink will not send to the compositor frames it knows as being late already (causing a discontinuity in the frames IDs), and count them as being dropped. If we were to look at discontinuity on the compositor we would account for those frames twice. FramesID will also increase non-linearly if a frame isn't painted because it's not visible (either out of the visible tree or in a hidden tab). What we can measure however, is when a frame should have been painted but didn't because it was too late by looking at the value returned by ImageComposite::ChooseImageIndex() or when a new set of images is being received by the ImageComposite. Any images found in the earlier array but never returned must have been dropped due to timing. Looking at the index continuity greatly simplify the logic as we no longer need to worry if a video is hidden or not, or be part of a layer that is itself hidden as neither SetImages will be called then, nor ChooseImage For now, we only account for those frames dropped, and do not report them yet. Differential Revision: https://phabricator.services.mozilla.com/D2176
257fe22ca35f: Bug 1245400 - P1. Make ImageComposite::mImages a private member. r=nical
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 13 Jul 2018 12:42:18 +0200 - rev 487981
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1245400 - P1. Make ImageComposite::mImages a private member. r=nical We will use the characteristic of which TimedImage is returned to keep track on how many frames were dropped because they were too old. As such, we must make sure the retrieval of the current image is serialised. This allows to reduce duplicated code between WebRenderImageHost and ImageHost classes. Additionally, make RenderInfo::img member const as really, we never want to modify that one. A future change will enforce that RenderInfo.img never survives longer than the ChooseImage()'s caller to clarify the lifetime of the TimedImage. Differential Revision: https://phabricator.services.mozilla.com/D2175
ad10cbe201c4: Bug 1429298 - Part 6: Apply motion path transform matrix. r=nical
Boris Chiou <boris.chiou@gmail.com> - Tue, 07 Aug 2018 18:07:01 -0700 - rev 487868
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1429298 - Part 6: Apply motion path transform matrix. r=nical We implement the layout part of offset-path. Now we don't have offset-distance, so use the default value, 0%, for it. Note: rename mCombinedTransform as mIndividualTransform, which only stores the combined individual transforms. We apply the individual transforms, motion path transform, and specified transform in ReadTransforms. (We have to follow the order, so we don't combine the specified transform in FinishStyle.) Differential Revision: https://phabricator.services.mozilla.com/D2968
cc2785ab879e: Bug 1429298 - Part 6: Apply motion path transform matrix. r=nical
Boris Chiou <boris.chiou@gmail.com> - Wed, 22 Aug 2018 01:22:28 +0000 - rev 487844
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1429298 - Part 6: Apply motion path transform matrix. r=nical We implement the layout part of offset-path. Now we don't have offset-distance, so use the default value, 0%, for it. Note: rename mCombinedTransform as mIndividualTransform, which only stores the combined individual transforms. We apply the individual transforms, motion path transform, and specified transform in ReadTransforms. (We have to follow the order, so we don't combine the specified transform in FinishStyle.) Depends on D2967 Differential Revision: https://phabricator.services.mozilla.com/D2968
4841b3ddbacb: Bug 1483772 - Never have mAsyncTask be non-null when we cannot paint. r=nical
Ryan Hunt <rhunt@eqrion.net> - Thu, 16 Aug 2018 10:33:14 -0500 - rev 487788
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1483772 - Never have mAsyncTask be non-null when we cannot paint. r=nical In bug 1482415 a special check was added for the case where we fail to allocate a buffer and started an async task. This papered over one crash for another as ClientPaintedLayer also assumes that if there is an async task there is a capture. It'd be best to just null out mAsyncTask and keep those checks as is. Differential Revision: https://phabricator.services.mozilla.com/D3520