searching for reviewer(mikedeboer)
ca120c3031d2db4c2d9bff03a1334ee25e8c8502: Bug 1552185 - Fix the @amazon search alias on non-en-US builds. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Thu, 16 May 2019 17:16:32 +0000 - rev 532965
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1552185 - Fix the @amazon search alias on non-en-US builds. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D31489
b76c9bbbe88188ba4216fe94a9779370654bea20: Bug 967013 - Re-enable browser_contextSearchTabPosition.js on Mac as the intermittents seem to have gone away. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Thu, 16 May 2019 14:04:06 +0000 - rev 532911
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 967013 - Re-enable browser_contextSearchTabPosition.js on Mac as the intermittents seem to have gone away. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D31405
afbd9e47febe41fc0308306c0ac53527ff577102: Bug 1541419 - Correct the search form url for Ebay in 'be' locale. r=mkaply,mikedeboer
Mark Banner <standard8@mozilla.com> - Mon, 13 May 2019 18:33:24 +0000 - rev 532720
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1541419 - Correct the search form url for Ebay in 'be' locale. r=mkaply,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D30398
3d13d2cb56d1f1ed2f09dbc630f206f76f2aa368: Bug 1541419 - Correct the search form url for Ebay in 'be' locale. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Fri, 10 May 2019 08:50:06 +0000 - rev 532179
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541419 - Correct the search form url for Ebay in 'be' locale. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D30398
a0ab4288cda4246470aae59f9f1be2c1be65dcd8: Bug 1548769 - Remove WebExtensions icons theming support. r=mikedeboer
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 08 May 2019 20:28:24 +0000 - rev 531932
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548769 - Remove WebExtensions icons theming support. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D29802
e8dbcc5c516f05fe34f90efaf6fd199118979012: Bug 1548769 - Remove WebExtensions icons theming support. r=mikedeboer
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 08 May 2019 18:31:29 +0000 - rev 531920
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548769 - Remove WebExtensions icons theming support. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D29802
4a3a0cf2e77aeedd4542f8f05925304d926949a6: Bug 1548750 - Harden the search link added mechanisms and browser_tooManyEnginesOffered.js against the search service initialisation not having completed yet. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Tue, 07 May 2019 10:51:44 +0000 - rev 531690
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548750 - Harden the search link added mechanisms and browser_tooManyEnginesOffered.js against the search service initialisation not having completed yet. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D29807
a40e9f3da7aca0279d4a1b58f3bf87e169e24b58: Bug 1549122: Duct tape to prevent deadlock when search extensions upgraded on startup. r=mikedeboer a=Aryx
Dale Harvey <dale@arandomurl.com> - Mon, 06 May 2019 13:06:34 +0200 - rev 531476
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1549122: Duct tape to prevent deadlock when search extensions upgraded on startup. r=mikedeboer a=Aryx Differential Revision: https://phabricator.services.mozilla.com//D30004
f8d2d04438931fccd53ba405b1ed5c394f296e15: Bug 1548141 - Ensure SearchService has started. r=mikedeboer
Dale Harvey <dale@arandomurl.com> - Wed, 01 May 2019 08:32:12 +0000 - rev 530877
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548141 - Ensure SearchService has started. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D29430
05728c3ec05302f36d5d97692787e08f39710801: Bug 1546496 - test_findbar.xul is failing when it is not run inside the isolated clipboard job r=mikedeboer
Joel Maher <jmaher@mozilla.com> - Tue, 30 Apr 2019 11:12:44 +0000 - rev 530731
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546496 - test_findbar.xul is failing when it is not run inside the isolated clipboard job r=mikedeboer test_findbar.xul is failing when it is not run inside the isolated clipboard job Differential Revision: https://phabricator.services.mozilla.com/D29164
f795602b2b7efba44cdb395b5f28a48a0ad3a1b2: Bug 1545140 - Add tags to search tests to allow running just the main tests or the search config tests. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Wed, 24 Apr 2019 15:20:49 +0000 - rev 529486
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545140 - Add tags to search tests to allow running just the main tests or the search config tests. r=mikedeboer Depends on D28648 Differential Revision: https://phabricator.services.mozilla.com/D28649
46b5a3dff2bc3be9cca5046378c108e85567ee29: Bug 1545140 - Wait for a bit longer in test_reloadEngines to ensure that cache writes are fully complete. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Wed, 24 Apr 2019 14:57:28 +0000 - rev 529485
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545140 - Wait for a bit longer in test_reloadEngines to ensure that cache writes are fully complete. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D28648
448a0265509b6f1f75863f820a03a88efa72d7fb: Bug 1532170 - Move search ignorelist data to RemoteSettings. r=mikedeboer,glasserc
Mark Banner <standard8@mozilla.com> - Thu, 18 Apr 2019 08:50:31 +0000 - rev 528875
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1532170 - Move search ignorelist data to RemoteSettings. r=mikedeboer,glasserc Differential Revision: https://phabricator.services.mozilla.com/D25382
67d59eccba20c9a96f3e0a06a8e947dc06918ecc: Bug 1518546 - Fix method signatures throughout SearchService.jsm to be consistent. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Wed, 17 Apr 2019 14:41:39 +0000 - rev 528701
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1518546 - Fix method signatures throughout SearchService.jsm to be consistent. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D27823
9e0b9cbb8982e59fab316a224d17b53f38a4ea65: Bug 1496075 - Part 3: Use webextensions in SearchServices. r=mikedeboer,mixedpuppy
Dale Harvey <dale@arandomurl.com> - Thu, 11 Apr 2019 20:49:31 +0000 - rev 527918
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1496075 - Part 3: Use webextensions in SearchServices. r=mikedeboer,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D25246
abf4f3d3b075d1af90654f9f665e2b52455ff46d: Bug 1496191 - When test_big_icon is listening for search engine modifications, ensure it QIs the engine to have the proper interface information. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Wed, 03 Apr 2019 09:17:40 +0000 - rev 526550
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1496191 - When test_big_icon is listening for search engine modifications, ensure it QIs the engine to have the proper interface information. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D25900
ff41bdbd94e519ae96b6ebac2309612d499797bd: Bug 1532730 - Update engines on reload. r=mikedeboer
Dale Harvey <dale@arandomurl.com> - Thu, 28 Mar 2019 16:32:41 +0000 - rev 525454
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1532730 - Update engines on reload. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D24192
e49c905f4cf68877d022c8457913253e1cb3acb1: Bug 1529366 - Implement batch-updating of Touch Bar inputs. r=mikedeboer,spohl
Harry Twyford <harry.a.twyford@gmail.com> - Mon, 18 Mar 2019 12:14:11 +0000 - rev 523685
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1529366 - Implement batch-updating of Touch Bar inputs. r=mikedeboer,spohl Changes updateTouchBarInput to a batch-updating updateTouchBarInputs. Also adds a check for a cached localized title to getTouchBarInput(). Differential Revision: https://phabricator.services.mozilla.com/D20956
dab3dbd695e82058d8c6ad39d907844986aab3f9: Bug 1535378 - Adding a test for the serialization of principals r=ckerschb,mikedeboer
Jonathan Kingston <jkt@mozilla.com> - Mon, 18 Mar 2019 16:29:51 +0000 - rev 523678
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1535378 - Adding a test for the serialization of principals r=ckerschb,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D23554
b5794f0035103a7f991c3475b198541b7a22c0bd: Bug 1545974 - Disable browser_UrlbarInput_tooltip.js from running in QuantumBar mode on beta due to timeouts (and QuantumBar not shipping in 67). r?mikedeboer,a=test-only
Mark Banner <standard8@mozilla.com> - Fri, 26 Apr 2019 08:54:17 +0100 - rev 523363
Push 11165 by mbanner@mozilla.com at Fri, 26 Apr 2019 09:24:23 +0000
Bug 1545974 - Disable browser_UrlbarInput_tooltip.js from running in QuantumBar mode on beta due to timeouts (and QuantumBar not shipping in 67). r?mikedeboer,a=test-only Differential Revision: https://phabricator.services.mozilla.com/D28950
327e3dce985ba4c81a2d8a46a56ea764e9c0aef4: Bug 1532170 - Move search ignorelist data to RemoteSettings. r=mikedeboer,glasserc,a=pascalc
Mark Banner <standard8@mozilla.com> - Tue, 23 Apr 2019 13:39:30 +0100 - rev 523297
Push 11137 by mbanner@mozilla.com at Tue, 23 Apr 2019 17:21:09 +0000
Bug 1532170 - Move search ignorelist data to RemoteSettings. r=mikedeboer,glasserc,a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D28474
3dc7b1a572313386a459b174e7335847e3c1dbb2: Bug 1532730 - Update engines on reload. r=mikedeboer a=pascalc
Dale Harvey <dale@arandomurl.com> - Thu, 28 Mar 2019 16:32:41 +0000 - rev 522962
Push 11011 by dvarga@mozilla.com at Fri, 05 Apr 2019 19:03:02 +0000
Bug 1532730 - Update engines on reload. r=mikedeboer a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24192
dc1994aefb3dfc3e974604f1bef424d7067ad24b: Bug 1496191 - When test_big_icon is listening for search engine modifications, ensure it QIs the engine to have the proper interface information. r=mikedeboer, a=test-only
Mark Banner <standard8@mozilla.com> - Wed, 03 Apr 2019 09:17:40 +0000 - rev 522943
Push 10999 by ryanvm@gmail.com at Thu, 04 Apr 2019 13:32:36 +0000
Bug 1496191 - When test_big_icon is listening for search engine modifications, ensure it QIs the engine to have the proper interface information. r=mikedeboer, a=test-only Differential Revision: https://phabricator.services.mozilla.com/D25900
f001c13667acf1ffe2728d95ade809e8b8819bf4: Bug 1531893 - Add support for search channel. r=mikedeboer
Michael Kaply <mozilla@kaply.com> - Wed, 06 Mar 2019 09:31:47 +0000 - rev 521038
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531893 - Add support for search channel. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D22169
81d7a246c2b0d47820c3e186a0c9832685be2f77: Bug 1490974 Part 3: Add a test that invisible text and text in option tags doesn't generate a find result. r=mikedeboer
Brad Werth <bwerth@mozilla.com> - Tue, 05 Mar 2019 20:19:51 +0000 - rev 520342
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1490974 Part 3: Add a test that invisible text and text in option tags doesn't generate a find result. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D10632
330d7fe2bf6b43a7b35759f15b303c3092281a74: Bug 1490974 Part 2: Remove an assert that insists only editable elements can use independent selection. r=mikedeboer
Brad Werth <bwerth@mozilla.com> - Tue, 05 Mar 2019 20:19:15 +0000 - rev 520341
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1490974 Part 2: Remove an assert that insists only editable elements can use independent selection. r=mikedeboer Depends on D10631 Differential Revision: https://phabricator.services.mozilla.com/D21428
cdafab7858451738ce6f5d6b6fb4c2ce937a443d: Bug 1490974 Part 1: For find-in-page, prevent invisible nodes and option nodes from being included in find results. r=mikedeboer
Brad Werth <bwerth@mozilla.com> - Wed, 27 Feb 2019 21:23:55 +0000 - rev 520340
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1490974 Part 1: For find-in-page, prevent invisible nodes and option nodes from being included in find results. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D10631
f6bf5eeec2734b7427e50a3d5b71c80e6048d60c: Bug 1522530 - Port session store test browser_599909.js to QuantumBar. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Wed, 27 Feb 2019 14:35:17 +0000 - rev 519327
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522530 - Port session store test browser_599909.js to QuantumBar. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D21225
1e95c3246660be51aa6529391d4a0c3f85e38dd3: Bug 1518548 - Remove the sync telemetry histogram r=mikedeboer
ui.manish <1991manish.kumar@gmail.com> - Sat, 23 Feb 2019 09:40:28 +0000 - rev 518611
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518548 - Remove the sync telemetry histogram r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D17865
7c5bbf3bb4d8428b3216e7b23f43f8b1b64dfab5: Bug 1522039 - Changes default Touch Bar button set and replaces icon on Close Window button. r=bwinton,mikedeboer
Harry Twyford <harry.a.twyford@gmail.com> - Thu, 21 Feb 2019 19:23:33 +0000 - rev 518379
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522039 - Changes default Touch Bar button set and replaces icon on Close Window button. r=bwinton,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D17831
8f6a8dc753082014450b522528b51aad05395340: Bug 384278 - Added additional state variable to store window state before window minimization. r=mikedeboer
Orangelynx <orangelynx@outlook.de> - Wed, 20 Feb 2019 09:03:09 +0000 - rev 517918
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 384278 - Added additional state variable to store window state before window minimization. r=mikedeboer Current window state in the sessionstore system includes `sizeMode` which can be "normal", "minimized", "maximized". However, the OS also remembers whether the window was "normal" or "maximized" before minimization to restore it appropriately. With this fix, sessionstore does likewise. Differential Revision: https://phabricator.services.mozilla.com/D13234
165bdb5717f30118fdf71a3d215db854e97ddb34: Bug 1524688: Part 11 - Convert search service to static registration. r=mikedeboer
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 20:00:19 -0800 - rev 517347
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524688: Part 11 - Convert search service to static registration. r=mikedeboer
9895239d8ac64bef30e5f6390f18456ffe209e4e: Bug 1524688: Part 11 - Convert search service to static registration. r=mikedeboer
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 20:00:19 -0800 - rev 516946
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524688: Part 11 - Convert search service to static registration. r=mikedeboer
a1f9a3e18986242af272c6d61099c64c19e16d1a: Bug 384278 - Added additional state variable to store window state before window minimization. r=mikedeboer
Orangelynx <orangelynx@outlook.de> - Sun, 03 Feb 2019 14:29:29 +0000 - rev 514470
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 384278 - Added additional state variable to store window state before window minimization. r=mikedeboer Current window state in the sessionstore system includes `sizeMode` which can be "normal", "minimized", "maximized". However, the OS also remembers whether the window was "normal" or "maximized" before minimization to restore it appropriately. With this fix, sessionstore does likewise. Differential Revision: https://phabricator.services.mozilla.com/D13234
f5b403254529339cb9185b813cad0820fd90891b: Bug 1135303 - Don't warn when closing multiple tabs if sessionstore can undo close the requested amount of tabs. r=Gijs,mikedeboer
Jared Wein <jwein@mozilla.com> - Wed, 30 Jan 2019 13:36:25 +0000 - rev 513935
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1135303 - Don't warn when closing multiple tabs if sessionstore can undo close the requested amount of tabs. r=Gijs,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D17858
ac4d65b918938cf6e110bd03d8d993bd22f7a798: Bug 1516704 incognito support in session api, r=rpl,mikedeboer
Shane Caraveo <scaraveo@mozilla.com> - Tue, 29 Jan 2019 20:18:36 +0000 - rev 513858
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1516704 incognito support in session api, r=rpl,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D16921
64d26b5a25b85c70f801d7bf46bddda2714a1a1d: Bug 1516704 incognito support in session api, r=rpl,mikedeboer
Shane Caraveo <scaraveo@mozilla.com> - Mon, 28 Jan 2019 12:39:39 +0000 - rev 513649
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1516704 incognito support in session api, r=rpl,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D16921
a66d868f77c404b2ea45fa81c740088bee76bdb3: Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer
Alphan Chen <alchen@mozilla.com> - Mon, 28 Jan 2019 19:44:03 +0000 - rev 513594
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D12672
1efa956efdffaac618e5f989e84d0a35ab9f1d7f: Bug 1507286 - Convert content-sessionStore.jsm to C++ r=mikedeboer,nika
Alphan Chen <alchen@mozilla.com> - Mon, 28 Jan 2019 14:53:18 +0000 - rev 513501
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1507286 - Convert content-sessionStore.jsm to C++ r=mikedeboer,nika Test Plani: browser/components/sessionstore/test/ Differential Revision: https://phabricator.services.mozilla.com/D15845
747303cab27a597bbfdffd2c1db157f5d65c4f0f: Bug 1522994 - Resolves crash when using Touch Bar inputs out-of-context. r=mikedeboer
Harry Twyford <harry.a.twyford@gmail.com> - Sun, 27 Jan 2019 22:06:38 +0000 - rev 512710
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1522994 - Resolves crash when using Touch Bar inputs out-of-context. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D17695
0509a9edc58aa8f5a2a51e9684f93c913d6d55ab: Bug 1507286 - Convert content-sessionStore.jsm to C++ r=mikedeboer,nika
Alphan Chen <alchen@mozilla.com> - Fri, 25 Jan 2019 13:14:28 +0000 - rev 512550
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1507286 - Convert content-sessionStore.jsm to C++ r=mikedeboer,nika Test Plani: browser/components/sessionstore/test/ Differential Revision: https://phabricator.services.mozilla.com/D15845
21ad3aeb636f3e28853927b4a7b36262320d6f58: Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer
Alphan Chen <alchen@mozilla.com> - Fri, 25 Jan 2019 10:19:04 +0000 - rev 512541
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D12672
a6cc9b15b1e3f464589488b0f490eadd9bb20f74: Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer
Alphan Chen <alchen@mozilla.com> - Thu, 24 Jan 2019 12:53:28 +0000 - rev 512395
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1497146 part 3 - Convert FormData.jsm to C++ [restore() part] r=peterv,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D12672
143af10f6e44656bf48b6cf63a3a7adda3c393c9: Bug 1313429: Followup to add a missing break for a case in a switch statement (discovered by coverity). r=mikedeboer
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 24 Jan 2019 00:14:51 +0100 - rev 512346
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1313429: Followup to add a missing break for a case in a switch statement (discovered by coverity). r=mikedeboer
099f631b90046b102aa1868455f03b7f9942eaba: Bug 1313429 - Add Touch Bar functionality to Firefox r=spohl,mikedeboer,flod
Harry Twyford <harry.a.twyford@gmail.com> - Tue, 22 Jan 2019 17:13:33 +0000 - rev 511967
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1313429 - Add Touch Bar functionality to Firefox r=spohl,mikedeboer,flod Adds Touch Bar functionality to Firefox across eight commits. Differential Revision: https://phabricator.services.mozilla.com/D5496
170f979a5f7d570780bb45872ce1ab4c8138ceec: Bug 1483440 - Part 2 - Don't use purge-domain-data to clear session history for a domain. r=mikedeboer,baku
Johann Hofmann <jhofmann@mozilla.com> - Thu, 17 Jan 2019 17:41:23 +0000 - rev 511413
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1483440 - Part 2 - Don't use purge-domain-data to clear session history for a domain. r=mikedeboer,baku Differential Revision: https://phabricator.services.mozilla.com/D16461
b1a1231573cd3922090c48dc9676db8d8371ef58: Bug 1497146 part 2 - Convert FormData.jsm to C++ [collect() part] r=nika,peterv,mikedeboer
Alphan Chen <alchen@mozilla.com> - Thu, 17 Jan 2019 14:56:51 +0000 - rev 511386
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1497146 part 2 - Convert FormData.jsm to C++ [collect() part] r=nika,peterv,mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D12112
39207d39e5c2d3a8980bc910820c8b37f812b77e: Bug 1498812 - Part 9: Switch session store/session history to use visual viewport for scroll position tracking. r=mikedeboer,snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 11 Jan 2019 19:50:09 +0000 - rev 510656
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1498812 - Part 9: Switch session store/session history to use visual viewport for scroll position tracking. r=mikedeboer,snorp For simplicity's sake, for now we keep storing only one scroll position per history entry (bug 1499210), so if we have to choose between the layout and the visual viewport, the latter is a vastly better choice, as it more accurately represents the scroll position as perceived by the user, especially when the page has been pinch-zoomed. This also means that instead of the normal scroll events, the session store now has to listen for the corresponding events specific to the visual viewport. We also extend the scroll position test to check that the scroll position isn't just properly saved, but also actually properly restored in practice as well. We only add this test now instead of already adding it beforehand like we did with the rest of the test - to avoid having to temporarily extend the checkScroll() helper function to deal with todo()/todo_is etc. - because getting that part of the test to complete without timing out (which would be one of its natural failure modes, because the expected events would be missing) would require faking even more scroll events - because we already have the todo() tests that are telling us the we didn't *store* any scroll position in the first place, so there's no point in trying to actually restore anything For the GeckoView saveAndRestoreState test, we now spin the event loop once before setting the scroll position in order to give APZ opportunity to settle down after the initial page load. Differential Revision: https://phabricator.services.mozilla.com/D15690
4eccacfc8801a8401d72458210dac451515b5bda: Bug 1498812 - Part 6: Allow promiseBrowserEvent to listen in system group. r=mikedeboer
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 11 Jan 2019 19:49:34 +0000 - rev 510653
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1498812 - Part 6: Allow promiseBrowserEvent to listen in system group. r=mikedeboer Likewise the only way to catch our internal visual viewport events. Differential Revision: https://phabricator.services.mozilla.com/D15687
7b00521b6f3176cb88698b4773d9be13f0e54b2e: Bug 1498812 - Part 4: Add scroll position test that is specifically testing the Visual Viewport. r=mikedeboer
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 11 Jan 2019 20:36:16 +0000 - rev 510651
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1498812 - Part 4: Add scroll position test that is specifically testing the Visual Viewport. r=mikedeboer The existing tests didn't catch this problem, because calling scrollTo(), which is both what a) the session store and session history itself are currently using to set the scroll position to be restored, as well as b) how the existing session store test is setting the page up to be scrolled ready for testing forces both the layout and visual viewport positions to the respective coordinates, even if the same configuration of visual and layout viewport offsets could never be achieved through manual scrolling (i.e. bug 1516056). This then triggers all the expected events and makes it so that reading the scroll position through the layout viewport returns the expected values, which is why the existing tests never noticed that something is off. Therefore, we introduce a test here that has a page where the layout viewport can never scroll (at least horizontally) and where we simulate scrolling by actually inputting fake touch events instead of simply calling scrollTo(). This will result in only the visual viewport scrolling, ensuring that we can properly test the new expected behaviour of the session store and session history. Because layout and visual viewport scroll positions aren't necessarily updated at exactly the same time and the session store is currently still relying on the conventional "scroll" events (relating to the layout viewport), which means the tests have to rely on the same events, too, we don't yet switch all session store tests to generally verify the current scroll position of the page using the visual viewport, and temporarily make this only opt-in via the corresponding helper function in head_scroll.js. I know that the proper way to reference "foreign" files in text manifests is to use !/absolute/path/to/file/helper.js, but as one of the files originally comes from a chrome mochitest and the other one (apz_test_utils.js) doesn't and this test itself is a chrome mochitest, this was the best way I found to get both files copied into the correct directory on the test device so the test could access them. Differential Revision: https://phabricator.services.mozilla.com/D15685