searching for reviewer(mfinkle)
4a2454585e72: Bug 1252570 - Remove mozPay. r=ehsan,mfinkle,fabrice
Fernando Jimenez <ferjmoreno@gmail.com> - Fri, 19 Aug 2016 15:14:53 +0200 - rev 351844
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1252570 - Remove mozPay. r=ehsan,mfinkle,fabrice MozReview-Commit-ID: C50fvuNJoGq
f15a0c2d0178: Bug 1261617 - Add UITelemetry for search counts. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Wed, 11 May 2016 17:23:48 -0700 - rev 336684
Push 6249 by jlund@mozilla.com at Mon, 01 Aug 2016 13:59:36 +0000
Bug 1261617 - Add UITelemetry for search counts. r=mfinkle I largerly kept this patch the same as Finkle's initial revision except that I don't include the engine identifiers due to bug 1272166. MozReview-Commit-ID: 84672CDOOVX
e62b981d0cbe: Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 11 May 2016 11:40:49 -0400 - rev 336109
Push 6249 by jlund@mozilla.com at Mon, 01 Aug 2016 13:59:36 +0000
Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle MozReview-Commit-ID: 9Et4AhCzAr9
52749e84bf25: Bug 1266163 - Replace FENNEC_READER_VIEW_BUTTON histogram with UI telemetry. r=mfinkle,barbara
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 20 Apr 2016 15:22:46 -0400 - rev 335444
Push 6249 by jlund@mozilla.com at Mon, 01 Aug 2016 13:59:36 +0000
Bug 1266163 - Replace FENNEC_READER_VIEW_BUTTON histogram with UI telemetry. r=mfinkle,barbara MozReview-Commit-ID: 1guxvXp6loC
1f70bee0d12e: Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle
Eitan Isaacson <eitan@monotonous.org> - Mon, 02 May 2016 14:02:16 -0700 - rev 335408
Push 6249 by jlund@mozilla.com at Mon, 01 Aug 2016 13:59:36 +0000
Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle This simplifies some old code. We get rid of a whitelist of services, and rely on the face that accessibility and explore by touch is enabled to enter our internal accessibility mode. The whitelist methode held 2 assumptions that are not true anymore: 1. There are some non-accessibility accessibility service apps in the wild that read notifications. In later Android versions this has been made into a non-a11y use case with NotificationListenerService. So the cases of non-a11y accessibility services has shrunk. 2. Not all screen readers (Gingerbread TalkBack, for example) supported explore by touch. Today, we exclusively support accessibility services that use explore by touch, and we should not activate our accessibility mode in any other case. MozReview-Commit-ID: LMeCedoIGbb
123a7cac7ce9: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle
Chenxia Liu <liuche@mozilla.com> - Tue, 03 May 2016 16:19:49 -0700 - rev 335068
Push 6249 by jlund@mozilla.com at Mon, 01 Aug 2016 13:59:36 +0000
Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle MozReview-Commit-ID: A24qXyNpWwk
cdec576dad5e: Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle
Eitan Isaacson <eitan@monotonous.org> - Mon, 02 May 2016 14:02:16 -0700 - rev 335020
Push 6249 by jlund@mozilla.com at Mon, 01 Aug 2016 13:59:36 +0000
Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle This simplifies some old code. We get rid of a whitelist of services, and rely on the face that accessibility and explore by touch is enabled to enter our internal accessibility mode. The whitelist methode held 2 assumptions that are not true anymore: 1. There are some non-accessibility accessibility service apps in the wild that read notifications. In later Android versions this has been made into a non-a11y use case with NotificationListenerService. So the cases of non-a11y accessibility services has shrunk. 2. Not all screen readers (Gingerbread TalkBack, for example) supported explore by touch. Today, we exclusively support accessibility services that use explore by touch, and we should not activate our accessibility mode in any other case. MozReview-Commit-ID: LMeCedoIGbb
ee66f2755acf: Bug 1263110 - Part 3 - Remove the remains of the old crash loop detection. r=mfinkle r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Apr 2016 17:51:57 +0200 - rev 334100
Push 6249 by jlund@mozilla.com at Mon, 01 Aug 2016 13:59:36 +0000
Bug 1263110 - Part 3 - Remove the remains of the old crash loop detection. r=mfinkle r=sebastian The number of recent successive crashes is now tracked wholly within Java, so we can remove the old Gecko pref and the associated reset code. MozReview-Commit-ID: 7bR9wqJsLoi
ec981b82951f: Bug 1263110 - Part 2 - Implement crash loop detection in Java. r=mfinkle r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 19 Apr 2016 13:51:06 +0200 - rev 334099
Push 6249 by jlund@mozilla.com at Mon, 01 Aug 2016 13:59:36 +0000
Bug 1263110 - Part 2 - Implement crash loop detection in Java. r=mfinkle r=sebastian Bug 701092 originally implemented some functionality to detect successive crashes and then turn off session restore for the next start, however that functionality got lost when parts of the startup session restore code were moved to Java. This patch re-implements this functionality within the Java UI. Unlike the previous implementation, we don't reset the crash counter in onPause(), because often enough onPause() will execute even after a crash. Instead, we check in onResume() whether our last foreground activity cycle crashed or not. To avoid cross-process writes and reads to shared preferences, the crash reporter no longer sets the relevant flags in GeckoApp's shared prefs directly, but instead writes an empty CRASHED file to the Mozilla directory as a flag, which is then checked for by the main process during startup. Alternative solutions considered were: - Using Context.MODE_MULTI_PROCESS for accessing the shared prefs. Works, but forces the shared preferences to always be re-read from storage and is also deprecated from API 23 onwards. - Using a ContentProvider for managing the cross-process shared prefs as suggested in Google's documentation. Seems somewhat over-engineered for this use case. - Sending a broadcast from the crash reporter to signal the main process, so it can update the relevant shared prefs from the correct process. Doesn't work reliably immediately after crashing - sometimes the broadcast never arrives. - Setting the crash flags directly in the crash handling functions in GeckoAppShell. Could work even when not building the crash reporter, however doesn't work easily for native crashes, because those are handled internally by Gecko without going through the Java crash handling code. MozReview-Commit-ID: 6g7AmnJhoQk
b7d44db6027d: Bug 1263110 - Part 1 - Move crash reporter settings into their own shared pref. r=mfinkle r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 18 Apr 2016 18:56:28 +0200 - rev 334098
Push 6249 by jlund@mozilla.com at Mon, 01 Aug 2016 13:59:36 +0000
Bug 1263110 - Part 1 - Move crash reporter settings into their own shared pref. r=mfinkle r=sebastian The crash reporter runs in its own process but uses GeckoApp's shared prefs both to store its own settings and to signal to the main process that it has crashed, which can be somewhat problematic because each process might fail to notice settings changes made by the other process. As the simple solution of enabling Context.MODE_MULTI_PROCESS for accessing the shared prefs is now deprecated, we'll devise an alternative solution instead. In Part 1 we move the settings that are used exclusively by the crash reporter into a separate shared prefs instance. MozReview-Commit-ID: 1QWBAL2Xcn2
9a4077c55f8b: Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle a=ritu
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 11 May 2016 11:40:49 -0400 - rev 332877
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle a=ritu MozReview-Commit-ID: 9Et4AhCzAr9
8e724faf0734: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle a=lizzard
Chenxia Liu <liuche@mozilla.com> - Tue, 03 May 2016 16:19:49 -0700 - rev 332854
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle a=lizzard MozReview-Commit-ID: A24qXyNpWwk
9a49926c3edb: Bug 1261836 - Content notifications: Check if new content is already in history. r=mcomella,mfinkle
Sebastian Kaspari <s.kaspari@gmail.com> - Wed, 13 Apr 2016 13:01:52 +0200 - rev 332358
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1261836 - Content notifications: Check if new content is already in history. r=mcomella,mfinkle If the URL of new content is already in the user's history then we won't show a notification for it. MozReview-Commit-ID: B26SBvXOnxY
17fd65ac5332: Bug 1260758 - Add distribution field to Fennec core ping - forgot to add file; r=mfinkle,mkaply
Michael Comella <michael.l.comella@gmail.com> - Wed, 13 Apr 2016 15:31:36 -0500 - rev 330951
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1260758 - Add distribution field to Fennec core ping - forgot to add file; r=mfinkle,mkaply
50704924c908: Bug 1260758 - Add distribution field to Fennec core ping; r=mfinkle,mkaply
Michael Comella <michael.l.comella@gmail.com> - Wed, 13 Apr 2016 15:17:13 -0500 - rev 330950
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1260758 - Add distribution field to Fennec core ping; r=mfinkle,mkaply
5b37f138e5bf: Bug 1239376 - Fix StrictMode thread read access in SysInfo.getMemSize. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Wed, 27 Jan 2016 12:06:33 -0800 - rev 330507
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1239376 - Fix StrictMode thread read access in SysInfo.getMemSize. r=mfinkle This caused a StrictMode violation on startup. MozReview-Commit-ID: Ip2ywUoexOh
bc3a8e4f9a3a: Bug 1259158 - Update tab queues prompt telemetry to use UI telemetry instead of histograms. r=sebastian r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 01 Apr 2016 10:59:03 -0400 - rev 329534
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1259158 - Update tab queues prompt telemetry to use UI telemetry instead of histograms. r=sebastian r=mfinkle MozReview-Commit-ID: 4aws9Rcy5W1
7875a8acb8c4: Bug 1256415 - Replace FENNEC_GECKOAPP_STARTUP_ACTION histogram with UI telemetry. r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 18 Mar 2016 19:07:18 -0400 - rev 329529
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1256415 - Replace FENNEC_GECKOAPP_STARTUP_ACTION histogram with UI telemetry. r=mfinkle MozReview-Commit-ID: ElmELmp7baV
230a0a44d087: Bug 1259507 - Add UI Telemetry probes for DOM Push API in Fennec. r=mfinkle
Nick Alexander <nalexander@mozilla.com> - Tue, 29 Mar 2016 11:39:35 -0700 - rev 329125
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1259507 - Add UI Telemetry probes for DOM Push API in Fennec. r=mfinkle The probes in this patch are annotated with the extra "dom-push-api" to distinguish from future Fennec-specific push messages. These probes allow to determine for each user the difference: {# sites subscribed to} - {# sites unsubscribed from}. If we assume the same site is not subscribed to multiple times, this is a good approximation to the total number of sites the user receives push messages from. To test manually: 0) Install Fennec and execute |adb shell setprop log.tag.Telemetry DEBUG|. 1) Subscribe to notifications on a site like serviceworke.rs. Observe a UI Telemetry SAVE event, like: D/Telemetry( 7109): SendUIEvent: event = save.1 method = service timestamp = 277456 extras = dom-push-api 2) Send a push notification using the sites' interface. Observe a UI Telemetry PUSH_RECEIVED_MESSAGE event, like: D/Telemetry( 7109): SendUIEvent: event = action.1 method = service timestamp = 361795 extras = dom-push-api 3) Unsubscribe to notifications by revoking permission using Site Settings from the URL bar. Observe a UI Telemetry PUSH_UNSUBSCRIBED_FROM_SITE event, like: D/Telemetry( 7109): SendUIEvent: event = unsave.1 method = service timestamp = 393600 extras = dom-push-api MozReview-Commit-ID: IOCwfXFnowA
41c11b33eedb: Bug 1248408 - Preserve text from previous a11y event if new event does not provide any. r=mfinkle
Eitan Isaacson <eitan@monotonous.org> - Thu, 31 Mar 2016 13:46:14 -0700 - rev 328943
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1248408 - Preserve text from previous a11y event if new event does not provide any. r=mfinkle MozReview-Commit-ID: 3hIquiKLvl7
84180ddf65a7: Bug 1241810 - Bug 1251317 - Add telemetry for content notifications. r=mcomella,mfinkle
Sebastian Kaspari <s.kaspari@gmail.com> - Thu, 03 Mar 2016 14:16:17 +0100 - rev 328200
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1241810 - Bug 1251317 - Add telemetry for content notifications. r=mcomella,mfinkle MozReview-Commit-ID: Hlh1sW0kHFg
1aea33a2d87b: Bug 1251009 - Remove unused nsICertificateDialogs.notifyCACertExists() method. r=keeler, r=mfinkle
Cykesiopka <cykesiopka.bmo@gmail.com> - Wed, 16 Mar 2016 12:48:59 -0700 - rev 327521
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1251009 - Remove unused nsICertificateDialogs.notifyCACertExists() method. r=keeler, r=mfinkle MozReview-Commit-ID: 5CFAsy5e1Cl
663c40336889: Bug 1116036 - Avoid failure in robocop testHistoryService and enable on 4.3; r=mfinkle
Geoff Brown <gbrown@mozilla.com> - Wed, 09 Mar 2016 21:34:23 -0700 - rev 325882
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1116036 - Avoid failure in robocop testHistoryService and enable on 4.3; r=mfinkle
893ca601352a: Bug 1252617 - Probe to measure when offline error page is shown. r=mfinkle
Barbara Bermes <bbermes@mozilla.com> - Wed, 02 Mar 2016 15:36:05 -0500 - rev 325209
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1252617 - Probe to measure when offline error page is shown. r=mfinkle
db12e253eb84: Bug 1250122 - Fix number of arguments to nsIPermissionManager::Add. r=mfinkle
Gian-Carlo Pascutto <gcp@mozilla.com> - Sun, 06 Mar 2016 19:57:16 +0100 - rev 324965
Push 6048 by kmoir@mozilla.com at Mon, 06 Jun 2016 19:02:08 +0000
Bug 1250122 - Fix number of arguments to nsIPermissionManager::Add. r=mfinkle MozReview-Commit-ID: 6MLRoage5ff
d92c793bfa61: Bug 1256415 - Replace FENNEC_GECKOAPP_STARTUP_ACTION histogram with UI telemetry. r=mfinkle a=ritu
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 18 Mar 2016 19:07:18 -0400 - rev 324396
Push 5999 by kwierso@gmail.com at Mon, 16 May 2016 19:18:14 +0000
Bug 1256415 - Replace FENNEC_GECKOAPP_STARTUP_ACTION histogram with UI telemetry. r=mfinkle a=ritu MozReview-Commit-ID: ElmELmp7baV
629e46640752: Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle a=ritu
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 11 May 2016 11:40:49 -0400 - rev 324383
Push 5992 by kwierso@gmail.com at Sat, 14 May 2016 00:16:42 +0000
Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle a=ritu MozReview-Commit-ID: 9Et4AhCzAr9
0ee49a42aee5: Bug 1260758 - Add distribution field to Fennec core ping. r=mfinkle, r=mkaply, a=lizzard
Michael Comella <michael.l.comella@gmail.com> - Wed, 13 Apr 2016 15:31:36 -0500 - rev 324136
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1260758 - Add distribution field to Fennec core ping. r=mfinkle, r=mkaply, a=lizzard
24ee705f5b46: Bug 1248408 - Preserve text from previous a11y event if new event does not provide any. r=mfinkle a=lizzard
Eitan Isaacson <eitan@monotonous.org> - Thu, 31 Mar 2016 13:46:14 -0700 - rev 323826
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1248408 - Preserve text from previous a11y event if new event does not provide any. r=mfinkle a=lizzard MozReview-Commit-ID: 3hIquiKLvl7
3dcc4b8b947d: Bug 1246956 - Add loadReplace to session history. r=yoric r=mfinkle
Dragana Damjanovic dd.mozilla@gmail.com - Wed, 02 Mar 2016 12:17:22 +0100 - rev 322792
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1246956 - Add loadReplace to session history. r=yoric r=mfinkle
2d09899861de: Bug 1004734 - Create system notification on browser update. r=liuche,mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 24 Feb 2016 12:16:46 -0800 - rev 322553
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1004734 - Create system notification on browser update. r=liuche,mfinkle MozReview-Commit-ID: DsVhO2kagZB
417bac059dab: Bug 1250122 - Record granting permissions for the Camera on Android. r=mfinkle
Gian-Carlo Pascutto <gcp@mozilla.com> - Wed, 24 Feb 2016 13:39:32 +0100 - rev 321722
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1250122 - Record granting permissions for the Camera on Android. r=mfinkle
eaf669f32777: Bug 1250250 - Store updated seq no. before sending upload Intent. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Mon, 22 Feb 2016 11:20:37 -0800 - rev 321483
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1250250 - Store updated seq no. before sending upload Intent. r=mfinkle MozReview-Commit-ID: Ab2qycjDKOy
56ed0ec901c0: Bug 1246956 - Add originURI to Sessionstore. r=bz,Yoric,mfinkle
Dragana Damjanovic <dd.mozilla@gmail.com> - Mon, 22 Feb 2016 16:38:57 -0800 - rev 321465
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1246956 - Add originURI to Sessionstore. r=bz,Yoric,mfinkle
fc8c27e54b2c: Bug 1243216 - Run pngquant on images to compress them further. r=mfinkle
Chenxia Liu <liuche@mozilla.com> - Thu, 18 Feb 2016 18:45:15 -0800 - rev 321300
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1243216 - Run pngquant on images to compress them further. r=mfinkle MozReview-Commit-ID: ISx9rUsB4PX
7ba6d7255327: Bug 1227743 - Remove snippet (id) from rotation after the user clicks on it. r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Thu, 11 Feb 2016 15:29:25 -0500 - rev 321290
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1227743 - Remove snippet (id) from rotation after the user clicks on it. r=mfinkle MozReview-Commit-ID: 10m8yssL94U
414d0894875c: Bug 1244295 - Add junit4 tests for GeckoProfile.getClient & friends. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Thu, 18 Feb 2016 17:38:16 -0800 - rev 321273
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1244295 - Add junit4 tests for GeckoProfile.getClient & friends. r=mfinkle Added testGetDir to sanity check how the profile is set up for the test and left it in as a bonus. Additionally, changed access levels on the ensureParentDirs method because it only needed to be `protected` for testing. MozReview-Commit-ID: CDVQjyf3yP2
a805bd0f0a35: Bug 1244295 - Validate client IDs before sending them in a Telemtry report. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Wed, 17 Feb 2016 12:22:18 -0800 - rev 321272
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1244295 - Validate client IDs before sending them in a Telemtry report. r=mfinkle Additionally, we log some of the Exceptions thrown while retrieving the client ID to make it clearer what is happening. The underlying GeckoProfile methods ensure the profile path is not printed so we don't have to worry about leaking that. MozReview-Commit-ID: 3o0rvXDRZzM
57a14ecc71e8: Bug 1244295 - Create client ID if it doesn't already exist in GeckoProfile. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Fri, 12 Feb 2016 16:34:43 -0800 - rev 321271
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1244295 - Create client ID if it doesn't already exist in GeckoProfile. r=mfinkle Additionally, we'll try to migrate the client ID from FHR if it doesn't already exist. MozReview-Commit-ID: B9vfefeVi2i
6008843fb7ba: Bug 1247324 - Disable Switchboard in automation. r=gbrown,mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Thu, 18 Feb 2016 12:03:51 -0500 - rev 321036
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1247324 - Disable Switchboard in automation. r=gbrown,mfinkle MozReview-Commit-ID: ItqHBIEdD0Q
f8466087ba15: Bug 1234693 - Point Switchboard URLs to production mozilla-services endpoint. r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 17 Feb 2016 10:14:53 -0500 - rev 320879
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1234693 - Point Switchboard URLs to production mozilla-services endpoint. r=mfinkle MozReview-Commit-ID: ArdTpolY7rQ
c862ad446f98: Bug 1247903 - close is before going out of scope to prevent memory leak. r=mfinkle
Bogdan Postelnicu <bogdan.postelnicu@softvision.ro> - Fri, 12 Feb 2016 14:18:07 +0200 - rev 320502
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1247903 - close is before going out of scope to prevent memory leak. r=mfinkle MozReview-Commit-ID: IJPfV81KjKj
69b7bc4b0968: Bug 1246209 - Add profile creation date to core ping. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Mon, 08 Feb 2016 17:17:14 -0800 - rev 319932
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1246209 - Add profile creation date to core ping. r=mfinkle This patch adds 2 workarounds for the fact that getProfileCreationDate returns -1 when it can't find a creation date. Returning -1 turned out to be not particularly robust but I did it this way to avoid adding too many additional versions of methods in order to have optional parameters such as profileCreationDate. The workarounds are added as TODOs w/ bug #'s in the code and mentioned in the comments of bug 1246816 itself. A future implementation should probably add a Builder to pass a single Object as the argument to TelemetryPingGenerator.createCorePing to prevent the argument list from growing unreasonably large and to properly operate on optional parameters. I didn't do this in this patch in order to simplify the uplifted code.
ab551bd86c29: Bug 1246209 - Add getProfileCreationDate, implement from filestystem, & add stencil code. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Mon, 08 Feb 2016 17:10:26 -0800 - rev 319931
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1246209 - Add getProfileCreationDate, implement from filestystem, & add stencil code. r=mfinkle Retrieving the profile creation date from the filesystem is not strictly necessary to upload this data and returns -1 until it is implemented. If the decision is r+'d here, it will be implemented in bug 1246816.
1e366271eee7: Bug 1246209 - Extract readJSONObjectFromFile out of getClientId. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Mon, 08 Feb 2016 15:03:21 -0800 - rev 319930
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1246209 - Extract readJSONObjectFromFile out of getClientId. r=mfinkle
6c2cfa599981: Bug 1229890 - Convert JS callsites to use asyncOpen2 within mobile/ (r=mfinkle,sicking)
Christoph Kerschbaumer <mozilla@christophkerschbaumer.com> - Mon, 08 Feb 2016 08:53:17 -0800 - rev 319852
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1229890 - Convert JS callsites to use asyncOpen2 within mobile/ (r=mfinkle,sicking)
d007cfebe661: Bug 1234693 - Point Switchboard URLs to production mozilla-services endpoint. r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 05 Feb 2016 08:08:42 -0500 - rev 319782
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1234693 - Point Switchboard URLs to production mozilla-services endpoint. r=mfinkle
d81d3ca528ad: Bug 1243387 - (Part 2) Update SuggestClient to use NetworkUtils. r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 05 Feb 2016 09:38:48 -0500 - rev 319781
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1243387 - (Part 2) Update SuggestClient to use NetworkUtils. r=mfinkle
67713b7ddcd1: Bug 1243387 - Add telemetry probe to understand how often users load reading list items when offline. r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 05 Feb 2016 09:37:15 -0500 - rev 319780
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1243387 - Add telemetry probe to understand how often users load reading list items when offline. r=mfinkle
d0ed2f83c82c: Bug 1244329 - Flip the preference to on for requiring signed addons. r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 05 Feb 2016 09:59:29 -0500 - rev 319779
Push 5913 by jlund@mozilla.com at Mon, 25 Apr 2016 16:57:49 +0000
Bug 1244329 - Flip the preference to on for requiring signed addons. r=mfinkle