searching for reviewer(mconley)
4c5b03b42277: Bug 1430153 - Warm up tabs in the Ctrl+Tab panel. r=mconley
Dão Gottwald <dao@mozilla.com> - Fri, 12 Jan 2018 17:09:15 +0100 - rev 450845
Push 8543 by ryanvm@gmail.com at 2018-01-16 14:33 +0000
Bug 1430153 - Warm up tabs in the Ctrl+Tab panel. r=mconley MozReview-Commit-ID: IlXLt90MsrB
f466c92f42bf: Bug 1419775 - Part 1.Prevent send IPC message when cancelling the print job if IPC connection already closed. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 10 Jan 2018 09:00:10 +0900 - rev 450300
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1419775 - Part 1.Prevent send IPC message when cancelling the print job if IPC connection already closed. r=mconley If target content tab is already closed, progress dialog can't notify to content process that cancelling the print job. So this patch will prevent send cancelling message in this case. MozReview-Commit-ID: 7G1LACajVha
3eba56d0b50f: Bug 1428849 - Remove datetimepicker.xml bindings. r=mconley
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 09 Jan 2018 19:39:30 +0000 - rev 450210
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1428849 - Remove datetimepicker.xml bindings. r=mconley MozReview-Commit-ID: LhfabvhJP5d
7e989a375aa8: Bug 1425967 - extend TAB_COUNT probe to last until 65, r=liuche,mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 03 Jan 2018 17:25:41 +0000 - rev 450052
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1425967 - extend TAB_COUNT probe to last until 65, r=liuche,mconley MozReview-Commit-ID: AwHpPIrvOgE
b30d693096e3: Bug 1420285 - Change <browser> attribute isPreloadBrowser to preloadedState r=mconley
Ursula Sarracini <usarracini@mozilla.com> - Thu, 04 Jan 2018 15:54:37 -0500 - rev 449623
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1420285 - Change <browser> attribute isPreloadBrowser to preloadedState r=mconley MozReview-Commit-ID: 3ooQldAnPZl
3ac6f5c8accc: Bug 1414126 - disable browser_urlbar_search_reflows.js on Linux debug and Windows debug due to intermittent timeouts, r=mconley.
Florian Quèze <florian@queze.net> - Wed, 20 Dec 2017 16:56:33 +0100 - rev 448775
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1414126 - disable browser_urlbar_search_reflows.js on Linux debug and Windows debug due to intermittent timeouts, r=mconley.
fc7d77434051: Bug 1380465 - Enable browser_windowopen_reflows.js on Linux. r=mconley
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 20 Dec 2017 08:33:38 +0900 - rev 448649
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1380465 - Enable browser_windowopen_reflows.js on Linux. r=mconley MozReview-Commit-ID: FoGK0jngVfE
5619db8e95f7: Bug 1380465 - Drop the expected reflows about focus on url bar. r=mconley
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 20 Dec 2017 08:33:34 +0900 - rev 448648
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1380465 - Drop the expected reflows about focus on url bar. r=mconley Since bug 1377447 we use EnsurePresShellInitAndFrames for FlushPendingNotification when textbox gets focused, and EnsurePresShellInitAndFrames should not trigger any reflows. So in theory, there is something causes a reflow that we could improve on other platforms. MozReview-Commit-ID: FAcSZKrv0Fr
e7e988f26a6d: Bug 1380465 - Drop an expected reflow for Linux in browser_windowopen_reflows.js. r=mconley
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 20 Dec 2017 08:33:06 +0900 - rev 448647
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1380465 - Drop an expected reflow for Linux in browser_windowopen_reflows.js. r=mconley The reflow was suppressed by bug 1414252, and the expected reflow for other platforms was dropped in that bug. MozReview-Commit-ID: HyYhvntOpGx
f3dc5ed08890: Bug 1412456 - Change browser element's primary attribute immediately when tab change requested (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:20:21 -0800 - rev 447407
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Change browser element's primary attribute immediately when tab change requested (r=mconley) Currently the e10s tab switcher doesn't set the primary="true" attribute on a browser element until the tab switcher is destroyed. This means that using the |content| global is unreliable in e10s since it may take as long as the tab switcher's unload delay before the attribute changes. Normally this doesn't matter since |content| isn't useful in e10s. However, tests that use tabs like about:preferences rely on |content|, and there isn't a good reason to fix them. So let's just change the attribute immediately upon changing tabs. MozReview-Commit-ID: 1cgJbmXD6of
33d4345bf5fb: Bug 1412456 - Add BrowserTestUtils.addContentEventListener (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:21:36 -0800 - rev 447403
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Add BrowserTestUtils.addContentEventListener (r=mconley) This function makes it possible to listen for multiple events from the content process, even when there are frameloader swaps. This commit also adds a checkFn param to firstBrowserLoaded, which is useful. MozReview-Commit-ID: 93ItHIPSGVU
211c791a4c7f: Bug 1412456 - Send document CPOW as well as window CPOW (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:19:43 -0800 - rev 447402
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Send document CPOW as well as window CPOW (r=mconley) Currently, if you try to use contentDocumentAsCPOW, you'll get an exception saying that browser code is not allowed to use CPOWs. That's because we cleverly tried to get the CPOW via contentWindowAsCPOW.document. However, this property access happens inside remote-browser.xul, where CPOWs are forbidden. So it doesn't work. MozReview-Commit-ID: ANWad4tvGpU
27077db47231: Bug 1412456 - Disable add-on interposition (r=mconley)
Bill McCloskey <billm@mozilla.com> - Thu, 26 Oct 2017 15:06:31 -0700 - rev 447209
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Disable add-on interposition (r=mconley) MozReview-Commit-ID: 3burzHHoHlX
f35ec2a884f8: Bug 1412456 - Stop running addoncompat tests (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:22:08 -0800 - rev 447208
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Stop running addoncompat tests (r=mconley) MozReview-Commit-ID: KFgGDI8tV3o
d85af60fe259: Bug 1412456 - Add BrowserTestUtils.addContentEventListener (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:21:36 -0800 - rev 447204
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Add BrowserTestUtils.addContentEventListener (r=mconley) This function makes it possible to listen for multiple events from the content process, even when there are frameloader swaps. This commit also adds a checkFn param to firstBrowserLoaded, which is useful. MozReview-Commit-ID: 93ItHIPSGVU
736f38486832: Bug 1412456 - Change browser element's primary attribute immediately when tab change requested (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:20:21 -0800 - rev 447203
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Change browser element's primary attribute immediately when tab change requested (r=mconley) Currently the e10s tab switcher doesn't set the primary="true" attribute on a browser element until the tab switcher is destroyed. This means that using the |content| global is unreliable in e10s since it may take as long as the tab switcher's unload delay before the attribute changes. Normally this doesn't matter since |content| isn't useful in e10s. However, tests that use tabs like about:preferences rely on |content|, and there isn't a good reason to fix them. So let's just change the attribute immediately upon changing tabs. MozReview-Commit-ID: 1cgJbmXD6of
13a637602dc2: Bug 1412456 - Send document CPOW as well as window CPOW (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:19:43 -0800 - rev 447202
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Send document CPOW as well as window CPOW (r=mconley) Currently, if you try to use contentDocumentAsCPOW, you'll get an exception saying that browser code is not allowed to use CPOWs. That's because we cleverly tried to get the CPOW via contentWindowAsCPOW.document. However, this property access happens inside remote-browser.xul, where CPOWs are forbidden. So it doesn't work. MozReview-Commit-ID: ANWad4tvGpU
0e88de036c55: Bug 1412456 - Disable add-on interposition (r=mconley)
Bill McCloskey <billm@mozilla.com> - Thu, 26 Oct 2017 15:06:31 -0700 - rev 447199
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Disable add-on interposition (r=mconley) MozReview-Commit-ID: 3burzHHoHlX
49b93f807db0: Bug 1412456 - Stop running addoncompat tests (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:22:08 -0800 - rev 447198
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Stop running addoncompat tests (r=mconley) MozReview-Commit-ID: KFgGDI8tV3o
0c4506e124ac: Bug 1412456 - Add BrowserTestUtils.addContentEventListener (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:21:36 -0800 - rev 447194
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Add BrowserTestUtils.addContentEventListener (r=mconley) This function makes it possible to listen for multiple events from the content process, even when there are frameloader swaps. This commit also adds a checkFn param to firstBrowserLoaded, which is useful. MozReview-Commit-ID: 93ItHIPSGVU
a7aec2ce903b: Bug 1412456 - Change browser element's primary attribute immediately when tab change requested (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:20:21 -0800 - rev 447193
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Change browser element's primary attribute immediately when tab change requested (r=mconley) Currently the e10s tab switcher doesn't set the primary="true" attribute on a browser element until the tab switcher is destroyed. This means that using the |content| global is unreliable in e10s since it may take as long as the tab switcher's unload delay before the attribute changes. Normally this doesn't matter since |content| isn't useful in e10s. However, tests that use tabs like about:preferences rely on |content|, and there isn't a good reason to fix them. So let's just change the attribute immediately upon changing tabs. MozReview-Commit-ID: 1cgJbmXD6of
3e9fb71f1e8e: Bug 1412456 - Send document CPOW as well as window CPOW (r=mconley)
Bill McCloskey <billm@mozilla.com> - Mon, 04 Dec 2017 16:19:43 -0800 - rev 447192
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412456 - Send document CPOW as well as window CPOW (r=mconley) Currently, if you try to use contentDocumentAsCPOW, you'll get an exception saying that browser code is not allowed to use CPOWs. That's because we cleverly tried to get the CPOW via contentWindowAsCPOW.document. However, this property access happens inside remote-browser.xul, where CPOWs are forbidden. So it doesn't work. MozReview-Commit-ID: ANWad4tvGpU
76b60be19500: Bug 1423242 - Lower the font-size of the spacer during Whimsypong on Linux to prevent it from getting cut off. r=mconley
Jared Wein <jwein@mozilla.com> - Tue, 05 Dec 2017 10:50:47 -0500 - rev 446804
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1423242 - Lower the font-size of the spacer during Whimsypong on Linux to prevent it from getting cut off. r=mconley MozReview-Commit-ID: LweMVGHexI6
923256103e56: Bug 1422246 - Don't set tab label to about:newtab when navigating and changing remoteness r=mconley
Tim Taubert <ttaubert@mozilla.com> - Mon, 04 Dec 2017 11:25:00 +0100 - rev 446619
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1422246 - Don't set tab label to about:newtab when navigating and changing remoteness r=mconley Reviewers: mconley Reviewed By: mconley Bug #: 1422246 Differential Revision: https://phabricator.services.mozilla.com/D307
8173679f7bcb: Bug 1422269 - Allow asan-reporter to report crashed tabs immediately. r=mconley
Christian Holler <choller@mozilla.com> - Fri, 01 Dec 2017 12:43:09 +0100 - rev 446614
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1422269 - Allow asan-reporter to report crashed tabs immediately. r=mconley MozReview-Commit-ID: BsO3LID1J9s
ab3d38eb9e7d: Bug 1039069 - Show a hint of the change of the preferred language list. r=mconley
Chung-Sheng Fu <cfu@mozilla.com> - Tue, 24 Oct 2017 16:28:53 +0800 - rev 446443
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1039069 - Show a hint of the change of the preferred language list. r=mconley MozReview-Commit-ID: LHyXmdnyf3N
4036881d8ab0: Bug 1039069 - Provide a popup about English for international users. r=arthuredelstein,mconley
Chung-Sheng Fu <cfu@mozilla.com> - Tue, 12 Sep 2017 17:32:07 +0800 - rev 446442
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1039069 - Provide a popup about English for international users. r=arthuredelstein,mconley MozReview-Commit-ID: IL8i4vzjWQd
69af55073d39: Bug 1039069 - Show a hint of the change of the preferred language list. r=mconley
Chung-Sheng Fu <cfu@mozilla.com> - Tue, 24 Oct 2017 16:28:53 +0800 - rev 446228
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1039069 - Show a hint of the change of the preferred language list. r=mconley MozReview-Commit-ID: LHyXmdnyf3N
4fce39a14630: Bug 1039069 - Provide a popup about English for international users. r=arthuredelstein,mconley
Chung-Sheng Fu <cfu@mozilla.com> - Tue, 12 Sep 2017 17:32:07 +0800 - rev 446227
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1039069 - Provide a popup about English for international users. r=arthuredelstein,mconley MozReview-Commit-ID: IL8i4vzjWQd
09b116a802ff: Bug 1421672 - Explicitly declare the start/end values of CSS animations since optimizations require both. r=mconley
Jared Wein <jwein@mozilla.com> - Wed, 29 Nov 2017 12:49:22 -0500 - rev 446111
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1421672 - Explicitly declare the start/end values of CSS animations since optimizations require both. r=mconley MozReview-Commit-ID: 2U0Uia1pYF8
7a5b6591d679: Bug 1419527 - Use scrollend event to detect when spinner stops. r=mconley
Scott Wu <scottcwwu@gmail.com> - Thu, 23 Nov 2017 17:25:54 +0800 - rev 446073
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1419527 - Use scrollend event to detect when spinner stops. r=mconley MozReview-Commit-ID: AnRO1FOwhvP
85b0368a8c80: Bug 1420171 Part 3: Don't default the settings printer name on Linux when printing to file. r=mconley
Bob Owen <bobowencode@gmail.com> - Tue, 28 Nov 2017 08:59:00 +0000 - rev 445815
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1420171 Part 3: Don't default the settings printer name on Linux when printing to file. r=mconley
6dd2a65b4c3e: Bug 1414745 - Filter out everything except STATE_IS_NETWORK in nsBrowserStatusFilter::OnStateChange. r=mconley
Samael Wang <freesamael@gmail.com> - Fri, 17 Nov 2017 10:48:37 +0800 - rev 445635
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1414745 - Filter out everything except STATE_IS_NETWORK in nsBrowserStatusFilter::OnStateChange. r=mconley The mFinishedRequests / mTotalRequests counters in nsBrowserStatusFilter has been known buggy for around a decade. With e10s we double filtered in both parent and child processes which makes it worse. There are a few problems with the counters / filter: 1. The ResetMembers() were invoked on each network request starts, which means a iframe document loading followed by the root document loading would also reset the members incorrectly. 2. The filter for non-network request was incorrect. The basic idea seems to be that if `mFinishedRequests == mTotalRequests` and `!isLoadingDocument`, it should be the STOP request right after document loading finishes, and that STOP should be delivered so listener would get symmetric numbers of START / STOP of STATE_IS_REQUEST. However some requests such as imgRequest can start after document loading finishes, in this case the START would be filtered out (since mFinishedRequests != mTotalRequests), but STOP would be delivered to the listener. It's the reason that nsBrowserStatusFilter tend to deliver much more STATE_STOP than STATE_START. 3. When applying the filter on both parent & child side, the above issues often make the mFinishedRequests / mFinishedRequests be unmatched on parent side, eseentially filtered out most non-network requests and make the progressChange based on the counters useless. Firefox no longer shows the ratio of progressChange on the UI (and the number is incorrect anyway with current nsBrowserStatusFilter), and Fennec's progress bar is based on some predefined constants [1] which doesn't rely on progressChange either, so it not necessary to keep calculating a progress number with request counters. In addition, it seems tabbrowser & browser.js mostly only care about STATE_IS_NETWORK, and Fennec has already filtered out everything else [2], it should be safe to only pass STATE_IS_NETWORK to the listener, and we get the benefit of reducing unused IPC messages. [1] https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/mobile/android/base/java/org/mozilla/gecko/Tab.java#111-115 [2] https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/mobile/android/chrome/content/browser.js#4356-4357 MozReview-Commit-ID: 5tUP5SRwDoP
07ca590ac669: Bug 1374574 - Remove the FlyWeb system add-on from Firefox. r=mconley
Johann Hofmann <jhofmann@mozilla.com> - Wed, 22 Nov 2017 14:47:49 +0100 - rev 445599
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1374574 - Remove the FlyWeb system add-on from Firefox. r=mconley MozReview-Commit-ID: BWqZIGz5hQx
21d9bedcf411: Bug 1419226 - Part 1.Change observing target window of MozAfterPaint. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 27 Nov 2017 09:33:53 +0900 - rev 445527
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1419226 - Part 1.Change observing target window of MozAfterPaint. r=mconley Previous code, print preview waits for content window's MozAfterPaint. However gecko prevents send MozAfterPaint to content window[1]. So this code will not work correctly. However, software timer of firing MozAfterPaint ran this code.[2] This patch will * Change the observing content window to chrome window. * Add timer of MozAfterPaint event in order to ensure this event even if display list invalidation doesn't invalidate. Gecko create this timer in nsPresContext previously[2], but this bug will remove it [1] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/base/nsPresContext.cpp#2452 [2] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/base/nsPresContext.cpp#3466-3472 MozReview-Commit-ID: GcuKPjn0qhc
e9227aaffbe7: Bug 1396833 - Fix tab drag&drop not finishing due to CSS transform not kicking in r=mconley
Tim Taubert <ttaubert@mozilla.com> - Wed, 22 Nov 2017 08:15:09 +0100 - rev 444898
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1396833 - Fix tab drag&drop not finishing due to CSS transform not kicking in r=mconley Summary: In very rare situations, the right number of tabs and the right drop position will lead to the drop event handler trying to start a translateX() transform and then wait for the transitionend event that will never fire. If the old and the new translateX values are too close together (e.g. 1259.1000061035156 and 1259.0999450683594) then the layout engine won't actually start a transform. A simple solution is to round translateX values before comparing them and deciding whether to initiate a transition. Reviewers: mconley Reviewed By: mconley Bug #: 1396833 Differential Revision: https://phabricator.services.mozilla.com/D265
bc89bf67b38d: Bug 1412357 - Added mochitest asserts + logging to TestRunner.jsm. r=mconley
grenewode <grenewodemiller@gmail.com> - Sat, 11 Nov 2017 18:55:53 -0500 - rev 444739
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1412357 - Added mochitest asserts + logging to TestRunner.jsm. r=mconley Moved the call to TestRunner.initTest to head.js so that it only needs to be called once. Also, TestRunner._findBoundingbox now throws exceptions instead of returning null, which makes debugging and testing easier. MozReview-Commit-ID: LpJmEL3CfKd
79ac723d679b: Bug 1418494 - Flatten menucaption-inmenulist into menucaption;r=mconley
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 20 Nov 2017 10:05:35 -0800 - rev 444469
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1418494 - Flatten menucaption-inmenulist into menucaption;r=mconley The only time menucaptions are created are for optgroups, and they always get instantiated as menucaption-inmenulist. Flatten the inheritance here to get rid of a binding. MozReview-Commit-ID: KWzor0QDdma
b78cea997533: Bug 1409971 - Part 3. Set nsIPrintSettings::IsCancelled to true in order to cancel print job. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 15 Nov 2017 16:31:18 +0900 - rev 444123
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1409971 - Part 3. Set nsIPrintSettings::IsCancelled to true in order to cancel print job. r=mconley In content process, we should set nsIPrintSettings::IsCancelled to true in order to cancel the print job. nsPrintEngine use this flag for cancelling. MozReview-Commit-ID: EqnNJOlIm5s
154ec3c19c88: Bug 1409971 - Part 2. Notify cancelling print job when cancel button pushed. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 15 Nov 2017 16:29:49 +0900 - rev 444122
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1409971 - Part 2. Notify cancelling print job when cancel button pushed. r=mconley This patch will use existing nsIObserver, and distinguish each message by using parameter character. MozReview-Commit-ID: GAhPl7n9wmS
983d715192fe: Bug 1409971 - Part 1. Add cancelling print job interface to PPrintProgressDialog. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 15 Nov 2017 16:29:45 +0900 - rev 444121
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1409971 - Part 1. Add cancelling print job interface to PPrintProgressDialog. r=mconley This patch will add empty ipc interface in order to notify cancelling print job. MozReview-Commit-ID: KqBN5A4ARSd
30022d08636e: Bug 1152811 - Re-enable browser_pluginCrashReportNonDeterminism.js; r=mconley
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 15 Nov 2017 11:20:21 +0100 - rev 444092
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1152811 - Re-enable browser_pluginCrashReportNonDeterminism.js; r=mconley MozReview-Commit-ID: FgGqZG11V1H
36cb0ea65892: Bug 1414406: Remove inline options from talos tabswitch test add-on. r=mconley
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 14 Nov 2017 08:54:08 -0800 - rev 443542
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1414406: Remove inline options from talos tabswitch test add-on. r=mconley MozReview-Commit-ID: 4XTJgkBdBsa
854a8759f855: Bug 1409972 - Part 6. Remove printingui implementation of each platform. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 11:07:34 +0900 - rev 443388
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1409972 - Part 6. Remove printingui implementation of each platform. r=mconley MozReview-Commit-ID: BXocuT9zV0E
1d8e9cd8df19: Bug 1409972 - Part 4. Merge mac printingui. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 11:00:54 +0900 - rev 443386
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1409972 - Part 4. Merge mac printingui. r=mconley This patch will merge mac printingui implementation to common code. Primary differences are: * Remove progress implementation if build target is macOS. MozReview-Commit-ID: 8qoxgmzhqnM
fb5f9d6a7772: Bug 1409972 - Part 3. Merge windows printingui. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 10:58:10 +0900 - rev 443385
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1409972 - Part 3. Merge windows printingui. r=mconley This patch will merge windows printingui implementation to common code. Primary differences are: * Use nsCOMPtr on nsPIDOMWindowOuter. * Return NS_ERROR_FAILURE if nsPrintingPromptService doesn't have the nsPrintProgress member when calling ShowProgress(). This is the unexpected case. Original windows implementation has following difference, but this patch will not copy it: * Windows has own NS_IMPL_ADDREF / NS_IMPL_RELEASE implementation, however this implementation isn't different from XPCOM implementation. Bug 156318 doesn't show this reason. * Windows implementation lacks some function parameter checks. But unixshared code covers these checks. * Windows implementation doesn't have the nsIPrintSettings member into nsPrintProgress, but this is necessary in order to make printing cancelable. MozReview-Commit-ID: 8ja40rAaXBo
96fcac56b31e: Bug 1409972 - Part 2. Copy printingui implementation from unixshared. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 10:55:48 +0900 - rev 443384
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1409972 - Part 2. Copy printingui implementation from unixshared. r=mconley This patch will copy printingui implementation from unixshared in order to merge other platform implementation. This unixshared implementation has much common code hence using unixshared code is reasonable for merging. MozReview-Commit-ID: 4VManmNcbdc
3d465d9677d8: Bug 1409972 - Part 1. Apply clang-format to nsPrintingPromptService. r=mconley
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 10:53:08 +0900 - rev 443383
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1409972 - Part 1. Apply clang-format to nsPrintingPromptService. r=mconley Apply following the clang-format: ./mach clang-format --path toolkit/components/printingui/mac/nsPrintingPromptService.* ./mach clang-format --path toolkit/components/printingui/unixshared/nsPrintingPromptService.* ./mach clang-format --path toolkit/components/printingui/win/nsPrintingPromptService.* MozReview-Commit-ID: 8JGuyqiuKNX
4c90faaa680d: Bug 1416796 - Add UI densities configuration to a default set r=mconley.
Rand Mustafa <rndmustafa@gmail.com> - Mon, 13 Nov 2017 13:33:58 -0500 - rev 443362
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1416796 - Add UI densities configuration to a default set r=mconley. MozReview-Commit-ID: 9LQ8DdzNodN
676474b0b6b8: Bug 1404176 - Remove aborted print preview browser before bailing out. r=mconley
Matheus Longaray <mlongaray@hp.com> - Mon, 13 Nov 2017 17:17:57 +0100 - rev 443298
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1404176 - Remove aborted print preview browser before bailing out. r=mconley This patch clears out set of print preview browsers before bailing out when there is an error while putting the document into print preview mode. MozReview-Commit-ID: 20cm4DCktQk