searching for reviewer(mbrubeck)
8fd075dbd205cc159a8ed464453de4af975e1e8f: Bug 1518843 - Add GeckoView API to unregister WebExtensions. r=snorp,mbrubeck
Agi Sferro <agi@mozilla.com> - Wed, 17 Apr 2019 18:27:40 +0000 - rev 528741
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1518843 - Add GeckoView API to unregister WebExtensions. r=snorp,mbrubeck Depends On D23093 --- .../components/geckoview/GeckoViewStartup.js | 1 + mobile/android/geckoview/api.txt | 1 + .../geckoview/test/WebExtensionTest.kt | 17 +++++++-- .../org/mozilla/geckoview/GeckoRuntime.java | 31 +++++++++++++++- .../mozilla/geckoview/doc-files/CHANGELOG.md | 6 ++- .../geckoview/GeckoViewWebExtension.jsm | 37 ++++++++++++++++++- 6 files changed, 85 insertions(+), 8 deletions(-) Differential Revision: https://phabricator.services.mozilla.com/D22621
51fd0edf687f5105aac2d3366d6c30dc286490af: Bug 1524992 - Followup to add newline r=mbrubeck,rbarker
James Willcox <snorp@snorp.net> - Tue, 12 Mar 2019 19:22:16 +0000 - rev 521591
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1524992 - Followup to add newline r=mbrubeck,rbarker Differential Revision: https://phabricator.services.mozilla.com/D23192
a90e2dd8b1a55493679722ac3801a518c7794e93: Bug 1525738 - Stop running Android 7.0 x86_64 geckoview-junit tests; r=mbrubeck
Geoff Brown <gbrown@mozilla.com> - Tue, 12 Feb 2019 09:24:16 -0700 - rev 516593
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525738 - Stop running Android 7.0 x86_64 geckoview-junit tests; r=mbrubeck
8326406ad7b43e9e03e82a9069a9fae135be0636: Bug 1514252 - Use 160 DPI and a device pixel scale of 1.0 for GeckoView tests. r=geckoview-reviewers,mbrubeck#geckoview-reviewers
James Willcox <snorp@snorp.net> - Wed, 19 Dec 2018 16:43:29 +0000 - rev 508427
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514252 - Use 160 DPI and a device pixel scale of 1.0 for GeckoView tests. r=geckoview-reviewers,mbrubeck#geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D14565
564f2cc2bb9b1b2a015a386391971c8d001c9408: Bug 1507159 - Import NotificationDB.jsm in GeckoView r=geckoview-reviewers,mbrubeck
James Willcox <snorp@snorp.net> - Thu, 29 Nov 2018 22:26:51 +0000 - rev 507241
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1507159 - Import NotificationDB.jsm in GeckoView r=geckoview-reviewers,mbrubeck Differential Revision: https://phabricator.services.mozilla.com/D13301
3db77a4e0959dc7558499588af83efd5c53c6c44: Bug 1508728 - Handle autoplay permission requests in GeckoView example r=mbrubeck
James Willcox <snorp@snorp.net> - Tue, 20 Nov 2018 22:02:29 +0000 - rev 503913
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508728 - Handle autoplay permission requests in GeckoView example r=mbrubeck Differential Revision: https://phabricator.services.mozilla.com/D12452
3ed6e552f6520363c93d691566ce251a0d67989a: Bug 1492001 - Update cargo_build_defs for num-traits. r=mbrubeck
Matt Brubeck <mbrubeck@mozilla.com> - Tue, 18 Sep 2018 12:24:27 -0700 - rev 492744
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492001 - Update cargo_build_defs for num-traits. r=mbrubeck
a55bb4be01eee3c833d3c97944dcb476288ff0bf: servo: Merge #20573 - Add support for percentages in column-gap (from Ramshell:issue/20498); r=mbrubeck
Ramshell <ramshellcinox@gmail.com> - Fri, 06 Apr 2018 19:48:59 -0400 - rev 465752
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
servo: Merge #20573 - Add support for percentages in column-gap (from Ramshell:issue/20498); r=mbrubeck <!-- Please describe your changes on the following line: --> # Changes in this PR * I've removed the `if product == "gecko"` line in order to make the column_gap type "NonNegativeLengthOrPercentageOrNormal" always. * Then I've changed this line ```rust Either::First(len) => len.into(), ``` to ```rust Either::First(len) => len.0.to_pixel_length(content_inline_size).into(), ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #20498 (github issue number if applicable). <!-- Either: --> - [X] These changes do not require tests because there are tests already for this in wpt, in particular css/css-align/gaps/column-gap-parsing-001.html for the parsing bits, and css/css-multicol/multicol-gap-percentage-001.html for the layout bits. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: ecf71d77cde1ce998b2d2b7fd7a6d45dfe40343e
4891a59d620fd91c75a5d41618cb6b32ba9c4d39: servo: Merge #20517 - Fix the env_logger update (from Eijebong:fix_log); r=mbrubeck
Bastien Orivel <eijebong@bananium.fr> - Tue, 03 Apr 2018 09:14:41 -0400 - rev 464995
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
servo: Merge #20517 - Fix the env_logger update (from Eijebong:fix_log); r=mbrubeck When building an env_logger, we need to pass it the environment, otherwise it just takes some defaults and doesn't log anything. Source-Repo: https://github.com/servo/servo Source-Revision: 6b7957d9a009af5e5b5d36df70f100a5b5b64917
9211c666bc439ebbb2d30fc261b7e6dbe1658d01: servo: Merge #20468 - Fix style/build_gecko.rs for log 0.4 on a CLOSED TREE (from Eijebong:fix_log); r=mbrubeck
Bastien Orivel <eijebong@bananium.fr> - Wed, 28 Mar 2018 17:18:31 -0400 - rev 464059
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
servo: Merge #20468 - Fix style/build_gecko.rs for log 0.4 on a CLOSED TREE (from Eijebong:fix_log); r=mbrubeck Fix style/build_gecko.rs for log 0.4 Source-Repo: https://github.com/servo/servo Source-Revision: c8b0dc965d02754622c766017c2fec4145a2f15e
7886e5d9f94a783220379cd43d212e01ee47bd59: Bug 1446542 - Handle contextmenu events on about:logins on Android. r=mbrubeck
Matt Brubeck <mbrubeck@mozilla.com> - Fri, 16 Mar 2018 14:17:02 -0700 - rev 463749
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1446542 - Handle contextmenu events on about:logins on Android. r=mbrubeck MozReview-Commit-ID: HF6zLJLNvzu
cdc5de2052fef5e61c33f70b3b9d90eeb5e7874f: servo: Merge #20311 - Update WR (local clip API change, texture cache optimizations) (from glennw:update-wr-pic); r=mbrubeck
Glenn Watson <github@intuitionlibrary.com> - Thu, 15 Mar 2018 22:19:31 -0400 - rev 461961
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
servo: Merge #20311 - Update WR (local clip API change, texture cache optimizations) (from glennw:update-wr-pic); r=mbrubeck Update WR (local clip API change, texture cache optimizations). Source-Repo: https://github.com/servo/servo Source-Revision: 57b12aaaaf61ad02006014465ed2c93c7ecb1e77
94c9d05567db0432218dd9728012a067c1aa3517: servo: Merge #20300 - Update gleam to 0.4.24 (from gootorov:update-gleam); r=mbrubeck
Igor Gutorov <igootorov@gmail.com> - Wed, 14 Mar 2018 19:26:13 -0400 - rev 461745
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
servo: Merge #20300 - Update gleam to 0.4.24 (from gootorov:update-gleam); r=mbrubeck <!-- Please describe your changes on the following line: --> Needed to expose `get_framebuffer_attachment_parameter_iv()`. Source-Repo: https://github.com/servo/servo Source-Revision: 863f8477ed4766ffcff3b8fcf16c0d90bd179eb4
53cea1ff8415c833c631bfa0a417bcfade0dd062: Bug 1443988 - P2: Update futures and futures-cpupool crates. r=mbrubeck
Dan Glastonbury <dan.glastonbury@gmail.com> - Thu, 08 Mar 2018 12:23:10 +1000 - rev 459638
Push 8822 by archaeopteryx@coole-files.de at Thu, 08 Mar 2018 23:51:23 +0000
Bug 1443988 - P2: Update futures and futures-cpupool crates. r=mbrubeck * futures: 0.1.13 -> 0.1.18 * futures-cpupool: 0.1.5 -> 0.1.8 MozReview-Commit-ID: LDYFHxBfQMU
ff902c889d1ce72a9a1d5c346531947f54479e4e: Bug 1443988 - P1: Update audioipc to commit 7e866e5. r=mbrubeck
Dan Glastonbury <dan.glastonbury@gmail.com> - Thu, 08 Mar 2018 12:19:17 +1000 - rev 459637
Push 8822 by archaeopteryx@coole-files.de at Thu, 08 Mar 2018 23:51:23 +0000
Bug 1443988 - P1: Update audioipc to commit 7e866e5. r=mbrubeck Remove pinning version of futures crate. MozReview-Commit-ID: AcGtxmapWSl
b8b36764509e049c46840ab0f0aba01d561370c9: Bug 1443168 - Exclude gfx/wrench from the mozilla-central workspace. r=mbrubeck
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 05 Mar 2018 10:57:05 -0500 - rev 459119
Push 8817 by archaeopteryx@coole-files.de at Tue, 06 Mar 2018 14:33:14 +0000
Bug 1443168 - Exclude gfx/wrench from the mozilla-central workspace. r=mbrubeck MozReview-Commit-ID: CWZjptDcwLW
81695cb901cfc2253ba074c67221748782db51fe: servo: Merge #20163 - Don't panic on cells with both a rowspan and colspan in include_sizes_from_previous_rows (from Manishearth:rowspan-crash); r=mbrubeck
Manish Goregaokar <manishsmail@gmail.com> - Thu, 01 Mar 2018 20:36:50 -0500 - rev 458719
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
servo: Merge #20163 - Don't panic on cells with both a rowspan and colspan in include_sizes_from_previous_rows (from Manishearth:rowspan-crash); r=mbrubeck fixes #20162 Source-Repo: https://github.com/servo/servo Source-Revision: e446897cf603dd2f179c361523cc82ecad6e657b
3dc52ab4b2e22b13abfc8d7ea64762dc277850df: servo: Merge #20152 - Support zero rowspans (from Manishearth:rowspan-zero); r=mbrubeck
Manish Goregaokar <manishsmail@gmail.com> - Thu, 01 Mar 2018 13:36:43 -0500 - rev 458652
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
servo: Merge #20152 - Support zero rowspans (from Manishearth:rowspan-zero); r=mbrubeck This makes rowspan=0 work by storing notes on which group of rows we're in for tables containing both rowgroups and rows, and using that to respan cells with overlarge or zero rowspans. This also gets rid of the largest_leftover_incoming_size business, because now spans will always be correct and we'll never have any left over. Based on https://github.com/servo/servo/pull/20128 r? @mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: 6f2cd86b8ee7bbe71ff30758cf5c2174e008e9b5
668349d472eccd645a7f955a22d3c0ed284788b9: servo: Merge #20128 - Rowspan support for tables (from Manishearth:rowspan); r=mbrubeck
Manish Goregaokar <manishsmail@gmail.com> - Wed, 28 Feb 2018 18:40:39 -0500 - rev 458372
Push 8808 by archaeopteryx@coole-files.de at Fri, 02 Mar 2018 22:13:05 +0000
servo: Merge #20128 - Rowspan support for tables (from Manishearth:rowspan); r=mbrubeck fixes #20092 This just contains the first steps. We apply a naive algorithm: Spanning cells apply a pressure equal to `block_size / rowspan` on each row they are in. We move table row block size computation into the tables, and make it two pass. In the first pass we compute the sizes of each row, and in the second pass we assign them, adding them up for any involved cells. This is missing: - [x] Accounting for border sizes - [x] Applying pressure to rows that are not the row containing the cell - [ ] Reducing pressure on future rows if the current row is able to accomodate more of the cell - [x] For tables containing both rows and rowgroups, reset the rowspan info when we hit a rowgroup - [x] Correctly handle overflowing rowspans cc @mbrubeck @pcwalton Source-Repo: https://github.com/servo/servo Source-Revision: e2f28140184e9124bd9e94d0b15f289ec5258822
ef984964576b10af234557b817e3398bb465b966: servo: Merge #20031 - Reorganise display list builder (from pyfisch:transform); r=mbrubeck
Pyfisch <pyfisch@gmail.com> - Sat, 24 Feb 2018 10:06:16 -0500 - rev 457669
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #20031 - Reorganise display list builder (from pyfisch:transform); r=mbrubeck Description in the individual commits. Source-Repo: https://github.com/servo/servo Source-Revision: 6a2feb3c1bc1374dc97c788f07c2074895d2f1f1
2081e0e6009612f175d692cbbbc29a79cabc5040: servo: Merge #20021 - Lazy load fonts in a FontGroup (from jonleighton:lazy-font-group); r=mbrubeck,glennw
Jon Leighton <j@jonathanleighton.com> - Thu, 22 Feb 2018 10:49:52 -0500 - rev 457313
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #20021 - Lazy load fonts in a FontGroup (from jonleighton:lazy-font-group); r=mbrubeck,glennw Lazy load fonts in a FontGroup The first commit message explains this so I'll just copy it here: --- This is a step towards fixing #17267. To fix that, we need to be able to try various different fallback fonts in turn, which would become unweildy with the prior eager-loading strategy. Prior to this change, FontGroup loaded up all Font instances, including the fallback font, before any of them were checked for the presence of the glyphs we're trying to render. So for the following CSS: font-family: Helvetica, Arial; The FontGroup would contain a Font instance for Helvetica, and a Font instance for Arial, and a Font instance for the fallback font. It may be that Helvetica contains glyphs for every character in the document, and therefore Arial and the fallback font are not needed at all. This change makes the strategy lazy, so that we'll only create a Font for Arial if we cannot find a glyph within Helvetica. I've also substantially refactored the existing code in the process and added some documentation along the way. --- I've added some tests in the second commit, but it required quite a bit of gymnastics to make it possible to write such a test. I'm not sure if the added complexity to the production code is worth it? On the other hand, having this infrastructure in place may be useful for testing future changes in this area, and also possibly brings us a step closer to extracting a library as discussed in #4901. (What I mean by that is: it reduces coupling between `FontCacheThread` and `FontContext` -- the latter would have a place in such a library, the former wouldn't.) Source-Repo: https://github.com/servo/servo Source-Revision: f48dce120dddd8e3d585cfc8bc221faa2726bf6b
c79437be5a27e3b34bee47d1b3351968a409b3d7: servo: Merge #20034 - Handle table cell backgrounds during display list generation for <table> (from Manishearth:table-backgrounds); r=mbrubeck
Manish Goregaokar <manishsmail@gmail.com> - Wed, 21 Feb 2018 12:00:03 -0500 - rev 457148
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #20034 - Handle table cell backgrounds during display list generation for <table> (from Manishearth:table-backgrounds); r=mbrubeck Fixes #19788 Source-Repo: https://github.com/servo/servo Source-Revision: 0b4ea018b0df2ba5f65d2a5cc45b70e4243e324a
dfcfef9a322db951210fbf7f86d77badb489b8ca: servo: Merge #19975 - Kill browserhtml (from paulrouget:killbhtml); r=mbrubeck,emilio
Paul Rouget <me@paulrouget.com> - Tue, 13 Feb 2018 04:54:47 -0500 - rev 456055
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #19975 - Kill browserhtml (from paulrouget:killbhtml); r=mbrubeck,emilio Fixes https://github.com/servo/servo/issues/19971 Source-Repo: https://github.com/servo/servo Source-Revision: b1d3d6f6324394f0e9f17b027fef24420d829b5c
86ddf1e9b78742f37debc3b635bc39adaae8a07a: servo: Merge #19754 - Implement element.innerText getter (from ferjm:innertext); r=mbrubeck
Fernando Jiménez Moreno <ferjmoreno@gmail.com> - Tue, 13 Feb 2018 03:41:48 -0500 - rev 456023
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #19754 - Implement element.innerText getter (from ferjm:innertext); r=mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: 9e64008e759a678a3971d04977c2b20b66fa8229
49b2336ac922da38dda60d463e6a233fa5298e6a: servo: Merge #20001 - Autogenerate compute_damage (from Manishearth:compute-damage); r=mbrubeck
Manish Goregaokar <manishsmail@gmail.com> - Fri, 09 Feb 2018 12:02:04 -0500 - rev 455630
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #20001 - Autogenerate compute_damage (from Manishearth:compute-damage); r=mbrubeck fixes #10622 Source-Repo: https://github.com/servo/servo Source-Revision: e19bab84cf43c43930d7493840444a8ee2af1e8b
b5024605c7a3cc2719c5b1ec3050af79024cebab: servo: Merge #19949 - ports: Remove leftover CEF config file (from emilio:bye-cef); r=mbrubeck
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 04 Feb 2018 13:45:30 -0500 - rev 454849
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #19949 - ports: Remove leftover CEF config file (from emilio:bye-cef); r=mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: e54935c25a1bb100ac757aa78ddc0069d66accf0
e9204180b07821852b9bbfe4fb04d672bb9fddea: servo: Merge #19867 - Update README.md to fix font requirements for Arch Linux (from pandusonu2:ReadMeFix); r=mbrubeck
pandusonu2 <pandu.sonu@yahoo.com> - Thu, 25 Jan 2018 09:22:52 -0600 - rev 453256
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #19867 - Update README.md to fix font requirements for Arch Linux (from pandusonu2:ReadMeFix); r=mbrubeck The current specifications for installation of Servo in Arch Linux fails to run due to requirement of fonts. The fix is just to include the required package in the required dependencies list in README.md. <!-- Please describe your changes on the following line: --> I added the required font package for Arch Linux in the README file. This is in accordance with the comments on the bug #12107, which deals with similar requirements for Gentoo --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because - The changes are in README file <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 47b3693d7564b32813746c1dbb6ef29dbb08ffaf
29192e93c875f06ce3915b01c761839df02f2264: servo: Merge #19688 - Detect adjoining text fragments with no line break opportunity between them (from Manishearth:linebreak); r=mbrubeck
Manish Goregaokar <manishsmail@gmail.com> - Wed, 24 Jan 2018 22:42:59 -0600 - rev 453137
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #19688 - Detect adjoining text fragments with no line break opportunity between them (from Manishearth:linebreak); r=mbrubeck First attempt at https://github.com/servo/servo/issues/874 Source-Repo: https://github.com/servo/servo Source-Revision: 9c1307307575637f5ad360413c6a8395579ab511
4394ebd9f5667a6641f91e13deb99dcdd527d68b: servo: Merge #19852 - Allow floats to impact list item marker position (from jonleighton:issue-19796); r=mbrubeck
Jon Leighton <j@jonathanleighton.com> - Wed, 24 Jan 2018 19:35:39 -0600 - rev 453129
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #19852 - Allow floats to impact list item marker position (from jonleighton:issue-19796); r=mbrubeck Although not required by the specification, this matches the rendering of Gecko and Blink. Fixes #19796. Source-Repo: https://github.com/servo/servo Source-Revision: d974411e56e4e31ce3acd53411bb28cee6e13217
6f11e48a1faf5ad7722c57c24edbc8573eb2a1d2: servo: Merge #19789 - Do not leave space below baseline when it is not needed (i.e.there is… (from ferjm:issue-18831-fb-layout); r=mbrubeck
Fernando Jiménez Moreno <ferjmoreno@gmail.com> - Mon, 22 Jan 2018 08:14:29 -0600 - rev 452662
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
servo: Merge #19789 - Do not leave space below baseline when it is not needed (i.e.there is… (from ferjm:issue-18831-fb-layout); r=mbrubeck … no text) This is my first layout fix and a naive approach to fix #18831. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18831 Source-Repo: https://github.com/servo/servo Source-Revision: ec8975b18d043fd0c97678b93d6e8f56c504cee7
bc9d1434a49833a499a7ad68a717c1e3e638ca21: servo: Merge #19734 - style: Remove some unneeded indirection (from emilio:less-indirection); r=mbrubeck
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jan 2018 23:34:15 -0600 - rev 450306
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19734 - style: Remove some unneeded indirection (from emilio:less-indirection); r=mbrubeck All TElement's implement Copy, and are just pointers, so the double indirection is stupid. I'm going to try to see if removing this double-indirection fixes some selector-matching performance, and this is a trivial pre-requisite while I wait for Talos results. Source-Repo: https://github.com/servo/servo Source-Revision: e2c89df8eeb5f2dbac1436335aea52099a622d0d
f4ff0ac9e058e67c8efd58b27cdec44b44df221f: servo: Merge #19725 - Update WR (inset box shadow fix, line decoration optimizations) (from glennw:update-wr-bs-line); r=mbrubeck
Glenn Watson <github@intuitionlibrary.com> - Tue, 09 Jan 2018 08:22:13 -0600 - rev 450189
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19725 - Update WR (inset box shadow fix, line decoration optimizations) (from glennw:update-wr-bs-line); r=mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: d9800191e7248d003b4056987eef6b9bb02627ee
8d6681b91e53c342a291418dcd2c5180d755b95f: servo: Merge #19568 - layout: background-origin attribute for gradients (from pyfisch:background-origin-gradients1); r=mbrubeck
Pyfisch <pyfisch@gmail.com> - Fri, 15 Dec 2017 15:54:59 -0600 - rev 448339
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19568 - layout: background-origin attribute for gradients (from pyfisch:background-origin-gradients1); r=mbrubeck Fixes the glitches mentioned in #19554. Now gradient tiles are placed in the whole bounding box. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: dbfcb7bc39715211928a550d2807cb2ba1e161e7
d35b7eba50744683e17c2792f8f4129b0b0cb4b0: servo: Merge #19564 - style: Slightly simplify push_applicable_declarations (from emilio:push-applicable-simple); r=mbrubeck
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Dec 2017 11:28:16 -0600 - rev 448311
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19564 - style: Slightly simplify push_applicable_declarations (from emilio:push-applicable-simple); r=mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: 90290cfafed0bff88920fd286ea09656fd9e999f
a9ba24bfa82d533904745f0bd233dbfde69c8f7b: servo: Merge #19554 - layout: support tiled gradients (from pyfisch:tiled-gradients1); r=mbrubeck
Pyfisch <pyfisch@gmail.com> - Thu, 14 Dec 2017 13:20:34 -0600 - rev 448251
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19554 - layout: support tiled gradients (from pyfisch:tiled-gradients1); r=mbrubeck Use background-size, background-position properties to render CSS gradients. Some cleanup in display_list_builder.rs related to gradient calculations. Adds two wpt tests for tiled gradients. Note: For now even gradients with background-repeat: no-repeat are repeated. Sometimes the gradient is not repeated everywhere. Resolves partially #19482. (See the mentioned website for example gradients with these features) See also: #16657 and #10412 Some glitches can be seen in the attached file. I am unsure what the exact intended semantics of [`push_gradient`](https://doc.servo.org/webrender_api/struct.DisplayListBuilder.html#method.push_gradient) are and want to ask the webrender team before building in "workarounds" for the missing gradients. ![half-rhombes](https://user-images.githubusercontent.com/2781017/33958051-b16f964a-e043-11e7-8218-b28388e2cf8d.png) Source-Repo: https://github.com/servo/servo Source-Revision: 6ee8e6a1684d6dbc65933da11ce1a2c8ba660442
d1a257223f9039fdb1ea8e5ef63ad60f1574c8ea: servo: Merge #19536 - style: Move the code to parse a list of compound selectors (from emilio:compound-selector-list); r=mbrubeck
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 09 Dec 2017 17:15:14 -0600 - rev 447698
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19536 - style: Move the code to parse a list of compound selectors (from emilio:compound-selector-list); r=mbrubeck I'll need this for ::slotted(). Source-Repo: https://github.com/servo/servo Source-Revision: c6bf85eca90b9cb71ff05d4454a43a7da5fc3ac8
083f444180094f009a9442c59806f9b151c64281: servo: Merge #19538 - Use ? in Option more often (from emilio:questions-questions-questions); r=mbrubeck
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 09 Dec 2017 13:58:25 -0600 - rev 447696
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19538 - Use ? in Option more often (from emilio:questions-questions-questions); r=mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: 548028fd07d85dbbbd0511386f88ea19825dc258
251110eaf3c43520f1ba7c5d452b4a2c099e6cc9: servo: Merge #19264 - style: Remove unused argument in element_needs_traversal (from emilio:unused-arg); r=mbrubeck
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Nov 2017 10:03:05 -0600 - rev 444177
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
servo: Merge #19264 - style: Remove unused argument in element_needs_traversal (from emilio:unused-arg); r=mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: bd6caef234f9a1c29cc01c907255a4f307fbc827
cfbb11e2722459e4d663375fc080532094c8a1a2: servo: Merge #19140 - Update WR (Windows subpx rendering fix) (from glennw:update-wr-windows); r=mbrubeck
Glenn Watson <github@intuitionlibrary.com> - Wed, 08 Nov 2017 00:55:00 -0600 - rev 441568
Push 8130 by ryanvm@gmail.com at Thu, 09 Nov 2017 00:28:20 +0000
servo: Merge #19140 - Update WR (Windows subpx rendering fix) (from glennw:update-wr-windows); r=mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: b8fdb90b955d158ed72b2e0459bf22bc2fe8629f
b118bcc3fbb2f80e5755ef27c273a2d3fa20c7a1: servo: Merge #19135 - do not pass new size to Resize event (from paulrouget:resize); r=mbrubeck
Paul Rouget <me@paulrouget.com> - Tue, 07 Nov 2017 10:44:51 -0600 - rev 441376
Push 8127 by ryanvm@gmail.com at Tue, 07 Nov 2017 22:38:50 +0000
servo: Merge #19135 - do not pass new size to Resize event (from paulrouget:resize); r=mbrubeck It's not necessary to pass the new size to the resize event as it can be retrieved via `WindowMethods::framebuffer_size()`. From the perspective of the embedder, that makes things a bit easier. Source-Repo: https://github.com/servo/servo Source-Revision: 9de76632f4e26721fac39d0903d290bb8de9775c
1041e4a4b37844729f925a2195af09d652c66871: Bug 1414349 - Re-sync the list of top level crates for `mach cargo check`; r=mbrubeck
Nick Fitzgerald <fitzgen@gmail.com> - Fri, 03 Nov 2017 10:49:34 -0700 - rev 440880
Push 8120 by ryanvm@gmail.com at Sat, 04 Nov 2017 17:45:29 +0000
Bug 1414349 - Re-sync the list of top level crates for `mach cargo check`; r=mbrubeck Because there isn't a single, canonical source of truth, the `mach cargo check`'s list got out of date. MozReview-Commit-ID: EGNc2eNSumT
ddb12bb581202cf76a51ea3ed4b3adea1bcfc99b: Bug 1414349 - Add mozjs_sys to the top level crate set; r=mbrubeck
Nick Fitzgerald <fitzgen@gmail.com> - Fri, 03 Nov 2017 10:49:13 -0700 - rev 440879
Push 8120 by ryanvm@gmail.com at Sat, 04 Nov 2017 17:45:29 +0000
Bug 1414349 - Add mozjs_sys to the top level crate set; r=mbrubeck This is necessary because it runs as its own taskcluster job, and therefore has its own Cargo.lock file. MozReview-Commit-ID: HjB60bQnMeO
c60808ed560f4390e8991e63fbe1f5832c73b786: servo: Merge #19076 - Check full triples for "alt" compiler support, not just platforms (from servo:alt-triples); r=mbrubeck
Simon Sapin <simon.sapin@exyr.org> - Tue, 31 Oct 2017 18:14:53 -0500 - rev 440167
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #19076 - Check full triples for "alt" compiler support, not just platforms (from servo:alt-triples); r=mbrubeck Fixes https://github.com/servo/servo/issues/19075 Fixes https://github.com/servo/servo/issues/18227 Source-Repo: https://github.com/servo/servo Source-Revision: c18f412ba3df238b13af9e526c147db86b99f32f
9723ad4dc43b13dad3db0ffd65893d5ae5a86a18: servo: Merge #18967 - Bump bitflags to 1.0 (from Eijebong:bitflags2.0); r=mbrubeck
Bastien Orivel <eijebong@bananium.fr> - Mon, 30 Oct 2017 18:25:45 -0500 - rev 439970
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #18967 - Bump bitflags to 1.0 (from Eijebong:bitflags2.0); r=mbrubeck See #18809 Still haven't had time to test it but it should fix the tests failures that appeared in m-c Source-Repo: https://github.com/servo/servo Source-Revision: fe4139b779b3af749ec1426ddf4e1393c7b85442
7f574eb1f99cc0561b58c045a8cba0552e7ee930: servo: Merge #19061 - FreeType: don’t use usable_size() as deallocation size (from servo:ft-alloc); r=mbrubeck
Simon Sapin <simon.sapin@exyr.org> - Mon, 30 Oct 2017 12:40:34 -0500 - rev 439926
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #19061 - FreeType: don’t use usable_size() as deallocation size (from servo:ft-alloc); r=mbrubeck Instead use C-level malloc()/free() so that the size doesn’t need to be known during deallocation, since FreeType doesn’t provide it. Hopefully fixes https://github.com/servo/servo/issues/19058 Depends on https://github.com/alexcrichton/jemallocator/pull/21 Source-Repo: https://github.com/servo/servo Source-Revision: f18099118a5be17b5b1d6fdcc3352a98a1499e6a
2d5271ee816167f0a23ae7bf41bd5dff4117574d: servo: Merge #18979 - Windows Build: Install Visual Studio at default location (from sgift:patch-1); r=mbrubeck
Sebastian Gift <sebastian.gift@gmail.com> - Thu, 26 Oct 2017 12:37:31 -0500 - rev 439249
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #18979 - Windows Build: Install Visual Studio at default location (from sgift:patch-1); r=mbrubeck Visual Studio 2017 has to be installed at the default location or mach.bat will show an error that Visual Studio 2017 is not installed when trying to build servo. [X] These changes do not require tests because no code is changed, documentation only. Source-Repo: https://github.com/servo/servo Source-Revision: fd4843a40ef7c000bbd747208fcf61267dbf157f
7f9a9050fee12f086226b5646d363768e899e3d0: servo: Merge #18942 - Bootstrap from more permanent URLs (from servo:static.rlo); r=jdm,mbrubeck
Simon Sapin <simon.sapin@exyr.org> - Fri, 20 Oct 2017 07:44:26 -0500 - rev 438136
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #18942 - Bootstrap from more permanent URLs (from servo:static.rlo); r=jdm,mbrubeck The `rust-lang-ci` S3 bucket is ephemeral. `static-rust-lang-org.s3.amazonaws.com` is not going away soon, but using `static.rust-lang.org` when possible keeps things working if it ever does. https://internals.rust-lang.org/t/updates-on-rusts-ci-uploads/6062 https://internals.rust-lang.org/t/public-stable-rust-services/6072 We’ll still need to find a solution for "alt" rustc builds. In the meantime, this is a step. Source-Repo: https://github.com/servo/servo Source-Revision: 041bd626ace013f93fa7fe101c70f36543fc9b0d
edc055534a733ff284e8b0e05f2c27560e55b2d4: servo: Merge #18704 - Switch to using WebRender hit testing (from mrobinson:wr-hit-testing); r=jdm,glennw,mbrubeck
Martin Robinson <mrobinson@igalia.com> - Tue, 17 Oct 2017 17:09:25 -0500 - rev 437542
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #18704 - Switch to using WebRender hit testing (from mrobinson:wr-hit-testing); r=jdm,glennw,mbrubeck This trades quite a bit of complicated code in Servo for few more messages and a significant performance improvement. In particular, WebRender can search the entire display list at once instead of ping-ponging down the pipeline tree. This allows us to send mouse events to the correct pipeline immediately. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: ca08271345f78fa881c174545f5b69a8ccb78143
9769b8b1027e1b8428a74f43298e2deba15cce1a: servo: Merge #18735 - Update WR (clip masks on angle gradients, fix clips on transformed images) (from glennw:update-wr-angle-clips); r=mbrubeck
Glenn Watson <github@intuitionlibrary.com> - Wed, 04 Oct 2017 17:09:40 -0500 - rev 435342
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #18735 - Update WR (clip masks on angle gradients, fix clips on transformed images) (from glennw:update-wr-angle-clips); r=mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: 22685465156a07eadca0edfcc5eca119f3ec4681
1bf51e25a57b34f579979a1f5dea8cf013a9ce21: servo: Merge #18583 - Fix MallocSizeOf for TypedSize2D (from nnethercote:fix-TypedSize2D); r=mbrubeck
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 20 Sep 2017 18:38:51 -0500 - rev 431639
Push 7785 by ryanvm@gmail.com at Thu, 21 Sep 2017 13:39:55 +0000
servo: Merge #18583 - Fix MallocSizeOf for TypedSize2D (from nnethercote:fix-TypedSize2D); r=mbrubeck TypedSize2D's MallocSizeOf impl has two problems. - It measures `width` twice, and `height` not at all. - It erroneously asserts that `width` and `height` are scalars. This seems reasonable at first blush, but Stylo uses `BorderRadius<LengthAndPercentage>` which contains a `TypedSize2D<LengthAndPercentage, UnknownUnit>`, and `LengthAndPercentage` is non-scalar. This patch fixes both of these problems, and also removes a low-value `use` statement. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1401692 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because tested on the Gecko side. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: dfb80f07539298d5972c8ca108dda5f83d8e009f