searching for reviewer(mayhemer)
33d0d344ea16b9219b36d922fe45549c29326e6a: Bug 1548306 - Do not allow the ^ character to appear in the hostname. r=mayhemer, a=jcristau
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 04 Jun 2019 13:35:47 +0000 - rev 533730
Push 11410 by jcristau@mozilla.com at Mon, 10 Jun 2019 15:05:14 +0000
Bug 1548306 - Do not allow the ^ character to appear in the hostname. r=mayhemer, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D32895
acd3e9c548df552387c5d0c3c827a26d04045799: Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer a=jcristau
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 22 May 2019 06:31:22 +0000 - rev 533336
Push 11295 by ccoroiu@mozilla.com at Thu, 23 May 2019 11:54:32 +0000
Bug 1551729 - Revert bug 1548432 - Re-introducing the support for cookies without values, r=mayhemer a=jcristau This patch reverts the second part of bug 1548432. Differential Revision: https://phabricator.services.mozilla.com/D31267
8e0d5b9e2749609e129311f753a2e52812d7b628: Bug 1552248 support ftp channel in proxy api r=mayhemer,kmag
Shane Caraveo <scaraveo@mozilla.com> - Mon, 20 May 2019 15:05:26 +0000 - rev 533328
Push 11294 by malexandru@mozilla.com at Wed, 22 May 2019 15:13:54 +0000
Bug 1552248 support ftp channel in proxy api r=mayhemer,kmag ChannelWrapper is used throughout webext APIs and it requires a channel to support weakref. FTPChannel did not, thus ftp requests did not go through proxy.onRequest. Differential Revision: https://phabricator.services.mozilla.com/D31540
3f0b0cb94a5879f083dbee48f5db8270d05ae15f: Bug 1549912 - Support downgrade versioning of permissions database, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 16 May 2019 19:51:34 +0000 - rev 533046
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1549912 - Support downgrade versioning of permissions database, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D31192
f8dfee6dc6e57a2a27978313a0409db058a08255: Bug 1549912 - Support downgrade versioning of permissions database, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 16 May 2019 14:24:45 +0000 - rev 532961
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1549912 - Support downgrade versioning of permissions database, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D31192
dcf3a023d7d08907c6033a8c61c601a6b06e620a: Bug 1548472 - Collect telemetry about how is the cache split by the content type, r=mayhemer
Michal Novotny <michal.novotny@gmail.com> - Wed, 08 May 2019 13:15:40 +0000 - rev 532145
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548472 - Collect telemetry about how is the cache split by the content type, r=mayhemer Like in case of bug 1506534, this telemetry is sampled periodically every time 2GB of data is written to the cache, i.e. when the cache was used for some time and there is a chance that its content has changed significantly. Differential Revision: https://phabricator.services.mozilla.com/D29678
7fbf58d80879cbf94f82bddddb747bdfb9e4caa4: Bug 1546975 - Cache SSL resumption tokens in necko, r=mayhemer
Michal Novotny <michal.novotny@gmail.com> - Thu, 09 May 2019 22:04:43 +0000 - rev 532139
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546975 - Cache SSL resumption tokens in necko, r=mayhemer SSLTokensCache is a simple memory only storage for resumption tokens which are get and set using API for external TLS session caches in NSS. Differential Revision: https://phabricator.services.mozilla.com/D29465
5b5baa11e448f70893bc096aa518b4f58d07cc2f: Bug 1531344 - Be strict about incorrect chunked encoding. r=mayhemer
Dragana Damjanovic <dd.mozilla@gmail.com> - Wed, 08 May 2019 19:29:16 +0000 - rev 531965
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1531344 - Be strict about incorrect chunked encoding. r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D28811
723587a2ae497817823c4b42f339e91d640a6208: Bug 1531344 - Be strict about incorrect chunked encoding. r=mayhemer
Dragana Damjanovic <dd.mozilla@gmail.com> - Tue, 07 May 2019 17:57:33 +0000 - rev 531770
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1531344 - Be strict about incorrect chunked encoding. r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D28811
ee26da68184f8f32b402f3511c74ae96fac8e1f8: Bug 1541114 - Check mIPCOpen before sending messages r=mayhemer
Kershaw Chang <kershaw@mozilla.com> - Thu, 02 May 2019 12:00:57 +0000 - rev 531086
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541114 - Check mIPCOpen before sending messages r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D27869
6d240e54b7ce9e47eb6f65785c8506f9dec39c4a: Bug 1544526 - Copy the callback instead of moving r=mayhemer
Kershaw Chang <kershaw@mozilla.com> - Fri, 26 Apr 2019 18:33:28 +0000 - rev 530534
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544526 - Copy the callback instead of moving r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D27894
8292a59d195731409c327d64a5ca40cfc7777d03: bug 1441989 - remove ContentVerifier r=baku,mayhemer
Dana Keeler <dkeeler@mozilla.com> - Fri, 26 Apr 2019 22:21:36 +0000 - rev 530419
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1441989 - remove ContentVerifier r=baku,mayhemer ContentVerifier has been dead code since bug 1355166 (which, incidentally, means it has no tests). Its presence is preventing improvements to ContentSignatureVerifier (see e.g. bug 1534600), so this patch removes it. As a result, the nsILoadInfo attributes verifySignedContent and enforceSRI are also unused, so this patch removes those as well. Differential Revision: https://phabricator.services.mozilla.com/D28885
c45916f0bea2c5a258155bc3a9fbacfcbb8e30ea: Bug 1506534 - Collect telemetry to measure how much penalty we will experience with first-party cache isolation, r=mayhemer, data-r=chutten
Michal Novotny <michal.novotny@gmail.com> - Thu, 25 Apr 2019 12:21:17 +0000 - rev 530115
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1506534 - Collect telemetry to measure how much penalty we will experience with first-party cache isolation, r=mayhemer, data-r=chutten Whenever a cache entry is accessed during a document load, eTLD+1 of the top level document is added to the entry's metadata. Number of accessing sites is also stored in cache index. So we know how many copies of each entry would we have if we did a first party isolation without data deduplication. The telemetry is sent every time we write 2GB to the cache and then the data is reset. Telemetry report ID is an identifier of the telemetry cycle and it's used to invalidate eTLD+1 hashes in all cache entries. Differential Revision: https://phabricator.services.mozilla.com/D26425
b59840ac73586954d18a4c0f3c5cbdab3a6aded4: Bug 1513458 - attempt to determine why certificate decoding would fail in content processes r=mayhemer
Dana Keeler <dkeeler@mozilla.com> - Wed, 24 Apr 2019 21:10:58 +0000 - rev 530046
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1513458 - attempt to determine why certificate decoding would fail in content processes r=mayhemer Crashes resulting from the diagnostic assertions added in 2ca136370e18 suggest that certificate decoding is faiiling in the content process (which seems impossible given that presumably we successfully decoded the very same certificate in the parent). This should tell us what error code NSS is returning when this happens, which may illustrate the issue. Differential Revision: https://phabricator.services.mozilla.com/D27998
17b4c383ffbd54407ed6b16de81881c2bace8ca2: Bug 1545843 - Mark some HTTP XPIDL classes as builtinclass. r=mayhemer
Andrew McCreight <continuation@gmail.com> - Tue, 23 Apr 2019 16:05:29 +0000 - rev 529327
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545843 - Mark some HTTP XPIDL classes as builtinclass. r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D28295
c510cf43416cbd8be32987ebee55b88107e94415: Bug 1545821 - nsI-ify NetDashboardCallback. r=mayhemer
Andrew McCreight <continuation@gmail.com> - Tue, 23 Apr 2019 15:33:57 +0000 - rev 529324
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545821 - nsI-ify NetDashboardCallback. r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D28284
1f13810ca79e630b96812c10331b8f03691fe728: Bug 1544089 - Allow the configuration of the ssltunnel listening address, r=mayhemer.
Bob Clary <bclary@bclary.com> - Wed, 17 Apr 2019 14:37:28 +0000 - rev 528702
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544089 - Allow the configuration of the ssltunnel listening address, r=mayhemer. Differential Revision: https://phabricator.services.mozilla.com/D27722
23a77e063257414dd78aeb70d59e29cd68aa3295: Bug 1501108 - [1.3] Add GeckoView Session Context ID support. r=snorp,baku,mayhemer
Eugen Sawin <esawin@mozilla.com> - Tue, 16 Apr 2019 20:24:29 +0000 - rev 528677
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1501108 - [1.3] Add GeckoView Session Context ID support. r=snorp,baku,mayhemer Differential Revision: https://phabricator.services.mozilla.com/D19182
cad2b29b79d2a086c96feb0326cf61e53bb105da: Bug 1501108 - [1.2] Add GeckoView Session Context ID support. r=snorp,baku,mayhemer
Eugen Sawin <esawin@mozilla.com> - Mon, 15 Apr 2019 20:58:30 +0000 - rev 528385
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1501108 - [1.2] Add GeckoView Session Context ID support. r=snorp,baku,mayhemer Differential Revision: https://phabricator.services.mozilla.com/D19182
aad1c782f75344b91db649f459dab7691d6a8942: Bug 1542835 - Expose SSLChannelInfo.resumed on nsISSLSocketControl, r=keeler,mayhemer
Michal Novotny <michal.novotny@gmail.com> - Sat, 13 Apr 2019 09:58:00 +0000 - rev 528216
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542835 - Expose SSLChannelInfo.resumed on nsISSLSocketControl, r=keeler,mayhemer This patch adds resumed attribute to nsISSLSocketControl, which is needed in tests that check SSL resumption (e.g. bug 1500533). Differential Revision: https://phabricator.services.mozilla.com/D26597
1cf54b6a1c902ef00b7b3b68c08a4b8aa61b8703: Bug 1541114 - Check mIPCOpen before sending messages r=mayhemer
Kershaw Chang <kershaw@mozilla.com> - Fri, 12 Apr 2019 05:04:22 +0000 - rev 528030
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541114 - Check mIPCOpen before sending messages r=mayhemer To avoid sending ipc messages after the ipc channel is closed, check |mIPCOpen| before sending messages. Differential Revision: https://phabricator.services.mozilla.com/D26089
557f1dbc18ca494c059404dae75f8729763616a4: Bug 1541238 - add pref to delay 3rd-party tracker; r=mayhemer
Liang-Heng Chen <xeonchen@gmail.com> - Fri, 05 Apr 2019 16:30:08 +0000 - rev 527086
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541238 - add pref to delay 3rd-party tracker; r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D26266
90bec8daf359fd8039fdf2980e642be29f7d21b1: Bug 1541755 - Remove NSMODULE_DEFN in TestPACMan.cpp. r=mayhemer
Mike Hommey <mh+mozilla@glandium.org> - Fri, 05 Apr 2019 11:29:05 +0000 - rev 527073
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541755 - Remove NSMODULE_DEFN in TestPACMan.cpp. r=mayhemer The module is manually registered through the component manager in the gtest setup anyways. Differential Revision: https://phabricator.services.mozilla.com/D26063
f002275ecacad6271efb2dff75699e5714847da7: Bug 1456005 - Set LOAD_DISABLE_TRR flag in CaptiveDetect.jsm r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 05 Apr 2019 12:08:57 +0000 - rev 526945
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1456005 - Set LOAD_DISABLE_TRR flag in CaptiveDetect.jsm r=mayhemer This is useful to prevent issues in TRR mode 2 when a captive portal redirect occurs via DNS. For example, if we are in an unlocked CP and in suddenly locks, we must make sure that we don't use a cached DNS entry from when the portal was unlocked. This is especially relevant in split horizon situations. This isn't useful in TRR mode 3, as the flag would just cause the resolution to fail. For that we need to add the captive portal URI to the TRR exclusion list. Differential Revision: https://phabricator.services.mozilla.com/D25619
a75b9d4e84088f76f6e5f7068ad3cf2d7705b8f9: Bug 1451890 - TRR: set wait-for-portal false r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 05 Apr 2019 11:33:11 +0000 - rev 526942
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1451890 - TRR: set wait-for-portal false r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D25553
9b129ff965d75b364c9bdb4d737542cb4d1c40d1: Bug 1411725 - have XHR responseURL use the final channel URL so the expected URLs for substituted protocols like web-extension: are returned; r=mayhemer
Thomas Wisniewski <twisniewski@mozilla.com> - Sun, 31 Mar 2019 01:31:12 +0000 - rev 525777
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1411725 - have XHR responseURL use the final channel URL so the expected URLs for substituted protocols like web-extension: are returned; r=mayhemer have XHR responseURL use the final channel URL so the expected URLs for substituted protocols like web-extension: are returned Differential Revision: https://phabricator.services.mozilla.com/D23811
cec67adbdbb6d5b2948a68e4f6fb13612f949368: Bug 1539208 - P1 - Return an error when the Reponse object is null'd; r=mayhemer
Tom Tung <shes050117@gmail.com> - Thu, 28 Mar 2019 15:27:49 +0000 - rev 525547
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539208 - P1 - Return an error when the Reponse object is null'd; r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D25228
447f58b42b72d5f54f09d301ec1fe5ff03d3fd43: Bug 1539539 - Add main thread assertion and fix a clang warning r=mayhemer
Kershaw Chang <kershaw@mozilla.com> - Thu, 28 Mar 2019 15:03:46 +0000 - rev 525541
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539539 - Add main thread assertion and fix a clang warning r=mayhemer The resultCallback at [1] should be always executed on main thread, so adding an assertion to enforce this. This patch also fixes a warning at [2]. This is about moving a const captured variable. [1] https://searchfox.org/mozilla-central/rev/3d469329a42644b41e66944d8da22d78d8c0f5ec/netwerk/protocol/http/nsHttpChannel.cpp#551-558 [2] https://searchfox.org/mozilla-central/rev/3d469329a42644b41e66944d8da22d78d8c0f5ec/netwerk/base/nsNetUtil.cpp#2808 Differential Revision: https://phabricator.services.mozilla.com/D25219
9e2dd8254c43067c965fcaf9388f403939b56894: Bug 1533369 - Add content type to cache index, r=mayhemer
Michal Novotny <michal.novotny@gmail.com> - Wed, 27 Mar 2019 14:32:12 +0000 - rev 525187
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533369 - Add content type to cache index, r=mayhemer This patch adds content-type to metadata in cache entry and it is then propagated down to the cache index. Differential Revision: https://phabricator.services.mozilla.com/D23504
64664ada91eeeca17041a8498caf7966705eb6a8: Bug 1522412 - P3. Adopt nsIChannel.LOAD_BYPASS_URL_CLASSIFIER in the algorithm determining if we should classify a channel's URI. r=Ehsan,mayhemer
dlee <dlee@mozilla.com> - Mon, 25 Mar 2019 12:48:25 +0000 - rev 524743
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1522412 - P3. Adopt nsIChannel.LOAD_BYPASS_URL_CLASSIFIER in the algorithm determining if we should classify a channel's URI. r=Ehsan,mayhemer This patch uses the flag to exempt channels from classification, but it doesn't include the use cases of this flag. See Bug 1442496 for the list of the call sites should use this flag. Differential Revision: https://phabricator.services.mozilla.com/D22112
eb789cfccafcd7323660708f910303167c350563: Bug 1522412 - P1. Replace LOAD_CLASSIFY_URI flag with a heuristic algorithm. r=Ehsan,mayhemer
dlee <dlee@mozilla.com> - Mon, 25 Mar 2019 12:47:29 +0000 - rev 524741
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1522412 - P1. Replace LOAD_CLASSIFY_URI flag with a heuristic algorithm. r=Ehsan,mayhemer In this patch, we move from a model where URL classification is opt-in (by specifying LOAD_CLASSIFIER_URI) to a model where it is enforced by default unless a channel opts out or is deemed to be a critical channel based on simple heuristics. The heuristics exempt a channel from classification if it is triggered by system with an exception when it is a top level load. To ensure critical channels are never classified, we also exempt channels which are flagged as "BeConservative" (implemented in bug 1321783). Another load flag LOAD_BYPASS_URL_CLASSIFIER is also introduced for the same reason. Differential Revision: https://phabricator.services.mozilla.com/D22110
5dc08ac77984b6ccf679aebada2f59b16acc3d2d: Bug 1411725 - have XHR responseURL use the final channel URL so the expected URLs for substituted protocols like web-extension: are returned; r=mayhemer
Thomas Wisniewski <twisniewski@mozilla.com> - Thu, 21 Mar 2019 23:43:52 +0000 - rev 524381
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1411725 - have XHR responseURL use the final channel URL so the expected URLs for substituted protocols like web-extension: are returned; r=mayhemer have XHR responseURL use the final channel URL so the expected URLs for substituted protocols like web-extension: are returned Differential Revision: https://phabricator.services.mozilla.com/D23811
5399bca472b1a519f595480e786aa970f51cbb66: Bug 1522412 - P3. Adopt nsIChannel.LOAD_BYPASS_URL_CLASSIFIER in the algorithm determining if we should classify a channel's URI. r=Ehsan,mayhemer
Dimi Lee <dlee@mozilla.com> - Thu, 21 Mar 2019 07:32:46 +0000 - rev 524191
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1522412 - P3. Adopt nsIChannel.LOAD_BYPASS_URL_CLASSIFIER in the algorithm determining if we should classify a channel's URI. r=Ehsan,mayhemer This patch uses the flag to exempt channels from classification, but it doesn't include the use cases of this flag. See Bug 1442496 for the list of the call sites should use this flag. Differential Revision: https://phabricator.services.mozilla.com/D22112
b80098d0a5c4197287582b6db0bd71aaa6bbd05c: Bug 1522412 - P1. Replace LOAD_CLASSIFY_URI flag with a heuristic algorithm. r=Ehsan,mayhemer
Dimi Lee <dlee@mozilla.com> - Thu, 21 Mar 2019 07:29:48 +0000 - rev 524189
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1522412 - P1. Replace LOAD_CLASSIFY_URI flag with a heuristic algorithm. r=Ehsan,mayhemer In this patch, we move from a model where URL classification is opt-in (by specifying LOAD_CLASSIFIER_URI) to a model where it is enforced by default unless a channel opts out or is deemed to be a critical channel based on simple heuristics. The heuristics exempt a channel from classification if it is triggered by system with an exception when it is a top level load. To ensure critical channels are never classified, we also exempt channels which are flagged as "BeConservative" (implemented in bug 1321783). Another load flag LOAD_BYPASS_URL_CLASSIFIER is also introduced for the same reason. Differential Revision: https://phabricator.services.mozilla.com/D22110
70b9b6dbe5b8e2b55a240aa3b39ff6087de92276: Bug 1521729 - P2: Fix failure tests r=mayhemer
Kershaw Chang <kershaw@mozilla.com> - Mon, 18 Mar 2019 14:50:56 +0000 - rev 523651
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1521729 - P2: Fix failure tests r=mayhemer Due to the p1 patch, the first time we get the result back from NS_ShouldSecureUpgrade is always asynchronously. This means that the first http request could be completed slower than the http requests opened after the first one. There are some tests affected by this change, since these tests assume that http requests should be completed in the same order as these requests were created. This patch fixes the tests by introducing a new method in nsIHttpProtocolHandler. This method returns a promise and makes sure the HSTS data is ready to read synchronously when the promise is resolved. Once the HSTS is ready to read, the order of open/close channels will be the same. Differential Revision: https://phabricator.services.mozilla.com/D21683
917f02e20ab6edac88ba0d41d24a3b65409becdd: Bug 1521729 - P1: Support to get the result from NS_ShouldSecureUpgrade asynchronously r=mayhemer
Kershaw Chang <kershaw@mozilla.com> - Mon, 18 Mar 2019 15:48:21 +0000 - rev 523650
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1521729 - P1: Support to get the result from NS_ShouldSecureUpgrade asynchronously r=mayhemer 1. Make nsHttpChannel::OnBeforeConnect async. 2. There are two ways to get the result from NS_ShouldSecureUpgrade. One is getting the result synchronously from the input reference and the other is via the provided callback. Note that the callback is only used when the storage is not ready to read at startup. Differential Revision: https://phabricator.services.mozilla.com/D20191
74c650902989c6b30b913c4b20639bf71ba11aef: Bug 1541238 - add pref to delay 3rd-party tracker; r=mayhemer a=pascalc
Liang-Heng Chen <xeonchen@gmail.com> - Fri, 05 Apr 2019 16:30:08 +0000 - rev 523180
Push 11088 by opoprus@mozilla.com at Mon, 15 Apr 2019 12:42:31 +0000
Bug 1541238 - add pref to delay 3rd-party tracker; r=mayhemer a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D26266
7c663cf76b8d561d3334b11314ca41255b7a1b66: Bug 1151815 - Remove expiration time from the cache index, r=mayhemer
Michal Novotny <michal.novotny@gmail.com> - Mon, 11 Mar 2019 14:29:34 +0000 - rev 521700
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1151815 - Remove expiration time from the cache index, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D22499
a75985a8a0863ad2df578643c7507193115973f8: Bug 1530691 - Ignore OnStartRequest/StopRequest/DataAvailable after HttpChannelChild::ActorDestroy(Deletion) is called r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 07 Mar 2019 20:59:56 +0000 - rev 520900
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530691 - Ignore OnStartRequest/StopRequest/DataAvailable after HttpChannelChild::ActorDestroy(Deletion) is called r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D21908
c33c24d2142024dfb632fd4a50621fb2cf22e393: Bug 1527293 - Loading a large script transferred with Content-Range from cache returns empty file, r=mayhemer
Michal Novotny <michal.novotny@gmail.com> - Fri, 01 Mar 2019 13:04:36 +0000 - rev 520113
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527293 - Loading a large script transferred with Content-Range from cache returns empty file, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D21403
99eceab65655f71b82886e4fbb6fa3e557e075f5: Bug 1528352: Logging improvements in nsUDPSocket, and handle negative returns from PR_RecvFrom properly. r=mayhemer
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 28 Feb 2019 15:17:27 +0000 - rev 519831
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528352: Logging improvements in nsUDPSocket, and handle negative returns from PR_RecvFrom properly. r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D20565
d158405da51437dd36d5ce3e946fc1cc6f54ed38: Bug 1528352: Logging improvements in nsUDPSocket, and handle negative returns from PR_RecvFrom properly. r=mayhemer
Byron Campen [:bwc] <docfaraday@gmail.com> - Wed, 27 Feb 2019 15:39:57 +0000 - rev 519421
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528352: Logging improvements in nsUDPSocket, and handle negative returns from PR_RecvFrom properly. r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D20565
7bffd747d54adf39be339cfac01d785e4654ea55: Bug 1415508 - use Span in constructing a byte input stream; r=mayhemer
Alex Gaynor <agaynor@mozilla.com> - Mon, 25 Feb 2019 19:11:20 +0000 - rev 518838
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1415508 - use Span in constructing a byte input stream; r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D20687
54102692d3852d6e42a3cf24828750682eaf91d9: Bug 1522137 - Make resource://android return a nsIJARURI. r=snorp,mayhemer,bzbarsky
Agi Sferro <agi@mozilla.com> - Mon, 25 Feb 2019 15:38:33 +0000 - rev 518801
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522137 - Make resource://android return a nsIJARURI. r=snorp,mayhemer,bzbarsky resource://android URIs always point to a "jar:" URI so it doesn't make sense that the returned URL object implements nsIFileURL. This also makes it so extensions can be loaded from a resource://android URI. Audited all places where we use `nsIJARURI` and check for places where we assume it looks like `jar:`: the only (!) place where we do that is here: https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/dom/xhr/XMLHttpRequestMainThread.cpp#1852 Where we have special handling for `jar:` URIs. It looks like we would have less special handling for such a request to a `resource://android` and it could be fixed by just checking for the interface instead, but that's what's already happening today so it should work. That code is never reached for `resource://android` URIs as `mIsMappedArrayBuffer` is false for those URIs (see #2822). And the code is consistent in checking for the scheme instead of the interface (the other check is here: https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/dom/xhr/XMLHttpRequestMainThread.cpp#2822) Audited all places where we do `EqualsLiteral("jar")`: https://searchfox.org/mozilla-central/search?q=.EqualsLiteral%28%22jar%22%29&path= `SubstituteRemoteChannel`: looks interesting, but uses `nsISubstitutingProtocolHandler::ResolveURI` to first get the real URI (which is a `jar:`) so it works for our case. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/res/ExtensionProtocolHandler.cpp#414 `SubstitutingProtocolHandler.cpp` This case is explicitly fixed by this change, making it account for both `"jar"` and `"resource"`. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/res/SubstitutingProtocolHandler.cpp#299 `ReadSourceFromFileName`: this also looks interesting, but uses the channel to get the URI which returns the real `"jar"` URI and not the mapped `"resource"`. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/js/xpconnect/src/XPCJSRuntime.cpp#2837 `nsStringBundle.cpp` Accounts for both `"jar"` and `"resource"`, so it should work the same. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/intl/strres/nsStringBundle.cpp#437 Audited all places where we use `nsINestedURI` to make sure they would work for a `nsIJARURI` which does not implement `nsINestedURI`. `BrowserContentHandler.jsm` Uses `nsINestedURI` to figure out if a URI is local or not and then it checks whether it's a `"file"`, `"resource"` or `"chrome"` URI, for a `nsIJARURI & nsINestedURI` it would return a `"file"` which passes the test, for a `nsIJARURI` alone it would return `"resource"` which is also considered local by this code, so the result wouldn't change. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/browser/components/BrowserContentHandler.jsm#395-399 `nsScriptSecurityManager.cpp` `GetOriginFromURI`: This is the reason why `SubstitutingJARURI` doesn't implement `nsINestedURI`, the origin is computed starting from the innermost URI, which in our case would be a file. The behavior in our case is that the origin from a `resource://android` URI behaves like other `resource://` URIs, which is what we expect. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/caps/nsScriptSecurityManager.cpp#169 `CheckLoadURIWithPrincipal`: for `nsIJARURI & nsINestedURI` this code will only allow pages from the same jar to be in the same origin (which is correct), for `nsIJARURI` this code is unreachable and it would allow every `resource://android` to load every other `resource://android` URI (which is essentially the same thing). https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/caps/nsScriptSecurityManager.cpp#874-876 `nsDocShell.cpp` `DisplayLoadError`: Just looping through the nested URI chain to build an error message, no concerns here (it would just ignore the `jar:` part, which is fine). https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/docshell/base/nsDocShell.cpp#3986 `DoURILoad`: Looking for `view-source`, no concerns for `resource://android`. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/docshell/base/nsDocShell.cpp#9645 `nsObjectLoadingContent.cpp` Also looking for `view-source`, no concerns. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/dom/base/nsObjectLoadingContent.cpp#2004 `nsIconURI.cpp`/`nsIconURI.h` Exposing `nsINestedURI`. No concerns. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/image/decoders/icon/nsIconURI.cpp#58 `nsJARURI.cpp`/`nsJARURI.h` Exposing `nsINestedURI`, the subject of this audit. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/modules/libjar/nsJARURI.cpp#45 `nsIOService.cpp` `URIChainHasFlags`: This code looks at the chain of nested URIs to figure out if the chain of protocols has a certain flags. for `nsIJARURI & nsINestedURI` it would look at both `jar:` and `file:` protocols, while in `nsIJARURI` it would only look at the `resource:` protocol, which is our intention, since we want this URI to be treated like a `resource:` URI and nothing else. Note the `resource:` URI is always local (enforced by `NewURI`), so this should be ok. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/base/nsIOService.cpp#1494 `nsNetUtil.cpp`/`nsNetUtil.h` Implementation of `NS_ImplGetInnermostURI`, which wouldn't work for `nsIJARURI` alone, as expected. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/base/nsNetUtil.h#704 `nsSimpleNestedURI.cpp`/`nsSimpleNestedURI.h` Implementing `nsINestedURI` for `nsSimpleNestedURI`, no concerns. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/base/nsSimpleNestedURI.cpp#19 `nsViewSourceHandler.cpp` Looking at `view-source` inner URI to get the flags, no concerns. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/viewsource/nsViewSourceHandler.cpp#49 `nsHtml5StreamParser.cpp`/`nsHtml5TreeOpExecutor.cpp` More `view-source` handling code. No concerns. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/parser/html/nsHtml5StreamParser.cpp#310 https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/parser/html/nsHtml5TreeOpExecutor.cpp#884 `DownloadPlatform.cpp` `IsURLPossiblyFromWeb`: This line is unreachable as the method would return true because resource has `URI_IS_UI_RESOURCE`. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/components/downloads/DownloadPlatform.cpp#314 `getAnonymizedPath`: This code looks a little scary, and it's the first one that seems to conflate the fact that `jar: == nsINestedURI`. On the android case (line 2130) this code manually replaces the `resource://android` URI with a `jar:` URI, so it wouldn't matter whether `resource://android` implements `nsINestedURI` or not. Actually this code could be a lot easier by using `nsISubstitutingURL::resolveURI`, maybe I should open a bug. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/components/search/SearchService.jsm#2148 `getRemoteTypeForURIObject`: This also looks interesting. The switch at line 157 would go straight to line 218 for `resource:` URIs (irrespective of `nsINestedURI`) and then for `nsINestedURI` we would look at the `jar:` URI (and eventually the `file:` URI). While for not `nsINestedURI` we would call straight to `validatedWebRemoteType`. This might return `WEB_REMOTE_TYPE` instead of `FILE_REMOTE_TYPE`, but since it's already happening it should be ok (`resource://android` maps _today_ to a `jar:` file that return `WEB_RETURN_TYPE`) https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/modules/E10SUtils.jsm#150 `getURIHost`: This is another piece of code that benefits from not implementing `nsINestedURI` as the host would be correctly `"android"` instead of the apk path. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/mozapps/downloads/DownloadUtils.jsm#390 `initDialog`: Download dialog would show the `resource://android` URI instead of the actual `jar:` URI, kind of expected. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/toolkit/mozapps/downloads/HelperAppDlg.jsm#423 There are no places in the codebase where we do `== "jar"`. Looks like I've already looked at all hits for "jar" too. Checked for `"jar:` too and It looks like they are all from code that tries to build a `jar:` URI manually which is fine for this change. Audited all `schemeIs("jar")` occurrences: https://searchfox.org/mozilla-central/search?q=schemeIs(%22jar%22)&path= `browser-identity.js` Uses the channel URI which is always resolved to `jar:`, so that works regardless. See also: https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/netwerk/protocol/res/SubstitutingProtocolHandler.cpp#229 https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/browser/base/content/browser-siteIdentity.js#812 `tabbrowser.js` Only for `scheme == "about"` URIs. https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/browser/base/content/tabbrowser.js#789 `HelperAppDialog.js` Treats "jar:" and "resource" the same way. https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/mobile/android/components/HelperAppDialog.js#63 `WebNavigationContent.js` This code checks if the scheme is "jar" and if the original URI is "resource" it will use that instead, so in our case it will use the "resource" URI either way. https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/toolkit/modules/addons/WebNavigationContent.js#158 Depends on D18740 Differential Revision: https://phabricator.services.mozilla.com/D16913
c79d6bd85dd8b07ac3e6f1cf7c02d5d2b708302f: Bug 1522137 - Move resource://android handler to C++. r=mayhemer
Agi Sferro <agi@mozilla.com> - Mon, 25 Feb 2019 15:38:21 +0000 - rev 518800
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522137 - Move resource://android handler to C++. r=mayhemer This is needed to make the handler to avoid race conditions where some code tries to access a resource://android URI before the handler has been registered. Depends on D18739 Differential Revision: https://phabricator.services.mozilla.com/D18740
78d3e59ea9fae27455ea29b4d19ef108629aa31d: Bug 1507110 - Allow hijacking localhost only if network.proxy.allow_hijacking_localhost is set r=Gijs,mayhemer,mkaply,jmaher
Junior Hsu <juhsu@mozilla.com> - Tue, 19 Feb 2019 21:53:22 +0000 - rev 518160
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1507110 - Allow hijacking localhost only if network.proxy.allow_hijacking_localhost is set r=Gijs,mayhemer,mkaply,jmaher Differential Revision: https://phabricator.services.mozilla.com/D19325
d5bafd3c816e798da0c086687dcd0e0b6f85f777: Bug 1528814: Serialize Loadinfo for PExternalHelperApp. r=mayhemer
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 18 Feb 2019 18:11:22 +0100 - rev 517777
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528814: Serialize Loadinfo for PExternalHelperApp. r=mayhemer
bc1a5ca9464b2342b79ad1642b6fbe51139916e7: Bug 1528188 - Get the HttpChannelParentListener via the parent r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 18 Feb 2019 21:37:44 +0000 - rev 517694
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528188 - Get the HttpChannelParentListener via the parent r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D20184
2299664d9a0b83229ed527ca3e5c43452e69ab2a: Bug 1528188 - Add test with blocking webRequest which overwrites notificationCallbacks r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 18 Feb 2019 21:37:30 +0000 - rev 517693
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528188 - Add test with blocking webRequest which overwrites notificationCallbacks r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D20183
a7dc0e4d01361269d13061d0a611d0bc3e9b7aa0: Bug 1521808 - Add xpcshell-test for CrossOriginOpenerPolicy r=mayhemer,nika,annevk
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 15 Feb 2019 22:02:52 +0000 - rev 517499
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1521808 - Add xpcshell-test for CrossOriginOpenerPolicy r=mayhemer,nika,annevk Differential Revision: https://phabricator.services.mozilla.com/D18246